summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-05use XGraphic instead of ImageCaolán McNamara
we don't appear to use the Icon in our own code, though there may be a route to set it from an extension or via config Change-Id: I5e169db6335a8e64aeb3d2e6672f5a4b7c65c57f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-05Make order of UITest *.py test file processing deterministicStephan Bergmann
...hoping that this can prevent issues like the one seen with 1b0eb76eb1787d9d9fbd7a7a73ee8ae47b62dc33 "tdf#137617: sc: Add UItest" followed by d1232ee6b5e5cc3c811ef3ad72c83e9bd884bfe3 "uitest: reset formula syntax back to Calc A1" (i.e., where the first commit's Gerrit Jenkins build had apparently only succeeded because it happened to run the tests in one specific order, different from the order in which later, failing builds ran it) Change-Id: I4f1b5ada10d60e77b45a0edeb89069fe9376b63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105325 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-05external/libwpd: Missing include for size_tStephan Bergmann
...as now reported when building with recent trunk GCC/libstdc++ on Linux: > In file included from WPXContentListener.cpp:26: > In file included from ./WPXContentListener.h:29: > ./WPXTable.h:56:31: error: unknown type name 'size_t'; did you mean 'std::size_t'? > const WPXTableCell *getCell(size_t i, size_t j) > ^~~~~~ > std::size_t Change-Id: Ic20240f01c7b0305cb87ababf53a3aaf66072d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105324 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-05Colibre: fix some dark color, update Choose Control iconsRizal Muttaqin
Change-Id: Ifdd27ea71aa4c65b3ea85fad2b169f897174df3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105322 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-05tdf#137968 Added check for the headings orderIvan Stefanenko
Headings' levels order is important for readers and converters. Check firstly finds out if the node is a TextNode, then gets it's OutlineLevel. If it is greater than 0, i.e. the node is a heading, then it checks if node's heading level is greater then previous one's by more than 1. If so, warning is thrown. So the first heading level is always 1 and no heading levels are greater then previous by more than 1. Change-Id: I39d230d747699eddd36610193bde9b23f348e257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105274 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-11-05vcl pdf tokenizer: add real numbers testcaseMiklos Vajna
Fails with commit 0d68738d67eacdfebdca3c9183dc11f953b38174 (Correctly parse real numbers in PDFs, 2020-09-25) reverted. Change-Id: I449ed781a3dd4b78e27a3fd2e135495e7d6c35ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105297 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-05clean up some temp files after running testsAndras Timar
Change-Id: Ia28e96cf1f6ec476f202e99877fa80e93d691278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105314 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-05Added frac command. Sould solve tdf#137234.dante
Change-Id: I78dcd06a30b93c441dd5983711603f184d20c63b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105255 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05loplugin:unusedenumconstantsNoel
Change-Id: I9a2eb83647d6620b3c5b5ed5642227be47a657f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105303 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05xmlsecurity: reject a few dangerous annotation types during pdf sig verifyMiklos Vajna
Change-Id: I950b49a6e7181639daf27348ddfa0f36586baa65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105312 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-05SpinButtonEntry is unusedNoel
since commit f2517e82904b92989ed7e38a070c18234f460b33 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Sep 8 22:11:11 2020 +0200 improve loplugin:unusedvarsglobal Change-Id: Ibfa5a651eae01aeecd77a46d9f949ae6e48e17fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05tdf#83419 sw change tracking: fix bad autocorrectLászló Németh
In Show Changes mode, automatic sentence capitalization (or correction of two initial capitals) could change the first (or second) letter of a tracked deletion in sentence (or word) starting position. Change-Id: I9146a5c78abf69e758661fcf17f42564bd87a73e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105273 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-05get rid of long deprecated SwModify::BroadcastModifyBjoern Michaelsen
Change-Id: I9c65de16bf1f1a604c0045444203a16f30f2833e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105318 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-05Ensure no class directly derives from SwModifyBjoern Michaelsen
- make all classes that used to be SwModify to be sw::BroadcastingModify's - this makes sure they are all sw::BroadcastMixin too, so all clients of SwModify can be migrated over to use sw::BroadcastMixin (only) instead Change-Id: Idd217b98f9c20f01e0788bc65af796050dbb5699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105207 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-05INPUTENABLE is unusedNoel
since commit be3b1a8393ca3e77f31bea5d9caa7271fd53e9e4 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Aug 17 17:28:58 2020 +0100 weld OAppDetailPageHelper Change-Id: I97afdbd536c587a360b8f72b9faca71e8fa32ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05N8BitTcMask is unusedNoel
since commit 77809fba7d4bf5e0b604ffa3937c18d5530c2d56 Author: Luboš Luňák <l.lunak@collabora.com> Date: Fri Oct 9 19:28:49 2020 +0200 implement ImplFastBitmapConversion() for 8bit gray source Change-Id: I730aef10c1705ae6d3141014228cf79b8bfa3c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-05Use LONG hereMike Kaganski
... since VarDecFromI4 WinAPI uses LONG [1]. Reverts commit 6436302f40252bc6619e304e2051115fee902e20 (partially) and commit 6436302f40252bc6619e304e2051115fee902e20. [1] https://docs.microsoft.com/en-us/windows/win32/api/oleauto/nf-oleauto-vardecfromi4 Change-Id: I5b0805b5b22bea0017b4b2f40400445ab587f2c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105226 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-05use a utl::TempFile and clean it up after testAndras Timar
Change-Id: I1cbe7fd8002f6ba54532135de935805dd6a4e0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105319 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-05tdf#137532: do not reset attributes deleting selectionXisco Fauli
Regression from 6abed0ea006f3616e40faf2ae782cf64f8ac2914 While at it, extend unittest for tdf#79717 to test another regression from the same commit I found while testing the patch: type 'a', type bold 'b', select both characters, type 'c' -> it should be bold Change-Id: I5b0b8ce4bfdfb4d52051e25c366827d7b594bb1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105316 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-05Resolves tdf#132479: Rename "equal triangle" to "regular triangle"Ming Hua
"Equal triangle" is not a correct English term, as people use "regular triangle" or "equilateral triangle". Technically this is not a true regular triangle (i.e. equilateral and equiangular), but an isosceles triangle with equal width and height. For the name of an animation path there is no need for too much detail though, and "regular triangle" is close enough. Change-Id: I72f5373ae68dc1ba771cf605073c15210c5300e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105223 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-05Colibre: update icons with check markRizal Muttaqin
Change-Id: I106cefe7e8a2fa9277b9710d8f3aaae6523cb455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105321 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-05tdf#137790 calc: set minimal line width: unit testSerge Krot
Change-Id: Idac7c23e55b3c4ee94790458fca5e7a7a5522098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105301 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-11-04tdf#137949 Fix table row heigths.Gülşah Köse
Consider "Height" property of the the table while calculating the minimum row height. Change-Id: I4a57b69c4c0fc4dd004c895bd105ebc70f0c4bb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105228 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-11-04tdf#79717: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I866cbc057113003e5bbbd20e2e5812a1045b5133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105300 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-04Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id868397185ab487882a95a298e33a967df810a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104737 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2020-11-04Unit tests for: Improve 'resize with cell' handlingRegina Henschel
These tests belong to commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca They cover tdf#137576, tdf#137216, tdf#137044, tdf#137020, tdf#137355 and tdf#115655. I have replaced the rectangle comparison in scshapetest.cxx with the same one as used in bugfix-test.cxx Change-Id: I71b4499077e461fe826e6d8d29f801bc66da89fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105270 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-11-04remove SwClient::ModifyNotifcation, now unusedBjoern Michaelsen
... and there was much rejoicing. Change-Id: Ib7ed5a897f2a1e7490462eb47578a8efd22a669e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105233 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-04SwModify: remove the LockClientList madnessBjoern Michaelsen
sw::WriterListener has better debug messages anyway. Change-Id: I24ae3fabe885002d250ad30e596973c26316abcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105232 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-04Fix typosAndrea Gelmini
Change-Id: If310f08c8df54356b52bb9c0ac614c374c750814 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105268 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-04Fix typosAndrea Gelmini
Change-Id: I8a7a313b54aafc5347e00c5afec4648e09dbc981 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105295 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-04sfxlo-SidebarToolBox not used in any current .ui filesCaolán McNamara
map sfxlo-SidebarToolBox to sfxlo-NotebookbarToolBox in case it appears in any stale customized profiles Change-Id: I6035b9042450630b23b48a895e4e9d0ff8d730a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04use only NotebookbarToolBox, and not SidebarToolBox, in the notebookbarCaolán McNamara
Change-Id: I93e2acdcc176a7c179d4068597f00f8e9cd0bf7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105293 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04don't select entry 0 if there are no entriesCaolán McNamara
Change-Id: I99b13796501dca1551d32eb966db1afcca16e225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04tdf#137982 m_xFrame is already disposedCaolán McNamara
move the frame cleanup into a helper that listens to see if it got disposed by the preview itself Change-Id: I523285268118300f18b0f0f0a10fab7a9cced9c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04silence qa test coverity warningCaolán McNamara
Change-Id: Ic25815921360bb5899bf5d452ce77dd9b99fee03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04remove pimpl from PropertySetHelperNoel Grandin
Change-Id: I20e72b5927d64a69aacd3d4de117a7736d53eea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to d13a2e451488a17904e13a4060ccca8741aa7763 - tdf#137221 change link in "register-true" in Glossary "Register-true" embeds a sentence from "Page line-spacing" about how LO refers to register-true. The embedded sentence had a link to the help page about using this feature for printing. Now the <variable> for the sentence does not include the link, so that "register-true" can have a link to "Page line-spacing" in the Glossary. Change-Id: I71495a50b381619ec9eddb0cdea8e04059b0f631 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105217 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-11-04copy_paste_error: "clazz" looks like a copy-paste errorCaolán McNamara
Change-Id: Idc87fcca5da166a532792516277d8199c2558de5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04negative returnsCaolán McNamara
Change-Id: I6f710f1aecc2e242b6006a3360e31bf2a9438fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04resource leakCaolán McNamara
Change-Id: I1abd8acef55d5bdb4744ecf1a62d8e1396de0e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-04RTF import: change exception type thrown on destination errorsVasily Melenchuk
Previous exception (std::out_of_range) was not catch in case of invalid RTF imported: wrapping code checks only for uno::exception. This is not a case for loading file, but for parsing of clipboard containing invalid RTF it was causing fatal error, freeze and/or LO crash due to unhandled exception. I think there is no reason to add generic processing for std::exception in RTF filter: this can complicate diagnosing other potential problems. Instead let's throw UNO exception, like in other parts of RTF filter code. Change-Id: I064bbdc1559cc7700c96dbbeaf2911a2c8e0421e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105285 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-11-04remove pimpl from NamedValueCollectionNoel Grandin
Change-Id: I134e5fd78a3861e0067b749d93643960205daf69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04loplugin:constantparamNoel
Change-Id: Ia2fea86f940d0d2d1dba5ed56660584f3d3fb028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04uitest: reset formula syntax back to Calc A1Xisco Fauli
otherwise, it will interfere with other tests Change-Id: Ib671d0e5e0a0d47a42ed911d4f9de68b2f7fee9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-04tdf#105967 sw: add unit test for redlining of break symbolsLászló Németh
Pilcrow and line break symbols have got strikeout and underline of change tracking. Follow-up of commit 72ec44bc294dd814c0ba8657337b6b2646382b02 (tdf#105967 sw change tracking: fix line break symbol in empty line). Change-Id: I06d0fb40a8226ecada6e5452e611e9da1b556b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105254 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-04Fix apr build with current Xcode: Include <stdlib.h> for exit()Tor Lillqvist
(Or whatever it is that had broken it.) Change-Id: I72bc42e618f011518c05a2cdb875cfe64515b4d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105269 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-04remove pimpl in PropertyBagNoel Grandin
Change-Id: Ibf34c0d9a3090c190a63f63ba9bd661263aebae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04Make --without-webdav work even with --enable-mpl-subsetTor Lillqvist
Change-Id: I319e0b3aefa721f2503494783af6d73470f592a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105271 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-04tdf#136952 writerfilter: PageBreakBefore - don't always overwriteJustin Luth
There can be a number of things that can set PROP_BREAK_TYPE, and thus an un-inheriting value of PageBreakBefore should not cancel a w:br for example. There are two ways to approach this. One would be to never overwrite, and that should be safe in practice, since I don't see anywhere else that would specify a NONE value. However, if PageBreakBefore is true, it ought to override a theoretical NONE, or potential COLUMN break I would assume, so in that case a "yes" page break should probably override, but a "no" page break should not. Basically, if anything specifically requests a page break, they should get it. (Actually, I'm not sure how, but column and textWrapping breaks seem not to be affected by this - which is good. Only the page break seemed to be lost when PageBreakBefore=false. I tested by changing the w:br type to column, textWrapping, and the invalid value of none.) NOTE: If there is both a w:br and a PageBreakBefore=true, then MSWord 2003 treats both as a valid page break, but neither Word 2010 nor 2016 add the empty page. See bug report for two proof unit tests. Change-Id: I279874c60cc4cc572e0d190dc2afad0ad3431c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103223 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-04external: update pdfium to 4306Miklos Vajna
Change-Id: Ic10cf99fa412f8f0b3475e82d0a1839a7f04bd08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105272 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 06:22:51 +0000