summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-27Avoid calling osl_closeFile, osl_freeProcessHandle on null argumentsStephan Bergmann
See the discussion in the comment at <https://gerrit.libreoffice.org/c/core/+/ 94658/7#message-4afcb072d281450932788a9e8ea88cf2c6798e29> "Fix leak in extensions/updatecheck". Change-Id: I2314d108addbb4ef90762e5d5676c1d2480e1264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94978 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27tdf#132236 sw_redlinehide: fix SwUndoDelete with sections even moreMichael Stahl
SwUndoDelete::UndoImpl may want to move something like this into the nodes-array: [ 9] 0x6356fe0 TextNode "", [ 10] 0x31cba00 ~DeletedNode , [ 11] 0x64d8840 TextNode "Introduction - xzn Overview Of KmneqxziTY\t3", [ 12] 0x64e9750 TextNode "shell\t20", [ 13] 0x7a0f0a0 ~DeletedNode , The ~DeletedNode become end nodes of section nodes; in this case m_nSectDiff != 0. Don't skip these end nodes because in the above "Untitled 1.odt" example, they are not necessarily consecutive. Between the 1st and 2nd one a new SwSectionFrame must be created via the outer section, so adapt InsertCnt_() to check for extra end nodes in the range and do this. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I7bfba9efca1789392495ebec37eb3e5b6138bd07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94883 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27sw: dump sectionNodeIndex in layout.xmlMichael Stahl
useful to see if the sections are nested Change-Id: I49c92b8f3084f72a2753462724b596b07fffbe62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94882 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27tdf#131684 tdf#132236 sw_redlinehide: fix upper of frame moved...Michael Stahl
... in SwUndoDelete::UndoImpl; this wasn't fixed properly in commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c - the SwTextFrame was moved into the SwSectionFrame but its upper was whatever it was previously. This is rather ugly because with the constraint from the very special case of tdf#131684 the MakeFrames() requires one node with pre-existing frames, and it's not possible to move the pre-existing frame after MakeFrames() because then the tdf#132236 case will have an empty SwSectionFrame and InsertCnt_() will just delete it. So try to detect the situation with some hack in InsertCnt_() to move it into the SwSectionFrame. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: Ic0199c85d7523a49676ad3df1d2c4d8fe135c2ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94881 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27tdf#133396 FormattedField comes with differrent defaults than GtkSpinButtonCaolán McNamara
so explicitly set the GtkSpinButton defaults in their absence from a GtkAdjustment Change-Id: Idbf3370ab35c9d48a4f01a680ca4413238a8fd6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27Resolves: tdf#133385 dangling pTargetEntry after remove or clearCaolán McNamara
Change-Id: Id04b08ea5af1341d548f7bb1e3c3c7f5b7197548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94944 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27Related: tdf#133385 set cursor in row on right clickCaolán McNamara
if the target row is not already selected Change-Id: I7cb39118f4a695546d8d2251390d6d3279e82bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27ofz#22222 avoid calling DbgGetCaughtException if unnecessaryCaolán McNamara
Change-Id: Ia48240d2c0218ac3b790c78f458896a90c586869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94304 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27Remove obsolete configure checks after libreoffice-7-0 branch offStephan Bergmann
By now, any outdated builders where this would fail should have been identified and taken care of. Change-Id: If0af9fc390e7c132e08d0ec673c9073d92a028f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92458 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27oox smartart import, composite alg: implement vertical centeringMiklos Vajna
The bugdoc's case was that the total height would be used by 2 shapes, but then a constraint decreases the height of one shape, so not all vertical space is used. We used to just count from the top, need to center vertically, as PowerPoint does it. Change-Id: I436019e9e837b73130e387c9bcd309e20045b0f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94948 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-27logerrit: Don't suggest to set oneself a username.Guilhem Moulin
Usernames (used for HTTP and SSH authentication) are now automatically provisioned from SSO (along with the primary email address and display name). Username/email collisions are fatal and need manual resolution, but for most users the registration step should be somewhat simpler. Also, update the documentation to reflect /settings/#SSHKeys from gerrit 3.0's UI. Change-Id: Ia634c2f92f42b4b698543d990534ac15215a4c96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94931 Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org> Tested-by: Jenkins
2020-05-27Revert "Revert 'Fix leak in extensions/updatecheck'"Stephan Bergmann
This reverts commit f7a77ec55a94bcac13cde7c7e7644d70771b6098. Reason for revert: The original 05ab836cf3001093a6e375bcb3e4654bbedcfa52 "Fix leak in extensions/updatecheck" had not been wrong per se. The comment at <https://gerrit.libreoffice.org/c/core/+/94658/7# message-4afcb072d281450932788a9e8ea88cf2c6798e29> said "It shouldn't matter in practice". So the issue that comment raised can easily be either ignored completely or addressed in a follow-up commit. Change-Id: I75afaba57e3a6ba4fcce526481ff0df94360d929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94681 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27no GtkLabel with :border hack exist anymoreCaolán McNamara
Change-Id: Iaa1826f9de8fb7cb02d7d44cd499a350ce9da835 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27no GtkCheckButton with :wrap hack exist anymoreCaolán McNamara
Change-Id: Ibf6795798d68efe4ed64a9c3a94f6af550f62bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94941 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27no GtkRadioButton with :wrap hack exist anymoreCaolán McNamara
Change-Id: Ia2e3dbfb9cafbfb7d0463633277185e1a96bbc0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94940 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27no GtkDrawingArea with :border hack exist anymoreCaolán McNamara
Change-Id: I3e9bd08c1e03652c956336e1e6b83a99560babc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94939 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27properly scale stroke values in Skia drawPolyLine()Luboš Luňák
Related to the previous commit where I forgot to do this. Makes a difference e.g. for https://bugs.documentfoundation.org/show_bug.cgi?id=130478#c37 Change-Id: Id52f8db1580a78aec7c1e4764a5872f027c85a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94874 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-27tdf#133331: Added explicit type casts to resolve -fpermissive errorsMichael Warner
Change-Id: Id3dcceeddb35e3712d52ddf940eab82dab6a6da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7e39048579d0049c19299c1e31a2878e21e218ec - tdf#132586 Add RAND.NV() and RANDBETWEEN.NV() Change-Id: I181d4f7ce0ccca38339568c034754c40ef345026 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94724 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-27bump product version to 7.1.0.0.alpha0+Christian Lohmaier
Change-Id: I8b546885de4732d92f15af7e60ace8ba4edcd069
2020-05-27no GtkComboBox[Text]s with :pattern hack exist anymoreCaolán McNamara
Change-Id: I2985697096133cadce2a68a357c86757b07af5cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27no GtkSpinButtons with :pattern hack exist anymoreCaolán McNamara
Change-Id: I9d622890b3f8e58d6b634014f242e7cd9016d507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94937 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27update list of [MS-LCID] from 3/4/2020 14.0 rev.libreoffice-7-0-branch-pointDaeHyun Sung
update list of [MS-LCID] from 3/4/2020 14.0 revision see [MS-LCID]: Windows Language Code Identifier (LCID) Reference Link: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f Change-Id: I63c53915f0fb231def983bd80a10c31c55993004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94880 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-27Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 13d55bb42d2f5617f568fd8b000e3d0c8bc4be6b - update translations for 7.0.0 beta1 and force-fix errors using pocheck Change-Id: I1adc224071cce4a7e0b21209890b3777f9e2539b
2020-05-27Use $PRODUCTNAME_WITHOUT_SPACES in app bundle name in help message for macOSTor Lillqvist
Don't mention $PRODUCTNAME at all in the message in general as it might look confusing to newbie developers if it says "LibreOfficeDev". On the other hand, hardcoding "LibreOffice" is misleading, too, if what you are building is something not called LibreOffice. Change-Id: Iee4949ea68bbaa542b577cc652b5241eaf4ac438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94932 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-27tdf#78352: docx import: allow tab at left indent for listVasily Melenchuk
Looks like first tab stop for list bullets is at left paragraph boundry. Luckely there is a compatibility option for this. Change-Id: Iea4bd2b51912746dbd4722ff61eeb2e9293cab31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94559 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-27ofz#22588 Invalid-enum-valueCaolán McNamara
Change-Id: Id632537856086490c3231879a81692e80edad4c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27tdf#131572 Add java 9 module info for unoloader.jarSamuel Mehrbrodt
Add a java module named "org.libreoffice.unoloader" for this jar. Require this module from org.libreoffice.uno (libreoffice.jar has unoloader.jar in its classpath, so add the same dependency to the modules) Change-Id: I7471d65ac7a0d2c6a11c002027a21f0c441dd1f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94419 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-27tdf#131572 Add java 9 module info for libreoffice.jarSamuel Mehrbrodt
Add a java module named "org.libreoffice.uno" for this jar. This needs to be compiled with Java 9. But since we want to keep b/c with Java 8, the rest of the jar has to be compiled with Java 8. This bumps the *build* requirement to Java 9 while keeping the *runtime* requirement at Java 8. The gbuild JavaClassSet class is changed to invoke javac twice, where the 2nd invocation compiles with --release 9 and a --patch-modules argument so that it finds the results of the first invocation and also the javamaker generated files in CustomTargets. Change-Id: I888f5dbe097cc37136e68db5919939877c981862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-27tdf#133426 Make mail merge progress dialog modalMichael Weghorn
This prevents doing things like trying to start another mail merge for the same doc in parallel, thus crashing LibreOffice. Change-Id: I5df2e804d97e82cccca4f0e297cb6d3396652882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94933 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-27tdf#132594 Chart XLSX import: fix legend entries in pie chartsTünde Tóth
Legend entry text of pie chart wasn't imported correctly in XLSX documents created with Excel 2007. Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8 (tdf#128016 Chart OOXML Import: fix duplicated category labels) Change-Id: I4567437a41fe66e124dccbd148c0c49196d5c007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94864 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-27WB_LISTBOX_POPUP is newly unusedCaolán McNamara
Change-Id: I97a52499e1fda8a9426e6956e3e925e0572c41ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-27Revert "bloaty: use -ffunction-sections and --gc-sections for linking"Noel Grandin
This reverts commit bd39ec554f90badccfb26c843fd0d43237f1b622. Reason for revert: For -ffunction-sections and -fdata-sections, <https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Optimize-Options.html#Optimize-Options> warns: "Only use these options when there are significant benefits from doing so. When you specify these options, the assembler and linker create larger object and executable files and are also slower. These options affect code generation. They prevent optimizations by the compiler and assembler using relative locations inside a translation unit since the locations are unknown until link time. An example of such an optimization is relaxing calls to short call instructions." Change-Id: I84225ca94de9afff23bdd2913c77095d5d26f7ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27tdf#74244 Fix version info shown for major release candidatesEivind Samseth
Previous approach of setting the bundle version made e.g., 6.4.0.3 show up as version 6.4.3 which was clearly wrong CFBundleShortVersionString is supposed to be only three integers, but this does not seem to be enforced by Apple. Other applications, such as Spotiy, include even more than LO Removed CFBundleGetInfoString as it's been deprecated since 10.5 Change-Id: I7c64553f6bc2712506062d8f8ec388f5279b333d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94623 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27bloaty: use -ffunction-sections and --gc-sections for linkingNoel Grandin
strips out 3+ megabytes of duplicate functions (which originate in the generated UNO header files) Change-Id: I69ba5f478b2b062e2b05516bbaa2d18fa8312aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94868 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27tdf#133370 docx export: don't export unseen columnbreakJustin Luth
A compatibility option indicates whether a column break is treated as a page break when there are no columns. (Currently true only for DOCX). Don't export this column break when compat is off, because it WILL show up as a page-break in Word and LO when loaded. In theory, the RTF and DOC code that converts these into page-breaks on import could now be removed, but I can't think of any reason why that would be of benefit. testColumnBreak_ColumnCountIsZero in ooxmlexport4 covers the situation where docx MUST round-trip these. Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-27Remove some unused includesMiklos Vajna
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to cd96ed80cb27d31987cb878b379c3fa8c1dd0c03 - Added square brackets around applicable parameter in eight syntax statements (to indicate parameters are optional). All changes contained in one XHP file. Change-Id: Ia4855d44b49f7d4198e8d644f5b53741b5083371 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94838 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 190b78fd2add6bb8468cd69f3d6a7bcccd692fef - Add square brackets around final two parameters in syntax statement (to indicate parameters are optional) Change-Id: Icbe4f4d834244dc8bb397b0eb5fa5df5d543ddbb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94840 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to f9285f35a17dbdc69b0412cc73e4816906f85d9d - Add square brackets around final parameter in syntax statement (to indicate parameter is optional) Change-Id: I9703c7e556009613e377324b30a2a15accd33f5d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94839 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 1e6411ced00a5459e70a5f27651f2c55595ea9c5 - Add square brackets around final parameter in syntax statement (to indicate parameter is optional) Change-Id: I9c60cc607f157114da48e5369866adf68394dcf4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94837 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3dbc5d6b39165002e1de2f3ba6d99d6d7d9a5dd4 - tdf#126813 Fix scrolling of targeted references Change-Id: Ic7ce644cc0a5053905e980952ad31767fa87125c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94885 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26make highlight of get_dest_row_at_pos optionalCaolán McNamara
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26emit activate-row in vcl treeview on returnCaolán McNamara
to align it with the gtk one which does this Change-Id: Id439fe684f263f59285ba9291fc803f88309c066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94875 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 695cea8d8ed485a8c32f9ccb67e2a182159a6734 - Remove unused CSS class Change-Id: I9db4df3062c411570a77686ec2b4fe3124f71539 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94879 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to a736b5e008fad1d0c05c961669cb62e1876218b9 - Add square brackets around final two parameters in syntax statement (to indicate parametes are optional) Change-Id: I756376f90b8c9f51875ad1887142a82c6595daed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94836 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Don't run CompilerTest_o3tl_* with COMPILER_PLUGIN_TOOL=...Stephan Bergmann
...similar to 2228203a8211dea1c8addb98298096a094ec788b "Don't run CompilerTest_compilerplugins_clang with COMPILER_PLUGIN_TOOL=...", as otherwise e.g., `make check COMPILER_PLUGIN_TOOL=fakebool` failed with > o3tl/qa/compile-temporary.cxx:22:8: error: call to deleted function 'temporary' > f(&o3tl::temporary(n)); // expected-error {{}} expected-note@o3tl/temporary.hxx:* 0+ {{}} > ^~~~~~~~~~~~~~~ > include/o3tl/temporary.hxx:22:36: note: candidate function [with T = int] has been explicitly deleted > template <typename T> constexpr T& temporary(T&) = delete; > ^ > include/o3tl/temporary.hxx:21:36: note: candidate function [with T = int &] > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ Change-Id: I4dfa433708c064413f365375c84b85ced63c8d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94871 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26Drop -I$(dir $(2)) also from gb_*Object__tool_commandStephan Bergmann
...after ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 "-I$(dir $(3)) in gb_CObject__command_pattern is no longer needed" and f218f8f6c8c587d2d78679f935093329f145fede "-I$(dir $(3)) in gb_CObject__command_pattern is no longer needed" had already dropped it from plain gb_CObject__command_pattern. (0349c738da5970d9f0fc10d7cf4d7b766ce10e13 "support for compiler rewriters" had created gb_*Object__tool_command at a time when plain gb_*Object__command still contained those -I arguments, so had presumably just copied them over without a specific additional need to have them in the tool_command variants; and ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 and f218f8f6c8c587d2d78679f935093329f145fede then just failed to also remove them from the tool_command variants.) Presence of the -I arguments in the tool_command variants caused e.g. `make COMPILER_PLUGIN_TOOL=fakebool` to fail with > sw/source/filter/ww8/ww8par.cxx:97:10: error: replace <...> include form with "..." for inclusion of a source file next to the current source file, sw/source/filter/ww8/../../core/inc/DocumentRedlineManager.hxx [loplugin:includeform] > #include <../../core/inc/DocumentRedlineManager.hxx> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I7ef513507375dcee5d88db53cef58433f7f68e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26tdf#133216 - Objects are not printed (Win-only)Chris Sherlock
Seem to have been introduced in commit 6fa6704a7e7c6970b7a7c:6 "vcl: move functionality out of checkRect(), rendering function obsolete" This reverts: commit 7b47a96b20122863e77aa1918e878372b3485c9f. "vcl: refactor code into GenerateConnectedComponents()" commit 5ef0f7dfafd8b83818c831914467f93e47a5bb2f. "vcl: refactor code into GenerateIntersectingConnectedComponents()" commit 93649784ddbb7d9ca779d14fd60fb97385325d17. "vcl: move stage 1 functionality into DetectBackground()" commit 34a699f1894f30f68c3243784586617e01e60ab6. "vcl: refactor by creating GetActionAfterBackgroundAction() function" commit f85769f61b2d2380750be564c6de47f28be35b8a. "vcl: refactor by creating RecordMapModeChanges() function" commit 8318a636336dd6d6b5862a3366f85f96c64d8243. "vcl: refactor by creating SetBackgroundColorAndBounds() function" commit f0ca5a0c447f4fe4667693d744af61eaeb0625ee. "vcl: move functionality into FindIncompletelyOccludedBackground()" commit 449f23c44ccdf6d2bfe7baa143d32d8f585aef4b. "vcl: new local function setComponentsSizeAndColor()" commit 6fa6704a7e7c6970b7a7c695a4a548f8dc693d03. "vcl: move functionality out of checkRect(), rendering function obsolete" Change-Id: Ic85397c1b69f2b529cff90206387d017692cecf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94804 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-20 07:12:13 +0000