summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-24apparmor: allow also /usr/lib{,32,64}/jvm/**/bin/javaRene Engelhard
since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9 Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333
2018-05-24tdf117333 dbahsql: Chain SQLExceptionsTamas Bunth
Change-Id: Ic24d79f39d9cc36cf229c7410e1f96c4c3d316f9 Reviewed-on: https://gerrit.libreoffice.org/54671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-05-24libreofficekit: Run gla11y on gtv.uiSamuel Thibault
Change-Id: I1bb2be7d3636b70018276eb3d6b23ba7ace6e62a Reviewed-on: https://gerrit.libreoffice.org/53926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-24Properly handle language-specific parts of --with-help=html media/ sub-treeStephan Bergmann
...that previously ended up in language-independent parts of installation sets. The structure of that media/ tree doesn't allow to directly mis-use the existing AllLangPackage machinery (which expects the language to be encoded in the first pathname segment within the tree; and which is already mis-used for the helpcontent2/AllLangPackage_html_lang.mk parts). So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the language explicitly, independent of where it is encoded in the pathname (if at all). The underlying gb_AllLangPackage_add_file sets a gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need further fixing by anybody actually using that target; see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html> "Broken --with-help=html `make packageinfo`". All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed in either helpcontent2/Package_html_media.mk (for the language-independent files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language- specific files). Also note the two TODOs in helpcontent2/AllLangPackage_html_media_lang.mk. What is not quite right yet is that content from helpcontent2/AllLangPackage_html_lang.mk and helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language helpcontent installation sets (as intended, via the instructions in helpcontent2/CustomTarget_html.mk) and per-language languagepack installation sets (which is unintended). This needs to be fixed with a follow-up commit. This is the core part of a commit spanning core and helpcontent2. Change-Id: Ib29e52cf8a3ca7bcd234a8f6919c8eac6157cdbf
2018-05-24Updated coreStephan Bergmann
Project: help 33551e7fd85aa327f76bb343a3740bceb162bbfa Properly handle language-specific parts of --with-help=html media/ sub-tree ...that previously ended up in language-independent parts of installation sets. The structure of that media/ tree doesn't allow to directly mis-use the existing AllLangPackage machinery (which expects the language to be encoded in the first pathname segment within the tree; and which is already mis-used for the helpcontent2/AllLangPackage_html_lang.mk parts). So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the language explicitly, independent of where it is encoded in the pathname (if at all). The underlying gb_AllLangPackage_add_file sets a gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need further fixing by anybody actually using that target; see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html> "Broken --with-help=html `make packageinfo`". All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed in either helpcontent2/Package_html_media.mk (for the language-independent files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language- specific files). Also note the two TODOs in helpcontent2/AllLangPackage_html_media_lang.mk. What is not quite right yet is that content from helpcontent2/AllLangPackage_html_lang.mk and helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language helpcontent installation sets (as intended, via the instructions in helpcontent2/CustomTarget_html.mk) and per-language languagepack installation sets (which is unintended). This needs to be fixed with a follow-up commit. This is the helpcontent2 part of a commit spanning core and helpcontent2. Change-Id: Ie7916b75eee0dde3106e784d19e99fde5bb93195 Reviewed-on: https://gerrit.libreoffice.org/54749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-24member can be a ref instead of a pointerCaolán McNamara
Change-Id: Idb0c27933b42f3aef65f0bce098f9bd7a81dc034
2018-05-24ScTabViewShell is never optionalCaolán McNamara
Change-Id: I9f42fd6179c0a64cc14a051ca7c9e2ed9300f5c8
2018-05-24coverity#704702 Dereference after null checkCaolán McNamara
Change-Id: I876ffc1511b2115562039b97961c28d7b30e2c06 Reviewed-on: https://gerrit.libreoffice.org/54730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24coverity#1435749 silence Uncaught exceptionCaolán McNamara
and coverity#1399120 Uncaught exception Change-Id: If411cd6a392636c6ac99f1ae330b16611b24df93
2018-05-24coverity#1435748 silence Unchecked return valueCaolán McNamara
Change-Id: Iba303276f9c9564eb4afe2a9238b009dc8bbc9d3
2018-05-24reduce some unnecessary ScRangeList copyingNoel Grandin
and reduce unnecessary work in ScRangeList Change-Id: I0ee767fe28571f75f8a2ff980cea27c97c9797dc Reviewed-on: https://gerrit.libreoffice.org/54705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-24[Pardus] tdf#92685 Add insert page count option to header menuGulsah Kose
This patch is sponsored by ULAKBIM/Pardus project. Change-Id: I5ecca4f58ec0ecf6a639153b52a4424af1966820 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/54687 Tested-by: Jenkins <ci@libreoffice.org>
2018-05-24tdf#42949 Fix IWYU warnings in sd/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Removal proposals are dealt with here With fallout management as necessary Change-Id: Iaef9eec626334c480dd5a2def63bb476350ceebb Reviewed-on: https://gerrit.libreoffice.org/54617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-24EPUB export: fix gla11y warningsMiklos Vajna
Change-Id: I4d2ca93ff01e27ee3400adab230cb8679aacdaa9 Reviewed-on: https://gerrit.libreoffice.org/54727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-24Fix typoAndrea Gelmini
Change-Id: I0635a5f4f02a1de222656133bca1ff2da8ce59f6 Reviewed-on: https://gerrit.libreoffice.org/54711 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-24Add FullScreen bit to WindowStateStateTor Lillqvist
FullScreen in this context means a top-level window that is both full-screen from the desktop environment's perspective (which depending on the desktop environment might simply mean that it is as large as possible to fill its screen, leaving any system menus etc visible), *and* is in LibreOffice's full-screen mode (with no toolbars or other UI elements except the document contents visible). Not yet used, will be used in follow-up commits. Change-Id: Ia6f86e0d2a7c5a621c6f19d897d3b17ba6bfb8b4 Reviewed-on: https://gerrit.libreoffice.org/54733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-24Calc threading : Check for "self" references...Dennis Francis
...on indirect dependencies too. Here a self reference to any formula-group means if there are any references in a formula (of the formula-group itself or any of its dependencies) that points to any element inside the formula-group. If there are any self-references, then that formula-group can't be computed in parallel. For example, with this patch we can detect the following case:- Suppose the formula-group that we want to check is: "=(F2+G2-10)*10.0" spanning A2:A100. Let the formula-group starting at F2 be "=A1*0.1-10". The indirect dependency formula-group starting at F2, references back the elements of our original formula-group at A2. This makes the F.G at A2 unsafe for parallel computation. Concretly, this patch fixes a recalc crash on tdf#63638/1 Change-Id: I7b999a34571b191d2f70da6a3831f78b24a6b0a7 Reviewed-on: https://gerrit.libreoffice.org/54433 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-24Remove unnecessary includeMuhammet Kara
Change-Id: I660bc8efd441e9fc5b6f83f69dc632a26add193b Reviewed-on: https://gerrit.libreoffice.org/54712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-05-24revert tdf#76817 ooxmlimport: connect Heading to existing numbersJustin Luth
tdf#50774 has an example document which was broken by 6.1 commit 8e9e705de29a1a3d9b964c9350aa2a3a17cce6f9. Reverting does a couple of things: -go back to previous behaviour (right or wrong) - no regression. -gives an opportunity to find documents broken by reverting - i.e. it will give an indication as to which state has more broken docs. Can be re-visited in 6.2. -gives me an option to escape from this horrible mess without causing a regression in a production release of LO. Change-Id: Ib594b76d5533a0c4807cf70ef706c107e52cddcf Reviewed-on: https://gerrit.libreoffice.org/54293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-05-23tdf#117481 Breeze Add dbaccess icons for base sidebarandreas kainz
Change-Id: I5174261484c64a6f223c4a2e197d0e042c3581e3 Reviewed-on: https://gerrit.libreoffice.org/54737 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-23tdf#117629 Fix FontWork UNO API/SdrPage settingsArmin Le Grand
Change-Id: Id4da3ac2ff9f8bba382512cfafbca323d1002137 Reviewed-on: https://gerrit.libreoffice.org/54722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-23tdf#117481 Elementary: Add dbaccess icons for base sidebarandreas kainz
Change-Id: Ia4e2b0bb7b31671a50acf6659ea3ca83c3dfcb39 Reviewed-on: https://gerrit.libreoffice.org/54736 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-23Remove leftover "#undef DEBUG"Stephan Bergmann
...which might have had a purpose in the past, but look unused today. (DEBUG is defined in solenv/gbuild/gbuild.mk iff dbglevel >= 2, and `make Library_xsec_xmlsec dbglevel=2` doesn't run into any problems for me with the undefs removed.) Change-Id: I7f941e8c2d454f4206fb17bc791247606ffe6309 Reviewed-on: https://gerrit.libreoffice.org/54718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-23deb#899380 apparmor: fix gpg encryption hang trying to lock random_seedRene Engelhard
Change-Id: Ib9fb7652922dcc8364567953d17d7cae8ad170a7 Reviewed-on: https://gerrit.libreoffice.org/54726 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-23forward more a11y stuff for native drawing area widgetCaolán McNamara
Change-Id: Ic5529a73e317fb652944155fabc889b693447355 Reviewed-on: https://gerrit.libreoffice.org/54704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-23actually add AC_MSG_CHECKING/_RESULTs for --enable/disable-postgresql-sdbcRene Engelhard
Change-Id: I6b02998db5624960ba78ce8b1b0356601a80fc5e Reviewed-on: https://gerrit.libreoffice.org/54721 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-23Fix typoAndrea Gelmini
Change-Id: Ie9501a1cb9f8c2a747b92eb74c120816b49148d8 Reviewed-on: https://gerrit.libreoffice.org/54709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-23tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: https://gerrit.libreoffice.org/54720 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-23sw: prefix members of SwScriptInfoMichael Stahl
Change-Id: I1272d53d602052b09101bed8cf0fb4a19fecf52d
2018-05-23sw: fix max->min in SwTextNode::GetScalingOfSelectedText()Michael Stahl
(regression from b1ac01de06262bda39be7f970fbceeda9b267fe4) Change-Id: Ic2e835f19aaa4e9b26741c409515fc8d26cab1d3 Reviewed-on: https://gerrit.libreoffice.org/54707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-23colibre_svg: add links.txt from colibreTomaž Vajngerl
Change-Id: Ic248ce1a05f740df111a9f507c099965fdc48d35 Reviewed-on: https://gerrit.libreoffice.org/54716 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-23tdf#117481 Add dbaccess icons for base sidebarandreas kainz
Change-Id: If154c05eaf03f26655a910bf3e12c6bd867b8a03 Reviewed-on: https://gerrit.libreoffice.org/54713 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-05-23toolbar:id is not valid attribute of toolbar:toolbarChristian Lohmaier
according to framework/dtd/toolbar.dtd – and having the same ID everywhere also is kinda pointless.. Change-Id: Ia7768be2f951886e39e24d78fc6d69b4f3c84235 Reviewed-on: https://gerrit.libreoffice.org/54665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-23Add debug output operator<< for SalFrameGeometryTor Lillqvist
Change-Id: Ifb855eb3fa6d58c06cf145523dbb0735b2ca5a0b Reviewed-on: https://gerrit.libreoffice.org/54702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-23tdf#117247 just send a GRAPHIC_ARRIVED hint after updateTomaž Vajngerl
As we always load graphic complete now, we can just hint that it has arrived. In the future we might properly restore retrieving the stream of a graphic throught link manager, but not creating the partial graphic from it - just an async retrieval of the bytes. The graphic should then always be created completely with the GraphicFilter. Change-Id: I8560c9d41a057d228aa558316131ba99d436645b Reviewed-on: https://gerrit.libreoffice.org/54693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-23tdf#117729 add Frisian (fy) UI langaugeChristian Lohmaier
Change-Id: I46f75e969b1252a95118888507c116f44578dfbd Reviewed-on: https://gerrit.libreoffice.org/54699 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-23sd: extend bitmap bullet testsTomaž Vajngerl
Change-Id: I169f7306f3af2c283b1c928230eaf6566b1a6660 Reviewed-on: https://gerrit.libreoffice.org/54696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-23sd: convert XGraphic to XBitmap for the "GraphicBitmap" propertyTomaž Vajngerl
Change-Id: Idec08d4823775b11976f8650fe942f296d6dd4ce Reviewed-on: https://gerrit.libreoffice.org/54695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-23tdf#117228: crash in SfxItemSet::GetItemState...Henry Castro
(unsigned short, bool, SfxPoolItem const**) when pasting comment of closed document Re-work commit 1b7a8277aa3e9f73ccdf15e933a1ee3b42849a44. In the tiled rendering case, each view has its own clipboard, but not in desktop version which it has a shared clipboard each view. Change-Id: I57b1ab81e4c141829dbad899330e5c22204c384a Reviewed-on: https://gerrit.libreoffice.org/53922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-23Updated coreChristian Lohmaier
Project: translations 3f52ddee8a430cba4f5a9631cb41cc7981df96d0 add Frisian translation Change-Id: I2ac3bb11cf5fd5f83d65a37c7e225e4f8816cbce
2018-05-23remove Linux ("UNX") systray "Quickstarter"Rene Engelhard
Change-Id: Ie0e8b8b7ad59ee640d6b195dfae1a7cf745056fd Reviewed-on: https://gerrit.libreoffice.org/54543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-23Revert "vcl: StartPresentationMode should be using a sal_uInt32.."Noel Grandin
This reverts commit 9321c560943330fbc76dacfebff67bd740fbc95b. This is just plain wrong. Both the call sites and the function that this method in turn calls want to use sal_Int32. It doesn't seem to cause any actual problems, but that's probably just lucky. Change-Id: Id77867094b9c7c209edd8b575c9203aee6515ff3 Reviewed-on: https://gerrit.libreoffice.org/54691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-23rename config_extension_update.h.in to config_extensions.h.inRene Engelhard
... and move HAVE_FEATURE_EXTENSIONS there, too Change-Id: I37fe52071e1db32cf5cc1e51dbd89bb4f32a39c1 Reviewed-on: https://gerrit.libreoffice.org/54072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-23tdf#115386: Show Mail Merge toolbar for documents with MM fieldsMike Kaganski
Change-Id: I357a30d72c5ac4af8c64b82b4cc61c3bd606940a Reviewed-on: https://gerrit.libreoffice.org/54612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-23extend mutex protection to the whole of ScEditUtil::GetString()Luboš Luňák
Otherwise with Calc's threading enabled and novell#306440-1.xlsx this function gets called multiple times at the same time and the SetText() calls operate on the same object. Change-Id: Ic044132ac98bed46440aadbdad6ad36f3a2e9beb Reviewed-on: https://gerrit.libreoffice.org/54520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-23ofz#8473 Null-dereference READCaolán McNamara
Change-Id: Id6578d180fec3738be127993f02aaf45af915688 Reviewed-on: https://gerrit.libreoffice.org/54682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-23find-unneeded-includes: Make the output user friendlierGabor Kelemen
This way it's easy to copy-paste the problematic command for further investigation of IWYUs proposals Change-Id: I9e7403f0f05e64e562441941f00127a62bf15265 Reviewed-on: https://gerrit.libreoffice.org/54560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-23tdf#117505 RTF export: fix incorrect header distance for first/follow pagesMiklos Vajna
In case the first and the follow page format has different header distances, the DOC and DOCX import work with the distance from the first page format when they take the last item from the MSWordSections container at the end of the export. RTF writes section info before the document content, and in case there are separate first and follow page formats, then we work with the follow format since commit 20a53cb9e9c7b797c091fe6ac6a34dfb28c61304 (INTEGRATION: CWS limerickfilterteam08 (1.16.32); FILE MERGED, 2003-09-01) as a fix for i#13107. There is no perfect solution here, the sw doc model can store different header distances for first and follow pages, while Word works with a single distance. But RTF/DOCX/DOC import puts the relevant header distance to the first page format and DOCX/DOC export reads the distance from there, so be consistent and do the same in the RTF export as well. This means the DOCX import -> RTF export -> RTF import sequence from the bugreport will result in a correct header distance. Change-Id: I3f1fe3080360702c41d680b8785cc3602e74685e Reviewed-on: https://gerrit.libreoffice.org/54680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-23Fix typoAndrea Gelmini
Change-Id: Ic7a5cceb30c3301c05d1ec241ec7afb86af035d7 Reviewed-on: https://gerrit.libreoffice.org/54667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-23Fix typosAndrea Gelmini
Change-Id: Ibe94c7379a9389a0506c33666bf2bfb033f96f08 Reviewed-on: https://gerrit.libreoffice.org/54670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2024-12-28 06:15:00 +0000