summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-24Consistently use OUString in test::DirectoriesStephan Bergmann
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2 Reviewed-on: https://gerrit.libreoffice.org/41466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-24remove unused error code in vclNoel Grandin
ever since commit 920d4463f6e59b815852c173e2974ffc7b4bb284 Date: Thu Jun 23 13:13:28 2016 +0200 loplugin:singlevalfields in vcl(part1) Change-Id: I3691d03dadff10585a119ca8db8aa193b5a01702 Reviewed-on: https://gerrit.libreoffice.org/41492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24loplugin:useuniqueptr in cppcanvasNoel Grandin
Change-Id: I8e995128a7a1c5911efc82a762dbe7be015b2050 Reviewed-on: https://gerrit.libreoffice.org/41493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24Replace some lists by vectors in xstorage (package module)Julien Nabet
Change-Id: I0093b87ff70d9ea31ca08f8df161899d5ff4bb9f Reviewed-on: https://gerrit.libreoffice.org/41478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24oox: kill redundant breaksThorsten Behrens
Change-Id: I18aadb7b6b2fa50159624df1b4a7de9270473785 Reviewed-on: https://gerrit.libreoffice.org/41480 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24unnecessary condition:rGraphic.IsDummyContext()ccsheller
when bDummyContext is true at pre code,and call the rGraphic.SetDummyContext( false ). so this is unnecessary condition at follow code. Change-Id: I69da58485fd7b81c9111e188d47b98fe8065fc47 Reviewed-on: https://gerrit.libreoffice.org/41489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24remove unused error codes in svtoolsNoel Grandin
which seem to be unused since initial import Change-Id: Id5216bac53fafc1020003de10d8dde381b1121cf Reviewed-on: https://gerrit.libreoffice.org/41491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24Related: tdf#108795 never use an unresolved LANGUAGE_SYSTEM in SvxAutoCorrectEike Rathke
Substitute with the current work locale, using MsLangId::getSystemLanguage() instead was also wrong. Change-Id: I55db3bc1f76329320afc1f366d7426a8c2f66fb2 Reviewed-on: https://gerrit.libreoffice.org/41476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-24Related: tdf#108795 a shared SvxAutoCorrect instance can not be statefulEike Rathke
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect(). Since commit 284eb106767d094fc5c547efd6c11cc390e3538a and following the SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously inserted NO-BREAK SPACE should be removed again, depending on the next character input. That does not work, for example, if SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine instances, like it is the case in the Calc input line and cell which are synchronized; or any other two or more instances for that matter. The caller has to pass and remember a flag that is maintained by SvxAutoCorrect. Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412 Reviewed-on: https://gerrit.libreoffice.org/41475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-23Fix typoAndrea Gelmini
Change-Id: I04ca767a317af6afa8f3ef82fee137c86211e34a Reviewed-on: https://gerrit.libreoffice.org/41479 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-08-23tdf#111795 - Special character preview control should have borderAkshay Deep
Change-Id: Ic26888829c24f65b3d8039e74a632c14be338d44 Reviewed-on: https://gerrit.libreoffice.org/41356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-23tdf#45904 Move Java _XUniqueCellFormatRangesSupplier test to C++Jens Carl
Change-Id: I66c62f1676515437197d1875600407408040ca74 Reviewed-on: https://gerrit.libreoffice.org/41445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Remove/disable obsolete _XSpreadsheetDocument Java testJens Carl
The _XSpreadsheetDocument test is already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: Icc0fc266f6e375ceb94edd5a95d396540972a908 Reviewed-on: https://gerrit.libreoffice.org/41409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Remove/disable obsolete _XSheetOutline Java testsJens Carl
The _XSheetOutline tests are already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: I0803df8dec6fd2f18e89c7bd8b8d15d0e4ee4aa2 Reviewed-on: https://gerrit.libreoffice.org/41408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45905 Remove/disable obsolete _XNamedRanges Java testsJens Carl
The _XNamedRanges test are already written in C++ since commit b9337e22ce1dbf2eba0e8c8db294ae99f4111f91. Change-Id: I8610cc50ce23de7183efb5d9b6b436f1b9dceae1 Reviewed-on: https://gerrit.libreoffice.org/41349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Remove/disable obsolete _XDataPilotTable Java testsJens Carl
The _XDataPilotTable tests are already written in C++ since commit 95780ec73990f96dc16fc677c895d00fa1360008. Change-Id: I5785a2b8edbe3166c8f81348cb36c117a4b9b736 Reviewed-on: https://gerrit.libreoffice.org/41079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23tdf#45904 Move Java _XAreaLink tests to C++Jens Carl
Change-Id: I95112555de3a5dd5a75c478edb5856cf79919db9 Reviewed-on: https://gerrit.libreoffice.org/40859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-23DOCX: Fix an other test case of ActiveX control exportTamás Zolnai
When LO control is anchored to the end of the run, it is exported into a new run. Change-Id: I9269fd1b34924780aad61c452d1e2094dc8e4aad Reviewed-on: https://gerrit.libreoffice.org/41472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23loplugin:useuniqueptr, look for containers..Noel Grandin
that can use std::unique_ptr, and apply it in i18npool Change-Id: Ib410abaf73d5f392c7a7a9a322872b08c948f9e9 Reviewed-on: https://gerrit.libreoffice.org/41438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23VML, Watermark: detect shapetype from other subdocumentsSzymon Kłos
In some documents Watermark wasn't visible because shapetype wasn't detected. It was impossible to use shapetype defined in header1.xml in shape placed in the header2.xml. Change-Id: Ib406c8fc702968684ad46efd0857b768af2820f5 Reviewed-on: https://gerrit.libreoffice.org/41395 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-23Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apkGautam Prajapati
This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/ and xmlsecurity/ module to use NSS. xmlsecurity/ wasn't built for Android previously, this commit enables building xmlsecurity/ for Android and disables the support of gpgme in the same module(Only for Android). It also enables the linking of NSS shared libraries with liblo-native-code.so and adds a rule to package them along with the apk. Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1 Reviewed-on: https://gerrit.libreoffice.org/41308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23Clean up string constructionStephan Bergmann
Change-Id: I41ca0c7c9ac1892cc87eb4dbba858527aa340c75
2017-08-23ScFiltersTest::testUnicodeFileNameGnumeric only works with UTF-8Stephan Bergmann
Change-Id: If31062abf50125c65a90566f1276f37d6725f73c
2017-08-23libxml2: bunch of CVE fixesMichael Stahl
Change-Id: Ic786fef17cbdb574c342925a4c57875123ef3151
2017-08-23osl::Directory::createPath with excess slashes fails with E_INVAL on WindowsStephan Bergmann
Change-Id: Ic7d8a2e9bdad9a255f984116c4fdecd0e1c0d265
2017-08-23Report osl::Directory::createPath failureStephan Bergmann
Change-Id: I75ede7f03edf80c00d33281afdebc3b620fb33eb
2017-08-23Make ScBootstrapFixture::createFileURL generate properly encoded URLsStephan Bergmann
Requires the rsBaseString arg to the ScBootstrapFixture ctor to consitently be passed as a relative path without a leading slash. Change-Id: Ieff38d465b0053fdae42acc4babfb34d1a4827bd
2017-08-23drop SwBackgroundDestinationItem wrapperJochen Nitschke
other call sites just use SfxUInt16Item and overridden Clone does same as base class. Change-Id: I50acb4fbb08b3c2fdc4c7605d0ccecac0e9cc209 Reviewed-on: https://gerrit.libreoffice.org/41449 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-23loplugin:constparam in sc part2Noel Grandin
Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268 Reviewed-on: https://gerrit.libreoffice.org/41447 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23tdf#111964: only trim XML whitespaceMike Kaganski
OUString::trim() uses rtl_uString_newTrim, which relies upon rtl_ImplIsWhitespace. The latter treats as whitespaces not only characters with values less than or equal to 32, but also Unicode General Punctuation area Space and some Control characters. Thus, using OUString::trim() is incorrect when the goal is to trim XML whitespace, which is defined as one of 0x09, 0x0A, 0x0D, 0x20. The comments for OUString::trim() and rtl_uString_newTrim are corrected to describe which characters are considered whitespace. A unit test included. Change-Id: I45a132be923a52dcd5a4c35aeecb53d423b49fec Reviewed-on: https://gerrit.libreoffice.org/41444 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-23tdf#109184 auto cell color should be transparentSzymon Kłos
Don't add color to the property map if is set to auto. In this case white color was assumed and tables were white instead of transparent. Change-Id: I7f203b8f3831b86ba8de33dc57de227b3029c6d9 Reviewed-on: https://gerrit.libreoffice.org/41255 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-23configure: attempt to fix Android buildMichael Stahl
Can't find CONF-FOR-BUILD/donwload.lst Change-Id: Ie6bb993a2d6fcd7723b9f4437284b862eb194316
2017-08-23Don't crash if aProfileId is nullTor Lillqvist
Change-Id: I1505469200c4bcc82f07eae325882fd6454ebcc5
2017-08-23fix bug in ScTable::LastHiddenColRowNoel Grandin
found by inspection, noticed that the for loop is not actually using it's index variable introduced in commit b3579d71c6536ab1d03cc47249d582a574fd054a koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386# million, and integrated lots of speed optimization and bug fixes to ensure Calc remains usable after the row limit increase. Change-Id: Icfee19ddb051e8d4333ed4c91d384379bf494444 Reviewed-on: https://gerrit.libreoffice.org/41439 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23tdf#108943 RTF import: handle \tx inside a list level definitionMiklos Vajna
\tx in the list level definition has a different meaning (we should map it to the ListtabStopPosition UNO property), compared to when it's used as a plain text property. Change-Id: I7b98ae3d82bbd2c4ad41d0d7f4ad50525c4d0f9a Reviewed-on: https://gerrit.libreoffice.org/41442 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-23configure: try to keep PYTHON_VERSION from going staleMichael Stahl
Since it was set to 3.5.0, the bundled python was upgraded twice, but the directory is still named python-core-3.5.0 :( Change-Id: I15eec4148c2436e1f289d9851ce5bd212d4a368a Reviewed-on: https://gerrit.libreoffice.org/41433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-23Fix WID rangesStephan Bergmann
Change-Id: I50e7f6b16d835ec86e8a98e6d94ee812391a37d4
2017-08-23Fix and enable libxmlsec build for AndroidGautam Prajapati
This commit removes the OpenSSL dependency unconditionally from external/libxmlsec/ExternalProject_xmlsec.mk. xmlsec wasn't built for Android previously but it seems like Android was the only user of xmlsec OpenSSL backend. Now we have NSS built for Android as well, so it's safe to remove the OpenSSL dependency. Change-Id: I8652487be146c3ac643c4f6dc7a6a2845093c93f Reviewed-on: https://gerrit.libreoffice.org/41288 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23ctypeitm no more existsAndrea Gelmini
File deleted on commit 08566ea51944 Change-Id: Iccf35edc92c99779be519a4c722fa5d9bcef4b34 Reviewed-on: https://gerrit.libreoffice.org/41434 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23Fix typosAndrea Gelmini
Change-Id: Ic78d3e15c5e58f1306f8448c0806db275b3ae616 Reviewed-on: https://gerrit.libreoffice.org/41435 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-23SmartArt: shape rotation supportGrzegorz Araminowicz
Change-Id: I13bfbd3fafff5335ce8bc23b2579182aa5a94a80 Reviewed-on: https://gerrit.libreoffice.org/41393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-23SmartArt: basic support for layout constraintsGrzegorz Araminowicz
Change-Id: Ie234bfd9760cdacb6a25c04d73a260e7e59ef7d6 Reviewed-on: https://gerrit.libreoffice.org/41273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-23tdf#111844 infobar icons/text on high dpiHeiko Tietze
scaling factor added to text position Change-Id: Iaeb48fd4ac0439680fa3b6ca43f23a617efe1457 Reviewed-on: https://gerrit.libreoffice.org/41417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-23tdf#111975: Inline checkbox control's label is not saved to DOC formatTamás Zolnai
This MiserableFormFieldExportHack lives from the beginning of the git history: 7155b11b7eac65e242aca1efaf29ffcfa28f2564 So it might be a workaround of an old issue. By now when the checkbox is not inline, but a floating one, it is exported as ActiveX control, which works nicely. So just remove this workaround and let the code export also inline checkboxes as ActiveX controls. Change-Id: I350b7a7595bb46334c63d9dfcf40abf9e10943bc Reviewed-on: https://gerrit.libreoffice.org/41436 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-22editeng: warning C4701 potentially uninitialized local varMichael Stahl
Change-Id: I611f0b5652722f0de38dfb82440823b832a6029c
2017-08-22unotest: really run every CppunitTest with its own user profileMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt that was written by another unit test, in particular the file workdir/unittest/user/config/autotbl.fmt. The tests are actually started with -env:UserInstallation=$(call gb_Helper_make_url,$(call gb_CppunitTest_get_target,$*).user) to prevent exactly this problem, but unfortunately it's then overridden by a call to rtl::Bootstrap::set(), which overrides even command line arguments, from test::BootstrapFixtureBase::setUp(). Change-Id: I618574e94755ea38caf9583f3dcf7715396bca48 Reviewed-on: https://gerrit.libreoffice.org/41432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22editeng: avoid infinite loop in SvxBoxItem::CreateMichael Stahl
Apparently a sw unit test randomly read a partially written autotbl.fmt and the stream has m_isEof = true. Change-Id: Iacfbc42e83be6320d4aa695a5df4264f1db0b021
2017-08-22drop unused SvxScriptTypeItemJochen Nitschke
apparently there was never a user for this item since initial commit in the year 2000. SvxScriptSetItem gets the ScriptType by parameter see GetItemOfScript and PutItemForScriptType. remove SID_ATTR_CHAR_SCRIPTTYPE and don't put the item in any set. keep the gap in the ID range because it's not part of any range and there are already other gaps. Change-Id: Iee24f13b329593af2dc5548d8b6bc2282c2dc5b3 Reviewed-on: https://gerrit.libreoffice.org/41423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:constparam in sc part1Noel Grandin
Change-Id: I82fba7ebb3b4f018721642c96bbfa615c6a382c3 Reviewed-on: https://gerrit.libreoffice.org/41419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>