summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-06Sifr icon: add and update icon themeandreas kainz
Change-Id: I5fd636ce03b5ff47ff5e9263203a882bff7f21f5 Reviewed-on: https://gerrit.libreoffice.org/67430 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-06writerfilter: make members private in RTFMathSymbolMiklos Vajna
Change-Id: I5c63c28ba4c63e17b74e656d5382d45c9fcc6baa Reviewed-on: https://gerrit.libreoffice.org/67428 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-06tdf#107792 vcl/win: simplify WinSalInstance::CreateVirtualDeviceDmitriy Shilin
Change-Id: I7e2fd41f8c4359374af143aaf7544bb61a8878c7 Reviewed-on: https://gerrit.libreoffice.org/67189 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-06store originating exception when re-throwingNoel Grandin
Change-Id: I26959d3604a581f1528e575239970ab364c7fd50 Reviewed-on: https://gerrit.libreoffice.org/67413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06loplugin:flatten in soltoolsNoel Grandin
Change-Id: I3df754c58c90978ef5fccc90518ad1af92516a9e Reviewed-on: https://gerrit.libreoffice.org/67404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06Fix typoAndrea Gelmini
Change-Id: I1ba3434d13b8976ee80a8c45c137dccf27cecac7 Reviewed-on: https://gerrit.libreoffice.org/67432 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-06tdf#123189 DOCX import: skip table bkground colorLászló Németh
settings to keep interoperability, use only cell properties, as MSO. Change-Id: I167eb0e8732fa7dc7f890c2a21d59a15299be8ba Reviewed-on: https://gerrit.libreoffice.org/67429 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-02-05weld WebConnectionInfoDialogCaolán McNamara
Change-Id: Idff8a0589075c8b7c774f187f5082fd954251d77 Reviewed-on: https://gerrit.libreoffice.org/67420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05Remove code committed involuntarily.Xisco Fauli
Follow-up of a7da594593eb2d63004a91dc471683713ce9742a Change-Id: I7e252f9a881b2ac1098bc21bd193f66d32404056 Reviewed-on: https://gerrit.libreoffice.org/67423 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-05Move dubious file: -> smb: conversion from INetURLObject to file UCPStephan Bergmann
The Linux-only conversion of file URLs with a non-empty (other than "localhost") authority to smb URLs had been added in 2010 with 0b9ef81ba5ff08d85f21275222458a5b9b9e484c "tools-urlobj-smb-scheme-patch.diff: migrated" (applying a Go-oo patch?) but giving no rationale beyond "process relative SMB paths (in hyperlinks) correctly". That makes it hard to tell whether that patch is (still) actively useful for anything, or was just a misguided hack from the beginning: * Why make this Linux only? What about other non-Windows OSs? (On Windows, such URLs can be resolved as UNC pathnames.) If the reason for Linux-only was that it is the only OS where LO can handle smb URLs via GIO, why not make it conditional on ENABLE_GIO? * Why map to smb? There are various remote file access protocols. Hardcoding smb looks arbitrary here. Anyway, INetURLObject is arguably at a wrong level for such a patch. To not drop the hack wholesale, reimplement it in the file UCP, forwarding to a potential other UCP that can handle smb URLs any file://<host>/... URLs (rewritten as smb URLs) that the file UCP cannot handle itself. (file://localhost/... URLs will already have been normalized to file:///... by INetURLObject when they reach the file UCP, and even if they were not, the osl/file.hxx functionality underlying fileaccess::TaskManager::getUnqFromUrl knows how to handle them, so they will not take the forward-to-smb code branch.) (The corresponding #ifdef WIN code from 0b9ef81ba5ff08d85f21275222458a5b9b9e484c has already been removed with 82034b04e81b74a048595b0eac0f73581ecbc9e4 "tdf#119326 crash when adding "Windows Share" File resource".) (I came across that 2010 patch while looking into <https://bugs.documentfoundation.org/show_bug.cgi?id=107461> "Does not support 'file://' scheme with actual hostname". A next step would be to make the file UCP actually handle any file://<host>/... URLs that denote the local host.) Change-Id: I77242705dc4c6c1e9cb3a4f32253224ac6cb13cb Reviewed-on: https://gerrit.libreoffice.org/67372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-05Sifr icons: update svg theme and png oneandreas kainz
Change-Id: Ia706cce2a3eaba597f0d8b9cd3cf9ca2e9e8e49f Reviewed-on: https://gerrit.libreoffice.org/67421 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-05tdf#122625: Use solution for tdf#118879 in a more general caseXisco Fauli
Partially revert commit 36aa3f4d6f9e9da7289ed760cfb1e87600cb6459 Change-Id: Ia554d3e64da2ee620c69bc66b33a6cd305502c64 Reviewed-on: https://gerrit.libreoffice.org/67418 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-05weld CertPathDialogCaolán McNamara
Change-Id: I73c5aa3694d2580b707c2ce769e3e9ffbc076ec8 Reviewed-on: https://gerrit.libreoffice.org/67406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05sfx2: allow storeToURL() on the main threadMiklos Vajna
This is similar to commit f1e775470e68fb1ca1fee390c10064c55932180d (framework: allow storeSelf() on the main thread, 2019-01-30), just this handles "save as" instead of "save". The result is that combining this commit with the previous OnMainThread ones allows all of document load/save/save-as/command-dispatch on the main thread even when the action is invoked via remote UNO, which would run on a non-main thread by default. Change-Id: I7d50cceb66ecc6619fe25734107a2524ca872c2a Reviewed-on: https://gerrit.libreoffice.org/67412 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-05fix typo in commentsStephan Bergmann
Change-Id: I7defc08f6ce2a25f33839c5e8f76548d78443410
2019-02-05sc: fix -Werror,-Wshadow (Android)Miklos Vajna
Change-Id: I8e0f4e2042901b8f6bbc6e1358ca8ab5dae446ce
2019-02-05tdf#123058 qt5 fpicker: Honor autoextension settingMichael Weghorn
Store the file extension associated with the named filters in a map, and use that information to set the default file extension in QFileDialog accordingly if the corresponding checkbox in the dialog is enabled. Change-Id: I66f4f35da5d4378ac6337429e39260a4ed710a24 Reviewed-on: https://gerrit.libreoffice.org/67392 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-05tdf#122878: enable wrap for flys in footerPatrick Jaap
This patch removes the check for a footer node, intoduced by 23f698ecee033612ac3a9f5cfd7674b08bb3ccd1 preserving the behaviour for the connected bug reports i13832 and i24135. Without this check, the wraping becomes enabled for footer objects, too. With this enhencement, the commits 7df33caac85ac90c26e97dedbc201f46dc9e4cb4 d3db6ff43a531ecf1afc858a0a8832353d091644 are directly affected and therefore the unit test is edited. Change-Id: I093add9e251ac97859a66cb8b8563010ef734c2d Reviewed-on: https://gerrit.libreoffice.org/67069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-05loplugin:flatten in sotNoel Grandin
Change-Id: I66ca5113054862f1549a3d7c27da70cf4f5fc308 Reviewed-on: https://gerrit.libreoffice.org/67403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05loplugin:flatten in slideshowNoel Grandin
Change-Id: I826a43b36e35f9145c971b3608b6f56d27ff5f81 Reviewed-on: https://gerrit.libreoffice.org/67405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05Cleanup event properly; handle error from MsgWaitForMultipleObjectsMike Kaganski
Commit 11a2809e369b2a6fcbb2d7f0db131a945557c6e2 follow-up Change-Id: Id70a95f46655ade3b867e0377ddd5bee13993187 Reviewed-on: https://gerrit.libreoffice.org/67402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-05Allow computing spans of formula-groupsDennis Francis
Includes unit tests for correctness of the new functionality. Change-Id: I35f7449006d973de006a756664ae468b9a0dcb31 Reviewed-on: https://gerrit.libreoffice.org/66841 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-02-05crashtesting: crash on export of ooo37749-1.sxw to rtfCaolán McNamara
since... commit 18bb85aa303c17b7705a9ccb0dd3d76673a1955e Date: Sat Jan 12 12:04:04 2019 +0100 make SwFormat a ::sw::BroadcastingModify - clean up SwSection..Hint: Lazily reusing the Dying HintId is evil - switch the SwChartDataSequence to SvtListener - add some description to RuntimeException Change-Id: I1a83c3d11b8b05699f05e812bc021daa6fadb76a Reviewed-on: https://gerrit.libreoffice.org/67394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05Functions supporting Wildcards or Regular ExpressionsEike Rathke
Change-Id: I1e23f382e343d73a0d28ad0b88b0dc31fb75008d
2019-02-05simplify SfxEventNamesListNoel Grandin
no need to store elements of vector on the heap Change-Id: I314372b8f81b117c07676263c0c3481b51374f33 Reviewed-on: https://gerrit.libreoffice.org/67397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05Improve osl_getLocalHostname on WindowsStephan Bergmann
...returning a non-dotted result obtained from gethostname in case trying via osl_createHostAddrByName doesn't work either. The code had been like this ever since its introduction with 74f3ed51f1e3fa7a199210fd6ffc69d78a535c08 "made socket and pipe refcounted, added blocking read write methods, added direct access methods for struct sockaddr", but there appears to be no good reason not to return the non-dotted gethostname value as a fallback (and it may just have been an oversight not to do so; and on e.g. Linux we simply return whatever a successful call to gethostname provides, be it dotted or not, ever since at least ebd00f5c46707e0dfcdd074f581ae86c0576e69b "socket.cxx -> socket.c", too). (Calls to osl_getLocalHostname are few across the code base, so this change in behavior is unlikely to cause any regressions. I came across this wile looking into <https://bugs.documentfoundation.org/show_bug.cgi?id=107461> "Does not support 'file://' scheme with actual hostname", but this change is unrelated to any potential fix for that issue. It just felt right to get this fixed in passing.) Change-Id: I78e59140579b9d37ee435a8f121e58544d2235eb Reviewed-on: https://gerrit.libreoffice.org/67390 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-05tdf#119502: dbahsql: tables without primary keyTamas Bunth
No "PRIMARY KEY" keyword is needed, when composing a parsed sql which did not contain any primary key definition. Change-Id: Ife8b898806edba41a52d47dc04b1170606ea8aae Reviewed-on: https://gerrit.libreoffice.org/67379 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-02-05qt5 fpicker: Fix initial directory selectionMichael Weghorn
This takes over the fix from the KDE5FilePicker from commit 1af4ab72e2488515fcaedeb4a377ee070d68a495 for the qt5 one. Change-Id: Ibe34ecff9913fc91df2b9bd25b559375bab0ff83 Reviewed-on: https://gerrit.libreoffice.org/67385 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-05recording database fields fixedOliver Specht
Change-Id: I0abe538f37ffe6bb9b3fe0873abbf636ed0a4974 Reviewed-on: https://gerrit.libreoffice.org/67377 Tested-by: Jenkins Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2019-02-05oox: disable gradient fill grab-bag for PPTXMiklos Vajna
This was added in commit 2fcf3a871c94feeca11619ef5c8c0466ce61eb74 (ooxml: preserve gradient shape fill, 2014-01-31), and assumes that the theme colors can be preserved, as the theme definition is grab-bagged as well. But the theme is grab-bagged only for DOCX, not for PPTX, so skip gradient grab-bag for PPTX, otherwise the gradient would refer to incorrect colors in the theme. Change-Id: I98e1c67d4b10e68916f81dd7fc508eb4146d506b Reviewed-on: https://gerrit.libreoffice.org/67386 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-05tdf#122435: reimplement fix for tdf#109085Mike Kaganski
This reverts commit 3d8c159841bcab7365b2bed3df71ed3c15188312, and instead, checks if the MtaOleReq window is not destroyed yet, in addition to the wait for the condition. This allows to avoid wait forever for condition which never gets signalled, and process the sent messages when waiting. The window's WM_DESTROY handler sets the event signalling that. The Win32Condition's wait() is changed to take the abort event, and return true if its own event fired, and false if abort event fired. Change-Id: I1861dd3dabb39329976a3ccf2a5392c9ddbf9613 Reviewed-on: https://gerrit.libreoffice.org/67383 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-05weld TSAURLsDialogCaolán McNamara
Change-Id: Iae3f4f1acfca02daa66726da3434ffb4406ff71d Reviewed-on: https://gerrit.libreoffice.org/67380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05Sifr icons: add sc_ svg icons and update png oneandreas kainz
Change-Id: Ic67ef4baffaa37eb09332abda39de1a951d16b20 Reviewed-on: https://gerrit.libreoffice.org/67384 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-05tdf#121867 DOCX filter: handle page width zoomMiklos Vajna
And other non-fixed zoom types, similar to how DOC does it. Change-Id: Ie84340b4e662d2329b5d3918900adfd0c3e9b8e9 Reviewed-on: https://gerrit.libreoffice.org/67378 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-05Clang ASan fails with goldStephan Bergmann
...for whatever reason. Failure is > AddressSanitizer:DEADLYSIGNAL > ================================================================= > ==16438==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x2b6ba8bfe65c bp 0x7ffca100f290 sp 0x7ffca100ba28 T0) > ==16438==The signal is caused by a READ memory access. > ==16438==Hint: address points to the zero page. > #0 0x2b6ba8bfe65b (<unknown module>) > > AddressSanitizer can not provide additional info. > SUMMARY: AddressSanitizer: SEGV (<unknown module>) > ==16438==ABORTING > /home/tdf/lode/jenkins/workspace/lo_ubsan/testtools/CustomTarget_uno_test.mk:25: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CustomTarget/testtools/uno_test.done' failed (<https://ci.libreoffice.org/job/lo_ubsan/1177/>, but also seen with local ASan+ UBSan builds.) Started to fail with 98f5f97d4a4206ecfb0754e1901d9c44a3287d82 "make --enable-ld the default for debug builds, if available". (lld would automatically be disabled by configure.ac because it doesn't support --dynamic-list-cpp-typeinfo as needed by UBSan.) Change-Id: I7bfbfc4c879cbad7748e5855c22698eec5efc94c
2019-02-05sifr icons: add sc_ svg icons and update png oneandreas kainz
Change-Id: I0e838bddbbaa5f89dff9723be29cf25a9d06c6d3 Reviewed-on: https://gerrit.libreoffice.org/67381 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-05Fix typosAndrea Gelmini
Change-Id: Ie186b828d500b661029704f95f4c03e56d69c282 Reviewed-on: https://gerrit.libreoffice.org/67382 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: Ie8e1a7fdc8c728c7e9e43a444f0d039b2d60b121 Reviewed-on: https://gerrit.libreoffice.org/67309 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: I136a1cdb4a1522d78120f12e5f9ea5ced653c1b6 Reviewed-on: https://gerrit.libreoffice.org/67334 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: I371ff95ff9d05e0c57844f99c222165e55aa51e8 Reviewed-on: https://gerrit.libreoffice.org/67332 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: Icf81629c80b6c39cef98cba3ba98a20089f7b9ef Reviewed-on: https://gerrit.libreoffice.org/67331 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Fix indentationMatteo Casalin
Change-Id: I2ee92b2fcf0fd589663a0141a67a9aabee180159 Reviewed-on: https://gerrit.libreoffice.org/67330 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: I1786e75ff12f16450f62f5091981a26c89af2514 Reviewed-on: https://gerrit.libreoffice.org/67329 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use optimized OUString concatenationMatteo Casalin
Change-Id: Ib83b8cf3cbd46008413c71c098fea9946c090766 Reviewed-on: https://gerrit.libreoffice.org/67328 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: I7637728bac4b7f0df56c564b204dce08db1298e8 Reviewed-on: https://gerrit.libreoffice.org/67326 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: Ic500623b851cd8f4db665aa7c3de7443e0d39a87 Reviewed-on: https://gerrit.libreoffice.org/67324 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: Ifd3885d07f7bcad46039560bbb19f48074fb4cd0 Reviewed-on: https://gerrit.libreoffice.org/67323 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: I7f27f9a8023102c5e07fb45ed40e06ee862fccde Reviewed-on: https://gerrit.libreoffice.org/67322 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-04Use indexed getToken()Matteo Casalin
Change-Id: Ic81c216d24eb0b41549f2b82a3888c466d26c5ca Reviewed-on: https://gerrit.libreoffice.org/67321 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
generated by cgit (git 2.34.1) at 2025-01-31 13:22:58 +0000