summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-25lokdialog: Fix incorrect dialog sizes sent to clientPranav Kant
GetSizePixel triggers pending resize handler and gives more correct sizes than GetOptimalSize(). Some of the dialog with inconsistencies in sizes like EditStyle, Manage Changes, etc. are fixed with this patch. Change-Id: I0661b7d2e98233edf0cd2c9c525b271d0724da08
2018-01-25loplugin:useuniqueptr in XMLTransformerBaseNoel Grandin
and flatten some members, no need to allocate separate object Change-Id: I9f6b7ee89af935608424a88d9343d8bbebaaada1 Reviewed-on: https://gerrit.libreoffice.org/48513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:datamembershadow in SvxUnoTextRangeBaseNoel Grandin
make the superclass member private Change-Id: I665d87bfdfc3d7804cd4cac6108f9bc65b9ca2b5 Reviewed-on: https://gerrit.libreoffice.org/48552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25lok: Send the enabled / disabled state of .uno:TransformDialog.Jan Holesovsky
Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd Reviewed-on: https://gerrit.libreoffice.org/48534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25lokdialog: Parents for the Impress async dialogs.Jan Holesovsky
After 072e3ce1cfea5bb61cc5f3001c288df6deb45613, the dialogs must have parents, otherwise the LOK notification does not work for them. Change-Id: I46774d05a7d47adaaa0e06104541e47daf68f3db Reviewed-on: https://gerrit.libreoffice.org/48533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25Initialize more for sharing during pre-init.Michael Meeks
Change-Id: I12b90504ec9161318683ebad8f8e4dd1e614da89 Reviewed-on: https://gerrit.libreoffice.org/46120 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/48510
2018-01-25lok: Preload thesauri too.Jan Holesovsky
Change-Id: If2bfd3a024fc61900d3c12ff976df136d4e61bf6 Reviewed-on: https://gerrit.libreoffice.org/48502 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25sd: Kill an own scope guard impl. and use comphelper::ScopeGuard instead.Jan Holesovsky
Change-Id: I769c1c6c9d10081b706d0e1e0fbd7ad373a6e04f Reviewed-on: https://gerrit.libreoffice.org/48499 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25lokdialog: Convert the Tools -> Thesaurus... to async exec.Jan Holesovsky
Change-Id: Iee25e3fa970e5e28a14a95cfc8804ce944d4f762 Reviewed-on: https://gerrit.libreoffice.org/48497 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25why set CMDEVT on flags for unhandled commandsCaolán McNamara
Change-Id: I565e26ad01310cc05707123f4d42e24c77838793 Reviewed-on: https://gerrit.libreoffice.org/48530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25ofz#5628 close props, del extra paras, commit redlinesCaolán McNamara
Change-Id: Id019205b92b76d4514e3cf6091af7fbe6ddea47c Reviewed-on: https://gerrit.libreoffice.org/48517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25ofz#5578 remove Extraneous Paras before applying redlinesCaolán McNamara
Change-Id: Ibcc75de98f1d01f8617e34b3844b62e57142466e Reviewed-on: https://gerrit.libreoffice.org/48515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25release lastanchorpos before closing redlinesCaolán McNamara
Change-Id: I2fae6c2a6e44bdcd3c0d7f7a8cfa4a96973cc640 Reviewed-on: https://gerrit.libreoffice.org/48505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25reuse limitCaolán McNamara
Change-Id: I5942b6581c02ac55d7eb6acf535214daa5b34865 Reviewed-on: https://gerrit.libreoffice.org/48507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25ofz: out-of-memoryCaolán McNamara
Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d Reviewed-on: https://gerrit.libreoffice.org/48506 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25ofz#5661 check nLevel against maParaSprms sizeCaolán McNamara
Change-Id: I9bcaf176e6a2f70348712ca98c4176125c2f455e Reviewed-on: https://gerrit.libreoffice.org/48519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25loplugin:datamembershadow in SdXMLShapeLinkContextNoel Grandin
in this case, we can just drop the child member and re-use the parent member. The parent class barely contains any logic anyway. Change-Id: I520217c04a38b66323a76bf5fddb476bd3fc8e15 Reviewed-on: https://gerrit.libreoffice.org/48551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25[Pardus] tdf#92685 Add insert page number option to header menu.Gulsah Kose
This patch is sponsored by ULAKBIM/Pardus project. Change-Id: I9f1f5bd0f05b7f92204615b48a1e7be06272a8a3 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/47597 Tested-by: Jenkins <ci@libreoffice.org>
2018-01-25desktop: always clear LOK error message on successMiklos Vajna
Change-Id: Idefdbd3d9ae19f7cf5889017b111c12620ab08c2 Reviewed-on: https://gerrit.libreoffice.org/48541 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-25Add SAL_WARN in writerfilter graphic importPatrick Jaap
Change-Id: Iac6265094572c57f421b0533db2c90a41b2ef427 Reviewed-on: https://gerrit.libreoffice.org/48492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Fix typosAndrea Gelmini
Change-Id: If75cf86a65c6f03c6c467efb677e2f7e3e5da576 Reviewed-on: https://gerrit.libreoffice.org/48547 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25Fix typosAndrea Gelmini
Change-Id: Ieef0e3f21eb12cb5b72d39da4bc0a8c60dd0d5ce Reviewed-on: https://gerrit.libreoffice.org/48545 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25Sort dialog: Improve wordingSamuel Mehrbrodt
Previously it could easily be misread as "Include comments - only in boundary columns" (and the German translator obviously also read it that way). Change-Id: I37f58ebd6b1700e157d2355bbf05c4b42d5aae29 Reviewed-on: https://gerrit.libreoffice.org/48352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25Updating images should not depend on unrelated conditionSamuel Mehrbrodt
Instead update them unconditionally as it is done with comments. The data range has been set beforehand (considering the option to include boundary columns with images only) so at this point the swapping should happen unconditionally. Follow-up for 3a2a430ae8e2c1647c18d8904477949f6e2e7941 Change-Id: I1d75dd6e22db5cc28aa45f7b86dab013f3595199 Reviewed-on: https://gerrit.libreoffice.org/48383 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25Assert that parameters are validSamuel Mehrbrodt
Follow-up for 3a2a430ae8e2c1647c18d8904477949f6e2e7941 Change-Id: I46a4f8a4528b73e4dcb01770af127ddea4000fdb Reviewed-on: https://gerrit.libreoffice.org/48382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25Fix typosAndrea Gelmini
Change-Id: I13acf050d83099be8874514688936bb4ddbb1a26 Reviewed-on: https://gerrit.libreoffice.org/48543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25Fix typosAndrea Gelmini
Change-Id: I18d224557173b9ae5f20399b05132f45f08022a4 Reviewed-on: https://gerrit.libreoffice.org/48544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25Test for tdf#115088.Tamás Zolnai
Change-Id: I27c97d174089c6567e38899522603d4a39d8ad40 Reviewed-on: https://gerrit.libreoffice.org/48540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-25loplugin:pointerbool (clang-cl)Stephan Bergmann
Change-Id: Idaf9e1858afb8f22bba1767470138ec820a8d7cb
2018-01-25USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...presumably forgotten when the following cast of nRepeat in the SetRowsToRepeat call was changed from USHORT to sal_uInt16 in 7f33ed417b2e29e5470724ea76967f64699a2662 "removetooltypes01: #i112600# Remove tools types from sw" Change-Id: I3d1932215778977e40cc68fd3aad73477715c214 Reviewed-on: https://gerrit.libreoffice.org/48467 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25Allocate ImplPointArray::mpArray as a true Point[]Stephan Bergmann
...as the default Point ctor already zero-initializes its members, removing the need for the memset call (that causes -Werror=class-memaccess, "clearing an object of non-trivial type 'class Point'" with upcoming GCC 8). Also use unique_ptr. Change-Id: Idc139b97e18c0d48079a14755124be72da91fb37 Reviewed-on: https://gerrit.libreoffice.org/48522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25Use std::fill instead of memsetStephan Bergmann
...to avoid GCC 8 -Werror=class-memaccess ("clearing an object of non-trivial type ‘struct SwSrchChrAttr’"). Similar to <https://gerrit.libreoffice.org/#/c/48488/> "Allocate ImpXPolygon::pPointAry as a true Point[]", std::fill appears to produce adequate code here with recent compilers. Change-Id: I3ee0bc15e852b80e0429c8e0a4bc48424af9c5a3 Reviewed-on: https://gerrit.libreoffice.org/48518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25loplugin:useuniqueptr in XMLTextFieldExportNoel Grandin
Change-Id: I2b3e1ec5454bc3486fb41b010091adc549500daf Reviewed-on: https://gerrit.libreoffice.org/48512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:flatten in svlNoel Grandin
Change-Id: Id5c62c00aa8349468c0d547616424b2637533e7f Reviewed-on: https://gerrit.libreoffice.org/48485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in SvXMLNumFmtExportNoel Grandin
Change-Id: I720450a4bee17673907fba2e9a34879d2a98bcae Reviewed-on: https://gerrit.libreoffice.org/48481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in SdXMLExportNoel Grandin
and flatten some data structures, no need to allocate some of the the vector members on the heap Change-Id: I8e7e06144da2fa58c8e3352013d44d368d61ea1d Reviewed-on: https://gerrit.libreoffice.org/48480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in XMLEventImportHelperNoel Grandin
Change-Id: I2369ac92fa2f30b98b5910563dd6d0a6f8ca6a0c Reviewed-on: https://gerrit.libreoffice.org/48479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24tdf#62182 .uno:PrintLayout and .uno:BrowseView become set commands.Gulsah Kose
The patch was sent for the ULAKBIM/Pardus project Change-Id: I2c8c5d92bc6755043e086a0cad7739dd06a7655e Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/47390 Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24ofz#5573 Out of memoryCaolán McNamara
Change-Id: Ia0b291f23cd20306001f5d513eab62c49e924fa7 Reviewed-on: https://gerrit.libreoffice.org/48489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
The checks against USHRT_MAX were like that already in 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", while the casts to sal_uInt16 were later introduced with a7762676e1326ffdefbd6020b667db323640d03f "#83294# SwXTextTable/Cell::get/setData with a sequence of rows instead of a sequence of columns". Change-Id: Iab6f658f91edcec9e8e6fe6fbf0da730b3ad4581 Reviewed-on: https://gerrit.libreoffice.org/48468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24m_pTableEndPaM is unusedCaolán McNamara
since... commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c Author: Florian Reuter <freuter@novell.com> Date: Tue Sep 14 14:40:15 2010 +0200 sw-collapse-empty-table-par-like-html.diff: n#376690 Change-Id: I25b33855500f12d5475d5ed706414d7c3a24e996 Reviewed-on: https://gerrit.libreoffice.org/48494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24curl: upgrade to release 7.58.0Michael Stahl
* fixes 2 CVEs * disable some new optional dependencies Change-Id: If7725d126e68de04b67969a83c0ea08573a43679 Reviewed-on: https://gerrit.libreoffice.org/48493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-24Fix typosAndrea Gelmini
Change-Id: I359c5aff8c90359783588d189de4e5b94224fa9c Reviewed-on: https://gerrit.libreoffice.org/48232 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-24tdf#115030 Formula use "dot" instead of "acute" math command.ekuiitr
Change-Id: I5a382f73a786f45ce0b83864b21e5e6ae357fad4 Reviewed-on: https://gerrit.libreoffice.org/48440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-24Allocate ImpXPolygon::pPointAry as a true Point[]Stephan Bergmann
...as the default Point ctor already zero-initializes its members, remvoing the need for some memset calls (that cause -Werror=class-memaccess, "clearing an object of non-trivial type ‘class Point’" with upcoming GCC 8). Other such problematic memset calls are replaced with std::fill, which appears to produce adequate code with recent compilers (looked at GCC 7.2 and 8, Clang 7, at -O2), a tight loop of filling the memory with zeroes. A follow-up commit might want to use unique_ptr or vector for pPointAry. Change-Id: I566422b2213643ab762f0d87a25e745ec2f35ee4 Reviewed-on: https://gerrit.libreoffice.org/48488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24loplugin:emptyif (clang-cl)Stephan Bergmann
Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179 Reviewed-on: https://gerrit.libreoffice.org/48483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24sal_Bool -> bool (remaining uses of css::uno::Any::has)Stephan Bergmann
Change-Id: I041540307d48083955a74d20f73219ac458037fe Reviewed-on: https://gerrit.libreoffice.org/48482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24gtk3: single click with selection set doesn't unselectCaolán McNamara
this is a safe backportable fix, the unconditional nFlags |= SelectionEngineFlags::CMDEVT looks the real dubious thing to me, but only the gtk3 backend has swipe support so just returning immediately on a swipe definitely ok Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4 Reviewed-on: https://gerrit.libreoffice.org/48527 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24tdf#114913 Use master if char size wasn't setPaul Trojahn
The size returned by insertAt falls back to the master size if needed. Change-Id: I741b48616c6c848fc641c597cc72bf8b17e3cad4 Reviewed-on: https://gerrit.libreoffice.org/48456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-24tdf#115153 the missing test documentMichael Stahl
Change-Id: I74724ba61aadfad19501a87ab548219ea0a1f236