summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-01-16Use correct type when getting document colorsSzymon Kłos
After commit 0460be8848b0ce02c07183e41dd7137ac3b94164 Send document colors with lok callback There was issue detected by CI: /sc/source/core/data/document10.cxx:198:46: runtime error: downcast of address 0x6100000efa40 which does not point to an object of type 'const SvxColorItem' 0x6100000efa40: note: object is of type 'SvxBrushItem' 00 00 00 00 b0 79 19 48 ce 7f 00 00 01 00 00 00 94 00 be be 4c 17 00 00 a0 be be be cc cc ff 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SvxBrushItem' #0 0x7fce1fbed369 in ScDocument::GetDocColors() /sc/source/core/data/document10.cxx:198:46 Change-Id: I41f28b6bb54d7720d58c16d75b9d116a53f106cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162077 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-01-16cid#1586339 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I18109124eb1e78260b7cef8f809012118698e5c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162160 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-16tdf#154248 Impress: fix color of hyperlinkAttila Szűcs
Added a new FindAttrib method that searches in the attribs a bit different. The original FindAttrib searches in attribs as if their position intervals are closed from both side [Start,End]. However, the actual attribs array was created using PaMs as positions, and these are right-opened intervals [Start,End) Change-Id: I9a46b6b27ce447366fc20af1b46fd60b5c745359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161836 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162158 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-16ofz#65809 Direct-leakCaolán McNamara
since: commit c84a1928ea76cf175711942db9ca7bb2f0ec6f0b Date: Tue Oct 3 12:40:25 2023 +0530 sc: condfmt-perf: use a shared cache that... mbReadyForFinalize gets set to true, but the mpFormat is never set into the ScDocument, add a mbOwnsFormat to track successful transfer of ownership. Change-Id: I8f11c68a4253d1ad67ec96825d5036ad468562ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162128 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-16calc: on editing invalidation of view with different zoom is wrongMarco Cecchetti
This patch fixes the following invalidation issue: There are 2 views with different zoom levels. In a view text editing for a cell occurs. The other view is not invalidated properly: the computed invalidation rectangle is misplaced. Change-Id: I72db61486647640ee68e6cb2db96b2902de5b997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160303 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162161 Tested-by: Jenkins
2024-01-16crashtesting: still seeing occasional impl_notifyEvent_nothrow failuresCaolán McNamara
e.g.: #0 0x00007f5a3a5d45fc in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (this=this@entry=0x7f5a38ffd680, listener=empty uno::Reference) at include/comphelper/interfacecontainer3.hxx:253 #1 0x00007f5a3a5d9427 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> const&) (this=this@entry=0x7f5a3035ea08, func=...) at include/comphelper/interfacecontainer3.hxx:275 xListener = empty uno::Reference iter = {rCont = @0x7f5a3035ea08, maData = {m_pimpl = 0x7f5a30132260}, nRemain = 1} #2 0x00007f5a3a5d950e in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::notifyEach<com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035ea08, NotificationMethod=<optimized out>, Event=...) at include/comphelper/interfacecontainer3.hxx:290 #3 0x00007f5a3a5d39f9 in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:200 __func__ = "impl_notifyEvent_nothrow" #4 0x00007f5a3a5d3b83 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:233 rEventHolder = <optimized out> #5 0x00007f5a57cd95ba in comphelper::AsyncEventNotifierBase::execute() (this=this@entry=0x7f5a3010f670) at comphelper/source/misc/asyncnotification.cxx:139 so lets guard the OInterfaceIteratorHelper3 ctor. might as well use empty() to return early then, and align the OInterfaceIteratorHelper4 case with that. Change-Id: I138841840e032e6524792fb75168ccabc666b34c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-16tdf#53614 - Don't try to lock file after cancelling the import processAndreas Heinisch
After cancelling the import process don't try to lock the file. Otherwise, the document in use dialog will be shown which has literally no effect. Change-Id: I0a9c786899a7fc648678c785e316d28fc43c7fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162150 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-01-16Add a minimal Python extensionHossein
This is a minimal Python extension. It is possible to run main.py from: 1. Inside a LibreOffice extension 2. Inside LibreOffice, and also via APSO 3. Outside LibreOffice, as an external process, and also in a Python IDE The provided Python script is very useful for debugging extensions as an example. That is because it is possible to debug it in an IDE before packaging it as a LibreOffice extension. Python file is checked with: $ flake8 --ignore E501 main.py Change-Id: I24d9aefdfda29264bf6b5f9403a40fae35e610f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159938 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-01-16Fix typoAndrea Gelmini
Change-Id: Idfb2308f0f61a494524bb8c4bf74ae0c78b3cf06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162121 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-16Fix typoAndrea Gelmini
Change-Id: Icdfb0f41b7e69ea0efe441fdfba8b87aa370f413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162118 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-16Fix typoAndrea Gelmini
Change-Id: I86b1472e88a6baaaaf562dc69cb98b079e963ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162119 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-16Fix typoAndrea Gelmini
Change-Id: I8da56aa65ff0488097b1f0ca00ed8ad08c212d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162117 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-16sw: document SwUndoCpyDocMiklos Vajna
Explain how this differs from SwUndoInsDoc, when both insert content to the document. Change-Id: I426f5a229bffe16d98fa7f7cd0e64d394297becc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162153 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-01-16tdf#159158 writerfilter: relativeHeights of 0/1 are highest zOrderJustin Luth
Apparently 0 and 1 are the highest zOrders, 2 is the lowest, then 3... At least, this seems to be true for relativeHeight. Of course the documentation doesn't say anything about this, but documents conclusively prove a maximum zOrder of 251,658,240. [When MS Word 2019 round-trips a file with a relativeHeight of 0/1, it replaces them with the highest relativeHeight in the document, but values of 2+ are preserved.] Notice that there are two things that feed into zOrder, the other being z-index where negatives have special meaning in this context, but no special meaning for 0 or 1. Interestingly, relativeHeight is unsigned, but z-index is signed. This ends up not being a problem with a maximum of 0F00 0000. GOOD! LO normally exports starting from 2, but writes 0 if no zOrder. // It seems 0 and 1 have special meaning: // just start counting from 2 to avoid issues with that. Proof case that 0 is higher than both 300 and 225,763,766 make CppunitTest_sw_ooxmlexport8 CPPUNIT_TEST_NAME=testN747461 make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0equalA make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0equalB make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0max Change-Id: I3540252ca5b0be3b2d847f1a3885adb850f39c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162038 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-01-16tdf#159158 writerfilter: duplicate relativeHeights? last one wins #2Justin Luth
Revert the previous solution and replace it with this simpler one. This version of the patch is riskier, but from what I can see last one always wins for GraphicImport. I assume that Miklos just limited it to a certain situation as a sanity check to try to avoid causing regressions outside of the scope he was working on. The fact that all DOCX and RTF unit tests pass is a good sign. The only way I would expect this to cause problems is if z-index somehow can come into play with a GraphicImport (since both z-index and relativeHeight feed into zOrder). However, an assert didn't turn up any instances where applyZOrder was called without a relativeHeight being set. assert(m_rDomainMapper.IsRTFImport() || bOldStyle || UsedRelativeHeight); Change-Id: I28e8acd5997eed0e82d5853c85b672c62b21afe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162036 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-01-16tdf#159158 writerfilter: duplicate relativeHeights? last one winsJustin Luth
[When MS Word 2019 round-trips a file with a duplicate relativeHeight it replaces them with unique relativeHeights in the export.] My THEORY is that bOldStyle should always be true for GraphicImport, so a follow-up commit will basically revert all of this, but at least if my theory is wrong, I'll still have fixed this problem. Notice that there are two things that feed into zOrder, the other being z-Index. I assume the very explicit code that says that (except for bOldStyle) first one wins must be the standard for z-Index. make CppunitTest_sw_ooxmlexport18 \ CPPUNIT_TEST_NAME=testTdf159158_zOrder_duplicate Change-Id: I842d016a7922427ce1290a7134d4e19fed52880f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-01-16cool#1770 sw: make Edit Sections dialog async and mark it a jsdialogMéven Car
We want our dialogs to be async so they don't lock documents when opened and to allow concurrent edition. In SwEditRegionDlg, we need to make sure the reference to the SwWrtShell isn't read from 'this' after `response()`, as it is now the dialog is disposed of earlier in the async case. How to test: Create a new Writer document, insert a section, right-click inside the section, pick the 'edit section' menu item to trigger this dialog. Change-Id: Ibafca69542f13d16beef5a8fca006428cbcfe5c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161828 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161830 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-01-16sw Edit Sections: hide Link section in LOK caseMéven Car
In the LibreOfficeKit case the section does not make sense as the application has only restricted access to files, so hide it. Test: In Writer new document, insert a section, right click on section, Edit section..., Link section is visible. In LOK case the Link section is not present. Change-Id: I7aab8b384909d25e52f5fca2bf54f86e5c662b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161878 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit f9546a5e9e204fc058365aaddfb0dfa8f9a26418) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162130 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-01-16loplugin:unusedfieldsNoel Grandin
Change-Id: Ic53aacfc76cb73902cf5e304153975fa02509da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-15Add missing g_free in salnativewidgets-gtk + reorder ones in cpdmgr (vcl)Julien Nabet
Change-Id: I2608a2fe238d124f3a158438e8219fbc63f750d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162126 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-01-15tdf#159148: sc_ucalc: Add unittestXisco Fauli
Change-Id: I748529b2a35fdfcac52fe33ecd39006471ed8e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162086 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-15tdf#159174: sc_uicalc: Add unittestXisco Fauli
Change-Id: I5df0a4b4e0e9d0af5b9187def68e2971b2c86dff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162089 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-15Replace deprecated "gdk_cursor_unref" by "g_object_unref"Julien Nabet
Change-Id: I593f5d8f0775e07e67cce66432bab52723f3afff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162116 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15Fix location of an g_object_unref in vcl/glomenuJulien Nabet
Change-Id: Icef8e74867758c815e1a55ae0906dead9b70ae6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162115 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15sw: search for alternative weights when embeding on docxJaume Pujantell
Sometimes a docx document might come whith a font with niether normal or bold weight embedded as regular, so when embedding a font in docx search for alternative weights if neither a normal or bold matching font has been found. Change-Id: I95cf2634c392cec6e97e5dd12a90de6e50228ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161596 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> (cherry picked from commit 96d52b9e6879df3ab9697a7c0322cda5e08eb9af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161942 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-01-15tdf#158830 fixes regression introduces with tdf#158044Oliver Specht
Removing paragraph attributes equal to style attributes now works also for paragraphs within tables. This fixes also the regressions documented in tdf#158978 and tdf#158982 Change-Id: I9f430e23fd33cff4d6ec1d1954969666f0080574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161824 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2024-01-15Flatpak: Work around patched libpng in org.freedesktop.SdkStephan Bergmann
see <https://github.com/flathub/org.libreoffice.LibreOffice/pull/268/commits/7c79189f674c7cc88f0ab2790d8d198f4a855182> "Work around patched libpng in org.freedesktop.Sdk": ...which carries <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/873b28450476c434a3f6fa86cb1874b11968a479> "elements/base/libpng.bst: Add support for animated PNGs", thus handles "acTL" chunks by itself, thus doesn't call the LibreOffice handle_unknown_chunk function (in vcl/source/filter/png/PngImageReader.cxx) for such chunks, thus never sets APNGInfo::mbIsApng to true, so causes CppunitTest_vcl_png_test to fail with > PngFilterTest.cxx:382:Assertion > Test name: PngFilterTest::testApng > assertion failed > - Expression: aGraphic.IsAnimated() (<https://buildbot.flathub.org/#/builders/6/builds/92958>) since <https://git.libreoffice.org/core/+/bf944e33569e4a1d6236a54671b7320cdc6ffaf6%5E%21> "tdf#104877 Add basic APNG format support". The patch appears to originate from <https://sourceforge.net/projects/libpng-apng/>, and it might be possible to adapt the LibreOffice code to also work with such a patched libpng (whose png.h defines PNG_APGN_SUPPORTED). However, for now just use LibreOffice's own external/libpng instead of the patched one. Change-Id: Ib67056d11dfa6456920a18216a3b2bbec45f3662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162112 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-01-15sc: condfmt-perf: use a shared cache that...Dennis Francis
is reset only when the data changes. Resetting is done only on invalidation of associated ranges of data via a listener. Earlier there were three separate caches that resets on every draw. Change-Id: I1c185ece4b781bf6db7c82697cd5225d98c82651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157508 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 1aa1a5340f63b31524117a3cfd6e05bee2aa1aa0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161998 Tested-by: Jenkins
2024-01-15Simplify a bitMike Kaganski
Change-Id: Icdaaed6710593d8082239d14e03b71ad82165658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162085 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-01-15tdf#151752: sc_uicalc: Add unittestXisco Fauli
Change-Id: I560de65bffbac2aa8cb194a15958249176c9db46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162080 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-15editeng: return ParaPortion from the list as a ref.Tomaž Vajngerl
Change operator[] for getRef(..) method, so instead of returning a pointer, return a reference to ParaPortion instead. This also needs changes to the code, because we now need to make sure before hand that the ParaPortion is really available in the list and when this is not possible or convenient, the change the call to use existing "SafeGetObject" instead. Add "exists" to check if the object is available in the ParaPortionList. In addition add "lastIndex" method to return the index of the last ParaPortion in the list (shortcut for Count() - 1). Change-Id: Id52c38f996468af51c75d50185110ec8502169e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162071 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-01-15crashtesting: null deref of xValueSeqCaolán McNamara
since: commit 0bf4338cfe406a0d527ac78ce76ff7dd3837df03 (HEAD) Date: Mon Jan 8 13:52:03 2024 -0500 tdf#137691 chart2 export: preserve NumberFormat of DataSeries make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691 Change-Id: Ibd65207b01885961f207da04204e7e2512c20d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15tdf#140330: do not deduplicate conditional formatting in undo contextMike Kaganski
Change-Id: If9c64a7af46ca601b3c47a80642d914facafdc62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162084 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-01-15Fix typoAndrea Gelmini
Change-Id: Iea3ba026c91fd00285da842273c646dded9d8bda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162053 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-01-15Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 4b6dc2bb6c67853f31c6059ca1b8fda32f00d751 - Update SF_UI help page ui.Documents() must be defined as a method - instead of a property - in order for Python scripters not to be confused. Change-Id: Ic43c0bc212f914d2971d2366cb9b6c21e5fd6052 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161946 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2024-01-15Fix typoAndrea Gelmini
Change-Id: Ic65f4cff636d67d94cb0cafc4f75f3bb57190c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161976 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-01-15loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I14ee125874b6f0f1ff5406a3eafea0b19df1a7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-15tdf#159186 Use changed value when editing string-list a second timeSamuel Mehrbrodt
Change-Id: I0e26a053b3b5fb04abf87894bcfebccea8bdd26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162074 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-01-15android: Update com.google.android.material:material to 1.11.0Michael Weghorn
Change-Id: Ic0f84c275e8780bd2c3da42cb5387587a4e26833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161883 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-01-15android: Avoid icon name clash with material libraryMichael Weghorn
Rename the file for the keyboard icon from `ic_keyboard_black_24dp.png` to `ic_keyboard_black__24dp.png` (note the extra underscore) to avoid a name clash with an icon of the same name in the Material components: [1] Keeping the same name would result in this lint error when upgrading to material 1.11.0 (which an upcoming commit will do): > Task :lintStrippedUIEditingDebug FAILED /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 213 errors and 1 warning were filtered out because they are listed in the baseline file, lint-baseline.xml [LintBaseline] /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 6 errors/warnings were listed in the baseline file (lint-baseline.xml) but not found in the project; perhaps they have been fixed? Another possible explanation is that lint recently stopped analyzing (and including results from) dependent projects by default. You can turn this back on with android.lintOptions.checkDependencies=true. Unmatched issue types: PrivateResource, RedundantNamespace, TypographyEllipsis (3), UnusedNamespace [LintBaseline] /home/michi/development/git/libreoffice-WORKTREE-android/android/source/res/drawable-hdpi/ic_keyboard.xml:4: Error: The resource @drawable/ic_keyboard_black_24dp is marked as private in com.google.android.material:material:1.11.0 [PrivateResource] android:src="@drawable/ic_keyboard_black_24dp" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Explanation for issues of type "PrivateResource": Private resources should not be referenced; the may not be present everywhere, and even where they are they may disappear without notice. To fix this, copy the resource into your own project instead. 1 errors, 0 warnings (213 errors, 1 warning filtered by baseline lint-baseline.xml) (For the currently-used material 1.10.0, this warning was previously ignored since it's already listed in the lint-baseline.xml file, but that doesn't apply any more after an update.) [1] https://github.com/material-components/material-components-android/blob/bb351291a360319df31d5cee27e091c3e64f65a4/lib/java/com/google/android/material/timepicker/res/drawable/ic_keyboard_black_24dp.xml Change-Id: I2babc445c69f1043967118be81905c334a0285d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161889 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-01-15android: Update Android Gradle Plugin to 8.2.1Michael Weghorn
This was suggested by Android Studio. Change-Id: I7278ce5e5b21477459e40a315912c846ec9b6d57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161882 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-01-15gbuild: WASM: try to fix "Missing generated source file *_embind.cxx"Michael Stahl
Need a dependency on UnoApiHeadersTarget. Change-Id: Ie9ca3a4806d15e2535f1119a00f9214ce9520a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161973 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-01-15tdf#159068 sc: fix detective shapes (PDF/UA export)Tibor Nagy
The detective shapes(DetectiveArrow,ValidationCircle) don't have the option to set alternative text, so it should be marked as decorative. Change-Id: If83b29eb071b25f9eaa92a23337e416048b6aa8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162059 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-01-15sc: don't stop if we can't cast one view to ScTabViewShellTomaž Vajngerl
Probably the intention here was to skip the view if we can't cast it to ScTabViewShell and not stop updating all the other views when we can't cast. Change-Id: Idbc2cd2d0c0ac5773fb45badb9098cb776d56691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161958 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-01-15sc lok: set the GridWindow size to the client area size + testTomaž Vajngerl
This solves the issue when we click on a long first column (size 800px - default GridWindow size) at a right end position (>800px) and the selection jumped to the neighbouring cell. This solution reverts the workaround for this issue and properly sets the GridWindow to the current reported client visible area size (set with the ScModelObj::setClientVisibleArea call). Also includes a test for this issue. Change-Id: Ia5449893a90ffa0072aad68d772ad9b00206f113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161907 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161957 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-01-15Fix loplugin:singlevalfields handling of DesignatedInitExprStephan Bergmann
...as seen when building CompilerTest_compilerplugins_clang against recent LLVM 18 trunk libc++, > [CPT] compilerplugins/clang/test/singlevalfields.cxx > DesignatedInitExpr 0x1388bb790 'void' lvalue bitfield > `-MemberExpr 0x1388bb760 'const __alignment':'const enum std::__format_spec::__alignment' lvalue bitfield ->__alignment_ 0x1401d5868 > `-CXXThisExpr 0x1388bb750 'const __parser<_CharT> *' implicit this [...] > error: 'expected-error' diagnostics seen but not expected: > File /Users/stephan/llvm/inst/bin/../include/c++/v1/__format/parser_std_format_spec.h Line 499: oh dear, what can the matter be? [loplugin:singlevalfields] [...] Change-Id: I1cce598780bafc9306c9fbc42a1c98ff1f5450a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162075 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-01-15cid#1545843 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545976 COPY_INSTEAD_OF_MOVE cid#1546073 COPY_INSTEAD_OF_MOVE cid#1546499 COPY_INSTEAD_OF_MOVE just silence these with a hammer Change-Id: I071bc9814287944928eea0286455bc59f7f6cefb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15cid#1546160 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545547 COPY_INSTEAD_OF_MOVE cid#1545642 COPY_INSTEAD_OF_MOVE cid#1557206 COPY_INSTEAD_OF_MOVE Change-Id: I7a1bd4fcd065d4546917deb5d279691c8450f456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162061 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15cid#1545775 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546321 COPY_INSTEAD_OF_MOVE cid#1546272 COPY_INSTEAD_OF_MOVE cid#1546287 COPY_INSTEAD_OF_MOVE cid#1545443 COPY_INSTEAD_OF_MOVE Change-Id: Ia16a60665497e2c798fc03a2157587c107192558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162060 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-01-15cid#1546380 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545812 COPY_INSTEAD_OF_MOVE cid#1545463 COPY_INSTEAD_OF_MOVE cid#1545290 COPY_INSTEAD_OF_MOVE cid#1545844 COPY_INSTEAD_OF_MOVE Change-Id: Ie6d997fc6282599631dc9e07e2e59893e499c239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 06:36:12 +0000