summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-13tdf#139566: Fix select all (table + text) when document window looses focus.Tamás Zolnai
Without setting mbSelectAll properly the selection cursor is converted to a SwShellTableCursor, which can't handle if a selection is extended outside of the table. Change-Id: Ibd43097ac782b9fc02ff818d3911ebcd20efbd21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109185 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109205 Tested-by: Jenkins
2021-01-12Avoid loplugin:stringviewparam when there already is a string_view overloadStephan Bergmann
This avoids clang-cl > In file included from core/connectivity/source/drivers/ado/Aolevariant.cxx:20: > connectivity/source/inc\ado/Aolevariant.hxx(72,40): error: replace function parameter of type 'const rtl::OUString &' with 'std::u16string_view' [loplugin:stringviewparam] > OLEVariant(const OUString& us) > ~~~~~~~~~~~~~~~~^~ which would make that OLEVariant ctor overload redundant with the existing OLEVariant(std::u16string_view us); overload, but with the OUString overload gone, implicit conversions from OUString to OLEVariant would no longer work, e.g., > connectivity/source/drivers/ado/AColumn.cxx(184,76): error: no viable conversion from 'rtl::OUString' to 'const connectivity::ado::OLEVariant' > OTools::putValue(m_aColumn.get_Properties(), sAdoPropertyName, getString(rValue)); > ^~~~~~~~~~~~~~~~~ Change-Id: I92a5cc29d9fd2a5ff1a951f79df64879d0f71743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109180 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12uitest: sc: factor out common code ( part 1 )Xisco Fauli
Change-Id: Ib0b84349c138d361001af4547d91a81d8b5d8e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109166 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-12loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I64177842c3f77a5ae43574a18f389b64f61bc868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12Simplify some string constructionStephan Bergmann
(motivated by clang-cl loplugin:stringliteralvar) Change-Id: Iab08e6128a52710fd7d41f0731ac044c00e7d454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109173 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12cid#1471553 establish that pViewData will never be nullCaolán McNamara
seeing as these are created from CreateScSubTotalDlg and that is always called with a aArgSet containing a ScSubTotalItem with a non-null ScViewData set Change-Id: I1e3d243e4b00d54f9f5015a543556c39d6053f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12sw: prefix members of SwLinePortion, SwPosSize, SwRepaint and SwTextMarginMiklos Vajna
See tdf#94879 for motivation. Change-Id: I83fc138714ad170fad0465b884d6297134a0d806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109076 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-12tdf#42982: Improve UNO API error reportingBayram Çiçek
Change-Id: I78c6fed4e94f1ebfc772db4dec9955da7230bc3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109071 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-01-12Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 75c9e1fd0d4516a4bbe2a513d4a123049c92934b - Fix typos Change-Id: I232cd6b08484abea225560cfe96bd30166394dc7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109170 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-12transparency->alpha in tools::ColorNoel
this just changes the Get/Set methods, the constructor and internal representation of Color is not changed. Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12tdf#138544 sw LoadUserSettings: default DoNotJustifyLinesWithManualBreakJustin Luth
This is the second patch in the series. When you start a new document, Writer compat setting "Expand word space on lines with manual breaks in justified paragraphs" is on. Now, when saving and reloading it with LoadUserSettings disabled, it is still the program default of "on", instead of "off". So this one is slightly more dangerous because it will prevent setting old behaviours for MULTIPLE settings which are not listed in the UI. (Anything that trusts that ConsiderWrapOnObjPos to indicate a very old document.) The fact that we are explicitly not loading ConsiderWrapOnObjPos from the document should not imply that this document is an old one. At this far point away from StarOffice 8, it is probably safer to assume the document is new, not old. P.S. I'm pretty sure the reset of ExpandWordSpace was a complete error during a refactor. (At that point, it was the only item that defaulted to true.) The only scenario I can imagine is that at one point in time, ExpandWordSpace was not part of the SvtCompatibilityOptions, and so this would add it. But now it certainly is one of the options, and so this pointless pre-init is simply overwritten. Change-Id: Ibe160099839bcf40d5659f7d5246854c7c4fb5e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108546 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-12Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 6d4dab0752d6a058ea6f57d079686c3bfbf888bf - Use switches for Ctrl vs. Command on macOS Change-Id: I03d2ee23802f1da02129f5f40852d231b94c16c0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109163 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-12tdf#138995 DOCX import: fix handling of textbox zordersMiklos Vajna
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), the problem was that a textbox's shape + textframe are internally 2 sdr objects, so once GraphicZOrderHelper knows the current shape should be on top of a shape+frame pair, it should suggest a larger ZOrder. This is necessary till there is no setter version of SwTextBoxHelper::getOrdNum(), which would allow import filters to ignore this complexity, but that would be a larger change. Change-Id: Ibbb1bcd9301eb369f25f211120f62be7c59b0fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109111 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-12oox smartart: fix crash in pyra algorithm with a single child shapeMiklos Vajna
Regression from commit 14a56533ff2c9c859d22cd3039ada75b99e94bc0 (SmartArt Pyramid: Now lays out shapes, 2018-07-10), the added pyramid algorithm by first centering the topmost children, then decrementing the horizontal postion of each additional shape, with the end goal of having 0 horizontal position of the last children. This means that simply avoiding the division in the 1-child case leads to correct results, because in this case the only child is also the last child at the sane time. Change-Id: Ifd0027e9616b0909dbfde43e1555427b50de4dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109161 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-12move CppunitTest_sc_uicalc from subsequentcheck to slowcheckXisco Fauli
this way, Jenkins executes this module on Windows and Mac as well. Before I submitted this test, I ran 'make clean && make CppunitTest_sc_uicalc' on a Win machine Change-Id: I5bb708e3b61f16c3bd53da2222f19f2b73742819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109106 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-12pivot table: make options cancel button workingSzymon Kłos
Change-Id: Ife5b5b09d7fb0879f5c29a5aefeec4746bc0ae56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107816 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109099 Tested-by: Jenkins
2021-01-12jsdialog: make Data field dialog workingSzymon Kłos
Change-Id: Iae4ec2b585272fb09253b6e05ac2a59da2219fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107777 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109098 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-12jsdialog: enable Data field dialogsSzymon Kłos
Change-Id: I87a1446737f7d73b4d8b5b03590a0fcd3236c97c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107776 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109097 Tested-by: Jenkins
2021-01-12loplugin:noexceptmoveStephan Bergmann
...since 80497c7d81af36f703d122ac78baa26387a5854d "vcl: implement BinaryDataContainer copy, move + test" Change-Id: Ifb9fb074d3263686ec498ef889c25f24dd4a4013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109095 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12rhbz#1913070 null derefCaolán McNamara
its plausible that SfxViewFrame::Current() has returned null, use pSh->GetDispatcher() instead protected by null check against pSh Change-Id: Ibefdcabea09cb3a1a411678585af33a99f8a1c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12cid#1470786 Uncaught exceptionCaolán McNamara
Change-Id: I85e75e40c9280b16b12ea268b5070f0ce450208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12rhbz#1902708 null derefCaolán McNamara
Change-Id: I718ac8a59e5cb18c840e458de8e9f877c6449fd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12tdf#137083 consider negative width in DrawPageViewGridRegina Henschel
SdrPageView::DrawPageViewGrid is called too for a ScDrawPage of a RTL-sheet. In that case both the width of the SdrPage and the left edge of the passed rectangle are negative. The x-values for drawing the grid were wrong and a right-to-left sheet did not show the grid. The patch adds a case distinction with correct x-values for case RTL. Change-Id: I6d0c15bf7bbe8aff6ab2e72a440ba81f2e0e2281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108989 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-01-12WW8LVL members do not require a specific layoutStephan Bergmann
While the struct is apparently modelled after a specific data format, all the individual members are accessed by dedicated code, never via something like memcpy. Change-Id: I7eff8a251d9fa9f6d771cc425584b9765308d723 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109110 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12tdf#83618 Make line spacing values agree crash fixJim Raykowski
The intent of this patch is to fix the crash reported at https:// bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to cui/source/tabpages/paragraph.cxx in commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1 and changing the change made to svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the already available pointer to the current SfxViewFrame instead of calling the SfxViewFrame::Current function again. Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109152 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-12cid#1471720 Dereference after null checkCaolán McNamara
Change-Id: I62a8410c2f21684d063001825748f8fdbd7727b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109059 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12-Werror=maybe-uninitializedStephan Bergmann
...in code introduced with 00140e3df4a22e75261de3af18c6c0fc3f5fc92c "lok: send chart line width updates". Falling back to zero is in line with the preceding, similar sal_uInt16 nLineTransparence = 0; ... block (introduced with 3dc00a8de9f9f1b1ad0c60134391638544cdd143 "handle line dash in chart line panel"), but using o3tl::doAccess or o3tl::forceAccess might be more appropriate. Change-Id: I8c2286b386aa9052d1d2af0f9f25847829ca4df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109081 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12Translate German commentsJohnny_M
Change-Id: Ic0383c4be4f16bf0507c59f03a6453d241d93719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109032 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-12Revert "WIN replace clipboard update thread with Idle" et alStephan Bergmann
This reverts commit 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle" plus follow-up commits f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de "WIN don't notify clipboard change with SolarMutex" and c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object". The Gerrit Jenkins Windows builds had started to abort after timeout for almost all builds now. Going back to before the youngest of the above three commits, c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object" did not improve things (see the <https://gerrit.libreoffice.org/c/core/+/109100> "Test build #1, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds timed out). But going back to before the oldest of the above three commits, 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle", does look promising (see the <https://gerrit.libreoffice.org/c/core/+/109155> "Test build #7, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds succeeded). So the hope is that reverting all three commits brings back a green master, allowing us to understand and fix the actual issue later. Change-Id: Ie83ba742f216396b49f561d19c2cda7758740502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-11Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3a202a242eacd1bb7739686cc4803950cbe3d24f - Update SF_Dictionary Help page Improves text and adds new examples. Change-Id: I17fca5debf0a0f4f952a3d624ba2a64cf1d596eb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109112 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-11Revert "Revert "NotifyClients no more""Bjoern Michaelsen
- ... and ensure caching gets checked in SwFormat this time. This reverts commit d988b0cdeb54d84a0347a036a277c21c12544ab9. Change-Id: Iea887f841c47cde4a025a305eb0984392e3bb5cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109037 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-11Bin two unused macrosTor Lillqvist
Change-Id: I3e84b2183401e82b7b66c7a191b38d45ee935854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109109 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-11Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to c825f67c94487cc177b515b8d13b78d013869348 - Basic error handling functions - extra link to ScriptForge.Exception service Change-Id: Id4842de06e7f45c2f5eec61f67ec1dfee9d8341b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109009 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to abc66a37199c42a8fe969e796e91d36b9565775f - tdf#139498 update "Attributes" and "Find&Replace" help This patch updates labels so that all Attributes in 7.2 are listed in this help page, and corrects some of the explanations. ( shared/01/02100200.xhp ) (Attributes) * Revise explanation of how to search for attributes, including how to use "including styles" checkbox + add "Overline" attribute and explanation * update labels and explanation for Case effects * update label Scale -> "Character Scaling" and its explanation * update label: "Split Paragraphs" --> "Do not split paragraph" and improve explanation * correction to "Individual words" explanation * removed specification of Underlining types and Strikethough types (because many more have been added, and they all work) * improved explanations for "Outline", "Relief", "Shadow" and "Page line-spacing" * add <relatedtopics> section and embed to "Find and Replace" and "Searching with Attributes" * update to <h3> This patch makes a general review of Find and Replace ( shared/01/02100000.xhp ) (Find and Replace) * fix switch that prevented showing of header and explanation for Calc and Writer * change h2 to h3 for controls that are in a section to give better visual impression of relationships among controls * move notes to more appropriate places * combined two notes that overlapped * move position of "Comments" control for Writer * update to <h1>,<h2>,<h3>,<note>,<tip>,<keycode> Change-Id: I224eff872ffe3e584263bdc6da8bd6dfa3dbe2ff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108995 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-11Fix -Werror,-Wundef in Skia (at least for Raspberry pi 4)Julien Nabet
Detected on Raspberry pi 4, for example: In file included from /home/pi/lo/libreoffice/vcl/skia/SkiaHelper.cxx:34: In file included from /home/pi/lo/libreoffice/vcl/inc/skia/utils.hxx:28: In file included from /home/pi/lo/libreoffice/workdir/UnpackedTarball/skia/include/core/SkRegion.h:11: In file included from /home/pi/lo/libreoffice/workdir/UnpackedTarball/skia/include/core/SkRect.h:11: In file included from /home/pi/lo/libreoffice/workdir/UnpackedTarball/skia/include/core/SkPoint.h:11: In file included from /home/pi/lo/libreoffice/workdir/UnpackedTarball/skia/include/core/SkMath.h:11: /home/pi/lo/libreoffice/workdir/UnpackedTarball/skia/include/core/SkTypes.h:371:5: error: 'SK_CPU_SSE_LEVEL' is not defined, evaluates to 0 [-Werror,-Wundef] if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE1 ^ ... but there are others, see: http://document-foundation-mail-archive.969070.n3.nabble.com/Building-LO-on-Raspberry-pi-4b-error-unknown-attribute-externally-visible-on-jni-part-tt4293505.html Since it may happen on some other envs and it can't be bad to explicitely initialize this preproc var, it seems relevant to use this patch unconditionally. Change-Id: Icc5794fcd3139cbdbd8d57a6938d31aee51a3e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 0703d0cacd74d084009d7f8436fa833c77b56c1f - Refactor and fix links in database Help Change-Id: Id6a6eabd496ca6c49979e6766081d78274217c4e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109096 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-11Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to c412498d5a623090b6dab0a6a07ca71ac7bd3b7c - tdf#131206 update and correct Template fields in Insert dialog + add missing choice: path/file name * update change in field format "Style" -> "Template name" (because of tdf#139295) Change-Id: I350988201d2bb1a7b68bfb9c2bbebe42dd67bba3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108337 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-01-11Avoid assertion failure related to cursor sizes on macOSTor Lillqvist
No idea why this assertion failure started to show up now (at least when viewing a presentation slide show). Anyway, apparently the code needs to handle 256x256 cursors, too, and not just 128x128 and 32x32 ones. Apparently the assertion failure is caused by icon-themes/colibre/vcl/res/null.png. Sadly I don't really understand the code around here, but this commit gets rid of the assertion failure, and that is good enough for me for now. This problem was reported in a comment in the otherwise unrelated tdf#138122, and the assertion failure caused a hang, which is not good, reported as tdf#139535. That general problem is not fixed by this commit. Change-Id: I1390f00e03e0766d54969d9d62311a55da8e8945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109083 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 71f9d3530768b594d2e8b3ff0f9c038b23e668cf - Fix typo Change-Id: Ia17979ad96a5ba97b212223b236647af70b6f93b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109090 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-11tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorVishwas
Change-Id: Ic08f7d7c2b8da6dd5ede2a719633d123412de3ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108737 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-11CreateScSubTotalDlg always called with a non-null pArgSetCaolán McNamara
Change-Id: I8a13a66ab7ce55a48896a921dc3b91594abefbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11MakeNumberInfoItem always passed a non-null ScViewData*Caolán McNamara
Change-Id: Ibf6c837f841749b7fb25fd448c954105ef78beeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109067 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11Related tdf#123632: fix crash in accdoc (sw)Julien Nabet
Make sure to use gtk3 rendering - Open https://bugs.documentfoundation.org/attachment.cgi?id=149492 - Click F5 to open the navigator - Go to Images - Try double click the third and last image at least 15 times -> crash, here's part of bt: Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. SwFrame::IsInTab (this=0x0) at sw/source/core/inc/frame.hxx:938 938 if ( mbInfInvalid ) (gdb) bt 0 SwFrame::IsInTab() const (this=0x0) at sw/source/core/inc/frame.hxx:938 1 0x00007fd7e78caf9c in SwAccessibleDocument::getExtendedAttributes() (this=0x7e4e090) at sw/source/core/access/accdoc.cxx:596 2 0x00007fd7e78cbf9d in non-virtual thunk to SwAccessibleDocument::getExtendedAttributes() () at sw/source/core/access/accdoc.cxx:708 3 0x00007fd7f18f90ad in attribute_set_new_from_extended_attributes(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleExtendedAttributes> const&) (rExtendedAttributes=uno::Reference to (SwAccessibleDocument *) 0x7e4e180) at vcl/unx/gtk3/a11y/gtk3atktextattributes.cxx:1229 4 0x00007fd7f19113f3 in wrapper_get_attributes(_AtkObject*) (atk_obj=0x7df37d0) at vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:394 I put "Related" because I don't know if it corresponds to the initial bug but I used the attached file of the bugtracker Change-Id: Ief9fda9f7bcf277d18490169eee2e43fb046a1bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109051 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-11xmloff: "form:datasource" vs. "db:data-source"Michael Stahl
Recently xmloff started to use XML_DATASOURCE for "form:datasource" but it actually means "data-source". Add XML_DATA_SOURCE and use it for "db:data-source". (regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a) Change-Id: I893efd3fb0fb7c19ae998442459bf36cb1da0b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-11sw: fix redline assert during moving downLászló Németh
numbered list items: sw/source/core/doc/DocumentRedlineManager.cxx:97: redline table corrupted: empty redline Change-Id: Ief26248b5cad3967d867c80261c1d51f11e6233d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108940 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-01-11CreateScAutoFormatDlg always passed a non-null ScViewData*Caolán McNamara
Change-Id: I0b9568df6fdc571b5fa6cbf75a7473ac588442da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11SetTabNoAndCursor never passed a null ScViewData*Caolán McNamara
Change-Id: I972a7825306f6251f9b864ae451fdb491fcd837a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109065 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11PasteFromClipboard never passed a null ScViewData*Caolán McNamara
Change-Id: I472e280ed110bb54fc204426c50ec98acbd3a556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109063 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11ScFormatShell::pViewData is never nullCaolán McNamara
Change-Id: I29831bae8656aea014dd278c5ee87eb5f9af8db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109062 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11cid#1371301 avoid Missing move assignment operator warningCaolán McNamara
Change-Id: I93c849edbc171baba65cc44422fd396372c6f694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-04-26 20:14:00 +0000