summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-25drop some unused declarationsCaolán McNamara
Change-Id: I88a160767c22ed234777b69c9003cc3b1a065b94
2016-10-25no RSWND anymoreCaolán McNamara
Change-Id: I5547a0d19ae60ea06dd666c77deaf0de910975d0
2016-10-25no WindowResHeader, no RscWindowFlagsCaolán McNamara
Change-Id: Id41e9414237c849c211785151e9170c71a449238
2016-10-25can drop RSC_WINDOW nowCaolán McNamara
Change-Id: Ic60b35eb78ebd3e934cbf45c2184edf59c971a53
2016-10-25can drop RSC_CONTROL nowCaolán McNamara
Change-Id: I651b9d2ead019507b8e48c4e19797bf8f8b9a438
2016-10-25no Control loaded from .src nowCaolán McNamara
Change-Id: I25af1187f7888ad3f8d7078e3b59d3e4a09b8ab5
2016-10-25drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhereCaolán McNamara
Change-Id: Ibf64359936ea224dc7342585b99691f88630c6ca
2016-10-25drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhereCaolán McNamara
Change-Id: I1a82e91539947939667e0c458f964e7e13c50514
2016-10-25no users of RscClassArray leftCaolán McNamara
Change-Id: I1eeeca93ef6e57bddde54dc0abf5c1984da962cc
2016-10-25no evidence that LangKeyCode is needed for anythingCaolán McNamara
Change-Id: I01cf8019fb6bba15c6ed48564ad2e65bf3fbd187
2016-10-25no need for ResId here nowCaolán McNamara
Change-Id: I2b9ec5e587724550ea8b78f023f18b6ec65d7f75
2016-10-25remove now unused ImplLoadRes methodsCaolán McNamara
Change-Id: I8ff86fa847a74d48ccd06e8945beac9cf5653ab9
2016-10-25no raw Window is loaded from .src anymoreCaolán McNamara
Change-Id: I81e4bb23f4a819f59115cdf58afe19097b4ce68f
2016-10-25SvTreeListBox cannot be loaded from .src nowCaolán McNamara
Change-Id: I80090f4daf9b7f224392a76449a87ab6aa6b7d05
2016-10-25no FixedText loaded from .src nowCaolán McNamara
Change-Id: Ic377c5238e1763a2defdce72bbe893e826aae5ac
2016-10-25nothing uses RSC_BUTTON anymore nowCaolán McNamara
Change-Id: I016d1507fcadf5da1207241c6feec1a03188eef7
2016-10-25no PushButton loaded from .src nowCaolán McNamara
Change-Id: Ib866107995ab0496cf4f37a5e780458031d2fc25
2016-10-25no Edit controls loaded from .src nowCaolán McNamara
Change-Id: I42c7377c101c642ea39028e05e4ffd58fc7435d7
2016-10-25no ListBox loaded from .src nowCaolán McNamara
Change-Id: I7d30c38777f6a36c991271a3617d3f75c83cd490
2016-10-25convert conditional format src fragment to .ui and layoutCaolán McNamara
this is a difficult widget Change-Id: If4ea45230679c46f7ad763f07c876dd74d4478d0
2016-10-25xmlsecurity: add PDF signature removal testcaseMiklos Vajna
This one needs no access to private test keys, so no workaround is needed for older NSS. Change-Id: Ia233901658832cf55157511b4c5b5c2ccb243425
2016-10-25tdf#84678 DOCX import: fix handling of textbox marginsMiklos Vajna
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), the problem for a long time was that in Writer text frames without borders couldn't have text margins, either. Recently a compat setting was added in the WW8 filter for this situation, so use that in the DOCX import as well, and improve SwTextBoxHelper to handle the margin properties. Change-Id: I472bbc414f21f2ec7334482c460a5c3be3e95e94 Reviewed-on: https://gerrit.libreoffice.org/30255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-25screenshot annotation: More readable markupKatarina Behrens
this should placate clang too Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-25screenshot annotation: put back removed fieldsKatarina Behrens
I hate you loplugin !!! Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-25screenshot annotation: Make this a default buttonKatarina Behrens
Change-Id: I1a1db338696cf56062306a54a43c746a21a3431d
2016-10-25screenshot annotation: insert markup for annotated widgetsKatarina Behrens
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-25screenshot annotation: Display markup for embedding the imageKatarina Behrens
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-25screenshot annotation: tweak dialog a bitKatarina Behrens
Add some descriptive labels Remove OK button (redundant in this context, Save Screenshot... does the job) Change-Id: I36e32986f777675f297390b691f2cd1681a0eaa2
2016-10-25Revert "tdf#96505 Get rid of cargo cult "long" integer literals"jan iversen
This partly reverts commit 8ae33b1652cb1e654c426350169d3bb9fa031a4f. Added a comment why 1L is needed in this file. Change-Id: I92349b42decb964a45d4dc9c50b89cd22766acb9 Reviewed-on: https://gerrit.libreoffice.org/30259 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-25Updated coreCaolán McNamara
Project: help 136c9a855fb9267a840030a289d80c9d7a18d82a drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhere Change-Id: Ief870688649828c459db277eba15ead976eac68a
2016-10-25Resolves: tdf#103472 gtk3 dnd must clear listener after dragDropEnd dispatchCaolán McNamara
like the generic dnd impl does Change-Id: Ie860c43329ee2f9332d12a53cd691ac7fcbb5eac
2016-10-25tdf#44282 fix missing space for numbered lists in TOCAbhilash
Change-Id: I885ec27b46f2c0966e8ed38e5ca8eb03822190c7 Reviewed-on: https://gerrit.libreoffice.org/29913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-25tdf#96505 Get rid of cargo cult "long" integer literalsRosen
fixed all long integer literals in file Change-Id: Ib557d88d4e4f17d5c334c92d611d002fe163f2f6 Reviewed-on: https://gerrit.libreoffice.org/29235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-25loplugin:staticmethodsStephan Bergmann
Change-Id: Id1a6184c3d3efab2d0ad921ee44b9b96ddddf74e
2016-10-25-Werror,-Wunused-variableStephan Bergmann
Change-Id: I55a0388838a7b9aebc6fd07c92e4d1a8081a4fb6
2016-10-25improve debug outputDavid Tardon
Change-Id: I7c5b8e67ee19e6a7d7909acb03d2d695cdc17a24
2016-10-25tdf#103448 remove WPS Office exts. from MIME typesDavid Tardon
Change-Id: I99e199ba0dd703703f0feafeb1a9b6970507050d
2016-10-25CppunitTest_xmlsecurity_pdfsigning: fix this on RHEL6Miklos Vajna
The pdfdocument problem is present only on 32bit. The pdfsigning problem is present on RHEL6, but not on RHEL7, for some reason NSS fails to parse the provided profile (generated by a bit newer NSS). Just return early in that case, we want to test the PDF code there, not NSS. Change-Id: I1123865d4b2176676a8fdaf648222fda8ca0b923 Reviewed-on: https://gerrit.libreoffice.org/30229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-24Rename ClearFormulaContext() to make it more representative.Kohei Yoshida
In the future we might put more prep code in here, in addition to clearing the context data. Change-Id: I44256a0dfbe1301e2c1443b291f4635ca0ba80f5
2016-10-25tdf#103389: Resaving a DOCX document with two canvases leads to a broken file.Tamás Zolnai
Make custom shape export more robust. In case of the test document, WriteCustomGeometry is called, but this call does not export anything, and so we get a shape without any geometry in the DOCX file, which causes problem to MS Word. Change-Id: Ie7a4e2b8a18bfddaeeb81425ae5f1de04140d43f Reviewed-on: https://gerrit.libreoffice.org/30241 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-24Updated coreFabio Biocchetti
Project: help 2f35a021df0677851b7f05522ca5b97b3992aca9 Fix comments in script and JavaScript refactor. Comments correction in shell script Introduced js debouncer for search bar xml-stylesheet tag removed Introduced parameter passing through pages Links in XHP pages now work with js Minor adjustments Change-Id: Ibf5f7a74c3249fa6f1ff4d3037fe821797e88d1d Reviewed-on: https://gerrit.libreoffice.org/30231 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-10-24tdf#103452: add missing xPopupMenu.disposeAndClear();Julien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=128226 Change-Id: If6641531b96f33b2864f69bd4195c92548fce148 Reviewed-on: https://gerrit.libreoffice.org/30234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-24solenv: force gbuildtoide test to use the same "make" as the callerMichael Stahl
Possibly mis-matching make binaries could be the reason behind failures that have been observed on Jenkins: make[3]: Entering directory '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/windows_msc_dbgutil_32/solenv/qa/python/selftest' make[3]: *** internal error: invalid --jobserver-fds string 'gmake_semaphore_5488'. Stop. Also, to enable this: Revert "Revert "prep WinResTarget for WNT in testdir"" This reverts commit 6e261cb19e5751eb0553ad0c5b357b1a5747518c. Change-Id: Idb858b5eeced91f19c9dd5600c4fdc5370b73cc5 Reviewed-on: https://gerrit.libreoffice.org/30226 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-24remove link to github cause breeze_svg are now in coreandreas_k
Change-Id: Ib30c7c7a9f2fecc108ea47b05f558a2ce8e6bf91 Reviewed-on: https://gerrit.libreoffice.org/30232 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-24tdf#79892: Improve performance of transliterationAron Budea
Pass resolved language to transliterate call, so it doesn't have to be resolved each time inside. Change-Id: Ibcad3b8517cb92c3462e14207c0a79ca2c76d73b Reviewed-on: https://gerrit.libreoffice.org/29829 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-24Updated coreChandanathil P. Geevan
Project: help b560ca36513ef209b23081dc5b971d30dd60e5f1 tdf#80439 Help pages for (NET)WORKDAYS.INTL removed useless file replaced commas with semicolons in function expression Change-Id: I76ce8945d7f5d51f7b356dc8063db1b4623e905b Reviewed-on: https://gerrit.libreoffice.org/30217 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-10-24Calculate size of embedded Impress document properlyStephan Bergmann
The '- 1's had been like that ever since cbd8e4d144757f40b75063bb4ab0e13ca2cfaad0 "added VisibleArea and MapUnit properties" but caused the following problem, suggesting that they may have been an off-by-one error right from the start: Opening an .odt Writer doc with an embedded (via "Insert - Object - OLE Object... - Create new - LibreOffice 5.3 Presentation") Impress doc for which the .odt's content.xml records <draw:frame ... svg:width="5.5508in" svg:height="3.9366in" ...> causes XMLTextFrameContext_Impl::Create (xmloff/source/text/XMLTextFrameContext.cxx) to create a size (in 100th mm?) of 14099x9999, which is converted to 7993x5669 twips, which are then passed to an SwFormatFrameSize ctor (sw/source/core/layout/atrfrm.cxx). However, double-clicking into the Writer doc's Impress area (to make the Impress doc editable) and then clicking back into the outer Writer doc's area (to put the Impress doc back into non-editing mode) causes the Writer doc to be considered modified (e.g., the "Save" icon gets a small green "plus" overlay) due to the call to SfxObjectShell::SetModified at > SfxObjectShell::SetModified(bool) (this=0x21293a0, bModifiedP=true) at sfx2/source/doc/objmisc.cxx:314 > SwDocShell::SetModified(bool) (this=0x21293a0, bSet=true) at sw/source/uibase/app/docsh2.cxx:1243 > SwDocShell::Ole2ModifiedHdl(bool) (this=0x21293a0, bNewStatus=true) at sw/source/uibase/app/docsh.cxx:1093 > SwDocShell::LinkStubOle2ModifiedHdl(void*, bool) (instance=0x21293a0, data=true) at sw/source/uibase/app/docsh.cxx:1090 > Link<bool, void>::Call(bool) const (this=0xa32c0c8, data=true) at include/tools/link.hxx:84 > sw::DocumentStateManager::SetModified() (this=0x82e77f0) at sw/source/core/doc/DocumentStateManager.cxx:48 > SwDoc::SetAttr(SfxItemSet const&, SwFormat&) (this=0xa32c050, rSet=SfxItemSet of pool 0x21dbd60 with parent 0x0 and Which ranges: [(88, 88)] = {...}, rFormat=...) at sw/source/core/doc/docfmt.cxx:492 > SwDoc::SetAttr(SfxPoolItem const&, SwFormat&) (this=0xa32c050, rAttr=..., rFormat=...) at sw/source/core/doc/docfmt.cxx:468 > SwFlyFrame::ChgSize(Size const&) (this=0xa14ae10, aNewSize=Size = {...}) at sw/source/core/layout/fly.cxx:1993 > SwFEShell::RequestObjectResize(SwRect const&, com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> const&) (this=0x83fc880, rRect=SwRect = {...}, xObj=uno::Reference to (OCommonEmbeddedObject *) 0x7fff745f7530) at sw/source/core/frmedt/fefly1.cxx:1334 > SwOleClient::ViewChanged() (this=0x4a15a10) at sw/source/uibase/uiview/swcli.cxx:151 > SfxInPlaceClient::Invalidate() (this=0x4a15a10) at sfx2/source/view/ipclient.cxx:812 > SfxInPlaceClient::SetObjAreaAndScale(Rectangle const&, Fraction const&, Fraction const&) (this=0x4a15a10, rArea=Rectangle = {...}, rScaleWidth=Fraction containing std::unique_ptr<Fraction::Impl> containing 0x1d47a40, rScaleHeight=Fraction containing std::unique_ptr<Fraction::Impl> containing 0x8c0d910) at sfx2/source/view/ipclient.cxx:785 > SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef&, SwRect const*, SwRect const*, bool) (this=0x83fc880, xObj=..., pFlyPrtRect=0x0, pFlyFrameRect=0x0, bNoTextFramePrtAreaChanged=false) at sw/source/uibase/wrtsh/wrtsh1.cxx:825 > SwWrtShell::LaunchOLEObj(long) (this=0x83fc880, nVerb=0) at sw/source/uibase/wrtsh/wrtsh1.cxx:591 > SwEditWin::MouseButtonDown(MouseEvent const&) (this=0x490b2e0, _rMEvt=...) at sw/source/uibase/docvw/edtwin.cxx:3366 > ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) (xWindow=..., nSVEvent=MouseNotifyEvent::MOUSEBUTTONDOWN, bMouseLeave=false, nX=750, nY=341, nMsgTime=32828148, nCode=1, nMode=(MouseEventModifiers::SIMPLECLICK | MouseEventModifiers::SELECT)) at vcl/source/window/winproc.cxx:698 > ImplHandleSalMouseButtonDown(vcl::Window*, SalMouseEvent*) (pWindow=0x19d19a0, pEvent=0x7fffffffc928) at vcl/source/window/winproc.cxx:1999 > ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x19d19a0, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/source/window/winproc.cxx:2329 > SalFrame::CallCallback(SalEvent, void const*) const (this=0x1996820, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/inc/salframe.hxx:280 > GtkSalFrame::CallCallbackExc(SalEvent, void const*) const (this=0x1996820, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/unx/gtk3/gtk3gtkframe.cxx:4219 > GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) (pEvent=0x16403d0, frame=0x1996820) at vcl/unx/gtk3/gtk3gtkframe.cxx:2615 > <emit signal ??? on instance ???> (instance=instance@entry=0x16f0e20, signal_id=<optimized out>, detail=detail@entry=0) at gsignal.c:3441 > gtk_widget_event_internal (widget=0x16f0e20, event=0x16403d0) at gtkwidget.c:7731 > propagate_event (topmost=<optimized out>, event=<optimized out>, widget=0x16f0e20) at gtkmain.c:2545 > propagate_event (widget=<optimized out>, event=0x16403d0, captured=<optimized out>, topmost=0x0) at gtkmain.c:2647 > gtk_main_do_event (event=0x16403d0) at gtkmain.c:1878 > _gdk_event_emit (event=event@entry=0x16403d0) at gdkevents.c:73 > gdk_event_source_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at gdkeventsource.c:367 > g_main_context_dispatch (context=0x63a520) at gmain.c:3154 > g_main_context_dispatch (context=context@entry=0x63a520) at gmain.c:3769 > g_main_context_iterate (context=context@entry=0x63a520, block=block@entry=0, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3840 > g_main_context_iteration (context=0x63a520, may_block=0) at gmain.c:3901 > GtkData::Yield(bool, bool) (this=0x73e260, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtk3gtkdata.cxx:479 > GtkInstance::DoYield(bool, bool, unsigned long) (this=0x73e3c0, bWait=false, bHandleAllCurrentEvents=false, nReleased=0) at vcl/unx/gtk3/../gtk/gtkinst.cxx:423 > ImplYield(bool, bool, unsigned long) (i_bWait=false, i_bAllEvents=false, nReleased=0) at vcl/source/app/svapp.cxx:504 > Application::Yield() () at vcl/source/app/svapp.cxx:551 > Application::Execute() () at vcl/source/app/svapp.cxx:468 > desktop::Desktop::DoExecute() () at desktop/source/app/app.cxx:1367 > desktop::Desktop::Main() (this=0x7fffffffe1e8) at desktop/source/app/app.cxx:1694 > ImplSVMain() () at vcl/source/app/svmain.cxx:185 > SVMain() () at vcl/source/app/svmain.cxx:223 > soffice_main() () at desktop/source/app/sofficemain.cxx:165 > sal_main () at desktop/source/app/main.c:48 > main (argc=1, argv=0x7fffffffe528) at desktop/source/app/main.c:47 because OCommonEmbeddedObject::getVisualAreaSize (embeddedobj/source/commonembedding/visobj.cxx, called from SwOleClient::ViewChanged, sw/source/uibase/uiview/swcli.cxx, ultimately returning the value 14098x9998 calculated in SdXImpressDocument::setPropertyValue, converted to twips) reports a size of 7993x5668 twips instead. Change-Id: I8056b99b036970e308a89937b95c57996a8e7c79
2016-10-24tdf#75280 Clean up usage of sal_uIntPtr.Hieronymous
doctempl.hxx doesn't contain any sal_uIntPtr instances. GetCount and GetRegionCount functions return sal_uInt16 hence sal_uIntPtr instances have been converted to sal_uInt16. Change-Id: Ifb48bf861c8ab5f262a535a7d34794eafd75fd6d Reviewed-on: https://gerrit.libreoffice.org/29904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-24Use an enum classTor Lillqvist
Change-Id: If75874ee12197edd367f5527a37e467041005794
2016-10-24Bin pointless macroTor Lillqvist
Change-Id: I460d5e7c431d2613999db86a73d4e14663ff038d