summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-24CVE-2020-25713 raptor2: malformed input file can lead to a segfaultCaolán McNamara
due to an out of bounds array access in raptor_xml_writer_start_element_common use a better fix than the initial suggestion See: https: //bugs.mageia.org/show_bug.cgi?id=27605 https: //www.openwall.com/lists/oss-security/2020/11/13/1 Change-Id: I9203904755b0e4ac98ae1e39942fd6f616c1efff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106488 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24tdf#42949 Fix new IWYU warnings in directory swGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4bb84c3f401aba8a3dede9cec3a7f2187a2ba02a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24Remove unused parameter (flagged now by loplugin:stringview)Stephan Bergmann
Change-Id: I474fbadfa9ab356829077d428cbd18a61a7ea919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106487 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24FindActuralStyleName->FindActualStyleNameNoel
Change-Id: I25e021caeb1c71529350df95099fb344edfd5b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24tdf#138430 scrolled windows need to have auto scrolling disabledCaolán McNamara
Change-Id: I8a622f00238d3d20d21d2439d6fc4fb13358f0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24tdf#138430 schedule a reformat if we turned off the scrollbarCaolán McNamara
Change-Id: Ida7d7419f0513624071b31820660add93ac78615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24Remove unused parameter (flagged now by loplugin:stringview)Stephan Bergmann
Change-Id: I78e2b60945f256de5e7455373a2ecff72f9eaae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106484 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24loplugin:stringviewparam (--enable-online-update)Stephan Bergmann
Change-Id: I9da6453bce5eb628eb1a4eee0863b77b548e95d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24Update git submodulesOlivier Hallot
* Update dictionaries from branch 'master' to a470d37edcd50733fcfcfdf85c72e7bcdf1ecb81 - tdf#138368 Cleanup pt_BR spelling dict 1) Delete entry at line 66278 of the .dic which has a non-extended ascii char and change first line of the .dic from 312368 to 312367 for new line count 2) convert CRLF to LF 3) iconv -f ISO-8859-1 -t UTF-8 pt_BR/pt_BR.dic > pt_BR/pt_BR.dic.new mv pt_BR/pt_BR.dic.new pt_BR/pt_BR.dic 4) iconv -f ISO-8859-1 -t UTF-8 pt_BR/pt_BR.aff > pt_BR/pt_BR.aff.new mv pt_BR/pt_BR.aff.new pt_BR/pt_BR.aff 5) add FLAG UTF-8 to .aff to indicate flags are no longer single bytes Change-Id: Ib1e9b29d0ecdcf060b3e11207670d26b0f307464 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/106402 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-24Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 4ce5903f1a64531b32402523c0d33050b42bba7a - tdf#132643 Translate German section IDs Change-Id: Ie4b39ecb9ab54191d4b834fa2e0b06acfba67851 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106413 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-24Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to be0e3871b278a2de2242dff2358134d40e4b0dee - tdf#132643 Translate German section IDs Change-Id: I1e6409649083aa5b9cdb69cbcedf41c3856be089 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106406 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-24sw: fix copying and deleting of section content via APIMichael Stahl
The problem happens if a section starts or ends with a table: SwXTextSection::getAnchor() may return a SwXTextRange with one position in a table cell and another position in a different table cell, or outside the table, neither of which is valid to set the cursor via SwXTextViewCurosor::gotoRange(). Introduce a new special mode for SwXTextRange, RANGE_IS_SECTION, analogous to RANGE_IS_TABLE but actually working. Only SwXTextView can be used to create XTransferables, and it requires selecting first via either the SwXTextViewCursor or select(). It's currently not possible to select the content of a section in the ViewShell in these problematic cases, and would be some effort to add. So add a new interface XTransferableTextSupplier that can be used to create XTransferable from the SwXTextRange with RANGE_IS_SECTION. The core CopyRange() and DeleteRange() functions can deal with SwPaMs that start or end in non-text-nodes, so pass the whole section content to these in SwXTextRange::setString() and in SwXTextView::getTransferableFromTextRange(). Change-Id: If7e3210e8a26f5618317c294f2b2f3ed5c217f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106293 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24sw: exception messages for SwXTextRangeMichael Stahl
Change-Id: Iee53473ead4151348c2f02f4a83bd0bd17c46758 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106292 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-24tdf#137546 sw: fix text position at textbox alignmentAttila Bakos (NISZ)
Follow-up of commit 06fd06597796d9e92117602245f3968c93707708 (tdf#124430 Writer Editing: Fix textbox aligning). Testing: 1. Insert a shape. Choose menu item "Add Text Box" of its local menu, and write a short text in it. 2. Choose menu item "Align->Right" of the local menu of the shape. The textbox is aligned to the right margin and before the fix, text position had changed slightly within the shape. (Only moving the textbox fixed it.) Change-Id: I758e0f65c8b51e09ac15a96e19819cb3ad3beacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105253 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24tdf#124176 Use #pragma once in extensions/source/abpilotShyamPraveenSingh
Change-Id: Ia370a447a23d6d78c380667fd07ba5f230c927dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106474 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-24tdf#138137 sc: remove red circle in merged cellTibor Nagy
This mark wasn't removed when valid data is entered in the merged cell. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I7632abadde9c482819f80af2600ab4c58292a821 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106172 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24Avoid unnecessary, wrong downcast from SwFormatRowSplit to SwFormatFrameSizeStephan Bergmann
...after b28e514d5e0ea45490b3cab30e1d97dd3da2c794 "callnk: Replace needless SwClientNotifyCall with CallSwClientNotify", as seen during e.g. CppunitTest_sw_ooxmlexport3 CPPUNIT_TEST_NAME=testDontSplitTable::Load_Verify_Reload_Verify (see <https://ci.libreoffice.org/job/lo_ubsan/1834/>): > /sw/source/core/layout/tabfrm.cxx:3900:30: runtime error: downcast of address 0x6020001b9990 which does not point to an object of type 'const SwFormatFrameSize' > 0x6020001b9990: note: object is of type 'SwFormatRowSplit' > bd 0e 00 2f 70 4c 61 a4 c2 2a 00 00 02 00 00 00 7a 00 00 00 00 00 00 00 00 00 00 04 10 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwFormatRowSplit' > #0 0x2ac29baf508b in SwRowFrame::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/tabfrm.cxx:3900:30 > #1 0x2ac2988d9b4d in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:367:18 > #2 0x2ac2988d9e45 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:372:15 > #3 0x2ac2988d7025 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/calbck.cxx:184:5 > #4 0x2ac2989205c8 in SwFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/format.cxx:325:9 > #5 0x2ac29b2746d9 in SwFrameFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/layout/atrfrm.cxx:2619:15 > #6 0x2ac2988d5208 in SwClient::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:115:9 > #7 0x2ac2988df973 in SwClient::SwClientNotifyCall(SwModify const&, SfxHint const&) /sw/inc/calbck.hxx:161:80 > #8 0x2ac2988da413 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:381:13 > #9 0x2ac298927a44 in SwFormat::SetFormatAttr(SfxPoolItem const&) /sw/source/core/attr/format.cxx:536:13 > #10 0x2ac2f953e607 in MSWordExportBase::OutputTextNode(SwTextNode&) /sw/source/filter/ww8/wrtw8nds.cxx:2257:54 > #11 0x2ac2f9571ace in MSWordExportBase::OutputContentNode(SwContentNode&) /sw/source/filter/ww8/wrtw8nds.cxx:3505:13 > #12 0x2ac2f98681dc in MSWordExportBase::WriteText() /sw/source/filter/ww8/wrtww8.cxx:2804:13 > #13 0x2ac2f8e8e01b in DocxExport::WriteMainText() /sw/source/filter/ww8/docxexport.cxx:1670:5 > #14 0x2ac2f8e8abf4 in DocxExport::ExportDocument_Impl() /sw/source/filter/ww8/docxexport.cxx:520:5 > #15 0x2ac2f98b52f3 in MSWordExportBase::ExportDocument(bool) /sw/source/filter/ww8/wrtww8.cxx:3360:19 > #16 0x2ac2f8f106a1 in DocxExportFilter::exportDocument() /sw/source/filter/ww8/docxexportfilter.cxx:86:17 > #17 0x2ac2dc707424 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/core/filterbase.cxx:492:49 > #18 0x2ac2eddb9010 in (anonymous namespace)::WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /writerfilter/source/filter/WriterFilter.cxx:155:23 > #19 0x2ac28d79c39b in SfxObjectShell::ExportTo(SfxMedium&) /sfx2/source/doc/objstor.cxx:2451:25 > #20 0x2ac28d78b3ac in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1539:19 > #21 0x2ac28d7be9f7 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2926:39 > #22 0x2ac28d7b6d1c in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2717:9 > #23 0x2ac28d724080 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objserv.cxx:315:19 > #24 0x2ac28d93df20 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3086:42 > #25 0x2ac28d944909 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1728:13 > #26 0x2ac2a93a73b7 in SwModelTestBase::reload(char const*, char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:554:16 > #27 0x2ac2a93a56e3 in SwModelTestBase::executeLoadVerifyReloadVerify(char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:110:5 > #28 0x2ac286939928 in testDontSplitTable::Load_Verify_Reload_Verify() /sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:936:1 > #29 0x2ac28693d184 in void std::__invoke_impl<void, void (testDontSplitTable::*&)(), testDontSplitTable*&>(std::__invoke_memfun_deref, void (testDontSplitTable::*&)(), testDontSplitTable*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 > #30 0x2ac28693cd5e in std::__invoke_result<void (testDontSplitTable::*&)(), testDontSplitTable*&>::type std::__invoke<void (testDontSplitTable::*&)(), testDontSplitTable*&>(void (testDontSplitTable::*&)(), testDontSplitTable*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 > #31 0x2ac28693cbb2 in void std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11 > #32 0x2ac28693c812 in void std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17 > #33 0x2ac28693b8a1 in std::_Function_handler<void (), std::_Bind<void (testDontSplitTable::* (testDontSplitTable*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2 > #34 0x2ac2868427b1 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14 > #35 0x2ac28693ab84 in CppUnit::TestCaller<testDontSplitTable>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #36 0x2ac23bbb05ba in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #37 0x2ac25698b937 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:46:14 > #38 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #39 0x2ac24aff3fd7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:78:12 > #40 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #41 0x2ac247b490a8 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:61:16 > #42 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #43 0x2ac23bb18f84 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #44 0x2ac23bb81c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #45 0x2ac23bb7b697 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #46 0x2ac23bc1aa79 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #47 0x2ac23bbaec21 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #48 0x2ac23bbb2a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #49 0x2ac23bbb1c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #50 0x2ac23bbb2a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #51 0x2ac23bbb1c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #52 0x2ac23bc4860e in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #53 0x2ac23bc194de in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #54 0x2ac23bc4956b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #55 0x4fedce in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:323:20 > #56 0x4fb4c0 in sal_main() /sal/cppunittester/cppunittester.cxx:473:20 > #57 0x4fa4ae in main /sal/cppunittester/cppunittester.cxx:380:1 > #58 0x2ac23d859554 in __libc_start_main (/lib64/libc.so.6+0x22554) > #59 0x425ea4 in _start (/workdir/LinkTarget/Executable/cppunittester+0x425ea4) Change-Id: Icd1fdd2a7b11106761d17cd22b1f9a4fe9f8896d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24tdf#138194 Chart OOXML import: set text break to trueTünde Tóth
of rotated category axis label, if the rotation is 90 or 270 degree and the inner size of the chart is not fixed. Change-Id: I02e1fd940af8a277435aa46d4ad93a42b6723710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106422 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24tdf#138181 Chart OOXML: fix deleted legend entries of pie chartsTünde Tóth
The legend of the pie chart showed deleted legend entries too when VaryColorsByPoint was false. Change-Id: I6fc978af0db6e2d39d7f451e765d7ef81c73a05c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105943 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-24Remove unused ScrollBarBox from tabpageSamuel Mehrbrodt
This displays an empty rectangle at the upper left of the tabpage. Change-Id: I8424a3f8ec4896814b135aa2c86012f0b33ee1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24tdf#138253 sw textbox: fix content of draw format on undoMiklos Vajna
Regression from commit da4f9b77a6cd39b1ae5babdd476d1575c8b9371c (tdf#135149 sw: fix deleting textbox of as-char shapes, 2020-09-07), the crash was caused by a user-after-free triggered from the X11 clipboard code. This could happen beause the clipboard document had a draw frame format, which has an SwNode pointer, but the SwNode instance was outside that clipboard document, and the owning document is already gone. So by the time the clipboard document would be deleted, the SwNodeIndex can't de-register itself. The root cause was that the doc model was corrupted after a cut of a textbox + undo: the textbox pointers of the fly/draw formats were OK, but not the SwFormatContent of the draw format. Change-Id: I5761b72948caca397320aed801559e8493c33e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-24tdf#134528 Add "Reset All" button to Calc Solver dialogRafael Lima
Change-Id: I27a2fb4dddf3da31801bc2283ee58a24a921d7ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24static_cast after dynamic_castNoel Grandin
Change-Id: I196d4e9065961d6f4e3fef4475dd5f406e998447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24remove linestartendattribute.hxx from clang-format excludelistTomaž Vajngerl
Change-Id: I2d6cef1d3dff33c6cb2695c645d4f30e899c4616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106390 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-24tdf#132860 Assign value to set_sensitive flag in m_xNameshubham656
Change-Id: I9438e1a18253d90ff26e71b3aab83e96468fb9d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106461 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-11-24Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5b768d6f04f57ea77e66be18136908b44ac65cde - tdf#103463 add explanation of what strings get autocorrected to hyperlinks ( shared/guide/autocorr_url.xhp ) + add table with examples of URLS * update to <h1>,<h2> ( shared/00/00000002.xhp ) * update to <h1>,<h2> Change-Id: I67150576098eeb0e4a2ada3e4edf910b234c1dda Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106136 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 66ed66b2168a36c8606abea78d1d3b1b6183b211 - Review outline contents visibility help page. Change-Id: Icd54040eab3d5130ebcf495a3de9526c1fd0670c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106462 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to e4bc24515c948609dd96488ec087b10f91ca5cd0 - ScriptForge library help - WiP main page Change-Id: I27f9fc5d1731fd23a0130c52f372711a920a02d7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106433 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Colibre: tdf#138350 fix wrong color from monoline color to these HEXRizal Muttaqin
color values: - black : 000000 - magenta : ff00ff - green: 00ff00 In order to obey color replacement function Change-Id: I575709a84b83e7bf61f089477d5edd8810f880ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106391 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-23tdf#138374: sw_ooxmlexport15: Add unittestXisco Fauli
Change-Id: Ie0bb8fa230f092fa3b0c96e47af4d553c6ff2db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106424 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-23tdf#138430 toolbar bullet dropdown should have a scrolledwindowCaolán McNamara
as should the matching dialog pages Change-Id: Ib327d3c02d1bc5ae11a6a76d52c9e17803f05534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23CVE-2020-25713 raptor2: malformed input file can lead to a segfaultCaolán McNamara
due to an out of bounds array access in raptor_xml_writer_start_element_common See: https://bugs.mageia.org/show_bug.cgi?id=27605 https://www.openwall.com/lists/oss-security/2020/11/13/1 Change-Id: Ida4783a61412ffce868eacf81310da338d3e2df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23ofz#27519 only generate bitmap preview when neededCaolán McNamara
Change-Id: I35d20d65b607d6441b001c7d839a793349ef3b1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23tdf#138428 don't record SetName("ScPostIt") in undoCaolán McNamara
Change-Id: Iae87db47907078282e48035ad7892dbf52942e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23tdf#124176: Use pragma once instead of include guardslastirembender
Change-Id: Idd8dda6abecdb04356dd00d7dabcc6ff6bd85208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-23sw: prefix members of SwFrame, SwFrameAreaDefinition, SwLayVout and SwLineRectMiklos Vajna
See tdf#94879 for motivation. Change-Id: I93627e54ba9330e8e1ff2136ab00ecd743c0dd79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106397 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-23Removed duplicated includeAndrea Gelmini
Change-Id: I5eea6c78222caac889cb7b3895ac5766be8c0478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106416 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-23Fix typoAndrea Gelmini
Change-Id: If4a6264729432cee6fc27765ad0f35e9bc4f0f43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106417 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 0dd71d6f5bb3d1357ac6d10d096cea6b062c67df - tdf#132643 Translate German section IDs Change-Id: Ia93e92171fc9454ca983cc45a66950e8414097b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106412 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e3677611529f252a457472525eb4921bd161a950 - tdf#132643 Translate German section IDs Change-Id: Iac095cb8044be87b39a636e7fcb3caa51ee48e49 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106411 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 8721891176d1c987175279d07dc2b8fea8c3db39 - tdf#132643 Translate German section IDs Change-Id: I8c4738d6047cb84fe3bc79c4eb158bf3850917ea Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106409 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 8118cb51e9189e291c7247272a3c187e9b29bac5 - tdf#132643 Translate German section IDs Change-Id: I0bc5e98c02ae99051a00a1372931e99c7d3423f1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106410 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 7b97c7b9d9f83aea116826a7d28e800b4fd498cd - tdf#132643 Translate German section IDs Change-Id: Ie907199976c2f49d9f9266cb4eb3493162db18c8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106408 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 80461d6b6b2d47cc1dc1625303beba23d196d577 - tdf#132643 Translate German section IDs Change-Id: I77431b510deed18fee1b8fec49f9822db42600f9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106407 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to d6958b620959f9002b67e95482636a51c7074ef1 - tdf#132643 Translate German section IDs Change-Id: I95c587c0d0de74217c056828ac69c7c0ed8cf0ec Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106405 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 8717db5e246bea737810c858232ac9fa8f601722 - tdf#132643 Translate German section IDs Change-Id: I96b2b894da950043655303446de9225764f0e836 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106404 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 51021a18b572d1c3553551711bc116abbe8e9fbf - tdf#132643 Translate German section IDs Change-Id: I544360715f484422264832db7ab27f315b7a450d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106353 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 05e1156c95cb17b7b129cd7eec6d6eb543f7b131 - tdf#132643 Translate German section IDs Change-Id: I859693de0791ea82548710023d7751fe4974e617 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106352 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-11-23Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to e535220b7f91840258860261721173de52f05b28 - tdf#132643 Translate German section IDs Change-Id: I3e35ce317a4705a4174c65c863b6bbcf569f335f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106351 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>