summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-05-21Fix typos in sparklines extended tipsOlivier Hallot
Change-Id: I96848ed20e9a6d3e2d18e07c5f781bb98ed72f80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167902 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-05-21loplugin:ostr in sc/qaNoel Grandin
Change-Id: If731102d69667eaaa088cf804a8c7563b24ded5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-21tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playbackMichael Weghorn
Similar to the way that GTK 4's native facilities for video playback are used for the gtk4 VCL plugin, initially added in commit commit d0a527ec09516bc7215baf229adb90cd21ffa27a Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Feb 10 12:55:18 2022 +0000 first cut at using Gtk4 built in video playback , implement media playback using QtMultimedia for the Qt 6 based VCL plugins (qt6/kf6) via a new service "com.sun.star.comp.avmedia.Manager_Qt". Video playback with the mechanism used for qt5 no longer works with qt6, as "qwidget5videosink" that gets used on Wayland for qt5 wasn't ported to Qt 6 and is unmaintained, s. the commit message of commit 88d57cf241209ffec9eaed3e523942ab51af6db6 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Sep 29 11:09:51 2021 +0200 qt6: Add a qt6 VCL plugin for more details. Additionally, this also doesn't work properly any more on X11/with the xcb Qt QPA platform, see tdf#145735 comment 7. Instead of using GStreamer directly, let Qt handle the low-level stuff by using the QtMultimedia module [1] instead. This adds a new dependency on QtMultimedia. For building, this requires installing the Qt 6 QtMultimedia development headers (e.g. package `qt6-multimedia-dev` on current Debian testing). Except for WASM, the use of QtMultimedia is enabled by default when building with autogen options `--enable-qt6` or `--enable-kf6`, but can explicitly be disabled using `--disable-qt6-multimedia`. In tests with the qt6 VCL plugin on Debian testing, with a sample presentation containing an embedded video, attachment 145517 from tdf#120452, video playback generally works for both, the xcb and the wayland Qt QPA platforms: * Video and audio are played as expected on the external screen in presentation mode when using the presenter console * Video and audio playback work in non-presentation mode by clicking on the video and using the controls in the Impress sidebar (play, pause,...). However, the following issues were observed with the current implementation: * There's an odd frame/margin around the video. * In non-presentation mode, the placeholder shown until the video gets started using the controls in the sidebar is just an "audio icon", not a frame from the actual video. (This might be related to the fact that `QtPlayer::createFrameGrabber` currently returns an empty reference.) * At least on Wayland (issue not observed with QT_QPA_PLATFORM=xcb so far), when using the presenter console, video playback in the presenter console (i.e. on the non-presentation screen) is unreliable: The video sometimes shows, but sometimes doesn't. At least the (more important) one on the presentation screen was reliably shown in my tests, however. Tested with git dev versions of qtbase (as of commit 8d5e7d50d8dbf1ad79bd8ff9f6ef6028eba481c9), qtwayland (as of commit 6f0ebd916f176f6fbe35af28caeb52b62768ac94) and qtmultimedia (as of commit 264b7e8d7d5683252102b5e5149685c8b8a70c2d). [1] https://doc.qt.io/qt-6/qtmultimedia-index.html Change-Id: I29c3c7ded01c61b49b192fa5c313d8a92c942185 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167869 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-21Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to bfc9b74f251bd2aca3605732c30b61bd6715a7eb - tdf#160382 Document new features in Slide Show Settings help page In text/simpress/01/06080000.xhp - Added additional index bookmark values to make the page easier to find. - Remove screenshot because it does not represent current dialog options - Updated the link to the embedded How to get section, to reflect changes to text/simpress/00/00000407.xhp. - Added information for the - Live-mode slideshow editing - Buttons size - Enable insecure WiFi connections features. - Added a heading to the description of the Download App option. - Added Related Topics section. In text/simpress/00/00000407.xhp - Added TabUI instructions for accessing Slideshow Settings. - Created a new section called "slide_show_settings" to allow multiple paragraphs to be linked. In text/simpress/guide/presenter_console.xhp - Add variable tag to heading so that the page can be easily linked from other pages. Change-Id: I71a836cefd8f0aa176dfaec0d539f043b1e973c7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167824 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-05-21loplugin:ostr in sw/qa/apiNoel Grandin
Change-Id: Ib8ad745095eceb588e502c44644136d943e79013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167894 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-21Resolves tdf#160834 - Unclear meaning of "Ignore pieces of length"Heiko Tietze
Access in the UI removed Find the options under ooO.Writer.Comparison.IgnoreLength and IgnorePieces Change-Id: Ic76277ba6838bf5cf858089303f4882bc9a7c2de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167888 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-05-21tdf#161190: fix crash when exporting spreadsheet as PDF...Julien Nabet
with "whole sheet export" option' See bt here: https://bug-attachments.documentfoundation.org/attachment.cgi?id=194240 Change-Id: I453882be5c8bb761a722482f9c94a2b2bb5c7dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167890 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-05-21svx: prefix members of SdrUndoDelPageMiklos Vajna
See tdf#94879 for motivation. Change-Id: I6ef4ca1df66f22e4fb6a13a7b39ca0152484fd6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-21Fix bashism in configure tests for curl and libcmisChris Mayo
When /bin/sh is dash: ./configure: 35165: test: yes: unexpected operator checking whether to enable breakpad... no ./configure: 35218: test: yes: unexpected operator Causing HAVE_FEATURE_CURL not to be set to 1 and build to fail: sw/source/ui/misc/translatelangselect.cxx:160:24: error: no member named 'TranslateDocumentCancellable' in namespace 'SwTranslateHelper' 160 | SwTranslateHelper::TranslateDocumentCancellable(m_rWrtSh, aConfig, m_bCancelTranslation); | ~~~~~~~~~~~~~~~~~~~^ Introduced in: 5bf7c2fa5794 ("Fix --disable-curl build", 2023-09-14) Change-Id: Ifbc4bc1a7cde86101ff13b05ec7cee6836798605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167831 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-05-21tdf#69724 Allow to change default bullet symbols in UITibor Nagy
Change-Id: Ife700096fb55ebc752ae289398a36ee78b3e5ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167660 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-21cool#9019: draw/impress: disable the Grid for nowHubert Figuière
So that the grid isn't shown in the thumbnail. This will need to be reverted later for cool#7406 Change-Id: I01fbc7ebc9e33a27fb866b7ea6dbaaac68ae8f9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167872 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 41130a39ad68310a0136605cbced1f191396c456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167826 Tested-by: Jenkins
2024-05-21tdf#158803 pyflakes F821: undefined name 'com' and remove bare except clausesLeonard Sasse
Change-Id: Id116753a19a4fa5a29ad9a4f61f5ba3bf1ce95d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165451 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-21tdf#158803 compilerplugins: remove semicolons; improve membership checksLeonard Sasse
Change-Id: Ifd5fdee23e5adba2b5a667f74c38ba6fb28f54b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165446 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-21Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 0f39dc88044b1f0c431b90458ff8ae606b05ec67 - Fix typo Change-Id: Ia07532dd18408e39d03cfbc8d9125ba89f3e8a1d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167889 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-05-21lok: translate formula bar functions to each localeJaume Pujantell
On calc the native formula symbols were loaded once on start-up and assumed to not change. This adds a map language to symbols when LOK is active and chooses the correct set of symbols on each call. Change-Id: I821fb3ad4a06d764399e3fdf4a2ec628909312db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167870 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> (cherry picked from commit 421ef056cf5e991ae3072cd1acb5ef23aa7c780a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167825 Tested-by: Jenkins
2024-05-21fix crash when push the Bullets button on the toolbar and then press theTibor Nagy
dropdown part of the button caused by commit I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4 (tdf#161056 Show bullets used in document in bullets dropdown) Change-Id: I215d7cb677825821917a4fd8c498deaaab9fc9b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167838 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-05-21tdf#160984 sw continuous endnotes: enable DOCX importMiklos Vajna
This was working for DOC already. For DOCX, this was already enabled once with commit f9982c24066d6dd2f938cc20176af0f196bc018f (tdf#58521 DOCX import: enable ContinuousEndnotes compat flag, 2021-07-13), but then it was reverted later with commit commit eeda1b35a6e87d5349545464da33d997c52f15e3 (Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag", 2021-08-10), because of tdf#143456. Enable it again, now that the section-based layout seems good enough to handle larger number of endnotes, e.g. the 48 endnotes from tdf#143456. Change-Id: Id221f31f9208e84db2c358546d4d6ceea991b6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167881 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-21tdf#158803 Remove E999: SyntaxError's and some other minor editsLeonard Sasse
Change-Id: I32d75eb03b1f1fd011dcbc6950bf74800446a422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165464 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-21qt a11y: Don't leak QAccessibleEventMichael Weghorn
Create the `QAccessibleEvent`s passed to `QAccessible::updateAccessibility` as local stack variables instead of on the heap, to not leak them, as `QAccessible::updateAccessibility` does not take over ownership, i.e. doesn't delete them. This is also what the example in the Qt doc [1] does. This fixes leaks reported by Valgrind, for example: ==104242== 416 bytes in 13 blocks are definitely lost in loss record 23,612 of 27,514 ==104242== at 0x4840F83: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==104242== by 0x186F6884: QtAccessibleEventListener::HandleStateChangedEvent(QAccessibleInterface*, com::sun::star::accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:144) ==104242== by 0x186F8478: QtAccessibleEventListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:401) ==104242== by 0x61B2756: comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun::star::accessibility::AccessibleEventObject const&) (accessibleeventnotifier.cxx:256) ==104242== by 0x61ADB50: comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&, int) (accessiblecomponenthelper.cxx:127) ==104242== by 0xBAA46FB: VCLXAccessibleComponent::ProcessWindowChildEvent(VclWindowEvent const&) (vclxaccessiblecomponent.cxx:173) ==104242== by 0xBAA4285: VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent&) (vclxaccessiblecomponent.cxx:124) ==104242== by 0xBAA3BBC: VCLXAccessibleComponent::LinkStubWindowChildEventListener(void*, VclWindowEvent&) (vclxaccessiblecomponent.cxx:114) ==104242== by 0xD56C687: Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const (link.hxx:111) ==104242== by 0xD56977E: vcl::Window::CallEventListeners(VclEventId, void*) (event.cxx:296) ==104242== by 0xD6C83A1: vcl::Window::ImplSetReallyVisible() (window.cxx:1328) ==104242== by 0xD6C846C: vcl::Window::ImplSetReallyVisible() (window.cxx:1344) [1] https://doc.qt.io/qt-6/accessible-qwidget.html Change-Id: I82af810f0c618ffd5c5e4c8f568f4b4358df5900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167862 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-21qt a11y: Use "r" prefix for referenceMichael Weghorn
Change-Id: Icf3021872321bc1ea23c09497008b5fc401a3591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167861 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-21writerfilter: avoid infinit loop when resolving embeddings on docxJaume Pujantell
If a docx file contains a loop on the .rels files for headers and/or footers the code would enter an infinite recursion while looking for embeddings. Change-Id: I2122fd6b1677812f561e96a9511a61b0e938e94a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167784 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2662257ca9594a0c5fc1371c8e397f562c726f8c - tdf#159872 UNIQUE function help page - Attempt to address issues raised by Regina. Change-Id: I85892d15a5bf8bb798f733cd4fddc309e5906894 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167755 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-05-20loplugin:ostr in variousNoel Grandin
Change-Id: I9f399b3752da9df930e0647536ffcd4e82beb1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-20use more concrete UNO types in swNoel Grandin
Change-Id: I3cf017e74e7cc9902486d6dba1d89f70c47c978a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167864 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-20remove hole in SwFrameAreaDefinition structNoel Grandin
since this is used in various performance sensitive places Change-Id: Ibdce6bd0de458a5a970654a88b984aff49210ef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-20Drop remnants of a long-obsolete hackMike Kaganski
In commits 6dd5a96e1e3a6bb307f8f2d43cce2b5f2cde659d (INTEGRATION: CWS unopkg1 (1.1.2); FILE ADDED, 2004-04-14), 19a10039a59002b68291e7f200f85fd962592d75 (INTEGRATION: CWS unopkg2 (1.2.4); FILE MERGED, 2004-06-11), and 886715b6b6f30fed36d50a4ddf84ed5984f4f993 (INTEGRATION: CWS scriptingf7 (1.3.4); FILE MERGED, 2004-07-23), a hack was introduced to allow empty substorages. Later, in commits 0d6b24a721f05fedef9cd32b596a0fec71a5089f (INTEGRATION: CWS tdoc3 (1.7.24); FILE MERGED, 2004-11-09) and 5f4d17724f7323077191114486edff8cdce05b2f (INTEGRATION: CWS scriptingf9 (1.6.2); FILE MERGED, 2004-12-23), that hack was removed, but one place was kept, which is removed now. Change-Id: Iaaf46421ddbe942878ebe17ca1e585be9db5999d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167823 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-20tdf#160969 Update extended tip for Comment IndicatorDione Maddern
In sc/uiconfig/scalc/ui/tpviewpage.ui - Updated extended tip for "Comment Indicator" to reflect the current appearance of the Tools > Options> Scalc > View dialog Change-Id: Iff0d7b0c05d54099818816e6146bc678d06a1e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167867 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-05-20Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to cbb8c2d8d957f8a4729b32ac098c8a88f72d797a - tdf#160909 Update help page for Scalc View Options In text/shared/optionen/01060100.xhp - Added index bookmarks for new features - Removed old comment. - Updated "How to get" section to reflect current menu options. - Updated help page to cover new options: - Pointer - Comment authorship - Column/Row highlighting - Edit cell highlighting - Summary on search - Removed the section describing the "Color" option because that option no longer appears in the "View" dialog. In text/shared/optionen/01060000.xhp - Added link and variable tags to the title, so that the page can be easily linked from other pages. Change-Id: Ib738453b33efcded574576052b7add3cb6bb25c0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167463 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-05-20Update git submodulesStéphane Guillou
* Update helpcontent2 from branch 'master' to 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c - related tdf#69192 document --show=slide_number option Change-Id: I9944a6d4dbaa7ec7f5283c677063cac74bc7e80d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167614 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-05-20tdf#69192 fix cmdlinehelp: --show[=slide_number], etc.Justin Luth
I had skimmed the help file earlier, and concluded that { } are used elsewhere to indicate optional paramaters. However, there is --quickstart[=no], and -env:<VAR>[=<VALUE>] which exactly match my optional addition. Thanks Stéphane for pointing this out. Also included are some other changes we made to clarify the help wording in general, so the documentation and the cmdline help are in sync. We dropped Files other than Impress documents are opened in default mode, regardless of previous mode. because: -from an initial reading it doesn't convey any useful meaning. -searching for other uses of "mode" in the file suggests it means that prior --print/--convert-to/--view modes no longer apply. This override of prior modes is true for all modes, but only this argument tries to spell this out. -it seems rather inconceivable that any user would attempt to mix --show with any other arguments or more than one file. Change-Id: I191e572506cf2b39ed6c9ff4ebaf66f258a176a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167633 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-20documentation: list format placeholder has been "%1%" since LO 7.2Justin Luth
Vasily's commit aa5c6d127559912ad60a63fbd972b78fb8f9691b new ODF numbered list parameter loext:num-list-format Internal LO format for list format is changed: instead of placeholders like %1, %2, etc we right now use %1%, %2%... Reason: for ODT documents, having more than 9 levels there is ambiguity in "%10": it is "%1" followed by "0" suffix, or "%10"? It was introduced in 6.4.5 for DOCX support with Vasily's commit 7459b9ecb54a298f02d19089620149718f8d8d48 tdf#116883: sw: support for lists level format string Change-Id: I5962ed04c555356c6a3fc05ab7e036975d7eee40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167833 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-20tdf#156105 sw: make SvxNumberFormat GetPrefix/Suffix more trustworthyJustin Luth
As soon as SetPrefix or SetSuffix are called, any partially formed sListFormat is invalid (unless nothing changed). ListFormat creates sPrefix/sSuffix as a convenience/compat item, and changing it directly is NOT reflected in the sListFormat itself. Trying to keep them in sync would be very complicated. Any process that uses these functions OUGHT TO be doing it as building blocks to eventually call SetListFormat(prefix, suffix, lvl), at which point a proper sListFormat will be created. Change-Id: I05f681c812ea5207cb8127b30dafbd543ffea219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167832 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2024-05-20tdf#156105 sw: trust SvxNumberFormat GetPrefix/GetSuffixJustin Luth
After LO 7.4 (backported to 7.2.5) created this function that manually identifies the Prefix/Suffix, there was some work done to ensure GetPrefix and GetSuffix were trustworthy in LO 7.5's commit 835cda561217bd8c53af2de927158dd5712b06c0 Author: Justin Luth on Tue Aug 2 13:30:31 2022 -0400 related tdf#150197: use SetListFormat or SetPrefix/Suffix GetListFormat DEPENDS on having managed prefix/suffix itself... So, lets make sure we use and fix these functions in only one place. make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf156105_percentSuffix Change-Id: I44c021a200ba45960e39983087c6af268751fbc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167792 Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins
2024-05-20related tdf#156105 sw UI: recognize '%' in numbering prefix/suffixJustin Luth
bug 156105's listWithPercents.odt is an example of a properly defined ListFormat which contains a percent symbol in the prefix and suffix, which looked fine in the document itself, but was cut off short in the UI. sw/qa/extras/ooxmlexport/data/tdf116883.docx is also an example, which can be seen if you reduce the first entry to level 1 instead of level 2. Level 1 is improperly defined as "1%>". This is invalid formatting, so the entire thing should be considered a suffix. MS Word also considers it to be a suffix. This code segment still isn't completely comprehensive because it won't properly parse "%1xyz%1%." and "%1xyz%10%." but I'm losing patience. There is still a potential problem with the nInclUpperLevels calculation in case a '%' is used as an in-between separator, but that seems extremely theoretical and irrelevant to me. IIUC, the main impact is that it shows some extra dots in the bullets and numbering UI preview. Change-Id: Ic1b8fbda62917ad4c7b88bf4fff136d72242f977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167782 Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins
2024-05-20update language-subtag-registry to 2024-05-16Xisco Fauli
How the file was created: mkdir data cd data wget https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry cd .. tar cvjf language-subtag-registry-2024-05-16.tar.bz data/language-subtag-registry Change-Id: I1070881fac9d88508e58715c9a87d547ddf86a50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167860 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-20Fix typoAndrea Gelmini
Change-Id: I4ba7595b39be27161c333f8731ec4b0b35dab50a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167852 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-20Fix typoAndrea Gelmini
Change-Id: I439e80659a6e4aeba9c3f35decb0e2c7a8c87eeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167851 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-20avmediagtk: Use gb_Library_set_include for GTK4_CFLAGSMichael Weghorn
In the same way that `vcl/Library_vclplug_gtk4.mk` does it, set the `GTK4_CFLAGS` (which have the includes) via `gb_Library_set_include`, not `gb_Library_add_cxxflags`. This makes sure that they end up in the `INCLUDE` section in `workdir/GbuildToJson/Library/libavmediagtk.so` and thus end up in the IDE integrations as includes, which makes Qt Creator's Clang Code Model find them instead of showing an error ("gtkplayer.cxx:28:10: 'gtk/gtk.h' file not found"). See also this similar commit for more details: commit 6a53832080cf201e960113de8e1887d99e857606 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 17 15:35:58 2018 +0100 Use 'gb_Library_set_include' for GTK3_CFLAGS Change-Id: I5ef01aff32073d37b8add0b2250402ccaa48b2dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167857 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-20loplugin:ostr in sc/.../vbaNoel Grandin
Change-Id: Ifdf0ebba617432f49e2c14c8a52c495dc1c6a36a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167853 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-20loplugin:ostr in sw/.../accessNoel Grandin
Change-Id: Ib859d48d62ffcb9d82d3c63cc778430f45fe1d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167854 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-20don't need -I ... YaccTarget/connectivity/source/parse in formsCaolán McNamara
since: commit f0c8312bc6630ed64f174acc6f65bb5172765951 Date: Sat Feb 1 22:47:11 2020 +0100 tdf#42949 Fix IWYU warnings in forms/ Change-Id: I77835488ef0b19d4c271ad39018138cc371a352d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-20Fix typoAndrea Gelmini
Change-Id: I10d05b41028df776713db37d60e688d4f04bb739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167774 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-05-20Fix typoAndrea Gelmini
Change-Id: I22cd12c51d91bd7620bca29227871b3081813a36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167776 Reviewed-by: <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-05-20tdf#147906 implement hypot function for s1 x s1 + s2 x s2 statementsHakimOttey
Change-Id: I50a2f4cf7738ee3797723929fb6840d2633c882c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166814 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-20Change for loop to have getAccessibleChildCount in accessibletabbarHakimOttey
Change-Id: Ic020b1cd36abe2c568a119dfd400c718dc9de452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166989 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-19Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO stateCaolán McNamara
and not if it is implied to be toggled on by SwFormatFrameSize::SYNCED in which case on "ok" FN_KEEP_ASPECT_RATIO is set from the ui state so both tdf#151382 and tdf132591 work Change-Id: I039de0e8f0f9adcc3c02f0e07c12d83cd807887b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-19Resolves: tdf#160804 sc: ResizeMatrix: Use document grammarEike Rathke
API grammar (old GRAM_PODF_A1) here was always wrong and could never had matched the formula string obtained from the document, but in earlier days array separators weren't configurable so this may have worked accidentally.. Likely GRAM_PODF_A1 was introduced being confused by existance of older bApi parameter that never was true though and got eliminated later. Change-Id: Ie77ad4047c21d999bea1ff97c7c2b451f01121eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167844 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-05-19Resolves: tdf#157453 support FM_PROP_LINECOUNT for combobox dropdow rowsCaolán McNamara
Change-Id: I3d18ed505c2eea7305903f9a476c332db0148113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-19cid#1598293 silence Unchecked return valueCaolán McNamara
and cid#1598292 Unchecked return value Change-Id: I9880932b8fb2340ec122c907aea0374881238283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-19cid#1598236 silence Unchecked return valueCaolán McNamara
Change-Id: Id5dfed646336847607df0bd2fd10d345ac8ed64e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-12 09:15:46 +0000