summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-13NFC sw: cleanup and make RES_POOLTABSTYLE_DEFAULT consistentJustin Luth
It was introduced in 2016, and shortly thereafter many other styles were added using the full word TABLE. So make this one consistent since the eye just glances over the difference. In fact, in one place a comment even referred it it as _TABLESTYLE_DEFAULT. At first I was going to limit the change to just the one term, but the number of reference for everything was fairly small, so I just made everything consistent. Change-Id: I57cc0d081c4bbd5bcea872259065af483c94a334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/82997 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13Increase max ppt levels to 10Samuel Mehrbrodt
ppt files created with PowerPoint 2013 have that many levels Change-Id: I51fd84c6462b7c8d77417c958469804eb10a0a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94054 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-13aInfo should be usedTomoyuki Kubota
Change-Id: I6a62a65462fde741b3425f9095195c29924ce85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13loplugin:unusedvariableplusNoel Grandin
Change-Id: I58a466ac18debafa3bc2ff31c648ff51e126ab8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13gcc 10 also generates this clobber warningNoel Grandin
(specifically 10.1.1 is the version I have) Change-Id: I40fd720a9a75b809f24ca135c4ddb0ce61ecbe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13tdf#132008 Provide NewWindow in Groupedbar compact view dropdownandreas kainz
Change-Id: I4d532c7a31dca83a00d86f52184fb2a151ae2155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94037 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-13tdf#130778 remove old 6.x centered logo in the Star CenterRizal Muttaqin
Change-Id: I8bf2ac1344249042e8846c22abc1346c7d08d538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94066 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-13Check maximum end position to not assert() or "!!br0ken!!"Eike Rathke
While editing a formula in the Function Wizard it could happen that inserting an unclosed quote attempted to copy one more character than string length for parameter display. For example =FUNC("A";") Change-Id: Ic25ee0b97c3baee8d2e964c9e4b907415b0d889e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94086 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-13Resolves: tdf#132173 handle API sequence to inline array token correctlyEike Rathke
The API token of an inline array is always a two dimensional matrix. Regression from commit 3f80ac477354f4c6293d983d3ca9eef59a07dce0 CommitDate: Wed Apr 1 08:40:39 2015 +0200 Replace remaining getCppuType et al with cppu::UnoType Change-Id: I9ab2a807d29847fb843625b898ab8bbd005fab2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-12[en-US] Added 12 words to autocorrectMarco A.G.Pinto
Change-Id: Iad8181dfb6263745ba44622e2909879e12ebd5e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93144 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-12Revert "Image dialog property update"andreas_kainz
This reverts commit 951b6a9570ae2665f7b6e7cdd6d24d1fc513ba90. Reason for revert: <INSERT REASONING HERE> Change-Id: I84e8090210d8f4f712b3d8bce37fba8c9dcc6b38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93988 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-12lok: replace SetValue for ImplNewFieldValueHenry Castro
The ImplNewFieldValue notify changes in the spin control Change-Id: I64c0239b0a12ecdf9a3b7af4c496cee88d1b2cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94077 Tested-by: Jenkins
2020-05-12[en-GB] Added 12 words to autocorrectMarco A.G.Pinto
Change-Id: I551ffa201c5cda311efee4ca6bb2bb81c8f31e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93143 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-12colibre icons remove png icons from svg colibre icon themeandreas kainz
Change-Id: I487fb8307bb5512618f936f4c3ce5807ebfdcc89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94052 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-12Add some more source files for breakpointing convenienceTor Lillqvist
Change-Id: I3f0555a8a1a83342dd0dfff266f92c47ed5a9f80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94063 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-12Area fill bitmap presets invoice paper language fixandreas kainz
Change-Id: I57c6df6de2b27b342547b48370e0b19ad132859d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94036 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-12tdf#132435 only place menu vertically if up/down requestedCaolán McNamara
don't fallback to left/right if it doesn't fit, just scroll the menu instead Change-Id: I20b261fd7fee78555bf87b25dfeed33c23602493 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12allow double-clicking etc to expand on-demand rows tooCaolán McNamara
Change-Id: Idb8bca730d4c8d8da0d4689961cf1468051159d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12weld help browserCaolán McNamara
Change-Id: Ibd8dcc10c4403731953e2e46db4ae8f89ebc7e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93216 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12tdf#130778 update About Dialogandreas kainz
Change-Id: I1ca538a3c5589b30d53404f1f8d8ab2dcc2586f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94018 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-12Move SalInstanceButton to header fileSzymon Kłos
Change-Id: I3f6aa1975ae5859e0c340c82627d95e49313a668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94050 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-12Move SalInstanceComboBox to header fileSzymon Kłos
Change-Id: Iafa449cc1ebba93cc69da194857ea33b8f8510b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94049 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-12chart2: fix buildMiklos Vajna
Change-Id: Idc963641a4baf0a6f05be6609f5818ee9dc7f7d1
2020-05-12limit forms to http[s]Caolán McNamara
Change-Id: I3ed0bc626f693ec03f610dc7361f93cad914c9d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94015 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12tdf#128794 Chart: Fix OOXML import/export of Radial gradientBalazs Varga
Style should be radial at least when the horizontal/vertical center is not in the corner of a shape. Otherwise import as a linear gradient, because it is the most similar to the MSO radial style. Change-Id: I9bab7b787897bde51a06a950487de9843eb717a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93497 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Tünde Tóth <tundeth@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12external/icu: Silence UBSan invalid-null-argumentStephan Bergmann
...as seen during CppunitTest_i18npool_test_ordinalsuffix: > uloc.cpp:1206:5: runtime error: null pointer passed as argument 1, which is declared to never be null > /usr/include/string.h:44:28: note: nonnull attribute specified here > #0 in ulocimp_getLanguage_67 at workdir/UnpackedTarball/icu/source/common/uloc.cpp:1206:5 > #1 in uloc_getCountry_67 at workdir/UnpackedTarball/icu/source/common/uloc.cpp:1803:5 > #2 in ulocimp_getRegionForSupplementalData_67 at workdir/UnpackedTarball/icu/source/common/loclikely.cpp:1334:17 > #3 in idForLocale(char const*, char*, int, UErrorCode*) at workdir/UnpackedTarball/icu/source/common/ucurr.cpp:350:5 > #4 in ucurr_forLocale_67 at workdir/UnpackedTarball/icu/source/common/ucurr.cpp:535:5 > #5 in icu_67::DecimalFormatSymbols::initialize(icu_67::Locale const&, UErrorCode&, signed char, icu_67::NumberingSystem const*) at workdir/UnpackedTarball/icu/source/i18n/dcfmtsym.cpp:461:29 > #6 in icu_67::DecimalFormatSymbols::DecimalFormatSymbols(icu_67::Locale const&, UErrorCode&) at workdir/UnpackedTarball/icu/source/i18n/dcfmtsym.cpp:110:5 > #7 in icu_67::RuleBasedNumberFormat::initializeDecimalFormatSymbols(UErrorCode&) at workdir/UnpackedTarball/icu/source/i18n/rbnf.cpp:1854:53 > #8 in icu_67::RuleBasedNumberFormat::init(icu_67::UnicodeString const&, icu_67::LocalizationInfo*, UParseError&, UErrorCode&) at workdir/UnpackedTarball/icu/source/i18n/rbnf.cpp:1488:5 > #9 in icu_67::RuleBasedNumberFormat::RuleBasedNumberFormat(icu_67::URBNFRuleSetTag, icu_67::Locale const&, UErrorCode&) at workdir/UnpackedTarball/icu/source/i18n/rbnf.cpp:867:9 > #10 in i18npool::OrdinalSuffixService::getOrdinalSuffix(int, com::sun::star::lang::Locale const&) at i18npool/source/ordinalsuffix/ordinalsuffix.cxx:79:32 > #11 in non-virtual thunk to i18npool::OrdinalSuffixService::getOrdinalSuffix(int, com::sun::star::lang::Locale const&) at i18npool/source/ordinalsuffix/ordinalsuffix.cxx > #12 in TestOrdinalSuffix::testFrench() at i18npool/qa/cppunit/test_ordinalsuffix.cxx:53:29 etc. Change-Id: I4a87ee36fd33791c3906d6b6adc72ec824c4b3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94047 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-12Drop unused variableMike Kaganski
Change-Id: Ib92dc7c9f728eb40015ca96dd3c8708366bcf950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93991 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-12make VclPaned::set_position take effectCaolán McNamara
Change-Id: Id4ae096b413196cfb7118cd3a09a3f0a6c333f01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12always use the LinkManager's persist as the known refererCaolán McNamara
Change-Id: Ibb1bd9138993adbd8391b524c0cd654ba523cad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12use the LinkManager persist to determine the RefererCaolán McNamara
Change-Id: I4e93878972492a93af368ffa0560412132431a24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12Rename attributes to reflect that they represent different effectsMike Kaganski
... not only shadow. In preparation to add soft edge effect (tdf#49247). Change-Id: Ia5b17fff00e1c2d7f717179687dbd44410795a71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94007 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-12filter,writerperfect: adapt XHTML,EPUB to draw:mime-type in ODF 1.3Michael Stahl
Change-Id: I6391f7b4f0183a0193aaa10f2a41fac416a22c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92984 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-12missing licence headerCaolán McNamara
I wrote all this so this is the appropiate boilerplate since... commit 3832609a238d47375e634cbda4d092b11108fee4 Date: Wed Feb 19 13:32:14 2020 +0100 Create header file for SalInstanceBuilder Change-Id: I7615e15b220cd2e801a33c1418cf1f7cb0d72fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12add Paned accessCaolán McNamara
Change-Id: I5da0125a8f76d201e8dab2892b1f205c759599b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12Fix the buildStephan Bergmann
...after apparently a mid-air collision between f5636817e7677a3081263df9004940a7d5ac54af "tdf#112287 DOCX frame import: fix default vAnchor" and ec6eaa58addf0d8823f8c56d4ec168ff389da8c5 "fix memory leak of xmlDoc objects" Change-Id: I8fc70ee18aeb4be03b29da66bce666c563933249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94051 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-12xmloff: ODF export: adapt to ODF 1.3Michael Stahl
* OFFICE-3883 legend svg:width/svg:height * OFFICE-3928 chart:coordinate-region * OFFICE-3943 draw:mime-type * OFFICE-3765 number:fill-character, number:text * OFFICE-3860 number:min-decimal-places, number:forced-exponent-sign * OFFICE-1828 number:exponent-interval * OFFICE-3695 number:max-denominator-value * OFFICE-3941 text:index-entry-link-start/text:index-entry-link-end * OFFICE-3776 meta:creator-initials * OFFICE-3789 style:header-first/style:footer-first Change-Id: I78c79231c0708c3ae9943097d162898fab71988f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-12tdf#132811 DOCX: fix formula alignment – part 2Attila Bakos
Formula are aligned inline again, but in the right position, fixing both import and export. This partially reverts commit 8b613c4603047dc24aa9b03fb49f4fe1b65af2a3 (tdf#121525 OOXML import: fix formula alignment). Co-author: Tibor Nagy (NISZ) Change-Id: If5c13db749fe5c3b1aee754b47dabc9fabd7ebb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93631 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' to e21698f795b4098ecccf3119e23edd3d9e7aac1e - Fix helpers/make_icon_link.txt.py It contained Python-2--isms that caused errors when /usr/bin/python is Python 3 (at least on Fedora 32 with python-unversioned-command-3.8.2-2.fc32.noarch and python3-3.8.2-2.fc32.x86_64): > File "helpcontent2/helpers/make_icon_link.txt.py", line 21 > print "There was an error reading", file_icon > ^ > SyntaxError: Missing parentheses in call to 'print'. Did you mean print("There was an error reading", file_icon)? and > File "helpcontent2/helpers/make_icon_link.txt.py", line 39 > if line.find('png',0, len(line)) <> -1 : > ^ > SyntaxError: invalid syntax So fix helpers/make_icon_link.txt.py to be proper Python 3 and explicitly execute it with gb_ExternalExecutable_get_command,python instead of via a /usr/bin/python shebang. (That file was apparently not executed during the build prior to ee180ade07e36dd1fb8c7bdca6ecbab44ded9eb8 "tdf#128519 Automate icon repl't table for Help bld", so these issues were not noticied earlier.) Change-Id: Ia3cff9538ab537076a02b64ad8c1bf56dcfaf30b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94039 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-12tdf#132802 DOCX import: fix list bottom auto marginsLászló Németh
of the last list item, when its numbering based on the paragraph style. Before tables, table rows and before paragraphs without numbering or with different numbering list items got a regression from commit 9a132c8fab7d4d70b91e5ed92429c70a0466afcb (tdf#122342 DOCX import: fix bottom auto margin in lists) Change-Id: I23c73d94569e785ec780d708d983764534e356c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93973 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12tdf#112287 DOCX frame import: fix default vAnchorTibor Nagy
Vertical frame alignment was calculated from above margin instead of the bottom one, resulting bad positions, when vAnchor wasn't defined. Co-author: Attila Bakos (NISZ) Change-Id: I81bcf53ec826d5dcc9790c661d784b507d9ababc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93556 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-12tdf#38835 strip out OUString globalsMesut Çifci
Change-Id: I594a990b628463b7ab5eda5395de8bab5f080534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-12basegfx: simplify namespaces in ALL basegfx headersTomaž Vajngerl
Change-Id: Iaf9426507e3822363e69dff2cae2b22f34b1b26c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94034 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-12tdf#132939: avoid crash when uninitialized FilterDescriptorJulien Nabet
See bt: https://bugs.documentfoundation.org/attachment.cgi?id=160656 Change-Id: Ifacce7d39878e1b1d119aa878e7280eb3c9c2228 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93959 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-12fix "NFC writerfilter numbering: remove redundant code"Justin Luth
Earlier, in LO 7.0, I made an error in commit dbd98ebe9f90cedb41a90375688b200c35dd8928, where I failed to notice the difference between setLineId and setNumId, and removed setNumId as what I thought was duplicate code. (Thanks for pointing that out Mike Kaganski!) Reviewing the relevant code, setNumId seems to effectively be redundant after all. Removing it and just using the LineId value. There is a slight difference in the code flow, since numId was only set if the list didn't exist, but that appears to be irrelevant. Lists are not parsed/created until after styles are finished, so !pList.get() is implied by IsStyleSheetImport(). Change-Id: I2575966c8f1781bb278c787a2928d2b459867940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92125 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-12use pragma once in include/basegfx headersTomaž Vajngerl
Change-Id: Ief442ff36927b9b14d76d72b25a6cec3d481fb2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94033 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-12fix shebangRene Engelhard
$ ./solenv/bin/version.py 7.0.0 File "./solenv/bin/version.py", line 39 print('error updating %s: %s' % (filename, err), file=sys.stderr) ^ SyntaxError: invalid syntax Change-Id: I034e5b9abab1a555d8749eb5dd2349bfe90e4092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93839 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-12tdf#127778 DOCX import: fix unexpected heading on non-first page ...Miklos Vajna
... when the first page has a heading Regression from commit 17e51f427b3f0cec74ac8e0a1b3f51189006ae6f (DOCX import: first page header should always set default headers as well, 2014-11-21), the problem is around how to split a first + follow page style on import, and then do the opposite on export. This is described using a single section in OOXML, but Writer has 2 page styles for this (unlike in case of the DOC filter). This means the header margin has to be taken from one of these page styles. The above commit tweaked the import, so the follow page style has the wanted header margin, but this leads to incorrect layout. Fix the problem by tweaking the export instead: it has random access to the doc model, so it can take the header margin from the first page style if needed, and then the import side can be reverted, leading to correct layout. Also remove some leftover debug code in test/, which was added in commit 5352d45dd4a04f8f02cf7f6ad4169126d3b3586a (convert AnimationImport to fast-parser APIs, 2020-02-18). Change-Id: I4bbf7271f3a437e8432399bd1e32e9d24190a501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94013 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-12Fix initialization of Python-3.8--only at-end tp_print memberStephan Bergmann
Until Python 3.7, PyTypeObject had a member tp_print following tp_dealloc, which had then been repurposed as > /* Methods to implement standard operations */ > > destructor tp_dealloc; > - printfunc tp_print; > + Py_ssize_t tp_vectorcall_offset; > getattrfunc tp_getattr; > setattrfunc tp_setattr; > PyAsyncMethods *tp_as_async; /* formerly known as tp_compare (Python 2) in <https://github.com/python/cpython/commit/ aacc77fbd77640a8f03638216fa09372cc21673d> "bpo-36974: implement PEP 590 (GH-13185)" towards Python 3.8. Then only on the 3.8 branch (and prior to tag v3.8.0), <https://github.com/python/cpython/commit/ d917cfe4051d45b2b755c726c096ecfcc4869ceb> "[3.8] bpo-37250: put back tp_print for backwards compatibility (GH-14193)" added > destructor tp_finalize; > vectorcallfunc tp_vectorcall; > > + /* bpo-37250: kept for backwards compatibility in CPython 3.8 only */ > + Py_DEPRECATED(3.8) int (*tp_print)(PyObject *, FILE *, int); > + > #ifdef COUNT_ALLOCS > /* these must be last and never explicitly initialized */ > Py_ssize_t tp_allocs; at the end of PyTypeObject. This was apparently done so that third-party code containing initialization code like X.tp_print = 0; would continue to compile (by just adding back a member with that name, even if at a "random" new---and otherwise unused---location). However, for our way of list-initializing PyTypeObject instances in pyuno that new member caused "missing field 'tp_print' initializer" -Wmissing-field-initializers warnings, so 50ccb7e82b7053306721cbe220323be072306a29 "python 3.8.2 compile: add tp_print to PyTypeObject" added initializers for this new at-end member. But it did so in a way that raises three concerns: 1 The new member was already added in Python 3.8.0 (prior to tag v3.8.0), not only in 3.8.2. 2 The new member was only added to Python 3.8. It has not been added to current master towards 3.9. 3 It is unclear why the comments mention "Py_ssize_t" as the type of that new member, when actually it is of a function pointer type (see above). Probably best to just drop that from the comments, to avoid confusion. Change-Id: Ib44f43befd5f28d4c1ac1e9e14bd55bfb4473507 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94019 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to a5f1ad79fc3c7a7bf358f1ab9afe79269f5b8cf5 - Remove HTML attribute values from the translatable strings Change-Id: I9d1d0223b2eec3eb0e1181bda2f8aa6c7d90763f
2020-05-11added clear Direct Formatting button in calc sidebarPranam Lashkari
Change-Id: I7f18c696eb32332d9c65145e7788370304d91ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93969 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-03 05:31:26 +0000