summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-19drop some unused suppressionsCaolán McNamara
Change-Id: I4fc230216cb739f03e20cb6ab4ec2c53c6ad48c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103037 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-19It presumably is $LIBO_VERSION_SUFFIX that we want hereTor Lillqvist
Not $LIBO_VERSION_SUFFIX_SUFFIX. Follow-up to 271297d4fa4a8e045b6dc04942966a1058bed45c. Change-Id: I6356c84355e0ceac6e0ff492596e30a641935633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102283 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-19tdf#135366 Save line and fill of data labels to ODFRegina Henschel
LibreOffice has line and fill properties of data labels in charts as loext attributes in the style of the <chart:series> or <chart:data-point> element. For ODF there has to be a <chart:data-label> element with line and fill properties in its style. This patch adds the needed <chart:data-label> elements and their associated <style:style> elements. The element <chart:data-lable> exists in ODF since version 1.2. The solution requires no extended namespace. The check is adapted in lcl_getCustomLabelField. Import was already done in commit 87d1ebeb11a00301745ee3c3c03fffb7033ab59d Change-Id: I829dae5433e8257c775aa4f08e511d514df4e936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102381 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-09-19Fix crash from broken font CMAP subtableJan-Marek Glogowski
ParseCMAP crashes on a broken CMAP subtable of a font used by the bugdoc of tdf#119074, which returns a negative offset (technically it's large positive offset turning into a wrong negative integer, which is still out of bounds of the CMAP overall size - you get the point). This simply ignores that broken subtable, checking for other existing ones. Regressed-by: c7482bc2904401e7d975b5721ec861b8589253f9 Change-Id: I95820fe3bb6bd2fe2e0cf9d4c3536abce31fd497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103033 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-19tdf#135674: initialize Styles Inspector on startAron Budea
Change-Id: Iff1c72b0b0f9835414b6a44b08d1da4306162e11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103030 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-19tdf#136559 use freeze+all_foreach for performanceCaolán McNamara
doesn't do much for the gtk case due to https://gitlab.gnome.org/GNOME/gtk/-/issues/2693 but has an impact on the vcl case CheckAllChildren is then never called with a null pParent so simplify it based on that Change-Id: I3ae639aa70c7fca5eae9d2a7257cf39e7ce79e72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-19tdf#136705 give tab stop treeview a small height requestCaolán McNamara
so its natural height has no influence on the overall dialog height and it will take whatever height the dialog ends up at Change-Id: I98d6b2483f01ac2006dcc9d2ffa91824611a6d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-19Remove commented parts + reindentJulien Nabet
Code commented since initial adding of the test: author Muthu Subramanian <sumuthu@suse.com> 2012-08-14 17:04:40 +0530 committer Muthu Subramanian <sumuthu@suse.com> 2012-08-14 17:04:40 +0530 commit 3ccb8dac1405dc4ffa0ca3c45bd0724cc339d8ad (patch) tree 1fe5ae808b41458624624a9cd29502aa5bb290ad parent e3acf19c0502b0758359b56abda81e504d167630 (diff) Adding unit test case for n#759180 Change-Id: I85d58e7e0d1a595e2780612808bb8c51c1fb880e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103032 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-19The config.{guess,sub} in $SRCDIR is good for external projects, tooTor Lillqvist
No need for the older second copies in solenv/gbuild. Change-Id: I088f7d06b0727d1b336e3ba314b5c874d8ce3776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103027 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-19tdf#134157 fix Edit with external tool causes a CPU hitTomofumi Yagi
Switch Idle to 100ms Timer for fixing the bug Change-Id: I85a9bdcb173edd28d952d8e91c1b93d748e69206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102984 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-18ofz#25774 keep ParseCMAP within legal areaCaolán McNamara
Change-Id: Ic68fadd3d63631cbccda76e7679d95bb89452d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103017 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18tdf#136830: sd_export_ooxml2: Add unittestXisco Fauli
Change-Id: If42d57cb88119cc4cfc8266ec17c91d1d880fab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103008 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-18[API CHANGE] tdf#136836 emfio: set size hint on inner PDF if used as shape fillMiklos Vajna
The bugdoc has a shape, its bitmap fill is an EMF, which is actually a PDF. The PDF is has a height of 5cm, but the shape has a height of 14 cm. Inform vcl::RenderPDFBitmaps() about the size of the shape, so the result won't be blurry. This approach makes sure that we don't unconditionally render at higher resolution, i.e. the "load a PDF of 100 pages into Online" use-case won't use more memory than before. API CHANGE, because the EMF reader is only available via UNO, though it's likely that no actual external code would ever invoke it directly. Change-Id: If1d8def0136d408a31a0cc54777a7f26430a0ff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102996 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-18Make sure --enable-online-update does not leave behind UpdateCheckThreadStephan Bergmann
...which is known to cause test processes to crash during exit. (Also see 5cd04405c6b2d1ee46294ce0696d89d2edc97d16 "Disable automatic onFirstVisibleTask UpdateCheck during CppunitTests", so this commit now covers tests like JunitTests and UITests that start a full soffice process.) The relevant code is already rather complex and incomprehensible; it handles the automatic update check triggered by the onFirstVisibleTask UpdateCheckJob, manually triggered update checks, and downloading of new versions. To avoid regressions in all those various scenarios, I tried to add very targeted code that should only wait for a still running UpdateCheckThread triggered by the automatic onFirstVisibleTask UpdateCheckJob---which is the scenario that caused issues during `make check`. (For a manually triggered update check or download it is probably both less likely that related threads would still run during exit, as the user would likely wait for a response before closing LibreOffice, and less severe if threads would still run during exit, as any resulting crashes would likely be "harmless" and might not even be noticed by the user.) However, I note that this targeted fix does increase the complexity and inscrutability of this code even further... The new code does not actually try to join the UpdateCheckJob---see UpdateCheckThread::join referencing <https://bz.apache.org/ooo/show_bug.cgi?id=73893> "webdav ucp does not implement XCommandProcessor::abort". Rather, it waits for UpdateCheckJob::run to finish (after unblocking at least any m_aCondition.wait calls). This, however, can take a while if the update check's HTTP request is in progress. To be able to use a std::condition_variable (with sane semantics compared to osl::ConditionVariable) in UpdateCheck::waitForUpdateCheckFinished, the corresponding UpdateCheck::m_aMutex had to be changed from a (recursive) osl::Mutex to a std::recursive_mutex one (sticking to a recursive one just to be on the safe side, whether or not the code actually makes use of that). Change-Id: I2726acd33b884b807d840cfee2786fcf45815ad7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-18tdf#122648 DOCX import: fix table formula in all tablesLászló Németh
Table formula import worked only in the first table, because of using bad fallback table for cell references without table names during formula conversion to internal formula. Set table of the text field as the correct fallback table. Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe (tdf133647 tdf123386 tdf123389 Improved .docx table formula import). Change-Id: Ib080f12426c57c8c74fe919eb45637a655875d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102989 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18tdf#129685 PPTX import: fix unexpected centering of shape textMiklos Vajna
Regression from commit 89f0af144c18efafe2573801641689a1432c0cae (tdf#113198 set default shape paragraph alignment.., 2019-11-19), the old bugdoc had this markup: <a:bodyPr ... anchor="ctr"/> (centered) The new bugdoc has 2 shapes with text: <a:bodyPr .../> (aligned to left) <a:bodyPr ... anchorCtr="1"/> (should be centered) "anchor" is about vertical, "anchorCtr" is about horizontal centering of text. Checking what the binary filter does, it maps horizontal centering to TextHorizontalAdjust, so fix the original bug differently, by leaving ParaAdjust alone, and tweaking TextHorizontalAdjust intead: this keeps the old bugdoc working but fixes the new one. This caused a number of "change detector" XML-based tests to fail: all of them are unchanged visually, so the XML files are adapted to the new state. The tdf#113198 fix itself was fixing a regression from tdf#104722, and that commit had no testcase, I tested that we don't regress there, manually. Change-Id: I81a7b3e8c76bfbce5c5569d16d5238958ac20f75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103012 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-18cid#1466690 ScDocument* arg is never nullCaolán McNamara
So the various fallback null checks are shown to be redundant and can be removed. Change-Id: I93b3c3a9b124b7de48acebcb348a1261c1b0037c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18ScCellValue::getString never called with a null ScDocument*Caolán McNamara
Change-Id: Idff982e715b012e35e0abd0b904f4b83d7f6f51a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18ScCellIterator never passed a null ScDocument*Caolán McNamara
Change-Id: I5d8ea1533fe861cf969c2999343da217c82d54e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18AppendContentsIfInRefDoc never passed a null ScDocument*Caolán McNamara
Change-Id: Ia21f8fecdf8a6aea7ea9c6ea4d579c5e53882bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102982 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18ScViewData may not be available in ScNavigatorDlg ctorCaolán McNamara
e.g. launching the floating navigator before a document has been loaded. probably a problem since... commit 94512c499d678e9eeca05e84361d846bbd3b6950 Date: Tue May 26 21:03:25 2020 +0200 sc: rowcol: convert more use of MAXROWCOUNT Change-Id: I9f987c66b5a89f23e0ca02775d3bdb7b4dbf553a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18tdf#136830 Fix: positions of group shapes of PPTXnd101
For certain PPTXs, Impress fails to import the document with correct group shape positions. More specifically, chExt (Child Extents) calculation should take the values from group shape when 0 is given. Change-Id: I1f8e89dcfe61ab2071ad00850ff99aecb7218067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102895 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-18tdf#136247 OOXML export data label background color.Gülşah Köse
Change-Id: Ie3e00e8195239e6570bfe76c2451bae11c209145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102999 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-18Disable automatic onFirstVisibleTask UpdateCheck during CppunitTestsStephan Bergmann
Some CppunitTests like CppunitTest_sw_core_layout that use gb_CppunitTest_use_configuration and happen to run enough VCL may trigger the UpdateCheckJob (see example backtrace below), which is known to be problematic as it may spawn (via UpdateCheck) an UpdateCheckThread that is not joined, so it can still run during exit and cause trouble. However, there should be no need for CppunitTests to (accidentally) run that UpdateCheckJob anyway, so disable it. Example backtrace from CppunitTest_sw_core_layout: > #9 0x00007fe612e1e89a in (anonymous namespace)::UpdateCheckJob::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) (this=0x3422200, namedValues=uno::Sequence of length 2 = {...}) at extensions/source/update/check/updatecheckjob.cxx:150 > #10 0x00007fe612e1ec45 in non-virtual thunk to (anonymous namespace)::UpdateCheckJob::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) () at instdir/program/libupdchklo.so > #11 0x00007fe61917a51e in framework::Job::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) (this=0x33bbd30, lDynamicArgs=empty uno::Sequence) at framework/source/jobs/job.cxx:209 > #12 0x00007fe61918ae85 in (anonymous namespace)::JobExecutor::trigger(rtl::OUString const&) (this=0x3050030, sEvent="onFirstVisibleTask") at framework/source/jobs/jobexecutor.cxx:238 > #13 0x00007fe619267b09 in (anonymous namespace)::XFrameImpl::windowShown(com::sun::star::lang::EventObject const&) (this=0x31db1c0) at framework/source/services/frame.cxx:2606 > #14 0x00007fe6187b3107 in WindowListenerMultiplexer::windowShown(com::sun::star::lang::EventObject const&) (this=0x32136a8, evt=...) at toolkit/source/helper/listenermultiplexer.cxx:85 > #15 0x00007fe61855989b in VCLXWindow::ProcessWindowEvent(VclWindowEvent const&) (this=0x31d22c8, rVclWindowEvent=...) at toolkit/source/awt/vclxwindow.cxx:480 > #16 0x00007fe6185591a9 in VCLXWindow::WindowEventListener(VclWindowEvent&) (this=0x31d22c8, rEvent=...) at toolkit/source/awt/vclxwindow.cxx:396 > #17 0x00007fe618558a00 in VCLXWindow::LinkStubWindowEventListener(void*, VclWindowEvent&) (instance=0x31d22c8, data=...) at toolkit/source/awt/vclxwindow.cxx:390 > #18 0x00007fe622f934c8 in Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const (this=0x341f540, data=...) at include/tools/link.hxx:111 > #19 0x00007fe622f8f5bb in vcl::Window::CallEventListeners(VclEventId, void*) (this=0x3115da0, nEvent=VclEventId::WindowShow, pData=0x3115da0) at vcl/source/window/event.cxx:256 > #20 0x00007fe6230fbbb3 in vcl::Window::ImplSetReallyVisible() (this=0x3115da0) at vcl/source/window/window.cxx:1306 > #21 0x00007fe6230fbc9e in vcl::Window::ImplSetReallyVisible() (this=0x30ecc20) at vcl/source/window/window.cxx:1322 > #22 0x00007fe6230ff712 in vcl::Window::Show(bool, ShowFlags) (this=0x30ecc20, bVisible=true, nFlags=ShowFlags::NONE) at vcl/source/window/window.cxx:2312 > #23 0x00007fe6230ff859 in vcl::Window::Show(bool, ShowFlags) (this=0x3115da0, bVisible=true, nFlags=ShowFlags::NONE) at vcl/source/window/window.cxx:2328 > #24 0x00007fe6190aa53d in framework::StatusIndicatorFactory::implts_makeParentVisibleIfAllowed() (this=0x32d83f0) at framework/source/helper/statusindicatorfactory.cxx:373 > #25 0x00007fe6190a9b65 in framework::StatusIndicatorFactory::start(com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const&, rtl::OUString const&, int) (this=0x32d83f0, xChild=uno::Reference to (class framework::StatusIndicator *) 0x31128a8, sText="Loading :", nRange=4) at framework/source/helper/statusindicatorfactory.cxx:133 > #26 0x00007fe6190a74cf in framework::StatusIndicator::start(rtl::OUString const&, int) (this=0x3112880, sText="Loading :", nRange=4) at framework/source/helper/statusindicator.cxx:51 > #27 0x00007fe612f3263d in XmlFilterAdaptor::importImpl(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x3420600, aDescriptor=uno::Sequence of length 12 = {...}) at filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:70 > #28 0x00007fe612f36564 in XmlFilterAdaptor::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x3420600, aDescriptor=uno::Sequence of length 12 = {...}) at filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:308 > #29 0x00007fe61dc6f02d in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (this=0x32fa6a0, rMedium=..., xInsertPosition=empty uno::Reference) at sfx2/source/doc/objstor.cxx:2251 > #30 0x00007fe61dc61688 in SfxObjectShell::DoLoad(SfxMedium*) (this=0x32fa6a0, pMed=0x3316a40) at sfx2/source/doc/objstor.cxx:738 > #31 0x00007fe61dcc8e28 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x3320b00, seqArguments=uno::Sequence of length 14 = {...}) at sfx2/source/doc/sfxbasemodel.cxx:1883 > #32 0x00007fe61de63f9c in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x32deca0, rArgs=uno::Sequence of length 11 = {...}, _rTargetFrame=uno::Reference to (class (anonymous namespace)::XFrameImpl *) 0x31db230) at sfx2/source/view/frmload.cxx:680 > #33 0x00007fe6191f5f31 in framework::LoadEnv::impl_loadContent() (this=0x7ffe003aa618) at framework/source/loadenv/loadenv.cxx:1157 > #34 0x00007fe6191f2c12 in framework::LoadEnv::start() (this=0x7ffe003aa618) at framework/source/loadenv/loadenv.cxx:395 > #35 0x00007fe6191f0960 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) (this=0x7ffe003aa618, sURL="file:///sw/qa/core/layout/data/tdf134783_testAnchorPositionBasedOnParagraph.fodt", lMediaDescriptor=uno::Sequence of length 2 = {...}, xBaseFrame=uno::Reference to (class framework::Desktop *) 0x29e7768, sTarget="_default", nSearchFlags=0, eFeature=LoadEnvFeatures::NONE) at framework/source/loadenv/loadenv.cxx:300 > #36 0x00007fe6191ef2dc in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (xLoader=uno::Reference to (class framework::Desktop *) 0x29e7778, xContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x2124250, sURL="file:///sw/qa/core/layout/data/tdf134783_testAnchorPositionBasedOnParagraph.fodt", sTarget="_default", nSearchFlags=0, lArgs=uno::Sequence of length 2 = {...}) at framework/source/loadenv/loadenv.cxx:169 > #37 0x00007fe6192514b2 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x29e7700, sURL="file:///sw/qa/core/layout/data/tdf134783_testAnchorPositionBasedOnParagraph.fodt", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 2 = {...}) at framework/source/services/desktop.cxx:593 > #38 0x00007fe619251575 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at instdir/program/libfwklo.so > #39 0x00007fe61a48bc68 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x3045750, rURL="file:///sw/qa/core/layout/data/tdf134783_testAnchorPositionBasedOnParagraph.fodt", rDocService="com.sun.star.text.TextDocument", rExtraArgs=empty uno::Sequence) at unotest/source/cpp/macros_test.cxx:61 > #40 0x00007fe61a53754d in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) (this=0x3045700, rURL="file:///sw/qa/core/layout/data/tdf134783_testAnchorPositionBasedOnParagraph.fodt", pName=0x7fe621e07e58 "tdf134783_testAnchorPositionBasedOnParagraph.fodt", pPassword=0x0) at sw/qa/unit/swmodeltestbase.cxx:514 > #41 0x00007fe621e15f7a in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) (this=0x3045700, pDir="/sw/qa/core/layout/data/", pName=0x7fe621e07e58 "tdf134783_testAnchorPositionBasedOnParagraph.fodt", pPassword=0x0) at sw/qa/inc/swmodeltestbase.hxx:348 > #42 0x00007fe621e150ea in testAnchorPositionBasedOnParagraph::TestBody() (this=0x3045700) at sw/qa/core/layout/layout.cxx:155 Change-Id: Idcd348ecfa6b6495d9a8710e142232baed8ff45f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103003 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-18Fix typoAndrea Gelmini
Change-Id: I314e7bf6ea4a52929e9bac54b6c390105cf4a117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103011 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-18Fix typo in codeAndrea Gelmini
Change-Id: If7f65f0e42fb13bc40d7c77511406122fa50f458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101200 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18Fix typosAndrea Gelmini
Change-Id: I382bac84126095950a1d3932665c36fb16f1383b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18drop some unused suppressionsCaolán McNamara
Change-Id: Ie11e2ac56fc8a4f1b10f801824764322052bb124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102975 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18tdf#124013 XLSX shape export: fix missing solidFillRegényi Balázs
of the inside of the shape (resulting for example, invisible shapes). See also commit 83c30743eaf44d8eded4a73e3ac2585b5bdbaffc (tdf#77236 DOCX shape export: fix missing solidFill). Co-authored-by: Szabolcs Toth Change-Id: I4efde86f82e22e1aa49b89dc13557ef5f238ba83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102871 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18ScAddress::Parse never passed a null ScDocument*Caolán McNamara
Change-Id: I8832f2cc4311b30b9a15883e831260a19d089a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18Related: tdf#136559 set multiple columns in model at the same timeCaolán McNamara
reduces time from 40s to 13s Change-Id: I01d6a4fcaa5a868f9b9f9292f4a7e99e216ea23b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18tdf#135035 DOCX import: fix auto width of frame in columnAttila Szűcs
In compatibility mode FRAME_AUTOWIDTH_WITH_MORE_PARA no frames should be wider as the column it is anchored to, if the frame width is set to automatic. If there is a paragraph in the frame, that is longer then the parent width of frame, then the frame width will be set to the same size as its parents width. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ie5e7e94fd58219eb944ad9163b1ff2c1e7171858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102671 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18lok: make labels and tooltips translated for commandsSzymon Kłos
In the online we can have multiple sessions with different languages so load cached translations only if match current language Change-Id: I6fcf23f1c340c0c0daffa8862f0b74e4e458c1fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102016 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102960 Tested-by: Jenkins Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-18Styles preview widget language independentSzymon Kłos
Use both english / universal and translated names to identify a style. Change-Id: Ibd8b23e678e8bea5773d1da97adf5201377b4453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101832 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102963 Tested-by: Jenkins
2020-09-18writer: handle styles in multiple languages for onlineSzymon Kłos
Use translated name when style is applied and broadcasted. Avoid using style names created by the first view. Change-Id: I18abf3388e69f76ec99eda94e0b67782a52ab23f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101831 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102962 Tested-by: Jenkins Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-18writer: translate standard styles for onlineSzymon Kłos
in online we can have multiple users with different UI language Change-Id: I8fac53391832acace29388cdbca2c18853ef1690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101830 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102961 Tested-by: Jenkins
2020-09-18tdf#136267 OOXML Chart Import: create main category axis labels onceBalazs Varga
because InternalDataProvider can not handle different category names on the primary and secondary category axis. Revert e0b0502516a10181bbd1737b93b38b2bba4c98e8 commit, except the relevant unit test. Regression from commit: e0b0502516a10181bbd1737b93b38b2bba4c98e8 (tdf#128016 Chart OOXML Import: fix duplicated category labels) Also fix tdf#129994 (FILEOPEN - hang at import time), which is a a regression from commit fa0a981af41a2606541eec1cb20a379a739691e0 (tdf#114166 DOCX chart import: fix missing complex categories) Change-Id: I5d049e760eb1a647ea774be264349a2f16f15f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102463 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18jsdialog: use window only if visibleSzymon Kłos
When there is a name conflict we should take currently visible window. Change-Id: Iaccf03a78b083ecaca0ee6aa538674a6de093a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102903 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102983 Tested-by: Jenkins
2020-09-18Online: Show input help on Online / Core part.gokaysatir
Change-Id: I9d10179f266a725b770fdae50045fdb5d77178ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102708 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 110069adbba4d272450b30fa03c56efbd478e84c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102935 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-18tdf#123382 DOCX import: fix range IDs in column ALászló Németh
Range IDs ABOVE, BELOW, LEFT and RIGHT weren't recognized in the first table column. Also the original formula was not grab-bagged in the first table cell (A1), according to the limitation of isInTable(). Follow-up of commit 436cf6d31deb7f9594a5da52ec7883d7e3d34344 (tdf#123355 DOCX import: fix cell range ABOVE, BELOW) and commit 82189fdc93ac337e1de3379d678eca6b7654e6fc (tdf133647 tdf123386 tdf123389 fix DOCX table formula export). Change-Id: Ic7d9c63a5ca989328f7ed33e25e1eda45296b3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102849 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-18tdf#130785 Hide Insert Formula in online sidebarSzymon Kłos
Change-Id: Ifaf3fe2b7abc463ab35a6924d0d8535631cf490b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102949 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-09-18twain32shim: disable for Windows Arm64 buildJan-Marek Glogowski
I know the platform can emulate x86 code, but have no idea, if this would include x86 TWAIN32 drivers, so disable the build for now. Change-Id: I22cb2ab81ade9f91097586f382cdd4855e27d827 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102955 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-18only handle SID_CURRENTCELL if there is a ScViewData*Caolán McNamara
which I suspect is always Change-Id: Id02afb045b25472df793480823d6f17c0d1ac620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102958 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18Make Group dialog asyncSzymon Kłos
Change-Id: I37fd6c44d43b0f0b424bd023e13ffa07f601a08b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102876 Tested-by: Jenkins
2020-09-18xmloff: remove dead com.sun.star.comp.Draw.XMLSettingsExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I2152f32fd798b7a7df7086b125e77fe804185157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102973 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-18Resolves tdf#97918 - Individual UNO commands for distribution optionsHeiko Tietze
New UNO commands added, SID_DISTRIBUTE_DLG bend to dropdown, ui removed Menus and toolbars adjusted Change-Id: Ic0a3cc299f745a1a0cd18edead1f410ff57a1f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102272 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-18Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 5c93f0a8c1233c584aac64be9dc77d49bf074ade - tdf#92183 Documents events refresher Removed items: JScript runtime error, Print mail merge, Message received Added items: too many to mention This wiki WiP page details the - very limited - API sources I used: https://wiki.documentfoundation.org/User:LibreOfficiant/Events#Events_in_Documents Change-Id: I2f0b85f17fde9b99a2c7ee407d593d3c9207e4d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/102426 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-18Missing test dependenciesStephan Bergmann
From-scratch `make CppunitTest_sd_tiledrendering` had failed for me on Linux with > warn:vcl.builder:964054:964054:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/modules/simpress/ui/sidebarslidebackground.ui xmlreader/source/xmlreader.cxx:66 and > warn:vcl.builder:977272:977272:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebartextpanel.ui xmlreader/source/xmlreader.cxx:66 Change-Id: I351d68ee518b313b5d2b2c864139181710f58bb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102969 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-17tdf#133690 Hide surrounding border frame at sidebarandreas kainz
Change-Id: I6daff0ae587232b4b31d02aeb2529eff3fba36a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102967 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-17tdf#133482 don't increase dialog width when new columns addedCaolán McNamara
gtk will expand to fit all children, while vcl will clip. insert a borderless ScrolledWindow with "external" scrolling to allow the dialog to clip the children (same thing we do for our menubar to shrink down past its natural size) adjust the width calculation to avoid logictopixel rounding Change-Id: Id2e4f92959f1827c6960360d1530a9c63a4d0c00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-13 09:06:34 +0000