summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-03tdf#127766: Avoid ODR violation for class/struct FieldEntryTor Lillqvist
We had a class FieldEntry in registry/source/reflwrit.cxx and a struct FieldEntry in sd/source/filter/eppt/text.hxx. That causes problems when code from both is linked into one binary, as in the iOS and Android apps. The wrong FieldEntry destructor got called from the code in sd which of course lead to a crash. Fix by putting the one in registry into an unnamed namespace. (I put a large chunk of the source file in it while at it.) Change-Id: I1b32075f7aba256129b36ceb38eba605c882b9ff Reviewed-on: https://gerrit.libreoffice.org/80141 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-03loplugin:virtualdeadNoel Grandin
Change-Id: I86bae18ed2682871032aeb2a178f49f3e4601129 Reviewed-on: https://gerrit.libreoffice.org/80129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I9790d053248ae6bd58ecc026c774014c4e5e04aa Reviewed-on: https://gerrit.libreoffice.org/80115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03Resolves: tdf#127882 gtk 3.18 crash in property dialog teardownCaolán McNamara
due to the menubutton popovers in the custom property page workaround by reordering so scrolling window is torn down after the menubutton is destroyed and clear the popover in the menubutton dtor Change-Id: Icf06d912524af13a5590f160150f1a4e15f3e9f7 Reviewed-on: https://gerrit.libreoffice.org/80117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03fix DbaIndexDialog EditingActiveCaolán McNamara
Change-Id: I7f0fe341fef08358d71b13e646065b26f8a73951 Reviewed-on: https://gerrit.libreoffice.org/80114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03fix GtkGrid does not have a child property called xalignCaolán McNamara
Change-Id: I3e501d935bdb0bc6c3f151564f72b05fcc3b2f16 Reviewed-on: https://gerrit.libreoffice.org/80107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03loplugin:unusedfieldsNoel Grandin
and filter out the weld fields, since we're not touching them yet Change-Id: I3cc23c46d2650f13cb29c7d381687939d23e2882 Reviewed-on: https://gerrit.libreoffice.org/80104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03merge msgbox and stdtextCaolán McNamara
Change-Id: If95d78746eff3ae5343e7d4c6bb2433537ccb84d Reviewed-on: https://gerrit.libreoffice.org/80099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop some unnecessary includesCaolán McNamara
Change-Id: I656ed2e29988fe47e4db8fa2ea8edec022bd56c2 Reviewed-on: https://gerrit.libreoffice.org/80098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03Simplify a bit SfxAllEnumItem (svl)Julien Nabet
Make private GetValueByPos which is only used in svl/source/items/aeitem.cxx Remove "RemoveValue" method which is only used in InsertValue( sal_uInt16 nValue, const OUString &rValue ) It allows to call once "GetPosByValue" and the assert is useless since we're in the case: "else if ( nPos != USHRT_MAX )" I think we can more optimize by replacing vector by another container for pValues (type "SfxAllEnumValueArr"). Indeed, we insert and remove a lot in pValues in a specific position. Vector is not the best container for this There's also still the part "//FIXME: Optimisation: use binary search or SortArray" in GetPosByValue_ method Change-Id: I0cafea70e9d0361ef9a7b345ff770a9b888ef85b Reviewed-on: https://gerrit.libreoffice.org/80089 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-03tdf#127907 tdf#126724 Chart DOCX import: fix axis title positionBalazs Varga
Custom position of axis title reset to default when the document is opened in LibreOffice. Also fix tdf#126724 which was a regression from commit: 48480d4f19d2fb92ca4ae0527eec4753cdc439c0 (make tools::Rectangle::getBottom return 0 when empty) Note: The y coordinate of Y axis title position is still wrong because of another older bug. Change-Id: I449ad3b2252e05ab38d6752512d822c355ff8606 Reviewed-on: https://gerrit.libreoffice.org/79966 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-03drop some unnecessary includesCaolán McNamara
Change-Id: Ia388aef3063c99f3b0d9282f53e78edfda5ce4bb Reviewed-on: https://gerrit.libreoffice.org/80085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03update sw pchCaolán McNamara
Change-Id: I5cf649c825f5dfc7130a2973ea1734bc9de4509f Reviewed-on: https://gerrit.libreoffice.org/80084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03update sd pchCaolán McNamara
Change-Id: I557767fe8e148eabddd9ccdaf3fbe6caba2ac05d Reviewed-on: https://gerrit.libreoffice.org/80083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03update sc pchCaolán McNamara
Change-Id: I3ae5ee611d83ca1a3296711f72b96fcb9b475b38 Reviewed-on: https://gerrit.libreoffice.org/80082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop unnecessary includeCaolán McNamara
Change-Id: I2b93cda4110b15184cef657e4b63fec9b9aa166f Reviewed-on: https://gerrit.libreoffice.org/80081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03update basctl pchCaolán McNamara
Change-Id: Ia8adfaf9e4dfb31e44d401a411960abde7f28044 Reviewed-on: https://gerrit.libreoffice.org/80079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop some unnecessary includesCaolán McNamara
Change-Id: I76eceb7eec534171420f2ac26918e44dde0dd738 Reviewed-on: https://gerrit.libreoffice.org/80078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop debugging RulerDebugWindowCaolán McNamara
Change-Id: Icf0da14e17ca023bd93ca2a94290f5bbb8289f96 Reviewed-on: https://gerrit.libreoffice.org/80068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop unnecessary includeCaolán McNamara
Change-Id: I0122b989deef01f38e4fe4a1eb2d157ba01d660c Reviewed-on: https://gerrit.libreoffice.org/80067 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03rename SwNumFormatListBox back to NumFormatListBoxCaolán McNamara
Change-Id: Ie5d5a3d4bfad52d1f758a6b4e017a7f685630e97 Reviewed-on: https://gerrit.libreoffice.org/80066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03NumFormatListBox is unusedCaolán McNamara
Change-Id: I19292f1b1a2eb5abf250a222d0bdb254ae7350f2 Reviewed-on: https://gerrit.libreoffice.org/80065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03drop some unnecessary includesCaolán McNamara
Change-Id: Ib73e1e87d3b2c0a38dd56d891f4ade84845ce228 Reviewed-on: https://gerrit.libreoffice.org/80064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-03sw anchored object allow overlap: replace TODO with OASIS proposalMiklos Vajna
Change-Id: I2746a2c55ed05cc58b2bcfed4f61c0461fce6ea1 Reviewed-on: https://gerrit.libreoffice.org/80086 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-03tdf#125565 always send the graphic selection for the tableTomaž Vajngerl
Change-Id: I7085b2f1ddcfd83eccbbcaba4892cde95b6bd85c Reviewed-on: https://gerrit.libreoffice.org/80034 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-03tdf#81100 DOCX import: repeat header according to table styleLászló Németh
Table style based repeating table header wasn't repeated, only direct table formatting. Change-Id: I119e6d32bf22c6c85a84aa42ae4cd6c5f60166b2 Reviewed-on: https://gerrit.libreoffice.org/80053 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-02Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations from weblate and force-fix errors using pocheck Change-Id: I7557b97bdb5a55b6fe5b9566c90bf8fb6ddd6468 - update translations for 6.3.2 rc2 and force-fix errors using pocheck Change-Id: Idc89d7732f84e6b59bfca1494212ac70039b1e3b (cherry picked from commit 95b02f3806280a4a9580d7d9ee49980dcdf153cc) - update translations for 6.3.2 rc1 and force-fix errors using pocheck Change-Id: Ie9a2ed807a0fad0c57cdd939e147ae31b5082aa2 (cherry picked from commit 9063e2a14b9f0f8e67fc1ec8494f7ace8c12e47f) - update translations for 6.3.1 rc2 and force-fix errors using pocheck Change-Id: I68b4c6d31d4f902c9e1891192d433b101d6edb42 (cherry picked from commit 595d87648046bd70abf2eee0e328369f9c4be5e1) - update translations for 6.3.1 rc1 and force-fix errors using pocheck Change-Id: I05d66c16174c18360182c88b86ecea4f9c5f8183 (cherry picked from commit c85b9f992801d2d9de8c68c862b4b2d79ff5bc64)
2019-10-02pocheck: also preserve header in check for function namesChristian Lohmaier
Change-Id: I53b67e8c690b110d2d77e100b8170ac968e35e2b
2019-10-02update cui pchCaolán McNamara
Change-Id: Ia14ed249615417248a8c784b5aa2cbb46c008084 Reviewed-on: https://gerrit.libreoffice.org/80063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02drop some unnecessary includesCaolán McNamara
Change-Id: Ibbf459284a1555ad8ff836a610901844c82a6871 Reviewed-on: https://gerrit.libreoffice.org/80062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02update svx pchCaolán McNamara
Change-Id: I551fbb77d820bebc0686d0d9e2b2b652cd5760d6 Reviewed-on: https://gerrit.libreoffice.org/80055 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02move Breadcrumb to sole user in fpickerCaolán McNamara
Change-Id: I2028f921e78611698e82e50a652b67dba1ece909 Reviewed-on: https://gerrit.libreoffice.org/80054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02weld PrintDialogCaolán McNamara
Change-Id: Id4adbe484f88be74f45dab8e7ef426c66e5cbc8b Reviewed-on: https://gerrit.libreoffice.org/80002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Reinstate "Use G_ADD_PRIVATE and *_get_instance_private"Stephan Bergmann
(efc1d001821747dc72140aeb3e0f0b48b1eed005), which had erroneously been dropped by 1ae450504cf57457f9702684b1517fda1dd3c481 "drop gtk2 support" Change-Id: I73b9ecdb1ee4fe45ee3ba25a3f93d9b26908d58b Reviewed-on: https://gerrit.libreoffice.org/80027 Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Tested-by: Jenkins
2019-10-02Resolves: tdf#127873 accept ',' comma group separator in number entities againEike Rathke
Existing documents unwittingly may have used that as decimal separator in such locales (though it never was as this is always the en-US locale). "Regression" from commit 9336286a7ea5385541344f444e6f8702c85bdacb CommitDate: Fri Nov 30 22:15:22 2018 +0100 [API CHANGE] Resolves: tdf#42518 new KParseTokens::GROUP_SEPARATOR_IN_NUMBER Change-Id: I0ffc1b8ec7c1820fccd8277036c64093dddf82fe Reviewed-on: https://gerrit.libreoffice.org/80023 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-02Resolves: tdf#127904 modal depth dips below 0Caolán McNamara
when validation dialog is run modally, but changed itself to unmodal during execution. only NotifyModalHierarchy on modal<->unmodal transition and not on modality depth Change-Id: I85d4f67e5b0426aafbf80b1ae25fc3e3f19717af Reviewed-on: https://gerrit.libreoffice.org/80039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Resolves: tdf#127924 give hyperlink tooltip an areaCaolán McNamara
instead of just a point Change-Id: Ibadecd64f3296264790373528427a7a528646c73 Reviewed-on: https://gerrit.libreoffice.org/80038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Unit test for removeTextContext.Michael Meeks
Change-Id: Ib75259f1680fac41a84caeef57718203ec9c4b86 Reviewed-on: https://gerrit.libreoffice.org/79880 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02input: ensure that removeTextContext happens in the right order.Michael Meeks
Unfortunately the backspace key-events we emit trigger uno accelerator handling, which happens another PostMessage further out, so cheat by doing it synchronously, and relying on the PostMessage inside to get the ordering right. Change-Id: Ibee80af7674fd5107cb1c9ba323071ac024c45ae Reviewed-on: https://gerrit.libreoffice.org/79883 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02Ensure that 'input' events are processed asynchronously too.Michael Meeks
Change-Id: I715eadd444e428148cfff8a61436987517004fae Reviewed-on: https://gerrit.libreoffice.org/79882 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02Adopt a more brute-force approach for deleting text for now.Michael Meeks
Change-Id: Ib5e75703a50ec89716542c45bc9dd58f0e631509 Reviewed-on: https://gerrit.libreoffice.org/79881 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02LOK: disable LOKit in unit-tests only after destroying allAshod Nakashian
When we disable LOKit at the end of a unit-test, we do so before any of the smart-pointers go out of scope. These instances are then destroyed when LOKit is no longer active, in spite of the fact that they were created while it was. This leaves some dialog/window routing notifiers dangling, which cause assertion failures and access-after-free (when they are invoked on destruction inadvertently). The latter issue was found with 'make CppunitTest_sd_tiledrendering VALGRIND=memcheck'. The fix is to move these flags to the setup and teardown stages of cpp-unit. Change-Id: Ic4481305ca1a5cca14d70a4ebbc820a3fdeea9cc Reviewed-on: https://gerrit.libreoffice.org/80028 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02uitest: share some code.Michael Meeks
Change-Id: I2f586bd5e2e4c3cf1fc052cdfe526532dca9acd4 Reviewed-on: https://gerrit.libreoffice.org/79884 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02tdf#124601 sw FollowTextFlow: fix hori pos of objects outside the current cellMiklos Vajna
The problem is that the image in the bugdoc's footer is anchored in one cell, but its position has a value that shifts it to the next column and next row. The next column is the problem for the horizontal position. So build on top of the previous vertical position fix, and make sure that CalcRelPosX() doesn't limit the position inside the current cell for an in-table, follow-text-flow, wrap-though image. Once that's in place, make sure that we don't try to grow the cell due to follow-text-flow, wrap-though objects in CalcPosition(), since in a wrap-through vs follow-text-flow situation, the wrap-though should have priority (should not affect size of cells). Finally, now that cells don't grow in this case, the previously added special-casing of footers in SwFlyFreeFrame::CheckClip() is no longer necessary. Not growing the cells means we don't try to re-position the object. Change-Id: Ic55e4b5188704fa70314f91fe9a01987b6a56d7b Reviewed-on: https://gerrit.libreoffice.org/80032 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-02Silence -Werror=redundant-move (GCC 10 trunk)Stephan Bergmann
...after e8b74f5777440559fc9702a9bddd32b9428972a3 "-Werror,-Wreturn-std-move (clang-cl)" Change-Id: I0633612387e21eceeb64e677503614fa59285d3e Reviewed-on: https://gerrit.libreoffice.org/80036 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-02WTF "WTF 255 return value?"Stephan Bergmann
0e68bac85293e2d60fa6db3e46de8b74ab5d502b "set up python unit test infrastructure" had introduced unotest/source/python/org/libreoffice/unotest.py with the comment and commented-out code. It claims it has extraced "boostraping code from convwatch.py to unotest.py", but I can't find a trace in the git history of a prior incarnation of that comment and commented-out code. It is unclear what problem exactly the commenting-out of the check was supposed to address. So put the check in place and see what, if anything, breaks. (The commented-out return appears to be truly unnecessary, and has been removed completely.) Change-Id: Ie2108d70fbe076cd0832bd23bfb29fc60eedffef Reviewed-on: https://gerrit.libreoffice.org/80029 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-02Reinstate "Clean up uses of deprecated G_CONST_RETURN"Stephan Bergmann
(f5bbb2db98fe420174328e6c8e2f3d160a9b7758), which had erroneously been dropped by 1ae450504cf57457f9702684b1517fda1dd3c481 "drop gtk2 support" Change-Id: Ib7e2fc5bfa394dd6c49d5c9710e1c415fdfe2186 Reviewed-on: https://gerrit.libreoffice.org/80026 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-02add wheel events to drawing areaCaolán McNamara
Change-Id: I6071a2af3cbb01c4f21c45e289f779adc49e0dc2 Reviewed-on: https://gerrit.libreoffice.org/80022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02extend popup handler to cover all CommandEventsCaolán McNamara
Change-Id: I26360ce5c696d0e571385d83a15876eb2286e12f Reviewed-on: https://gerrit.libreoffice.org/80021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Avoid std::vector inheritance for SfxAllEnumValueArrJulien Nabet
No need to inherit, just create a typedef Change-Id: Ifeabb90e640e10e590f793716c022f91850ae8b9 Reviewed-on: https://gerrit.libreoffice.org/79991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-28 14:25:26 +0000