summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-16Unfriend someMike Kaganski
Change-Id: Ib0a87bae89903f9ae851a6e3e2d6ef9f9197cf13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134360 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-16sw: prefix members of SwMSDffManager, SwWW8FltControlStack, ...Miklos Vajna
... SwWW8FltRefStack and SwWW8ReferencedFltEndStack See tdf#94879 for motivation. Change-Id: I93ac7230bc383433d7232c5d14ed98339620316f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134380 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-16use more string_view in URLTransformer::parseStrictNoel Grandin
Change-Id: If3087253a75a1cba16f69eecccbaf845ed0b12bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-16Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to b62a15c05d585dddfa0206a478867feff1294df8 - tdf#148413 Help: Remove mention of dropped Character Set setting Change-Id: Ica686d2cef655d7039c0032dce3a5ff08f056f17
2022-05-16ofz#47473 OOM just skip the unused "reserved" data on readCaolán McNamara
and don't store it Change-Id: I7e68111b5ed724c5eab9e8040b8c28f542064ae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-16enable libc++ debug mode again if availableLuboš Luňák
Now includes a configure check for the std::to_string() crash. Change-Id: I45c3b804b7a1ff5f6520f7bdf772497f72ddee47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134338 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16std::stable_sort() where libc++ debug mode breaks a unittestLuboš Luňák
Libc++ debug has a feature that randomizes equal elements during sort, which normally wouldn't make a difference, but some tests rely on specific order of tested data. The ones failing without this include: CppunitTest_sw_ooxmlexport testMsoPosition CppunitTest_sw_xhtmlexport testTdf66305 CppunitTest_sw_ww8export testCommentExport Change-Id: Id49846939a264150cc82091718ffe6b904d7130e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134337 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16fix GETPIVOTDATA() field name lookupLuboš Luňák
Field names are case-insensitive, so the lookup was failing if the name wasn't typed in a way that matched exactly as case-sensitive. The A29 field in getpivotdata.fods test was passing only because the fields were typed in the same order as present in the pivot table, and std::sort() was accidentally stable. But reordering the fields in the formula makes it fail, and so does using libc++ with debug mode (which randomizes equal fields in std::sort()). Change-Id: I88d078da435685c3557f24dc5f4a0bfc4d563aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134336 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16make SharedString move operator= inline (tdf#126109)Luboš Luňák
Calc uses SharedString in mdds::multi_type_vector, which may move contents of its blocks on some operations, and making this inline makes such operations faster. Change-Id: I67d14639cf253c56b8cca5b2837bb06bc9afd7d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134339 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-16optimise common case of reading a single-pass PNGNoel Grandin
Change-Id: I5408f9d9b7c3e0d08c1bc6bafaca97f18898387f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-16tdf#62776 expand tooltips for + and -Seth Chaiklin
The tooltips for + and - in the LibreOffice filepicker are elaborated further. Change-Id: Ifb66caae78076971eeb74a20ac9284a07038bf1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134357 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-05-16ofz#46070 handle unknown line stylesCaolán McNamara
Change-Id: I8cc8f6d832e72483d27b09cc57afbde04df770ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134351 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-16tdf#149050 fix .uno:Gallery not opening Gallery deckJim Raykowski
Change-Id: I3e43d61e9a37f0815dafc2cf400bcb658e6c6948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134297 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-15cache string in DocInfoHelper::GetGeneratorStringNoel Grandin
since it doesn't change Change-Id: I8a9eee18b6de5f375ee2d4d67cdf48700590d007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-15use boost::flat_map in config_mapNoel Grandin
reduces time spent allocating Change-Id: Idd571db62d28be7e48672f76d741174a7ab40959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-15don't construct SequenceAsHashMap just to extract a couple of propertiesNoel Grandin
because construcing SequenceAsHashMap requires allocating a bunch of heap objects Change-Id: I2bb1d05b23613d8c8f8a475e006b313578c18c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-15tdf#149049 related: fix media object inserts twice in WriterJim Raykowski
Change-Id: Id7a7b845e0255086eb877d21699ddb0b80cc47c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134335 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-15tdf#149068 reject OpenGL versions that don't support glGenVertexArraysCaolán McNamara
use a throwaway toplevel to figure that out, because if the current window is used then gtk will always call glGenVertexArrays on it due to the creation of a GLContext which is the problem we want to avoid. Change-Id: I40ccc48b5ed2d9fd99d3c242244847c8448c3803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-15vcl/tiff-import-ccitt: Pragma once + prefix private membersJulien Nabet
Change-Id: I49a81f7ae354ca487e8c441629aff5edc2ede2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134341 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b5252c954087cb842dff319b8787e0ddc4eec315 - Refactor Direct SQL help page Change-Id: I7e201b789580caec861a754f40ff75f50e571123 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134332 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 1d913c170c5e0ef185b1e964fe4faaacc42b1616 - Refactor XSLT for code colorization Change-Id: Ia619b7b0b1548c9de0b183a731e0cca3033eb529 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134349 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-15tdf#124820 sc: overwrite more character level font attributesJustin Luth
The issue here is that certain character properties applied at the cell level did not clear out those properties from the character runs. Specifically strikethrough, underline, overline, italics, outline, shadow. Specifically for xlsx import - where a default value is specified in many cases instead of not being defined at all - this meant that the cell change had no real effect, since the direct properties have priority. A 2010 commit 4ef978de83610b0e1912bce1d59432b9c382b9fc did this for font, size, bold, and color. Perhaps that was all that was needed at that time, although even back these other properties probably should have been handled as well, because the cell-change didn't affect the entire contents. In 2013 a LO 4.1 commit f54ce3e7f6d6aab7e34c54ad8eff06650e076fef increased the impact during xlsx import. I assume that adding the CTL/CJK attributes is also necessary. Change-Id: Id933af1ce187a79851868a6a295b33758062fe3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134254 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-05-15vcl/tiff-import-lzw various changesJulien Nabet
Seen during tdf#119686 investigation: - Prefix private members + add some spaces for readability - Pragma once - Declare constexpr CODE_CLEAR, CODE_EOI and CODE_FIRSTMULTICHAR - Rename m_nTableSize to m_nTableCurrentId - Use constexpr instead of #define for a const - m_bFirst useless - Reinitialize at each StartDecompression call Change-Id: I6342f3b25bef94950a152186db07aa11ecc6cd5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134340 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4d4f563ca60a0dffe6a29c010bb6d833bb2abb91 - Revisit Base Query page Change-Id: I74ab17b065f0dcd516ba7a80ee08c4d11f84aa49 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134330 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to cfa7975316e7fa8e88a2c2e06ad37240d1b6e057 - Add SQL code colorization to Help pages Change-Id: I2c74e63c67a323a6e6b726da352dd23e1a88d886 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134329 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-15use comphelper::WeakComponentImplHelper in GenericClipboardNoel Grandin
Change-Id: I7135ca3c5f8080929b99a65a0034b568f071d618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-15no ScSortedRangeCache-based query for number-as-string (tdf#149071)Luboš Luňák
The comparison depends on the cell encountered, which makes it hard to prepare the sorted data. Change-Id: I22f55003acde7eedadb8a4c8d61390dd30b6ac8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134287 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-15ScSortedRangeCache-based query doesn't work with mbRangeLookupLuboš Luňák
Change-Id: I9ce8e3547fc261e92e1330df4c054c3efe532d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134286 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-15osl::Mutex->std::mutex in SvtLinguOptionsNoel Grandin
and fix SvtLinguConfigItem::GetOptions so that it only accesses state while holding the lock. Change-Id: Ie092bf427e130348131412a038bce7de8ebcde83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134327 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14ofz#47323 suppress Direct-leakCaolán McNamara
__lsan_default_suppressions works in a local oss-fuzz image but seems to have no effect when deployed which fits with the report of https://github.com/google/oss-fuzz/issues/6066 try explicit __lsan_disable/__lsan_enable guards which also works locally Change-Id: Ifbfdb9d9ba7014b78b43578c25fca97c3279bc5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134331 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-14tdf#133716: Fix edge gradient when upscaling imagedldld
When an image is getting upscaled with cario as engine it got blured borders. The issue that was worked on showed, in the PresenterConsole, that the borders of the previews and control area had an unnecessary gradient in it. As these borders are build from images which are getting upscaled, either in width or height a graident ocurred. This was because the cairo rending didn't had the correct pattern extention set: CAIRO_EXTEND_PAD. Nearly same issue also occured when adding an image to a presentation and upscaling it, the borders got blured. For images with either height or width equal to one this was a while back fixed: tdf#114117, but not for the general case. Using another extend mode fixes this, because the PAD extend mode doesn't blur the borders. CAIRO_EXTEND_PAD: pixels outside of the pattern copy the closest pixel from the source Change-Id: I39f8a14a69f035a43a93afb303f0a2e7ec8699c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-14Related tdf#149072: avoid warning "misuse of method"Julien Nabet
complete warning log: <SwTextFormatColl::GetAssignedOutlineStyleLevel()> - misuse of method part of bt when opening attachment of tdf#149072 0 SwTextFormatColl::GetAssignedOutlineStyleLevel() const (this=0x77064d0) at sw/source/core/doc/fmtcol.cxx:608 1 0x00007f8a52aa7941 in sw::(anonymous namespace)::HeaderCheck::check(SwNode*) (this=0xa457630, pCurrent=0x7705e98) at sw/source/core/access/AccessibilityCheck.cxx:622 2 0x00007f8a52a9a6a3 in sw::AccessibilityCheck::check() (this=0x7ffe4a14ab10) at sw/source/core/access/AccessibilityCheck.cxx:947 3 0x00007f8a53ed2ad7 in SwDocShell::runAccessibilityCheck() (this=0x74ef0e0) at sw/source/uibase/app/docst.cxx:1559 4 0x00007f8a16e7fdec in ImpPDFTabDialog::OkHdl(weld::Button&) (this=0xa0e9990) at filter/source/pdf/impdialog.cxx:324 5 0x00007f8a16e7fb2d in ImpPDFTabDialog::LinkStubOkHdl(void*, weld::Button&) (instance=0xa0e9990, data=...) at filter/source/pdf/impdialog.cxx:317 Change-Id: I2ed50f14eff01babd47ada3831c0a051fc767dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134312 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14tdf#149072: fix export PDF with PDF/UA in GUI after Index language was setJulien Nabet
Regression of a1f9fea520f5b3f5d54a284886aa531693f32e7a Make accessibility check dialog async First add of m_xDialog->response(RET_OK) fixes the bug the second one is just here to have same behaviour as before the quoted patch Change-Id: Ib24459e4e946b83172271a9097930e5977e676be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134311 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14tdf#149079 don't skip disposing DnDListenerCaolán McNamara
even if there is no longer a DropTarget don't return early and omit to inform listeners of the disposing Change-Id: I6ce7fe1664049a9e0a88b549b1c8c94ec8072c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-14tdf#121740 cache hashcode in SequenceAsHashMapNoel Grandin
shaves 2% off load time Change-Id: I5bd4eabf61205df21a27d2822acd2676a7732a3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134315 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14optimise SfxFilterMatcher::GetFilterForProps a littleNoel Grandin
- avoid repeated construction of SequenceAsHashMap - avoid construction of OUString Change-Id: I62560dad26d3433e7c379669da437261b5fe0238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 789bc6e2c10536e5a876c5c4fb0126dbffe4dcbf - Bump Prism.js to 1.28 + Add SQL coloring syntax Change-Id: I3a68a54dee211d791da72b459647315395e17658 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134326 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5c82eb12e524d454c02798994d08d50548c9734c - Fix bad filename and links in Query Desing Help page + Remove internal links that breaks reading comfort. Change-Id: Ic417bfa2dd8f2b904575d69e6d3e98f0b8a8ce37 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134324 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Ic5163d9b570b907c6e7c840a8f6cc9dc73a8f958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134270 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 5cc5cbc6aefae06f547529bc0d417e14dc486fc4 - Fix typo Change-Id: Ia62d016ffacbeb4a9cac6a27f52843432c29e755 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: I1454a649ab434fe4d34a181bc572472a2784c1df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134321 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: If7581fbc808b985cbf6d81a2e66571ddc465f16e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134320 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Ib0913aef00cd252d3f082ec5e8b39064df63a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134319 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-14simplify initialisation in ToolBarManager::CreateControllersNoel Grandin
Change-Id: I2e876f0bff180e569394e2fe3c102b658a55d170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14use more string_view in getNameNoExtensionNoel Grandin
to avoid some allocation Change-Id: Ic8d42af03a4ffd15414e3458b5b08e04ded43114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14cheaper to let Any do the comparison in isSubSetNoel Grandin
rather than constructing temporary OUStrings Change-Id: Ibb083e3fab8a465ae5288359424b297faac83617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14elid some OUString construction in SmXMLExportWrapper::ExportNoel Grandin
Change-Id: Icc091a7fab3c9ce368bd45536de1e75d29431c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14bypass some unnecessary wrapping in Any in SfxEvents_ImplNoel Grandin
Change-Id: I96d1194253207642e7abe83b0b18c82eb3782824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-14Add extended tips for Direct SQL dialogOlivier Hallot
Change-Id: I0b46222ed60084544d6271fba258f02955baaa0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134295 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2022-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a6b0ba3babd4f6ed7aa55d9ccd85361970857977 - tdf#149086 Fix Help page for Direct SQL command Add target bookmark Update page content with latest UI enhancements Change-Id: I88ec6bf787d7e4bb5df24b8e1652e5f176afdbf9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134296 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2025-01-15 10:36:43 +0000