summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-29Resolves: tdf#119659 Check found position for result vectorEike Rathke
Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-29use XThemeColor instead of XInterface for *ThemeReference propsTomaž Vajngerl
Change-Id: I23b6a7429bbcf7901f3d817c970ee7ef4a453197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151184 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: I5b39a16479a69c0683d8e04497ad24421112751c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151126 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Simplify a bitMike Kaganski
Change-Id: Id768a3e10eb593af84bdea423ddfd090df33eef2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151182 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29tdf#155077: use the selected URL when writing languagesMike Kaganski
Regression after commit 9a55b97e980bbf2a0ce12841f6168f1f7545ac96 (tdf#40068 Remember last directory for basic/dialog import/export, 2021-07-14). Change-Id: I6ddb88cbe8a08128c451169de7e9ed4597dc4356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151181 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29tdf#45705 Define accelerators for zoom in/outRafael Lima
This patch defines the shortcut Ctrl+Shift+PgUp/PgDown for zooming in and out. Change-Id: I2ba486de82952e3cc06b56e70a8cb157cdae0ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150212 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-29Simplify strtmpl.hxxMike Kaganski
Replace bulky and difficult-to-read template argument names with clearer ones; remove excessive whitespaces; reorder to avoid forward declarations (these are remnants from the refactor from macros to templates, when I tried to keep the old structure as close to the original as possible). And also a small code simplification in doubleToString. Change-Id: I901cfb86daf410e85269538f36ebb6b553a4be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151125 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-29Prevent to get 0 font size in the auto-fitting algorithmTomaž Vajngerl
When the text box is empty, the size of the box can be returned as (0,0) so the auto-fitting algorithm will calculate the scaling to 0%, which means the text is shrinked to very small size or is invisible. This change fixes the issue so that if the size is (0,0) we just return and leave the scaling at 100%. Change-Id: Ie359461f23a1f7a496eb03b5670f588ad48bbf49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151178 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to cac49fecf0b35af451fd0e043b21f86a8a46b38d - tdf#139027 More on INDEX() function + Review after erack comments Change-Id: Ibc294c35dd98cbd5c9f2b638db4e9cf31e768edd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151175 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-04-28qt a11y: Forward changes to active stateMichael Weghorn
Forwarding of a11y state change events had in general been implemented in commit 8c3e8af0e60865ec6d38e2117efdb4ed2f10a20c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jun 17 17:29:19 2022 +0200 qt a11y: Forward STATE_CHANGED event as such , but that commit explicitly did not yet enable forwarding of changes to the `active` state; quoting from the commit message: > For some reason, forwarding changes to state `AccessibleStateType::ACTIVE` > resulted in Orca becoming unresponsive (stop talking) quite quickly. > That needs further analysis, so that state change isn't forwarded > to Qt for now. I no longer see this problem on Debian testing with Orca 43.1-1, current LO master and qtbase dev branch as of commit 589c6d066f84833a7c3dda1638037f4b2e91b7aa plus the pending Qt Gerrit change [1] ("a11y atspi: Implement TableCell methods Get{Column,Row}HeaderCells") in place. Without the latter qtbase change, I can observe Orca becoming unresponsive quite quickly when moving around in Calc after pressing Shift, which may be due to waiting for a timeout instead of receiving the proper reply to the AT-SPI methods that that Gerrit change implements. (S.a. QTBUG-113110 [2] for another scenario using a simple pyatspi script to trigger what is potentially the same underlying issue.) Therefore, drop the old workaround. With this LO and the Qt change in place, Orca announces the focused and selected cell(s) in Calc with the qt6 VCL plugin and these steps: 1) start LO Calc with the qt6 VCL plugin 2) press Shift and wait a few seconds 3) move around using the arrow keys 4) select cells using Shift + arrow keys Ideally, this should also work without step 2, but apparently that step currently somehow triggers something relevant (creation of relevant a11y objects and registration of their listeners?) that doesn't yet happen without step 2. [1] https://codereview.qt-project.org/c/qt/qtbase/+/473907 [2] https://bugreports.qt.io/browse/QTBUG-113110 Change-Id: Icff8bbe7a6ee233407804c9098166945cdef4315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151176 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-28Add .cache (Qt Creator) and gdbtrace.log (gdb)Hossein
Change-Id: I80ebe9270bcb895ea95d2fd679417dd4f2b22165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151047 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-04-28tdf#145538 Use range based for loopsRadhey Parekh
Change-Id: I6a393526d96fc5c7bee88fc03fc254dbdbe975cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138157 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-04-28survive exporting to pdf without config for fuzzingCaolán McNamara
Change-Id: I229f25a8a15b21257756ecfa008b9e99681003c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-28fix type checks of raw SdrObject's in writerNoel Grandin
Which are no longer possible since SdrObject is abstract now. I assume the original code was gunning for the kind of objects that were being created before commit 24a374ebc9da56cc6721e8feaa1e15ba850bf41d tdf#154040 use a SdrObjKind::NewFrame for frame creation in writer Instead of (ab)using SdrObjKind::NONE for the temporary, empty Since that is only explanation that makes sense Change-Id: I0c3a26cc303ab7d54193beacb285c69aaf98a63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151170 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2023-04-28Revert "remove dead code in SwDrawModellListener_Impl::Notify"Noel Grandin
This reverts commit e8c265d06a9f34fec382d67c65c38189f16ee323. Reason for revert: I misunderstood how the isType is working here Change-Id: Ic4fcedd02affa6df58b74b4cad231cfdf6288592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28tdf#90496 - Remember last used view in hyperlink dialogAndreas Heinisch
Change-Id: I500e9e58c84486307c50f4ccb878ad0340412246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151039 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-28Fix typoAndrea Gelmini
Change-Id: I20d3d5120c35d34d52b463ff7d8de74a4b8b02f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151158 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-04-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c8a6e326f6207982fd507161d48f7793cfe82c26 - Refactor page - no change in contents Change-Id: I5686fda46a1e572a6156b125f6dc9d11416af4d5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151174 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-28Revert "remove dead code in SwDoc::CloneSdrObj"Noel Grandin
This reverts commit 23046111d01ab0ec5feb570d428aea5ed4ece5fc. Reason for revert: I misunderstood how sw::isType is working here Change-Id: Ib5eac520f4ed79dbe1d6088a44e17b2b2a129877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28Move all handling of AA allowing from svt to drawinglayerMike Kaganski
Commit 444bf8710d5da7b584fbcb94693e4ed8d2e29297 (Update handling of AntiAliasing settings and processor2d, 2022-11-08) moved the actual variable holding the AA state to drawinglayer, which introduced a duplication of the information. This moves all the handling from svt to drawinglayer, so that svt functions only use respective drawinglayer functions. Well, almost: the IsAAPossibleOnThisSystem function needs vcl, so stays in svt. Change-Id: I887307fbca1ca0cff1f5f32446e3599817099c3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-28Resolves tdf#153499 - Hide newly introduced frame labelHeiko Tietze
Frame content is not shown for existing entries Follow-up to 4ec75d22eb916e3809e9e92f77fd25e33f6b21ee Change-Id: Ic2b40b19424245ede326a5ef5b53f684ca8a3f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151166 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-28Revert "Revert "introduce sw::SpzFrameFormat ...""Bjoern Michaelsen
apparently, in SwHistoryChangeFlyAnchor::SetInDoc, m_rFormat might actually reference a DrawFormat, not a FlyFormat, and that is likely fundamentally broken. But for now, lets just make m_rFormat a sw::SpzFrameFormat -- this already removes some pointless up and downcasting. This reverts commit 52acefd6024ec79f8333ba40eef83816eda3046f. Change-Id: I040d98548bf9ac1c25b93214224eb0812f8cb653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151150 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2023-04-28Capitalize "Display tracked changes" string to match othersRizal Muttaqin
Change-Id: I012871296dcf8b3d27003c681b4fa2179bb0f943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151165 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-28tdf#155046: sc_subsequent_filters_test4: Add unittestXisco Fauli
Change-Id: If0e64b6b4be769a485153465404370316d3f6587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151162 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-28disable dbl-click in ThemeDialog in LOK, remove the dialog sizeTomaž Vajngerl
The double click in THemeDialog exits the dialog automatically, but this causes a crash in online, so disable it there. No need to set the theme dialog size to a certain fixed value so we don't add white space. Change-Id: I555a631b7d0c515ec326c3654138982c59d3f021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151106 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-28tdf#86630 sw page number wizard: mirror margins as wellJustin Luth
This is only done in a very specific situation, when no heading/footer is defined at all. If we turn on mirroring at this point, then be helpful and mirror the margins as well. By default, this is irrelevant because the margins are identical. It isn't necessary for page numbering, but I think it is a nice touch to add something that most people wouldn't find otherwise. If they really want mirrorred page numbers, then it is highly likely they also want mirrored margins. Helping out people is the whole point of wizards after all. Change-Id: I20cde65dc95ea3115951a4ea3a01534399f19f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151153 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-28remove dead code in SwDoc::CloneSdrObjNoel Grandin
Dead because isType<SdrObject>(pObj.get() is unconditionally true, which renders the entire if statement dead. Ever since it was introduced in commit 68428bf17441dc0ec9dfcffd7cc6073660e552f0 Author: Vladimir Glazounov <vg@openoffice.org> Date: Fri Jul 4 12:19:41 2003 +0000 INTEGRATION: CWS aig02 (1.12.32); FILE MERGED 2003/07/03 13:29:21 od 1.12.32.4: #108784# further adjustments for support of drawing objects in header/footer <SwDoc::CopyLayoutFmt(..)> - do *not* connect draw frame format to layout, if its corresponding <MakeFrms> will not be called. 2003/07/02 16:04:01 od 1.12.32.3: #108784# - consider 'invisible' layer at drawing page for support of drawing objects in header/footer 2003/06/26 18:17:53 od 1.12.32.2: #108784# - further adjustments for support of drawing objects in header/footer 2003/06/26 17:02:11 dvo 1.12.32.1: #108784# copy shapes (but not controls) into header/footers Change-Id: Idca3d73ac5b790f93e56214ce1aaa3e99a173a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28fix regression in "tdf#119388 add new UNO listener/broadcaster"Noel Grandin
Upon further inspection, I note that part of the the code I added in commit ec940941e0bd7db15c5cf7d43df82226e0d849dc Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Aug 20 17:03:13 2019 +0200 tdf#119388 add new UNO listener/broadcaster would never have been able to be hit. Re-arrange a little to fix that. Change-Id: I537102d768591e5fa0ec2fb4b52b05dad4d26f29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28remove dead code in SwDrawModellListener_Impl::NotifyNoel Grandin
The isType<SdrObject>(pSdrHint->GetObject()) ) ) code has always been unconditionally true, because SdrHint has always returned an SdrObject, ever since it was introduced in commit 12b8488b9cf659adcafd4b998227397c57cf51ba Author: Vladimir Glazounov <vg@openoffice.org> Date: Wed Jul 9 08:16:20 2003 +0000 INTEGRATION: CWS sw020 (1.44.80); FILE MERGED 2003/07/01 11:50:20 od 1.44.80.1: #110554# <SwDrawModellListener_Impl::Notify(..)> - correction: no broadcast of notifications for writer fly frames and plane <SdrObject>-objects. Change-Id: I67e6576f0670856259edee35aaf001401e67d98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28msicreator: fix hardcoded wix toolset pathThorsten Behrens
On a Windows Server, the following installation procedure has the toolset end up below the x86 program dir: * % powershell Install-WindowsFeature Net-Framework-Core * % choco install -y wixtoolset Change-Id: I5e416cd24f51ae84cb0e6ef99b8a962355fb2b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150828 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-28sw floattable, crashtesting: fix PDF export of tdf114111-3.docxMiklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). The stripped down document has 3 tables: a toplevel, a middle and an inner one. The middle one is floating. SwFrame::GetNextFlyLeaf() doesn't support nested tables, so we move an inner table frame to a next page, causing a frame to have the in-table flag, without a table frame parent, leading to a crash. Fix the problem by just disabling floating tables for nested tables for now. It can be enabled later, and not supporting inner floating tables was the intent of 8818dd359fbf0f37e1b318de89ab2ea7d735f58 (sw floattable: fix handling of nested non-floating tables at cell start, 2023-03-20) anyway. Change-Id: I75db01c6c0fdd803130fbb2a8f2f90c6180051ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151155 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-28tdf#155028 Crash in: `anonymous namespace'::lcl_PasteFlyOrDrawFormatNoel Grandin
since commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 27 10:27:46 2021 +0200 ref-count SdrObject The CloneSdrObj() call needs to return a rtl::Reference or the created object might get destroyed before we return a (now stale) pointer to it. Change-Id: I3de46b025887e6d460860b37677d2b18b90fb3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28remove dodgy code in OReadToolBoxDocumentHandlerNoel Grandin
comparing hashcodes without doing an actual comparison is not safe. Code was like this since commit 6845330a228f7b516425e2dcb0aa5f2cdfaedc85 Author: Carsten Driesner <cd@openoffice.org> Date: Wed Oct 17 09:57:37 2001 +0000 #87255# support toolbar item style and help id Change-Id: Ie49647da257e6199d9502c916da2dd3d39d52377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28optimise find/insert calls to mapsNoel Grandin
Instead of doing two lookups, we can just call insert and then update the mapped-to value if the insert actually succeeded. Change-Id: I3df3b98f0debe6bf74c739dd5850e7714d9c2789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-28Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* implsStephan Bergmann
Ever since 95823ae83c8c13c5c10c5084e2a90549ff2eb25e "#95565#add new phonetic entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" was using the same implementation as "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)". But there appears to be no evidence that those implementation names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)" are actually used anywhere (see also c9b6bf655e6de50c55629b4805399932c90a3b30 "Add some tests for (Japanese) i18n::IndexEntrySupplier behavior"). And a problem with the current setup is that instantiation those two implementation names will return implementations whose getImplementationName() does not match those implementation names (but rather returns "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by syllable)", resp.)---which is something that would create failures with an improved CppunitTest_services. Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-28tdf#86630 sw page number wizard: mirror right/leftJustin Luth
If the user puts the page numbers on the left or right side of the page, they usually want that mirrored on even and odd pages. This got rather tricky, but in the end I have enough safeguards that it seems to work logically and stablely. So I think it is ready to be submitted. Change-Id: I321e575cd9f6718579ffee99f1258bffe26581f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151152 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-04-28tdf#86630 sw page number wizard: cleanup numbering type patchJustin Luth
Much nicer to use things have have references for guaranteed items. I didn't notice the previous use of this as I was copy/pasting my patch together from various sources. Change-Id: I47f44a12fba4fc30db0597bcdcb339c062bc8b78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151149 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-28tdf#86630 sw page number wizard: only turn on current page footerJustin Luth
Without specifying the name of the page style, all in-use page styles were having the header or footer enabled. That was not the intent. Change-Id: I5eadd73cb2d7e11b6a003826b5698e22df3f13c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151133 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-04-28tdf#155034 Revert "Update libxmlsec to 1.3.0"Justin Luth
This reverts commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b. Reason for revert: compiled version fails open/create some documents on Ubuntu 20.04, which is still an Ubuntu-supported release. Also fails to compile on 20.04 with built-in system NSS The clinching reason is for running bibisects. There was no compelling reason to make the change, just routine maintenance. So if something breaks or is annoying when doing routine maintenance, then revert it. The previous version is still 1.2.37, released in Nov 2022. So this will likely come up again relatively soon if there is a security fix required. But at least at the end of the 7.6 development cycle, we can avoid the pain. Change-Id: Ife387d6e4058b017ba18cba1fbcb2b2d50f52c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151118 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-28sw layout xml dump: extract SwBodyFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about body frames. Change-Id: Ieddbf592b8e7a5597b0de91a4acffa8abe2f2868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151143 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-28tdf#155048: forward AntiAliasing to drawinglayer also in temporary caseMike Kaganski
Commit 444bf8710d5da7b584fbcb94693e4ed8d2e29297 (Update handling of AntiAliasing settings and processor2d, 2022-11-08) made respective changes so that SvtOptionsDrawinglayer::SetAntiAliasing forwards the setting to drawinglayer. However, it only happened in non-temporary case, which is fixed now. Change-Id: I66f5630dde759e3a3aa305ef38f60c8e24e6330e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151109 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-28tdf#43369: Specific UI for collecting PostgreSQL connection settingsnirnay
strings.hrc is used to add the text visible in the GUI and hence coressponding strings have been defined for postgres GUI. dsntypes.cxx since a new GUI page has been created for postgres a new page routing has been inserted instead of it going to default Since oracle jdbc and mysql jdbc have almost the same GUI the oracle jdbc was used as reference since there is no middle page between the target GUI page, unlike in mysql jdbc. dsntypes.hxx corressponding page id has been added for postgres for routing. dbadmin.cxx new default postgres port id has been added added just like MySQL and defined like all. dsitems.hxx contains the DSID used dbadmin.cxx dbwizsetup.cxx this where the GUI page is being called for generation dbwizsetup.hxx holds the title page string UIConfig_dbaccess.mk includes the new postgres page postgrespage.ui is the UI page where the GUI part has been refered from specialjdbcconnectionpage.ui and the connection string has been taken from dbwizconnectionpage.ui instead of adding a label and edit option so that connection string prefix is handled in the GUI with pre-existing curledit.cxx DBSetupConnectionPage.hxx holds the declaration of all the functions called in the coressponding cxx file. The declaration is a mix of OGeneralSpecialJDBCConnectionPageSetup class from where the GUI is being handled and since there is no test connection from postgres the test driver has not been implemented, OConnectionTabPageSetup from which commit page has been inspired and OConnectionHelper is used to handle the connectionstring just like in the original class minus the file based system implementation. DbAdminminImpl.cxx is where the data is retrevied from GUI and and pasted at the back of the connection string which is now a usual postgres connection string. dbaccess.suppr the supression has been added for gtklabel of postgres which have no corresponding entry widget. Change-Id: Id60fd02a56b10c1cb9b09c9302c6ddf170be8493 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150546 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-27Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to bb3db75014e836ce6af4573bb8576c575a620efe - update translations for master and force-fix errors using pocheck Change-Id: I84abc5c49dc5bf2d198feb58356298e6fb2d1a96
2023-04-27EMF+ tdf#103859 Optimize EmfPlusFillRects and EmfPlusDrawRectsBartosz Kosiorek
Change-Id: Iac96cf2d4291646fb69cc87c471d2f68ed905d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2023-04-27add something for fodt to pdfCaolán McNamara
Change-Id: Ia2dd8a4d5c6e558ebea6c170a0b01b5f361e1d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-27avoid config when fuzzingCaolán McNamara
Change-Id: If7778a7799db8d14c990a398166358b084da48d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151134 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-27Renumbering comments in include/svx/svddef.hxxJulien Nabet
+ some reformating Change-Id: Ic72bbe5d0c714ebbeb14db54ebd0f0ab672b66b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151035 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-270 is ok for ParaTabStopDefaultDistanceJulien Nabet
since introduction of ParaTabStopDefaultDistance cced51a1ed7c140276aabfe857510afb974fcef5 tdf#102261: introduce editeng paragraph tab stop default distance Adds mnDefaultDistance to SvxTabStopItem that if defined will set a paragraph wide tab stop default distance and override the document wide setting. Also makes editeng consider mnDefaultDistance while getting tab stop default distance. The goal is to avoid: warn:xmloff:580503:580503:xmloff/source/core/xmlerror.cxx:163: An error or a warning has occurred during XML import/export! Error-Id: 0x20040001 Flags: 2 ERROR Class: 4 API Number: 1 Parameters: 0: ParaTabStopDefaultDistance Exception-Message: at /home/julien/lo/libreoffice/svx/source/unodraw/unopool.cxx:190 Position: Public Identifier: System Identifier: Row, Column: 2,12943 To reproduce this: Open a new Writer document. Go to Form → Text Box. Draw a text box. Right mouse click on the box → Control properties. General → Border Color: Set to something like "Green" (not: Default). Save the file and close the file. Reopen the file (from https://bugs.documentfoundation.org/show_bug.cgi?id=155029 Form control: Border color of Text controls won't be saved) Change-Id: I8252b1f0c4633a1588edbdc682c6faa48f6b25cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151070 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-27Fix typoAndrea Gelmini
Change-Id: If5a1b306db1a3abd49ed9a554fbff3f5dfa72771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151130 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-27tdf#152577 sc DBData: fix regression of database rangesTünde Tóth
Regression from commit 0c0444c44107f1a18f23dd0833d462d8dbf56569 "tdf#126926 sc DBData: delete the database range". Change-Id: I04923decdc768770f98763e60cd295400d15c769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151065 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2024-12-24 16:28:04 +0000