summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-24tdf#42949 Fix IWYU warnings in xmloff/source/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iaad32419c49406a11f7cfb5856b33539d2a2894b Reviewed-on: https://gerrit.libreoffice.org/79077 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-24Use initializer list instead of iterating an array to construct the mapMike Kaganski
The map and set are made function-local statics instead of members, to only create them once (as comment says). This also fixes the problem with missing comma between "page number" and "TableNormal", which presumably had prevented all entries starting from "PageNumber" from working properly. Change-Id: Iddfefb05b1ffd00d16f189ddb5a679adf7561aa6 Reviewed-on: https://gerrit.libreoffice.org/79430 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-24getDrawPreviewOptimalSize can take an OutputDevice argCaolán McNamara
Change-Id: Ifb36166b153858ca7e32974e9b297e583b66c256 Reviewed-on: https://gerrit.libreoffice.org/79444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24should use the controller hereCaolán McNamara
Change-Id: Ic6a97c0032521bf7099ba1ef9a1ab196d50e0894 Reviewed-on: https://gerrit.libreoffice.org/79445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24now guaranteed to have a controller and not a vcl::DialogCaolán McNamara
Change-Id: Ic8ba0234d4b2e13d59d743e6f03a229756484131 Reviewed-on: https://gerrit.libreoffice.org/79442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24LogicToLogic is a static memberCaolán McNamara
Change-Id: If87f2c6d89c14a92f7222ed040696186583c73e2 Reviewed-on: https://gerrit.libreoffice.org/79443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-24compiler check for rtl::OUStringConcat instancesLuboš Luňák
Something like auto str = "string" + OUString::number( 10 ); will not be OUString but actually rtl::OUStringConcat (which gets implicitly converted to OUString, but not with auto). Since those refer to temporaries from the expression, they should not outlive the expression. Change-Id: Ib4cde4b38befb3d49927d0cf01c52ebb2d36df89 Reviewed-on: https://gerrit.libreoffice.org/78830 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-24tdf#107784: DOCX Import: Show citation's title in fieldsXisco Fauli
Regression from 06f7d1a96eef5aa69d4872ff6d96eb5085296d09 The problem is ConditionalExpandAuthIdentifier method uses AUTH_FIELD_IDENTIFIER while we want to use AUTH_FIELD_TITLE for citations, as we do in DomainMapper_Impl::SetFieldResult Change-Id: I30dcceba79dda3532ce10732e43303233d2ee441 Reviewed-on: https://gerrit.libreoffice.org/79441 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-24replace LogicToPixel uses in SfxTabPagesCaolán McNamara
Change-Id: Ic1a132113b343d7253533763df5f3371d3b672e4 Reviewed-on: https://gerrit.libreoffice.org/79446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24gtk3: Depend on the window stylecontextCorentin Noël
Make all GtkStyleContext children of the one from the current toplevel and ensures that the scale factor is the same as the parent. Also make sure to load images using the right scaling factor. Change-Id: I491d79941690fc69171e9aac950493dcca7c78f2 Reviewed-on: https://gerrit.libreoffice.org/79311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24remove SvxLineEndDefTabPage::ResizeCaolán McNamara
Change-Id: I70128f34ab1ab56ec4f99a5533606bd1d49561c8 Reviewed-on: https://gerrit.libreoffice.org/79439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24get text colour without vcl::WindowCaolán McNamara
Change-Id: Ib1a9d438de9a310cf101aeda37f36a791b86ec76 Reviewed-on: https://gerrit.libreoffice.org/79438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24approximate_char_width -> get_approximate_digit_widthCaolán McNamara
Change-Id: Ic78d4d9ec6a7604085903b347a7a06926ab8d983 Reviewed-on: https://gerrit.libreoffice.org/79437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24tdf#124600 sw AddVerticalFrameOffsets: fix bad wrap of half-intersecting frameMiklos Vajna
Commit d07fc485d46f431405a3f6a002f951a08c559677 (tdf#116486 Consider upper margin in paragraph positioning with flys, 2018-04-10) already improved the interaction between paragraph upper margin and fly frames in Word compat mode, this improves the situation further. The problem is that in case the paragraph with an upper margin intersects with a fly frame, then it makes sense to take the area of the upper margin into account (i.e. intersect the fly frame rect with the frame area, not with the smaller print area), but in case the intersection covers only the margin area and none of the print area, then the intersection is ignored by Word, so we should do the same in compat mode. [ The "intersection bottom is above the para print area top" condition can be true only in compat mode. ] In other words, the mentioned commit fixed the position of a line of text below a fly frame, this one makes sure that a long line is not wrapped into 2 lines (referred to "text is covered" in the bugreport) in Writer, to match Word's behavior. Change-Id: I4581021c3dd570fbc8a89002394a43ef18f11a67 Reviewed-on: https://gerrit.libreoffice.org/79431 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-24tdf#127652 sw_redlinehide: don't set invalid SwTextFrame offsetsMichael Stahl
The obvious problem here is that if a deletion spans multiple text frames, the offset of the 2nd one must not be reduced lower than the start position of the deletion; apparently this fixes the subsequent crashes with stale text portions having now invalid indexes into the string. (regression from 0acde7514e666fc04805fd36503bd174162336ca) Change-Id: Iaf9e2c5ca06ed36dc0e8611891d19c22f7661d34 Reviewed-on: https://gerrit.libreoffice.org/79421 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-24enable/disable page toplevel containerCaolán McNamara
instead of the vcl TabPage that contains it Change-Id: I1d1da894afce4cf6d8fc109a77fd809e993de454 Reviewed-on: https://gerrit.libreoffice.org/79424 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24options dialog has a controller nowCaolán McNamara
Change-Id: I34b486ba54c361401327dbe8fcee007da4ca72c1 Reviewed-on: https://gerrit.libreoffice.org/79426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24unused aControlSize variableCaolán McNamara
Change-Id: I59b8bb107ac40c15a027426ece916d0b6713407b Reviewed-on: https://gerrit.libreoffice.org/79425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24tdf#104167 DOCX import: don't map Heading1 to Heading 1 para styleMiklos Vajna
This is nominally a regression from commit c12a78e42e1cbaaf4ea021c82acbec5ea177b1f6 (writerfilter: reset properties of reused styles, 2014-06-04), which assumed that style names are unique. They are not unique for the bugdoc, as it has paragraph styles named 'heading 1' and 'Heading1', both mapped to 'Heading 1'. The mapping for the style name without a space was added in commit 1d2af74e226bf44e1a0f1e1981ca965cffeaa0b2 (INTEGRATION: CWS xmlfilter02 (1.27.12); FILE MERGED, 2008-01-10), in the "2007/11/22 14:53:43 os 1.27.12.9: Tab stops almost perfect now" part, sadly without any indication on why that would be a good idea. The binary DOC import never mapped Heading1 to Heading 1, so it doesn't have this problem. Fix the problem by removing this mapping, it leads to formatting loss when a document has both HeadingN and Heading N styles. Change-Id: I26dd999f5a536e079ac351ba5d40d20c83b99310 Reviewed-on: https://gerrit.libreoffice.org/79422 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-23tdf#127499 added 9 new line styles all are (var) and in line with MSOandreas kainz
Change-Id: I0144e7279f80aaf308595ff2c802e9d756fa80fd Reviewed-on: https://gerrit.libreoffice.org/78960 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-09-23Resolves: tdf#127683 options dialog has a controller nowCaolán McNamara
Change-Id: I1143bb27f524960e44aa2cdb76f063a9b93d42be Reviewed-on: https://gerrit.libreoffice.org/79415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23config dialog uses a controller nowCaolán McNamara
Change-Id: I0341b0b51d638b5ea8f28d16dca87d50376873a4 Reviewed-on: https://gerrit.libreoffice.org/79417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23replace LogicToPixel uses in SfxTabPagesCaolán McNamara
Change-Id: I4022c8ac71f2bdfc77c8920568b8242431391623 Reviewed-on: https://gerrit.libreoffice.org/79418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23TODO is done, so drop SetSizePixel callCaolán McNamara
Change-Id: Iceb5b3147e48359dea4d22f0fcce9cf2319fbc0d Reviewed-on: https://gerrit.libreoffice.org/79416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23loplugin:fragiledestructor (macOS)Stephan Bergmann
Change-Id: I85542ed9e631ad8589d3bc3469d171ab1d5cb4f9 Reviewed-on: https://gerrit.libreoffice.org/79396 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23Resolves: tdf#127682 out_of_range thrown on print empty calc docCaolán McNamara
when odd/even pages requested and print is cancelled the abort procedure will ask for page 0 to be rendered on cancel, which doesn't exist since the odd/even support. Let the print of an empty page to ahead in the abort scenario Change-Id: Id8dfde57fca891ba3eb220cf6e495585abf4c918 Reviewed-on: https://gerrit.libreoffice.org/79413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23config dialog uses a controller nowCaolán McNamara
Change-Id: I3751a2c08c88638a9843da658b829abf1ffef14c Reviewed-on: https://gerrit.libreoffice.org/79408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23IsGroupObject == true doesn't mean its a SdrObjGroupCaolán McNamara
but that it has a SubList Change-Id: I473464de5c6bba5c36be1ad7cbd21a3158645d66 Reviewed-on: https://gerrit.libreoffice.org/79411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23drop strange use of Help::ShowBalloonCaolán McNamara
Change-Id: I90406d02d31f1e89e31a5c9d938d42eeb112ee25 Reviewed-on: https://gerrit.libreoffice.org/79407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23set correct parentCaolán McNamara
Change-Id: I1fc03238a68bcc42e0e43f3305baeb4407791eca Reviewed-on: https://gerrit.libreoffice.org/79409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23replace LogicToPixel uses in SfxTabPagesCaolán McNamara
Change-Id: Ic2ea87bd5bcb8ccee58818b638e70a561fc8f95b Reviewed-on: https://gerrit.libreoffice.org/79410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23SVGIO: Fix conditions after ab147995Xisco Fauli
Thanks to Michael Stahl Change-Id: I708dd87e82138a59afe311c9397f2c9e0fd4c274 Reviewed-on: https://gerrit.libreoffice.org/79404 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-23Improve SwRect (debug) printingStephan Bergmann
e.g. SwVisibleCursor::SetPosAndShow in sw/source/core/crsr/viscrs.cxx has legitimate calls to SSize() and Pos() of an SwRect for which IsEmpty() is true, so don't hide those values by just printing "EMPTY" Change-Id: I8240ed1cf8cbd2bca9caf599192250f0292eaeba Reviewed-on: https://gerrit.libreoffice.org/79403 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23tdf#127393 OOXML chart import: fix X axis position setting "CrossBetween"Balazs Varga
Set ShiftedCategoryPosition according to OOXML value CrossBetween. Change-Id: I6445c94507de83f84b08fd3380cbbf03886b5aa3 Reviewed-on: https://gerrit.libreoffice.org/79142 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-23UnoBaseClass: remove remaining leftover SwClient bitsBjoern Michaelsen
Change-Id: Ic7bc826b2d08701eaf4914fd4d5e019fd407cfb8 Reviewed-on: https://gerrit.libreoffice.org/79390 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-23tdf#39593 use getUnoTunnelImplementationArkadiy Illarionov
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd Reviewed-on: https://gerrit.libreoffice.org/79350 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-23tdf#124377: enable anti-aliasing metafile during redactionAron Budea
Change-Id: I6c8a0f6ceaad5d9ec47cce1b00b8ccdd77530aaf Reviewed-on: https://gerrit.libreoffice.org/79266 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-09-23loplugin:fragiledestructor (macOS)Stephan Bergmann
Change-Id: I908a7dbdb44c0b49315f0fd8559c21302dbc83a8 Reviewed-on: https://gerrit.libreoffice.org/79399 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23toggle default away from legacyCaolán McNamara
Change-Id: If89fec63d91f4d3df38a365a606036517e6b1c37 Reviewed-on: https://gerrit.libreoffice.org/79392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23missing treeview modelCaolán McNamara
Change-Id: Id1a405bb8f5c3d71b48c54e12b1e8ba23a27d842 Reviewed-on: https://gerrit.libreoffice.org/79391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23set wait on the correct parentCaolán McNamara
Change-Id: I0c0f4eb036713d12766fb425d5d563f6b2fc054e Reviewed-on: https://gerrit.libreoffice.org/79379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23loplugin:fragiledestructor (macOS)Stephan Bergmann
Change-Id: I8ac1f67999ccbb6c411359ac6fd4c473dc339d44 Reviewed-on: https://gerrit.libreoffice.org/79398 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-23ofz#17613 fix buildCaolán McNamara
Change-Id: Ie8463af051b46dcd24b1642c583cc48f4359beea Reviewed-on: https://gerrit.libreoffice.org/79395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23the PCH timestamp is actually LinkTarget's, not PCH'sLuboš Luňák
Because the timestamp says that the LinkTarget's PCH dependencies are ready. Change-Id: I5c9b965bf6d5a62b16972d5b0ea84a97f771e14f Reviewed-on: https://gerrit.libreoffice.org/79361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23remove unused gbuild codeLuboš Luňák
gb_CxxObject__set_pchflags just sets a variable, which is not used here. It should have been removed in 66a0713dc9c676182fcd7aa1e21f8dc25c05be5e, but even back then the removed function didn't depend on it, so this should have been removed even sooner. Change-Id: I629d6337d0aa4066bd3141b22aed84dfeeac5b7f Reviewed-on: https://gerrit.libreoffice.org/79315 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23Let's not bother looking for quite old iOS SDKsTor Lillqvist
Change-Id: I449d5fe425d741ca3b4a3be84e7e2bc015e90e32
2019-09-23iOS SDK 13.0 is the current versionTor Lillqvist
Change-Id: Icd8455ce122530e69f01b8345cbd02925305429f
2019-09-23This if branch is for macOS, not iOSTor Lillqvist
Change-Id: I4a502d4247bf86fd2bc5734a64e600ae0e214f21
2019-09-23The which ranges are inclusiveMike Kaganski
Change-Id: I3d2d8c08c7abacf7ae4c20b2760efe233eddd4ee Reviewed-on: https://gerrit.libreoffice.org/79393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-06 01:35:16 +0000