summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-10-14Remove unused comphelper::string::reverseString overloadStephan Bergmann
Change-Id: Ic1c56c7be9804685fd37b8f6a13aaab039e07afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141361 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-14Fix loplugin:stringconcatautoStephan Bergmann
...after af2879e434fa0dc6b2a626617ed865e4f66eb5ad "Deduplicate stringconcat more" changed the *StringNumberBase::toAsciiUperCase return typr from O[U]StringNumber to the underlying StringNumberBase. (And where that commit had added some odd check for a non-existing "StringNumber" type to compilerplugins/clang/stringconcatauto.cxx, presumably in error.) Change-Id: I622e6ae30fcec8f081c978eaf67ffb716a10ee4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141363 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-14add missing dependency for gbuild-to-jsonChristian Lohmaier
while most of the integration targets are meant to have a nice debugging environment, others like the vim-ide-integration or also the vscode one seek to provide a nice editing experience with code completion and code lookup. Ideally you'd be able to have the integration available immediately and can use the editor while a build is running in the background. But from a fresh builddir make vim-ide-integration (vscode-ide-integration) fails because of the missing dependency. That dependency probably is optional for the purpose of just providing a editing environment as opposed to providing build-targets like the integration does for some of the other IDEs, so I consider this commit more of a "good enough" workaround for the time being. Change-Id: I586445fed849d416fde9804a1e2a9c6ee0ed50eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141248 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-10-14tdf#150682 Change shortcut of inserting Math objects to Alt+Shift+EAron Budea
Ctrl+Alt combinations don't work on Windows if they're also doubling as AltGr modifiers, eg. in French keyboard layout, Ctrl+Alt+'=' (which is the same as AltGr+'=' ) is '}'. Avoid this by switching to different modifiers. In addition '=' can require a modifier to enter, eg. in German layout (Shift+0), so use an ASCII character, 'E' instead. Ctrl+Shift+E is listed as a problematic combination in Accelerators.xcu, settled on Alt+Shift+E in the end. Also partially revert d156e891db34e88991a6c18fd3cff6feddfc61c8, which did not work. Change-Id: Ie3625f2c55171187fbbe2c4f79821eba8c25f40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141227 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-10-14tdf#143148: Use pragma once instead of include guardsEmmanuel Peter
Change-Id: Idf9f5b604bc60d7f1bacdd0001ce252aaeb7835a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141334 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-10-14Merge makefiles of Writer and Draw templatesLaurent BP
Simplify the list of files in the same way as for wizard templates Change-Id: If93374de161b670a96b9d2447f03f29d8c085efa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141274 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-10-14Improve makefile of Impress templatesLaurent BP
Simplify the list of files in the same way as for wizard templates Change-Id: I38258dd0d06940acbf47e6cffbb76924e7d5466e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137364 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-10-14tdf#143148 Use pragma once instead of include guards in the header fileCalvince Otieno
Change-Id: I6566cfb722bbe2779e9a5b32fa83f17353457dc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141351 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-10-14tdf#151503 - Do not evaluate a missing optional variable to a booleanAndreas Heinisch
Change-Id: I671f857344f91de63612eabcbbdb2cab9b94cc0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141296 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-10-14Resolves: tdf#151468 honour tiff resolution fieldsCaolán McNamara
Change-Id: I57d996f49c6ae7e60991ff53eae867144b56d89d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-14ofz#52337 Direct-leakCaolán McNamara
cairo starts leaking things when a surface is in an error state Change-Id: I0be0d9f8e3c8938073cec1aa765ab82826ceb6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-14sw vba: add WordBasic.ScreenUpdatingJustin Luth
Change-Id: I3d074c224b77eff9f4ab1ea6bade6d66828fc88c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141273 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-14sw vba: add doxygen comment for class SwWordBasicJustin Luth
Change-Id: I8b12845341e8754c0882411c19a57b7a46e05e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141290 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-14WASM add Calc as optional build result, make it build & runBalazs Varga
Adding new config option: --with-main-module=<writer/calc> With this switcher we can build only WASM writer module or calc module. The default value is 'writer'. This commit also reverts: 26603bc9ef0116ed31c510dab82b69d3666447b5 (WASM fix orcus native exception handling (NEH)) Because Calc import is using liborcus for loading styles.xml. Change-Id: I4c330ef8eea7d08214bf357531ee0bf7383ab788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137946 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2022-10-14ScriptForge - (Dialogs) tdf#151510 fix CreateScriptService("dialog")Jean-Pierre Ledure
Bug description: Programmatic access to doc-based dialog is not possible using ScriptForge.Dialog service The relevant component was identified incorrectly in routine SFDialogs.SF_Register_NewDialog() Change-Id: I13f6302330ca097b8aef8fd3cdbd0b3d05a1b58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141337 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2022-10-14CppunitTest_sw_mailmerge2: use more SwParaPortion::dumpAsXml()Miklos Vajna
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1 (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing, 2022-04-07) for motivation. Change-Id: Iebce134a84b022f45548eb97af4325208e5a2235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141342 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-14vcl: followup 'vcl: extract function CreateAnimationDataItems'Chris Sherlock
Change-Id: I25d2057477dae952e2ded966cf2f7feedf6d90f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141341 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-14tdf#143148 Use pragma once instead of include guardsRakielle
used pragma in 3 files Change-Id: Ia8a67501388bb5f79485494fd2aa77a8e45d710f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141352 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-10-14Fix typo in codeAndrea Gelmini
Change-Id: If4cf1a77490650902d77705761b5168bdf5cece8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-14Start to fix the "BASIC Macros" dialog's "Assign..." buttonStephan Bergmann
c79212479f42cadd39173e77acc5e6446480ff05 "Fix a misuse of two-argument std string_view rfind" found that e.g. in Writer "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My Macros - Standard - Module1" and in "Existing Macros in: Module 1" select "Main", then "Assign..." had apparently rotten over time and brought up the "Customize" dialog's default "Menus" tab. With this fix, it now brings up the "Customize" dialog's "Keyboard" tab, in the "Category" tree list selects the appropriate "Module1" line, and in the "Function" list shows all the corresponding functions (just "Main" in this case). It doesn't yet select the appropriate line ("Main") in the "Function" list, though. That apparently needs further fixing. Change-Id: Ia5b9ef88d29e01f4f5e22ce3aec20f5fc22b5d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-14This can be constMike Kaganski
Change-Id: I5e0cb22c9276e41b0a42978a253456ebd9ebefa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141356 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-14CppunitTest_sc_shapetest: use member XComponentXisco Fauli
Change-Id: If881b238991cfce8d866edd662fb6eb70c8f29a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141336 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#150473 Wrap text and set min size for Function descriptionRafael Lima
This patch does the following changes to the Functions sidebar in Calc: 1) The function description now uses a TextView instead of a Label so that the text can now wrap. This is important because many descriptions are long and require more than a single line of text. 2) The minimum size of the description TextView is set to 6 lines of text. Because there's no easy way to set this minimum size (since it is inside a Slider control), then the following rule was applied. - If the user resizes the slider to less than 6 rows (in this case, moves it down), the next time a new function is clicked the slider is positioned so that 6 lines of text become visible. - Moving the slider up, thus giving more space to the description view is still allowed as prior to this patch. Change-Id: I52dfa8bef52b645fdce379408e6b790f6e8e5dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140507 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-10-13Change split regexp from \~ to ~Eike Rathke
gawk: ./list-dateacceptancepattern.awk:70: warning: regexp escape sequence `\~' is not a known regexp operator Also set the executable bit again.. Change-Id: Icdf45979d6fb19d207dcf5475845767438c3ef6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141340 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-13sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversedKevin Suo
For the simple Arabic string: ٱلسَّلَامُ عَلَيْك, the xpdfimport binary generates the follwing (drawchar) sequences: كَ يْ لَ عَ مُ ا لَ سَّ ل ٱ (i.e., in reversed order, one character by one character). Before this patch, after pdfimport the text shows up as لَسَّلٱ كَيْلَعَ مُا, which is reversed. It was surposed to combine these characters into text frames in DrawXmlOptimizer::optimizeTextElements(Element& rParent) (sdext/source/pdfimport/\ tree/drawtreevisiting.cxx:677), but actually it was not combined successfully there. The single characters were then passed to sdext/source/pdfimport/tree/drawtreevisiting\ .cxx:105, one by one, in the hope that the strings could be mirrored. The mirroring failed, because one single character, even after mirroring, always equals itself. The DrawXmlOptimizer::optimizeTextElements failed to combine the characters into one text frame, because the condition: (rCurGC.Transformation == rNextGC.Transformation || notTransformed(rNextGC)) would never be true, as at least its horizontal position is different. A further analysis indicates that we do not need to check the transformation here at all, as this is an optimizer for a TextElement and in case a character is transformed then it would already be in a different draw element (thus will never be combined with this TextElement). After the fix of DrawXmlOptimizer::optimizeTextElements which now successfully combines the characters, there is another issue in the old PDFIProcessor::mirrorString function. It seems to mirror the characters within a word, but if a string contains two words, then the two words are not successfully switched (e.g. for string "abc def" it produces "cba fed" rather than "fed cba"), which is not suitable for the case of RTL which requires all the characters been reversed. Fix this by using comphelper::string::reverseString. Change-Id: Ifa210836f1d6666dd56205ff0d243adfb4114794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141231 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-10-13tdf#47979 sw: test row & column selection with mouseLászló Németh
Commit 0140fd6501c2322cffddaaa14b49137009ffcae4 "tdf#151478 sw: fix row/column selection at nested table" fixed also selection with mouse, not only selection with Table->Select->Row and Table->Select->Column. Add unit tests for fixed row and column selections using code path of mouse clicks. Change-Id: I96c56a65e908a56fcaf43b8cfc2adbc091c65fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141297 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-13Remove duplicated includeAndrea Gelmini
Change-Id: I481d3dca7fe2fd60093ad77636edb8df836da1d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141262 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-10-13tdf#151352 crash closing form while TOTD dialog is displayedNoel Grandin
regression from commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat May 29 08:34:28 2021 +0200 IsDisposed->isDisposed in vcl/../window Change-Id: I51889f2451f03797f5b89019e6df32a64acda707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-13Drop now-redundant %selectStephan Bergmann
...after 3d236177be255b2027a997bfc12fe0833ca9a2f7 "Deduplicate O(U)StringConcatenation" Change-Id: Ib45d021da2bb5745055fa0cdebfd700680bfb787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141304 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-13Fix typoAndrea Gelmini
Change-Id: I4bfa53602b34d18ae9229aa8e110b85dfd160f94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141307 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: If62e035cf92f5fad359da9dd426f0975b1da6b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141308 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: I4171730123186c8b057e6a05e382f253f81a0013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141310 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ia4d7dd731e24c89c3228fdaf18cc0558a9c5ee66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141311 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ie04728548d82e6eb5b0d46e65c279dcda5442bf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141309 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Iff1adef6278239436bbaabd619ed12648d0819df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141305 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13Fix typoAndrea Gelmini
Change-Id: Ib12fdce5b4a46ec98828aeba6a293ca3a3e1c766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141312 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13CppunitTest_sc_macros_test: improve setup/teardownXisco Fauli
Similar to 8b4ac8c35d5e4efe3c0b83e15543a35213e786f2 "improve setup/teardown handling in VBAMacrosTest" Change-Id: I34b64a72f6cab1f85e6e2628b6fd07f408f62cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141302 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#124098: sc, ods import: do not recalculate row heightsBalazs Varga
if we have already optimal heights in the xml, because it is not necessary and it takes a lot of time loading a file. Citing here for completeness: a) if there is no height attribute and the "use_optimal-row-height" attribute is set then calculate the row height b) if there is a height attribute just use it and do not recalculate. Maybe TODO for later: optimize row height calculation more in sc Change-Id: I9d964aad744970e5d36f239c0ce39ce98c00f273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141204 Tested-by: Jenkins Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2022-10-13tdf#151417: sd_uiimpress: Add unittestXisco Fauli
Change-Id: I8f5f957557612ce78036d962968a3e9fef113cf8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141291 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#120326: properly prevent Windows from entering power savingMike Kaganski
The previous call to SystemParametersInfoW with SPI_SETSCREENSAVEACTIVE only prevented screen saver from running (which is not often used these days), but screen was still turned off (and power saving was started). Despite SetThreadExecutionState documentation [1] claims that it does not stop the screen saver from executing, my experiments show that it does (on my Windows 10). So just use it, because it is designed exactly for this task (documentation discusses the presentation applications). [1] https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-setthreadexecutionstate Change-Id: I6eced8f0a7c17211a0b68851a40227eed9a22b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141289 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-13crashtesting: uncaught exception on export of forum-fr-20226.sxi to pptxCaolán McNamara
due to not-found wav file linked to from presentation Change-Id: I48c7b4615d660a2a292feea36e228237235ab04f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#143123 port DocumentHandling examples to PythonChenxiong Qi
This port keeps the similarity with Java ones as much as possible. examples.html is also updated by adding the Python examples. Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: I2af26aaf42f5408bf254a4e0507442200f843661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139887 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-10-13Adapt CompilerTest_compilerplugins_clang to recent ClangStephan Bergmann
...where at least my recent Clang 16 trunk build now started to fail after af2879e434fa0dc6b2a626617ed865e4f66eb5ad "Deduplicate stringconcat more" with > error: 'error' diagnostics expected but not seen: > File compilerplugins/clang/test/stringview.cxx Line 171 (directive at compilerplugins/clang/test/stringview.cxx:170): instead of an '{{(rtl::)?}}OString' constructed from a 'OStringConcat<rtl::OString, rtl::OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview] > File compilerplugins/clang/test/stringview.cxx Line 196 (directive at compilerplugins/clang/test/stringview.cxx:195): instead of an '{{(rtl::)?}}OUString' constructed from a 'OUStringConcat<rtl::OUString, rtl::OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview] > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/stringview.cxx Line 171: instead of an 'OString' constructed from a 'OStringConcat<OString, OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview] > File compilerplugins/clang/test/stringview.cxx Line 196: instead of an 'OUString' constructed from a 'OUStringConcat<OUString, OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview] > 4 errors generated. > make[1]: *** [solenv/gbuild/LinkTarget.mk:337: workdir/CxxObject/compilerplugins/clang/test/stringview.o] Error 1 Change-Id: I0b8c7d4a012c40c2c2c3cc8a9e55c52f45e8cfc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-13sw: improve duplicated bookmarks in copied header/footer textMiklos Vajna
Bookmarks in copied text were renamed in a way that made it hard to differentiate between the original bookmark and the copy, e.g. "Bookmark 1" was renamed to "Bookmark 11". Bookmarks are supposed to have a unique name, so renaming makes sense, and it's probably better to do that compared to what commit 3ec224dcb15e0e663ba85077b8ea0e632f8f03f8 (DOCX import: avoid duplicated bookmarks in copied header/footer text, 2022-09-08) did to just omit them during copy. That solved the duplicated bookmarks, but if one had bookmarks around images to find them, now it doesn't work to find all such images. Fix the problem by going back to copying bookmarks, but copy "Bookmark 1" as "Bookmark 1 Copy 1" (and "Bookmark 1 Copy 2", etc), so API users can identify the original and the copied bookmarks. A similar problem is there for images as well, but that's not yet addressed here. Change-Id: Ic0689b05f790a99ff06523ff4836b1dd412af896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141293 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-10-13tdf#150664 Initialize input line correctlySamuel Mehrbrodt
Initialize code was not called when xlsx file was loaded (line count is only stored in ods format). Change-Id: I5b01f6079921af77ffd6da09ae5d5388b8beff1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141281 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-10-13tdf#150622 use high contrast selection fg/bg colors for text selectionCaolán McNamara
with SettingsForSelection SettingsText -> HighlightTextColor SettingsFill -> HighlightColor SettingsLine -> HighlightColor Change-Id: Iaac5834ce0f8b3f1b89376711b564773cfd0bfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13use OutputDevice clipping if its just a set of rectanglesCaolán McNamara
Change-Id: I249866d1aef29d256439c0437835a173d8a4c633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141286 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#145871: sw_odfexport2: Add unittestXisco Fauli
Change-Id: Ic473fa92b37ea1024ed5021ed6b59079d455c87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141285 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-13tdf#125363, tdf#123095 - Use CaseTransliteration for autofilterAndreas Heinisch
Change-Id: Ib6f1edebe26a69d3316a901e00d2bc6e0c66695f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141047 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-10-13tdf#151375: sw_odfimport: Add unittestXisco Fauli
Change-Id: I702059fcfc8e99b11412f959bc924af73780d351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141284 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-24 15:06:24 +0000