summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-12-19cid#1607671 Data race conditionCaolán McNamara
Change-Id: Id2e87001b77087a072705ba7ffa1a2190220a082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 18399240f2aa976041db1928b1ae9db1a0ad706d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178562 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19tdf#164213: don't activate OLE objects in read-only modeMike Kaganski
Similar to the check done in SwEditWin::MouseButtonDown. Change-Id: I1a1b8966502a6b1557d424f28cfc1c1ecdf4b65e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5950fe86b84bb062e88034e382fc5df90bb1e98c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178565 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19tdf#163395 tdf#153057 - sc fix standard filter problem with formattedBalazs Varga
values ScQueryEntry::ByValue was removed unnecessarily in the original patch, but it is necessary for filtering number values correctly. Regression from commit: 1f755525189884e4b2824889a6b9dea8933402db Change-Id: Ib013d971ad0b0809fc55949a6a2d9bf02418b516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178690 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178738
2024-12-19tdf#157476 tdf#150861 - sc fix autoFilter is filtering incorrectlyBalazs Varga
caused by rounding problem with duplicated values. We need to store the rounded values, based on the numberformat precision, otherwise later can cause problems at removing the duplicated values. Regression from: f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d Change-Id: I19f5248122ffca1e52adb96714df79dd9c64b23c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178683 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178737
2024-12-19CppunitTest_sw_apitests: remove leftover myNewGroup2.bau before the testMiklos Vajna
This fails for me in a tree that runs 'make check' and there was a previous 'make check' previously. Seems the trouble is that we have this C++ test creating an autotext .bau file, but there is also a Java one, so if we're not lucky with the order of these, the C++ one will fail with its hardcoded "must be 3 .bau files in instdir" assertion. Fix the immediate problem by removing the test .bau file before running the C++ test. A better, but more complex fix would be to create the test .bau file in the user profile (and not in instdir) for both the Java and C++ cases, and then none of these tests would influece other tests during 'make check'. Change-Id: I536d769db733515ec6a7d41fd7dbf601c4b582d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178548 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178576 (cherry picked from commit 703cbc0bb75b0943cf5b95ff62c6fe4b4a028788) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178589 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-12-19ReqIF: avoid 'target' attribute in 'a' elementsMike Kaganski
Change-Id: Iab34a18e2da766d30a2d6b5f5d8ed3855f3c8b8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178207 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 46ce77dfffaa6445ed05e1400284f4f9491b9faf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178556 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19tdf#164359 editeng RTF export: track unused parent styles recursivelyMiklos Vajna
Start edit mode for the shape in the document, double-click on a word which has a "level 2" bullet associated with it -> crash. This is a regression from c8b607b7c0096c58dc5187262bf0133dee728d50 (tdf#163883 editeng RTF export: fix broken offsets into the para style table, 2024-11-19), the direct cause is that ImpEditEngine::WriteRTF() maps all style pointers to a style ID and once we write the parent property in the style table, we unconditionally dereference our search result, because we know all styles should be in that map. The root of the problem seems to be that once parent styles are marked as used for the "only write used styles for the clipboard" case, those parents themselves can have parents, and we didn't mark those as used. Combined with the unconditional dereference, this leads to a crash. Fix this by walking up the parent chain till we get no parent. This assumes that importers create a valid document model, so there can't be loops while walking the parent chain. If that would be a problem in practice, we could check for that in the future. Change-Id: I4b416e78f26bf455040d95ee8ed220cfe870e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178703 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit a7a81b6fbe37af938ce461e790fac517be032317) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178718 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19crashtesting: unknown 'IsContentEmpty' property reloading rtf exportCaolán McNamara
of forum-mso-en4-218597.doc where the XText is a TextFrame, presumably a problem since: commit cfd3b14fd4e1ee889dd356523e5cdaa639786d37 CommitDate: Fri Aug 2 10:37:31 2024 +0200 tdf#162295 DOCX import: optimize the check if the header/footer is empty Change-Id: I14e851aea66ad66024e9a8e38b1d1cdef0bf570c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 88f0e9a245f4a52ea45a25274a075b48fae7ef9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178785 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19tdf#113015 Improve update descriptionBogdan Buzea
Change-Id: If5ba0ee65483ebe27e71522b25c34daf04751991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178534 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit 85212289dc3bcee17d2fac1d205b33f61bcdae74) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178749
2024-12-18tdf#163634 Format empty paragraph if they have a bullet/numberingOliver Specht
Some optimization in commit 52abeff6d5836b29dbefe69f284bbd89f6672ae2 ignores paragph attributes if the paragraph is empty. But it is not empty if it has an active list. Change-Id: I8885d0f201fc48279263a3d41ec6d660b534ded2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178311 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit fdb13df0cb759e65e48bb65b1513e8add429d4d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178553 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-12-18tdf#164353 tdf#130857 qt weld: Keep extra msg dialog widget in placeMichael Weghorn
Both, QMessageBox::setText, and QMessageBox::setInformativeText call QMessageBoxPrivate::setupLayout [1], and that one deletes the QMessageBox's previous layout, creates a new QGridLayout and sets that as the dialog's new layout. As a consequence, adding the widget that can hold extra controls to the dialog's layout only once by calling QtInstanceMessageDialog::addWidgetForExtraItems from the QtInstanceMessageDialog ctor isn't sufficient, but needs to be repeated each time the dialog layout may have changed. (Otherwise the widget is not contained in the layout, and "randomly" placed in the dialog, so it can e.g. overlap other UI elements in the dialog, see tdf#164353). Therefore, rework QtInstanceMessageDialog::addWidgetForExtraItems a bit, rename it to QtInstanceMessageDialog::positionExtraControlsContainer and call it also after updating texts. [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/dialogs/qmessagebox.cpp#n290 Change-Id: Ib17b5867393a0694701c56b0ab74165021a8bc51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178726 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit ffbe93aa93c0300dd4ff5f4d55dfb33e4c7a394d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178740
2024-12-18Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-25-2' to d0a91e3525fdedbc4d0af45ea7e261052bbbe281 - update translations for 25-2 and force-fix errors using pocheck Change-Id: I2af3d7d86339cf5588b28eb64593387454ff3508
2024-12-18tdf#163620 [API CHANGE] Add UI for libreoffice themesSahil Gautam
Instead of Color, we have Light and Dark in the registry. So each theme extension will specify dark and light color values for each "customizable element" like DocColor etc. Under appearance we have three radio buttons - light/dark/system. If system is selected then light/dark colors are switched based on the system's theme. if explicitly light/dark is selected - that color is used from the registry. ColorConfigValue now has three entries nColor, nLightColor, nDarkColor. nColor is used as a cache for the color being used at the moment. This is to avoid otherwise expensive function calls + hundreds of modifications in the codebase just to change nColor. nColor is cached either when the theme is loaded or when changes are committed in `ColorConfig_Impl::ImplCommit()`. Now, if Automatic theme is selected then themes is disabled and the application uses the system colors. If some other scheme is selected like "CustomTheme" etc, then LibreOffice themes/UI color customization is enabled and the theme colors are used. Instead of a scroll window, now we have a combobox for the registry entries and a single color dropdown to select the color value. This color dropdown is for convinience in case the user wants to change some specific color that's bothering him. For themeing, theme extensions should be used. API CHANGE + remove Color in favour of Light and Dark + AppBackground has additional two - BackgroundType and Bitmap + remove officecfg::Office::Common::Misc::Appearnce in favor of officecfg::Office::Common::Appearance::ApplicationAppearance + move LibreofficeTheme under officecfg::Office::Common::Appearance UI + it looks like https://i.imgur.com/UMxjfuC.png which is a little different from how the [mockup] on the ticket describes it, and that's because of lack of time due to upcomming feature freeze. + system/light/dark allow the user to switch between light/dark modes based on either the system theme (system) or by manually specifying light/dark. + ui themeing and color customization is disabled when automatic theme is selected, and enabled otherwise. [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469 Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit ddeeca35d9630f2d3d3afb83a2ec8f21458f6e19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178729
2024-12-18tdf#163620 [API CHANGE] remove persona/appearance-toggle related codeSahil Gautam
- remove ui and source files related to app colors and personalization tabs - remove persona entries from registry - remove functions related to persona settings from StyleSettings, vcl.. - remove ui and code related to tools - options - view - appearance combo box Change-Id: I98f0c38dc1facddd0e8dd03197c61a92287fdbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176836 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit c4962247e40b5e6750c522d43359d9436dcfec68) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178728
2024-12-18Update git submodulesBogdan Buzea
* Update helpcontent2 from branch 'libreoffice-25-2' to ae02c3ab71c924e57a32166f57fdfaf89bace1f0 - tdf#124954 Improve Help about cache spreedsheet formula Change-Id: If9fdd7fa699afd9735b98fb42def1c1700556591 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178535 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 6c4a6bbc4f688feeabeb307c0dea1ef0c8f2baab) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178716
2024-12-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to e7c95257e8a6c32fd460a11042d5cd5e38e27d1c - Typo Change-Id: I9ffdecb64a9a6adec25e6516615b65ea79e1e788 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178684 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 7001361d995b74c7ea2bb334e442797e57feaea7) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178699
2024-12-18Resolves tdf#140298 - SQL dialog must not become oversizedHeiko Tietze
SQL history becomes quickly too large for the dropdown control The patch sets a fixed width so this control wont take over the dialog size. Change-Id: I106ae19dfd505388e5b528becbc06e9d6110d45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178702 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins (cherry picked from commit 872945ecec6cabac691b036676d3dfe81f240948) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178719
2024-12-18Update git submodulesRobert Muir
* Update dictionaries from branch 'libreoffice-25-2' to edb2228a1d8caf12d3daf93aae7cf1dd4284ec42 - tdf#164366: fix wrong REP count in mongolian .aff file Commit d169602 broke parsing of this file by the lucene hunspell support, because now a `REP 3619` is followed by 3621 REP rules. Fix the count to be correct. Change-Id: I2c971dec7c44793e3d5b7a4030940014ddbebbb4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178710 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c3ff53711dcac4bdec24f23a2c1f9712a0833b67) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178711
2024-12-18Resolves: tdf#156398 use same color combination as used in tdf#51300Caolán McNamara
so we don't get white text on yellow background Change-Id: I346decaab293e2bb15c1110dfa61df5838607d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178695 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to 390cd867023cd8b4b76c66db1e4e5419ecd77498 - Typos Change-Id: I19aac6bc535a8ca337fe11247cb2823db64eb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178692 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 46b1c476e1b92773ea63f3e74460acb1cf5792a5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178698 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-12-18Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-25-2' to 4283c1d2e204566bb987351fc7b901f2eb058c0f - update translations for master/25-2 and force-fix errors using pocheck Change-Id: Ie775663b93d82f8392fa6317099ad158661dbdc7 (cherry picked from commit 86672eb8932b6779dd5b6d036c083662d4bcd15f)
2024-12-17tdf#132274 Clarify wording of default Writer zoom behaviourThorsten Behrens
There was apparently some confusion what 'latest setting' was referring to (in fact, it's the latest setting that was stored in the document, for most cases). Change-Id: I30d36567cde602ba18b0b721dec0c9e76b560edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178660 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 896e87937fe6985d2f8f47b6c28a78703eeb85c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178678 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-12-17gtk4: GtkIconView doesn't have convert_widget_to_bin_window_coordsCaolán McNamara
but still has the same problem as the gtk3 iconview with reporting positions when scrolled a problem since: commit a36a58933a1e07d3f54bacd5c2fe8ca53063a63a CommitDate: Wed Dec 4 07:40:30 2024 +0100 sd: convert sidebar masterpage panels from drawingview to iconview Change-Id: Ice549b40d88c5d2063e37ccb63490e3537736d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 55e77a48fbafd47036d7bd3ba11579c5f15f2359) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178566
2024-12-17crashtesting: unable to import rtf export of forum-mso-en-14843.docCaolán McNamara
user field names have control chars in them and import from rtf hits the code added by: commit a6516c76c01b92f7d35bfb352b63af7de42b5707 CommitDate: Wed Oct 30 14:44:09 2019 +0100 writerfilter: rtftok: filter control characters so control chars are stripped out, which results in a duplicate user field name which throws. Filtering out at doc import time seems to work better, so lets do that as well. Change-Id: I463e30b223bfb5639de23c696d112eda2c27b428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178657 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 7c2d94c6b41a71e0440953d753f6a7092626bc9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178671
2024-12-17xmlsecurity: fix tests to run with system NSS on Fedora 40Michael Stahl
testDropMacroTemplateSignature fails printing this: warn:xmlsecurity.xmlsec:3511616:3511616:xmlsecurity/source/xmlsec/errorcallback.cxx:53: signatures.c:599: xmlSecNssSignatureSetKey() 'rsa-sha1' 'VFY_CreateContext' 4 'NSS error: -8011' because policy sets NSS_RSA_MIN_KEY_SIZE to 2048. testPDFGood fails printing this: warn:svl.crypto:3587940:3587940:svl/source/crypto/cryptosign.cxx:1941: ValidateSignature: message is not signed warn:xmlsecurity.helper:3587940:3587940:xmlsecurity/source/helper/pdfsignaturehelper.cxx:482: failed to determine digest match because enabling SEC_OID_SHA1 for NSS_USE_ALG_IN_ANY_SIGNATURE doesn't enable it for SMIME signatures, so smime_allowed_by_policy() fails - obviously one has to use NSS_USE_ALG_IN_SIGNATURE to enable it in any signature. Change-Id: I59ffaf0994eee6b51362fd3296f61465d0fc7903 (cherry picked from commit a7b7b00b78426bff8607c77106ea62dd213f0821) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178663 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fae1eb775d44438a2193ba1ec07261ea0a94fef4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178667
2024-12-17tdf#164299 fix crash in pasting HTML tableOliver Specht
Supports <colgroup> element now. Change-Id: I4fe49f3c79c567e9364a1642e716846256c6070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178536 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> (cherry picked from commit 728f5eb01de33bd1f16f25d9bd7cdef6fa0909de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178569 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-17Add Nextloud to technical.dicAndras Timar
Change-Id: I68fec7cbaf167c2702ea38b93d74052d373fdf15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178599 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 91119801859ed20900ff30751ef00c9cb0dcd62d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178604 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 8e9e47bd73982d868b9db394bfbc1b718b5a85b5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178617 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-17Fix typo in earlier commitStephan Bergmann
...6d1cddea8e4e19287891ab8fb7e3774ae9976ea1 "tdf#135628 Let uri-encode encode newlines" Change-Id: I11e6f08947e85964f02fe1379217a2004492d0b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178619 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-16tdf#135628 Let uri-encode encode newlinesStephan Bergmann
...and invoke it via `printf ... | uri-encode` rather than `echo ... | uri-encode`, to avoid passing spurious newlines to it (which appears to have been the reason for it not to encode newlines in the first place) Change-Id: I26131a19f69c04b0beca8e8bab72c1dbb65300c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178596 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 6d1cddea8e4e19287891ab8fb7e3774ae9976ea1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178600 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16Update git submodulesMartin Srebotnjak
* Update translations from branch 'libreoffice-25-2' to 50d1abddaf46a7bfc9b2f56265669278906ebcd0 - Updated Slovenian translation Change-Id: I58f2b0be2d0af3d3174871e260647e79a1b52573
2024-12-16crashtesting: unable to import doc export of forum-de2-10510.ottCaolán McNamara
"No namespace defined for pic at sax/source/fastparser/fastparser.cxx:718" Change-Id: I417ee6608b63f27b92236ab96cc705d4261b8350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178581 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit d0ecc9bbffb15bd9b312e706238a131f9a19fa0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178598
2024-12-16Java-WebSocket: upgrade to 1.6.0Xisco Fauli
Downloaded from https://codeload.github.com/TooTallNate/Java-WebSocket/tar.gz/refs/tags/v1.6.0 Change-Id: Ibcf78603e1826721fc5620eef20d633addbf357f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178538 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 1f7aceea7a54c9c17dce2583659a19d11efd6159) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178575
2024-12-16tdf#150789 - FILEOPEN PPTX: fix text in SmartArt vertically offBalazs Varga
Calculate correctly the textbox area of upArrowCallout and downArrowCallout shapes in group shapes. In grouped list text area does not cover the whole shape but just a part of it at the top. In case of upArrowCallout and downArrowCallout the arrow size of the shape is not included in the textbox area of the full shape. Change-Id: If732305747c20da55bbd2896522c0b9c05cc4b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178343 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins (cherry picked from commit 9948c2ed03d227e178b9002dabc6edf34c32a5af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178546 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16crashtesting: assert on reimport of docx export of ooo102874-2.docCaolán McNamara
#0 SdrObjList::RemoveObjectFromContainer (this=0x1d12e30, nObjectPosition=3) at core/svx/source/svdraw/svdpage.cxx:1093 #1 0x00007ffff15da0bd in SdrObjList::SetObjectOrdNum (this=0x1d12e30, nOldObjNum=3, nNewObjNum=2) at core/svx/source/svdraw/svdpage.cxx:536 #2 0x00007ffff14c954c in SdrObject::ensureSortedImmediatelyAfter (this=0x4f56d30, rFirst=...) at core/svx/source/svdraw/svdobj.cxx:897 #3 0x00007fffcdc4978c in SwTextBoxHelper::DoTextBoxZOrderCorrection (pShape=0x4c3a660, pObj=0x4c3d730) at core/sw/source/core/doc/textboxhelper.cxx:1638 #4 0x00007fffcdc4bcbc in SwTextBoxHelper::changeAnchor (pShape=0x4c3a660, pObj=0x4c3d730) at core/sw/source/core/doc/textboxhelper.cxx:1247 #5 0x00007fffcdc4e613 in SwTextBoxHelper::synchronizeGroupTextBoxProperty (pFunc=0x7fffcdc4bc10 <SwTextBoxHelper::changeAnchor(SwFrameFormat*, SdrObject*)>, pFormat=0x4c3a660, pObj=0x4c3d730) at core/sw/source/core/doc/textboxhelper.cxx:1652 #6 0x00007fffcdd41a89 in SwDrawContact::Changed_ (this=0x4c55400, rObj=..., eType=SdrUserCallType::ChildMoveOnly, pOldBoundRect=0x7fffffff09d8) at core/sw/source/core/draw/dcontact.cxx:1250 #7 0x00007fffcdd410a7 in SwDrawContact::Changed (this=0x4c55400, rObj=..., eType=SdrUserCallType::ChildMoveOnly, rOldBoundRect=...) at core/sw/source/core/draw/dcontact.cxx:1005 #8 0x00007ffff14c7356 in SdrObject::SendUserCall (this=0x4c3d730, eUserCall=SdrUserCallType::MoveOnly, rBoundRect=...) at core/svx/source/svdraw/svdobj.cxx:2827 #9 0x00007ffff14b11d8 in SdrObjCustomShape::Move (this=0x4c3d730, rSiz=Size = {...}) at core/svx/source/svdraw/svdoashp.cxx:1499 #10 0x00007ffff152753b in SdrObjGroup::Move (this=0x1be18e0, rSiz=Size = {...}) at core/svx/source/svdraw/svdogrp.cxx:561 #11 0x00007fffce8c80b8 in SwViewShellImp::NotifySizeChg (unique_ptrI7SdrMarkSt14default_deleteIS2_EESaIS5_EE11_M_allocateEm=<error reading variable: Unhandled DWARF expression opcode 0x0>, hrowE=<error reading variable: Unhandled DWARF expression opcode 0x0>) at core/sw/source/core/view/vdraw.cxx:274 #12 0x00007fffce032bc1 in AdjustSizeChgNotify (pRoot=0x5e1c7f0) at core/sw/source/core/layout/pagechg.cxx:851 #13 0x00007fffce03243f in SwRootFrame::CheckViewLayout (this=0x5e1c7f0, pViewOpt=0x0, pVisArea=0x0) at core/sw/source/core/layout/pagechg.cxx:2445 #14 0x00007fffce032eec in SwPageFrame::Cut (this=0x5f19910) at core/sw/source/core/layout/pagechg.cxx:921 #15 0x00007fffce037d40 in SwRootFrame::RemovePage (this=0x5e1c7f0, pDelRef=0x7fffffff13c0, eResult=SwRemoveResult::Prev) at core/sw/source/core/layout/pagechg.cxx:1518 #16 0x00007fffce03808e in SwRootFrame::RemoveSuperfluous (this=0x5e1c7f0) at core/sw/source/core/layout/pagechg.cxx:1557 #17 0x00007fffcdfe8d04 in SwLayAction::InternalAction (this=0x7fffffff1a30, pRenderContext=0x5211510) at core/sw/source/core/layout/layact.cxx:694 #18 0x00007fffcdfe7cc6 in SwLayAction::Action (this=0x7fffffff1a30, pRenderContext=0x5211510) at core/sw/source/core/layout/layact.cxx:396 #19 0x00007fffce8d5995 in SwViewShell::CalcLayout (this=0x521c540) at core/sw/source/core/view/viewsh.cxx:1197 #20 0x00007fffcde1233f in SwEditShell::CalcLayout (this=0x521c540) at core/sw/source/core/edit/edws.cxx:111 Change-Id: I66ffbbfc74e52eea2e24e486d52607e84ffb8fcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 71a9de600abb46e9f8bf61fd3c139dd895c60c28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178543 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16check passed functions before useJim Raykowski
This is a follow up to commit 55e86edcb37a37123a69ce3e1eb9e20758415fb6 to fix a crash that occurs when importing a Basic library. The change made to functions arguments passed to ImportLib in PS28 requires they be checked for nullptr before use. For further understanding please see change to moduldl2.cxx at https:// gerrit.libreoffice.org/c/core/+/176254/27..28 Change-Id: I3f7ccc46134ddd2429c499d6e728e30331b51d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177924 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178564
2024-12-16Resolves tdf#164143 Tooltip with path to macro in new Macro OrganizerJim Raykowski
dialog contains percent symbols instead Cyrillic Additionally use the same approach to make the expected symbols appear in the description text view. Change-Id: I89adafde4305dbe9a6e56481ed246376bc1d94a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177925 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178563
2024-12-16improve SalInstanceNotebook m_aPages handlingNoel Grandin
I added some asserts here, and discovered that sometimes m_aPages and the pages in the underlying TabControl get out of sync. So rather than relying on indexing into a vector, just store a map indexed on the page identifier, which means everything uses the same scheme now. Change-Id: I1b8228e9b124521bda0e79c98e4961bedc71d641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178003 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins (cherry picked from commit 0aa4bfe37a80f3b17430cb91b4fd5e9e528efcbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178561 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16tdf#164129 sd: fix resizing of the notes text contentTibor Nagy
The notes text content was not resized when we changed the paper size in the print dialog. Change-Id: I2f610579e2ac84c298c4105a5c1235fbe62ad627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178146 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> (cherry picked from commit f958aea556e6ea067eb8696a1dff99f3458e8c19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178560 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16Fix GNU C++ version checkMike Kaganski
It must match the existing GNU C version check (starting at line 4812). An omission from commit 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 (Adapt Clang and GCC minimum version checks, 2023-09-23). Change-Id: Iaaf7d8ba5ab7d731db9f4e84311a37600444cedc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178439 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ae078891116a097d06133f4176421cde4cc333f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178542 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16tdf#164039: Improve tip of the day (II)Bogdan Buzea
Change-Id: I200173f7a7572ac170a2c0fc390d552a28ca016d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178249 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178559
2024-12-16tdf#164039: Improve tip of the dayBogdan Buzea
Change-Id: I4b40e012c557a08c61b7b383c4c57fc615d71c04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177298 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178558
2024-12-16fix bug in use of SwStyleNameMapper::GetUINameNoel Grandin
introduced in ca435be45f316120b9df6c9d547b781ed975817d "writer: handle styles in multiple languages for online" and sprinkle some [[nodiscard]] around to prevent future such issues Change-Id: Ie12a7966a4de93c9ad05fef01fd2ff606f9dde6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178087 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins (cherry picked from commit a33b6d57d04bc011cd0a8d44023efe1639915b09) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178557 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16cid#1606642 Data race conditionCaolán McNamara
Change-Id: I7b36a4632981a548c04b2bc31decc9be98200c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 059e695005b7eb500058f8c1c6cf83eb92dad20b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178555
2024-12-16Hold vcl::Window by VclPtrCaolán McNamara
suspicious that there is "delete pOLV" after retrieving a bare pointer, holdinf this by VclPtr looks sensible in any case. program/libmergedlo.so OutputDevice::LogicToPixel(tools::Rectangle const&) const /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/outdev/map.cxx:906 program/libmergedlo.so vcl::Window::LogicToPixel(tools::Rectangle const&, MapMode const&) const /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/window/window3.cxx:158 program/libmergedlo.so SdrObjEditView::SdrEndTextEdit(bool) /home/collabora/online-buildscripts/staging/builddir/libreoffice/svx/source/svdraw/svdedxv.cxx:1796 program/../program/libsdlo.so sd::View::SdrEndTextEdit(bool) /home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/view/sdview.cxx:780 program/../program/libsdlo.so sd::FuText::MouseButtonDown(MouseEvent const&) /home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/func/futext.cxx:290 Change-Id: Ic9e8c8cf4256acfcb45daa4b9d72b0cb1cea635a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178359 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 0b9573b77f785d857be2b5d20fb8e5d20beeca3d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178551
2024-12-16cid#1636690 Dereference after null checkCaolán McNamara
Change-Id: Ie32ffbe6148c2e12aa99068790fa7a1a1c0f27e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178399 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 236244b81ad58988341d66aea0018c2fa9c82a50) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178547 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16tdf#147067 Jump to clicked spot if left mouse click with Option keyPatrick Luby
Most macOS applications such as TextEdit and Safari jump to the clicked spot if the Option key is pressed during a left mouse click. Change-Id: I56149e42daf1825cfebde8be8cfbb53645b31928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178369 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 94508506e7f6b9e53c77b631c5d7de1e06ff78d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178379 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16tdf#79298 - FORMATTING: Copy/paste: import strikethrough attributeAndreas Heinisch
Change-Id: I0539e87f2a87f869e234ed7c944b9da6bd0e82bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177847 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins (cherry picked from commit 813f34d6726584368641f2e93fdaf79ff387d6b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178189 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16tdf#162716 Always strip line-ending charactersAlin Andrei Abahnencei
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: I3dfc6908e18f7bad54468620cf657a0a4afb8046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177393 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit 734f80b66947210861ab2beb216e0dc327959e18) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178041 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-16Gtk-WARNING gtktreestore.c:1047: Invalid column number 1 added to iterCaolán McNamara
Change-Id: I228cd7ae5d4b8686dbbebc6c50ea7048f3ff54e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 1df6e28bb20165aa33e856a1f9ad727d427665d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178539
2024-12-16crashtesting: fix assert while parsing tdf94588-1.odtJonathan Clark
Some ODF parsing code uses relative indices into XMLPropertyMapEntry arrays to enumerate related attributes. This change moves some recently-added paragraph property entries to the end of the respective array, fixing an assertion caused by accessing unexpected attributes via these hard-coded relative indices. Problem since: commit 7e4f4a0ccd3c56093dec44c7dcdd14c8b34623c3 tdf#163913 Implement font-relative margins Change-Id: Ia2671372f0152e4efb98bd25b390638e4458a1b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178318 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> (cherry picked from commit c697c36d4ef330b4cbf8c6bbeb4f893a3ea4c666) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178335 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-09 16:05:18 +0000