summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-26assume IFrame script/macro support isn't neededCaolán McNamara
seems undocumented at least Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26use skia's svg seed corpusCaolán McNamara
Change-Id: Iee1e7a6bbc3e50b3e882465aafea4c9b0650dcbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26expose parsing svgs for testingCaolán McNamara
Change-Id: I4d59aa9a684bd3e05fca473d6c7567cd8258b242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#151624 Fix Insert Formula tool in the Tabbed UIRafael Lima
As reported in the ticket the Insert Formula tool was misaligned in the Tabbed UI since the removal of the Emoji tool. This patch fixes that by making the tool use all the available vertical space. Change-Id: I26d36ba4fc6f38e80d8ab46bfdf88c08fbf2fd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150701 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-26Resolves tdf#153852 - Make sort dialog resizableHeiko Tietze
Change-Id: Ie0db5c713bf16443962245900655736aeddce532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151042 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-26tdf#108757 speed up PDF generationNoel Grandin
std::list->std::vector reduces output time by 10% because we search the m_aChildren often and vector is better at that Change-Id: I4d0d5f6248a9c36aa0085cb22315ad6e2f53738e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26tdf#108757 avoid some OUString construction on a hot pathNoel Grandin
Change-Id: I468bc9fac024dd9fa33286382264e2b84617481b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 3Miklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed the crash, but a layout loop remains. The current problem is that we could have a document of 3 pages where the last page had no anchor for the fly frame, so it took the anchor from the previous page, but this lead to negative frame heights and at the end an empty 3rd page. To fix the problem: 1) Make sure SwTextFrame::FormatAdjust() doesn't break the invariant that only the last frame of a floattable anchor has text content. 2) Make sure SwTextFrame::AdjustFollow_() doesn't join a frame that still hosts non-last split flys. With this, we have exactly 3 anchor frames (in a flow frame chain) for the 3 pages and the 3rd page looks correct. The original document still needs more work to fix the layout loop, though. Change-Id: I2fc9c4728fdf191ac5b5b435a10d553a699bae75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151048 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-26Bin leftover dead codeTor Lillqvist
Change-Id: Ie0583d52b01bba92e6fc41f0fee3fd4732f1d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151054 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-04-26Fix typoAndrea Gelmini
Change-Id: I05e089a8d04d2b5527cf466510b182eeac355836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151044 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Fix typoAndrea Gelmini
Change-Id: I13e43e0cd7f3f3e31b581c5b3cec12f5c0634cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151043 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26update creditsChristian Lohmaier
Change-Id: I934d635e0d241b9884017e4a22ba99e9d1459783
2023-04-26Revert "workaround compile failures in libxml, with clang-17"Noel Grandin
This reverts commit 4a828dde104551c1c3d935ed8b43ebc546fa77c3. Reason for revert: Caolan merged a better fix with aa87fe2562e7a55a18a1c757a49babfe74377bcd Change-Id: I3ae713555fc62782675dbc48ad51a36ff41bfcf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-26tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scaleTibor Nagy
This is a follow up to commit 3f614f431475e1bf3bb3bbeac59b0681309628b7 (tdf#95295: don't add duplicate conditional formats) The above commit clearly describes how this fix works. Change-Id: I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150899 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-26jsdialog: enable themedialog.ui and themecoloreditdialog.uiTomaž Vajngerl
Change-Id: Ie6c6af3e3a98548cad8b5bfb067382a03296b278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151033 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-26Related: tdf#155017 Stop after the first pop in case the shell was not on stackMike Kaganski
After commit 271f17a6022c64cbbe9befbc66a9eaaa0567d569 (tdf#155017: make sure that the correct shell is popped from SfxDispatcher, 2023-04-26). This restores the previous logic for a hypothetical case of a pop without POP_UNTIL scheduled for a shell, which was not on the stack (so that it wasn't removed in the code added in the commit mentioned above); I haven't a reproducer, but it definitely can happen, given how things work here. So I try to avoid breaking it even further :-) Change-Id: Ied0a1406881fbefe3cf069f816c50da03a41dcd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26use our existing zipfuzzer_seed_corpusCaolán McNamara
Change-Id: Ib0ea6ad80ff24d3b405051c22b4cdcc461ae2018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#152246 Fix RTL content control field positionHossein
With this patch, the horizonal position of the content control fields are corrected. Previously, they were calculated just like the fields in the LTR paragraphs. To implement this, I've used the GetTextFrame()->SwitchLTRtoRTL method. The remaining issue is that The exported fileds in the PDF are still LTR themselves. For example, the combo box will still be LTR. It should be pointed that handling vertical text is still an issue that should be addressed later. If you rotate the paragraph with content control field, the output does not obey, which is incorrect. Change-Id: I927d14f9ca90434b4397dcf175dbb9531dda0c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150515 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#138093 DOCX import: fix broken date selector control in tableCzeber László Ádám
In tables, first character of the text value of the date selector control left outside of the control during the import, resulting broken date selector, e.g. 2[023] instead of [2023]. (Clicking on the broken control, according to the year *023*, the selector listed the lowest possible value, year 1900, and selecting that, the result became 2[1900].) Note: the fix works well with nested tables, too, so likely the condition with tables is obsolete. Perhaps regression from commit b36ef83ea59eeaca239e58b95aa0b1acdcb99efc "tdf126701: MSForms: Fix import of date field at the end of the paragraph." and commit 68e1be4ccbb90ee9a788962219a88312c4ffbea2 "MSForms: Rework text-based date form field's representation". Change-Id: Ib217a3a06522bfe7b3b0fbc884f98504f628fc59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-26tdf#155006 don't show "InsertObjectFloatingFrame" by default in menus and ↵Caolán McNamara
toolbars still exists, just isn't presented by default. help describes this as "Inserts a floating frame into the current document. Floating frames are used in HTML documents to display the contents of another file." and "Changes the properties of the selected floating frame. Floating frames work best when they contain an html document, and when they are inserted in another html document." This is basically support for html IFrames and is a fairly obscure thing for an ordinary document. Change-Id: Iec8ff591393e4ee4ed8791094e1f15a225808c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150707 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 2Miklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed a crash, but a layout loop remains. One problem there is that we move too many rows to a next page. Analyzing what Word does and how we behave, we handled the TABLE_ROW_KEEP flag even for floating tables, but Word only does this when table wrapping is "none". Fix the problem by following suit, which gives the correct 2.5 rows on the first page of a reduced bugdoc. The layout loop for the original document still needs more work, though. Change-Id: Ief79d4b4e984a9e46ee133ae3e7e7cf81e13a836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151009 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-26Renumbering comments in include/svx/xdef.hxxJulien Nabet
Change-Id: Ice9f69824a6127dd23ce9e760b06ce9f03403604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Related tdf#154769: XML forms add anyURI/hyperlink datatypeJulien Nabet
See https://www.w3.org/TR/xmlschema11-2/#anyURI Since I copied-paste string datatype + add check url, I thought about deriving from string datatype but seeing https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/datatypes.html#built-in-datatypes anyURI doesn't derive from string TODO: contrary to "string" which uses "preserve" for "whitespace" "anyURI" uses "collapse" There's WhiteSpaceTreatment notion in datatypes.cxx and m_nWST associated, WhiteSpaceTreatment::Preserve seems to be the default but when searching about it, it's seems not used. Change-Id: Ifc2dc06072e40b9be168c2f40a9506fe7d267ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150822 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26tdf#86630 sw page number wizard: set page style numbering typeJustin Luth
Giving the user the opportunity to change the number type is rather important. Well, maybe not too critical since I assume that the default page number style is relatively accurate for each locale, and at least for English we always just use numbers for the page style. However, a wizard is the perfect place to expose such a setting, otherwise it is buried in page style settings - far from where anyone would look when inserting a page number. Change-Id: I9053504fa55d16ebf5424946b480cb044b79988c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151005 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#154855 DOCX export: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>Miklos Vajna
The bugdoc has a table where shapes are anchored in cells. The wrap type is set to "none" ("in front of text" in Word UI terms) and the follow text flow ("layout in table ell" in Word UI terms) option is enabled. The import into Writer is fine, but saving back to DOCX and checking in Word is not: all shapes move to the left cells. What happens is that since commit e993638d5ecd33783f2eebdccfa87a81e5a8a2c5 (DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>, 2022-01-24), we ignore layoutInCell in case wrapNone is used with a suitable horizontal relation orient, since Word doesn't capture anchored shapes inside the cells in practice in that case. This helps for the old bugdoc, but introduces the problem that we now lose the layoutInCell setting on export, which is not wanted. Fix the problem by leaving the import and the layout unchanged, but do the opposite mapping on export: if we have the relevant wrap and horizontal relation orient case, then enable layoutInCell, even if the doc model doesn't have it. Note that Word itself behaves inconsistently here: if you change the vertical offset of one of these shapes to position the shapes outside the cell, Word does it, even if "layout in cell" is enabled. Change-Id: I980a995d76afdee4716f7669081c688065427ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151000 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-26tdf#155017: make sure that the correct shell is popped from SfxDispatcherMike Kaganski
Honestly, I don't quite understand the idea of using the stack of shells in SfxDispatcher, when the order of addition of shells there does not match the order of removal. After opening the bugdoc, SfxDispatcher has these shells in xImp->aStack (from top to bottom): [8] SwWebView [7] SwWebTableShell [6] SwWebTextShell [5] SwWebListShell [4] FmFormShell [3] SwWebDocShell [2] SfxViewFrame [1] SwModule [0] SfxApplication SfxViewFrame dtor calls ReleaseObjectShell_Impl. * First of all, it calls PopShellAndSubShells_Impl for SfxViewShell; * Then it calls SfxDispatcher::Pop for SfxObjectShell; * Then it calls SfxDispatcher::RemoveShell_Impl for SfxModule; * Then SfxObjectShell is destroyed; * And finally, SfxDispatcher::SetDisableFlags is called. PopShellAndSubShells_Impl (for SfxViewShell) finds the passed SwWebView at the top of the stack (pos. 8), and removes it. SfxDispatcher::Pop for SfxObjectShell queues removal of the passed SwWebDocShell *without* SfxDispatcherPopFlags::POP_UNTIL mode. SfxDispatcher::RemoveShell_Impl first calls Flush, which actually executes the queued actions. At this point, an SwWebTableShell (pos. 7) is the top of the stack; SfxDispatcher::FlushImpl will pop it, and stop (because there was no SfxDispatcherPopFlags::POP_UNTIL at the previous step), so the intended removal of SwWebDocShell (which is at pos. 3) will not happen. Then RemoveShell_Impl will proceed searching for the specific shell (SwModule), and removing specifically that (at pos. 1). At the moment of destruction of object shell, the dispatcher's stack looks like this: [5] SwWebTextShell [4] SwWebListShell [3] FmFormShell [2] SwWebDocShell <-- The problem is here [1] SfxViewFrame [0] SfxApplication and pos.2 points to a destructed object. Finally, SetDisableFlags iterates all the shells still in the stack, setting their flags - and obviously accessing already destroyed object. In debug builds, this crashes reliably; in release builds, where dtors do not fill memory, the access of the just-destroyed objects likely often goes unnoticed. In different documents, the order and the set of shells there is different, e.g. an empty Writer document would have view shell just above object shell, resulting in correct removal of the object shell. I don't know what strategy is intended here. I decided to implement a small change, that makes sure that without POP_UNTIL, popping a shell removes exactly that shell that was requested for removal. Change-Id: I670d024056a5b32d5485f00a4799a8b0bacb6485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151003 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26tdf#155011: Fix assert/checkMike Kaganski
pFrameStartAfter may be a section frame itself, thus its FindSctFrame would not return this. Same for pSav. Change-Id: Ib592965b30eb47f37ba54fe7f39af0b8689b3175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-26tdf#153789 KJ: icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I9a989e039ae726e413c0a54ab805a0ee7d09c94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151007 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-26tdf#86630 sw page number wizard: default to center of pageJustin Luth
Defaulting to one side of the page only makes sense if the footer is mirrored. [Well, mirrored isn't the best word here because it only refers to margin spacing.] The only way to get mirrored footers is to have separate left and right pages. It would be nice to add mirroring to the wizard, but that can be done separately. First, lets just get a better default value in place. Change-Id: I314c6a34414a696c6f2e27bb2b0747fdb86f3b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150998 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-04-25Resolves: tdf#41304 Add percent operator % to reference delimitersEike Rathke
Change-Id: I094fcb800a29de424db28e1b58f1239381a3b4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151001 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25tdf#56258 i18npool en-US: re-arrange outline numbering suggestionsJustin Luth
This patch brings order out of chaos, organizing the outline choices into academic, modern, simple numeric, and misc columns. The very first suggestion should be the academic standard. Next comes a distinctly different modern alternative Simple numeric moves over to be above the other numeric, followed by a demo of the kind of mixture that can be designed in LO. Since the academic standard uses Roman numerals, it is offset on the next row by the other one containing Roman numerals followed by a modern classic, and the all-numeric ISO standard retains it current position. The bullet oddball logically remains as the last suggestion. In this patch there was no change made to the actual suggestions themselves. Earlier patches made changes to 3 definitions, which allowed for the nice correlations. I missed changing the descriptive "strings" in the earlier patches. I had assumed earlier that these monotonous descriptions were dynamically produced... Since the English description should not be translated, I added a comment that will be extracted to the PO as a comment. (Thanks Andras). I think it would be nice to use strings "Academic MLA/CMOS/Turabian/OWL compliant outline" "ISO 2145 outine" but that could be made in a separate patch. Let me just point out what happened with the strings in case this helps with translation NOTE: only languages that ultimately inherit from en_US need to re-translate: old RID_SVXSTR_OUTLINENUM_DESCRIPTION_0 -no string change -moved to _3 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_1 -string changed / list modified earlier -moved to _5 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_2 -string changed / list modified earlier -moved to _1 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_3 -no string change -moved to _2 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_4 -string changed / list modified earlier -moved to _0 old RID_SVXSTR_OUTLINENUM_DESCRIPTION_5 -no string change -moved to _4 RID_SVXSTR_OUTLINENUM_DESCRIPTION_6 -no change RID_SVXSTR_OUTLINENUM_DESCRIPTION_7 -no change Suggested translation order: -cut _3 and paste into _2 -cut _0 and paste into _3 -cut _4 and paste into _0 and fix definition -cut _5 and paste into _4 -cut _1 and paste into _5 and re-define -re-define _1 Change-Id: Ie4ec8423acddc24efefb270d9ed19ab77566e6e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150805 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-04-25svx: rework the theme dialog to allow editing theme colorsTomaž Vajngerl
In addition to editing of theme colors, this also changes the way how theme colors are represented in the theme dialog and the behaviour when changing applying a theme color change. Previously a theme colors were applied with double-click, now a double-click still applies, but automatically exits the dialog. The selected theme is applied also when OK button is pressed. Change-Id: Ic0f8399ede180d6ab0001a7f8b5dda0e7c49fa3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25add "m" prefix to member variables - SfxTabPageTomaž Vajngerl
Change-Id: I482c341518948bf92f81d4f89b7e307635220150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150974 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25Resolves: tdf#144547 ScRangeFindList: handle references in multi-line formulaEike Rathke
Also fix a color attribution error if when dragging the reference the new reference string is longer (colored too short) or shorter (colored too much including the next characters/operator/...) than the old reference string. Change-Id: I1b39fd5778d75290a0233f51a4198753fa858f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25tdf#154604 SdNavigator: Support listing in front-to-back z orderJim Raykowski
Enhancement patch to provide the option to list objects in front-to- back or back-to-front z order Change-Id: I2194cace08736d948002548887661314834cef89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150893 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-04-25tdf#38194 tdf#106556 Enhancement to highlight direct formatting,Jim Raykowski
paragraph style, and character style use in Writer documents Initial commit to realize direct formatting, paragraph style, and character style highlighting enhancement requests. Highlighting of character direct formatting is turned on/off using .uno:HighlightCharDF. Highlighting of paragraph styles and character styles is turned on/off using a check box in the Sidebar Styles panel. Closing the Sidebar also turns paragraph and character style highlighting off. Paragraph direct formatting is indicated by a hatch pattern over the paragraph style highlight bar and also by "+ Paragraph Direct Formatting" appended to the tooltip that appears showing the name of the paragraph style when the mouse pointer is over the style highlight bar. Colors used for styles highlighting are determined by a hash of the style name. Lightgray is used for character direct formatting. Known issue: Tooltip doesn't show for paragraph style highlighting in tables and in frames where the highlighting bar is drawn outside of the frame. Change-Id: I6e00ee38c1c169bc7c6542a1782c03b2593e1891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150451 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25add a fuzzer to test zip recovery modeCaolán McNamara
Change-Id: I25f82cd83afae0fb3b0cfc3f1586e28323369f8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25add --disable-pedantic to avoid warnings as error for xmlsecCaolán McNamara
like... symkeys.c:621:30: error: no newline at end of file [-Werror,-Wnewline-eof] #endif /* XMLSEC_NO_PBKDF2 */ ^ 1 error generated. make[5]: *** [Makefile:765: libxmlsec1_openssl_la-symkeys.lo] Error 1 Change-Id: I1dcd0cb6b350f412c30fb5a8d3aa4976cd0afde5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#154956 sw: delete bookmarks at end if whole node is selectedJustin Luth
Exposed by LO 7.2.2 commit 4bf04dea9afb30a9395e80b07a81d1908937ee8b Author: Michael Stahl on Fri Aug 27 14:38:18 2021 +0200 tdf#128106 sw: copy bookmarks at start if whole node is copied Change-Id: I9205463f9beb3704eeb63fe7556103230ba7283d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150772 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-25Resolves tdf#154080 - Allow customization of comment indicator colorHeiko Tietze
* New application color added * Border color depending on cell/sheet background * Comments color set to light magenta to align with similar tools Change-Id: I782e8359632c5a319e61f5d5ac3deb4614bd7e79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150970 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25Fix tdf#155004: ucb: webdav-curl: carry over Class1 bit only if setMichael Stahl
With d6182cb6704c06f33d284874b9fe96c85cce5bf5 there are cases when a webdav server inadvertendly releases the lock. Lets apply the fix only if the Class1 flag is actually set. Change-Id: I85e5253c7df0980f373d2dea788c331b81ed4a82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150552 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2023-04-25Remove lock file fuzzerCaolán McNamara
this found nothing in 12 months and exists to try and follow up on a confusing report which went nowhere in the end Change-Id: I7f3c6a5e2ccedad2e7b925b3c15b076cd22f1ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150972 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25expose recovering zips for testingCaolán McNamara
Change-Id: I4709a2fb0bbb0fcc4c7d57dad53c899e7ba79cb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25Resolves: tdf#155005 use of uninitialised valueCaolán McNamara
==2515797== Conditional jump or move depends on uninitialised value(s) ==2515797== at 0x33FAB399: ZipFile::recover() (ZipFile.cxx:1090) ==2515797== by 0x33FA4D32: ZipFile::ZipFile(rtl::Reference<comphelper::RefCountedMutex>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>, bool, bool) (ZipFile.cxx:111) ==2515797== by 0x33FEF134: void std::_Construct<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(ZipFile*, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (stl_construct.h:119) ==2515797== by 0x33FED528: void std::_Optional_payload_base<ZipFile>::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:278) ==2515797== by 0x33FEB73B: void std::_Optional_base_impl<ZipFile, std::_Optional_base<ZipFile, false, false> >::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:457) ==2515797== by 0x33FE77DB: std::enable_if<is_constructible_v<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>, ZipFile&>::type std::optional<ZipFile>::emplace<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:918) ==2515797== by 0x33FD61FD: ZipPackage::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (ZipPackage.cxx:760) ==2515797== by 0x64DE1EC: cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:732) ==2515797== by 0x64DDF19: cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:694) ==2515797== by 0x64E0E8F: cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (servicemanager.cxx:1018) ==2515797== by 0x34A3B25F: OStorage_Impl::OpenOwnPackage() (xstorage.cxx:435) ==2515797== by 0x34A3C16C: OStorage_Impl::ReadContents() (xstorage.cxx:541) ==2515797== Uninitialised value was created by a stack allocation ==2515797== at 0x33FAB02C: ZipFile::recover() (ZipFile.cxx:1034) since: commit abda72eeac19b18c22f57d5443c3955a463605d7 Date: Mon Feb 20 00:32:22 2023 +0100 tdf#82984 tdf#94915 zip64 support (import + export) where - aEntry.nCompressedSize = nCompressedSize; - aEntry.nSize = nSize; was removed before the subsequent use of aEntry.nCompressedSize/aEntry.nSize change things (git show -w for clarity) to check bounds first just for the range the extra fields might be in and read those, and then follow up with the original check that the newly discovered aEntry.nCompressedSize/aEntry.nSize are within the bounds of the overall file Change-Id: Iad4ce8297109b06bc5baf77df4f3e86659cbb4cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#155005 fail gracefully on encountering a negative compression valueCaolán McNamara
we are using sal_Int64 for this so a large enough value can be interpreted as negative here Change-Id: Id547a24591aca4b6ed7b7955621641a0666b0bd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150968 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#91332 XLSX export: fix missing solidFillTünde Tóth
Background color of shape inherited from theme lost after export. Regression from commit bc0a9076aa43a0782bcf81e55d3f84f6af0f68e8 "ooxml: Preserve shape theme attribute for solid fill". Change-Id: I2d8298ac17332ba3ad6a627ce8b07c23087ac7b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150674 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25tdf#119565 XLSX export: fix lost line properties inherited from themeTünde Tóth
Line properties (LineWidth and LineJoint) of shape inherited from theme lost after export. Perhaps regression from commit 5391d4872e71d1edba7acc4ad2d2e3b5b97e1723 "ooxml: Preserve shape style and theme attributes for line". Change-Id: I9977bb20f16245f3c95ccbe2c5c8033b5b0c9cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150547 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25tdf#150824 sw DOCX: fix export of new tracked tablesLászló Németh
New tracked tables handled by a single redline, which lost during the export: only the tracked text changes of the cells were exported, but not the table changes. This resulted also problems in MSO, e.g. rejecting text changes removed only single cells of the tables, modifying the table structure. To fix this, add missing tracking to the table rows, if needed. Follow-up to commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06 "tdf#79069 DOCX: support tracked table (row) deletion". Change-Id: Ic900cafa7bea3c934d8d1bd585b3e95f56746db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150967 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25oox: add support for theme import and export of blip effectsTomaž Vajngerl
This adds support for (most) blip effects import, export and the document model. Change-Id: Iec15f4de22c31268019fa1a60432e40ae8f03635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150262 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25oox: write graphic (blip) in ThemeExport - BlipFillTomaž Vajngerl
Share the graphic writing from DrawingML class, which needed a bit of refactoring and use it when writing the BlipFill when exporting a theme with ThemeExport. Change-Id: I89bf3be98f607b7641d231982af2f7a5e2c3d3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150261 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-11 06:20:13 +0000