summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-29libxmlsec: rewrite README now that we no longer patch the libraryMiklos Vajna
Change-Id: I8900e399df970056c8ac781c05e9eff6a43c31c7 Reviewed-on: https://gerrit.libreoffice.org/64195 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29remove unused SdrInsertFlags enum valueNoel Grandin
Change-Id: Ic68f2dc4e3752859c943d9885b52b70f33896aea Reviewed-on: https://gerrit.libreoffice.org/64172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29comment out the EvaluateAsInt compat code for nowNoel Grandin
sberg: Note how that Clang change keeps getting reverted; latest one is <http://llvm.org/viewvc/llvm-project?view=revision&revision=347656> "Revert r347417 'Re-Reinstate 347294 with a fix for the failures.'" But lets wait a little while to see how things settle there. Change-Id: I05b34ca1377792bcb4c557defd3e9b5d11ee2b14 Reviewed-on: https://gerrit.libreoffice.org/64168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29doc sprmPShd documentation.Justin Luth
sprmPShd (0xC64D) is a SHDOperand value that specifies the background shading for the paragraph. The SDHOperand structure is an operand that is used by several Sprm structures to specify the background shading to be applied. ShdAuto is a special value for Shd that specifies that no shading is applied and is defined as 0xFF000000 / 0x0000 ShdNil is a special value for Shd. If ShdNil is used in a Table Style definition, ShdNil is ignored and the shading of the cell is not affected. If ShdNil is applied outside of a Table Style, ShdNil specifies that no shading is applied. ShdNil is defined as 0xFFFFFFFF Change-Id: I66ec3cbccae60eb658ee00cb01b22cfae36482d0 Reviewed-on: https://gerrit.libreoffice.org/64184 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-29add test for tdf#105236Markus Mohrhard
Change-Id: I5464504ae9ee411221c2cb2ff6f27b7b7e131326 Reviewed-on: https://gerrit.libreoffice.org/64201 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#105236, only take number format from numeric cellsMarkus Mohrhard
Change-Id: I55deaa1f0579582a45dc1e10bb578b680eb98647 Reviewed-on: https://gerrit.libreoffice.org/64200 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#121612: update pivot caches during saving to XLSXVasily Melenchuk
Cache was empty so pivot table was not exported completely and pivot table filter were missing. Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d Reviewed-on: https://gerrit.libreoffice.org/63785 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-29Fix typoAndrea Gelmini
Change-Id: I8e340cc5bbf5131939446291177c3532911237ab Reviewed-on: https://gerrit.libreoffice.org/64183 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-28drop WB_SIMPLEMODE for TreeViewCaolán McNamara
multi selections are weird with this set Change-Id: I765c46294803d06911a6ac3fc37d68dd001aacdc Reviewed-on: https://gerrit.libreoffice.org/64187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Revert "Resolves: tdf#112696 survive missing SwDrawContact"Caolán McNamara
This reverts commit 2cb9c55e4da18fbfb2f578c46d094e6ca0d56fa1. Change-Id: I2d276d0171103d45be2cd66990fb5cf8d2fb4161 Reviewed-on: https://gerrit.libreoffice.org/64178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28LOK: don't emit redline commentsAshod Nakashian
Change tracking can be quite numerous. Showing the markers (and their comments" as comment-boxes is sensible where there is limited change in a doc. However with extensively modified doc, this becomes overwhelming both in terms of browser load and editing performance. As such, we disable them as they don't add much value. The user can still access them from the Track Changes > Manage menu. Use a rather nasty env. var hack to propagate this setting from WSD for now. Change-Id: I3f964816b4a10f565012b273added8a8413cd309 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d4f821b7a385953542e90b2749690b9f8f4cc782) Reviewed-on: https://gerrit.libreoffice.org/64176 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-28tdf#121581 change organize dialoogs to organize macroandreas kainz
add missing colibre icons improve layout for large icons Change-Id: Id9d003b945654f958ec43d530083e2070d4b580e Reviewed-on: https://gerrit.libreoffice.org/64159 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-28tdf#112696 if we select every member of a group, select the group itselfCaolán McNamara
Change-Id: I1b540772ff3a04c2cb32135c972f3a745c307eb9 Reviewed-on: https://gerrit.libreoffice.org/64179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Xcode 9.3 reportedly requires at least macOS 10.13.2Stephan Bergmann
...according to <https://en.wikipedia.org/wiki/Xcode# Xcode_7.0_-_10.x_(since_Free_On-Device_Development)>. (See also the discussion in the mail sub-thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081453.html> "Re: Compiler baselines".) Change-Id: Iab6fa737dfeb7cea93b18ec85c76d21da92e1d6d Reviewed-on: https://gerrit.libreoffice.org/64177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28tdf#121369 - Header and Footer parent stylesheiko tietze
New "Header and Footer" style introduced as parent to header/footer styles Right alignment set for HeaderR and FooterR Change-Id: Iff407da8907b761236ebc2aa8877b9d6b8294e10 Reviewed-on: https://gerrit.libreoffice.org/64152 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-28Check against concrete expected values in PdfExportTest::testTdf115262Stephan Bergmann
With d464d505fbf6e53a38afdd3661d320fac8c760d6 "Refactor calc non-linear ViewToDevice transform", the problems with my macOS build that I described in the commit message of (abandoned) <https://gerrit.libreoffice.org/#/c/61651/> "Omit 'Calc adjust to grid hack' when not rendering for the screen" are apparently solved: `make CppunitTest_vcl_pdfexport test` succeeds, and opening vcl/qa/cppunit/pdfexport/data/tdf115262.ods and exporting it to PDF while the on-screen Calc document is displayed at varying zoom levels leads to effectively identical files now. Assuming that 232 is the universally correct value for nFirstImageTop now (nRowTop appears to have always evaluated to 199), it looks cleaner to me to have the expected values spelled out explicitly in the test code. Change-Id: Idb9f30f4ab9641b5b5325ddd90084e4112e1b572 Reviewed-on: https://gerrit.libreoffice.org/64171 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28make unopkg gui not ask to 'restart' on extension changesCaolán McNamara
Change-Id: I185527fcc4481ab2bd97ad81849ee38c6fa50919 Reviewed-on: https://gerrit.libreoffice.org/64167 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Bin some unused declarationsTor Lillqvist
They used std::unexpected_handler so did not compile as C++17 anyway. Change-Id: I5f8bacb85cbd213dd6304d865a7b4cb7eb8f4b8f
2018-11-28Do like effe6b3d84302afce3d5095e4f376e7e3bf669e0 for iOS, tooTor Lillqvist
Change-Id: I9163e1722f163a04968df292ee8b29d472f9ac4f
2018-11-28NB tabbed compact: update toolbarandreas kainz
Change-Id: I5c2cd3339634cbb88f2c89226ff46d342eebc3a1 Reviewed-on: https://gerrit.libreoffice.org/64160 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-28Fix typosAndrea Gelmini
Change-Id: I66f31ff16a5cd5d8fca7e920fdd6b77bb124dfbb Reviewed-on: https://gerrit.libreoffice.org/63321 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28Fix SID_EXTRUSION_TOOGLE -> SID_EXTRUSION_TOGGLEAndrea Gelmini
It passed "make check" on Linux. If accepted, I have to update these files: helpcontent2/helpers/help_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle helpcontent2/helpers/longnames_commands.csv : SID_EXTRUSION_TOOGLE,.uno:ExtrusionToggle helpcontent2/helpers/uno_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle Change-Id: Ie315ef92b6aa8c03c6fc180f4e82d95f28975c2e Reviewed-on: https://gerrit.libreoffice.org/60631 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28Fix typo deactiveAndrea Gelmini
Change-Id: I68a87a9435784f949f1e7b730270641bd8e05b43 Reviewed-on: https://gerrit.libreoffice.org/63149 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28drop some unnecessary includesCaolán McNamara
Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#112215 null deref on missing optional ppd valueCaolán McNamara
Change-Id: Iba45437332df963e1aa213c587071ab293f36390 Reviewed-on: https://gerrit.libreoffice.org/64163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#121752 let scroll wheel change active notebook tabCaolán McNamara
Change-Id: If8437346a58ea14266f11293b94082740303e5a9 Reviewed-on: https://gerrit.libreoffice.org/64158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Let distclean remove all of generated config_build/ treeStephan Bergmann
Change-Id: I8d12454003c0bd23170007e30f96016b47820f5f Reviewed-on: https://gerrit.libreoffice.org/64157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Do not validate SSL cert in LOK caseAndras Timar
Currently we cannot tunnel interaction handler dialog, so if there is a problem with site's SSL cert, the operation (e.g. insert image) would silently fail. As a workaround, let's not validate the remote site's SSL cert, as we also do not validate the site's SSL cert when we download the file through WOPI from the site, in the first place. So this patch does not really make things worse, but makes it possible to use the insert image feature with a self signed cert in test environments. Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878 Reviewed-on: https://gerrit.libreoffice.org/64154 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-11-28On Windows, check for at least Visual Studio 2017 version 15.7Stephan Bergmann
...to further restrict the Windows MSVC baseline to not just VS 2017, but to the latest update (as the various updates bring significant improvements for C++11/ 14/17 support; see the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html> "Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)"). Change-Id: If6a1b62da1691ae8ae19edb4ed7b35e4b6e46501 Reviewed-on: https://gerrit.libreoffice.org/59209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Resolves: tdf#121746 block toplevels from closing...Caolán McNamara
while the extension manager is querying via a dialog. Reuse the isBusy for this. Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280 Reviewed-on: https://gerrit.libreoffice.org/64155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#94446 if this is a SQLException in disguise, throw that insteadCaolán McNamara
instead of the wrapper exception, so that dbaccess can apply its special handling for SQLException::ErrorCode of dbtools::ParameterInteractionCancelled in OLinkedDocumentsAccess::open if ParameterInteractionCancelled was the root cause Change-Id: I777893cf7355d8c4a9c48237284903176d81402d Reviewed-on: https://gerrit.libreoffice.org/64123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Require at least gperf 3.1, which no longer emits "register"Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..." Change-Id: I47b6d4a7b8370262ca942b4385e2c0e6f0adc613 Reviewed-on: https://gerrit.libreoffice.org/63953 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Require at least flex 2.6.0, which no longer emits "register"Stephan Bergmann
...according to <https://github.com/westes/flex/blob/ 83d5d1695a2ab1d69ea4d8e7df27146c644876fc/NEWS>. Its use is no longer allowed in C++17, so will start to cause build failures once we restrict builds to at least C++17. (The situation with gperf is similar, but instead of checking for a minimal known-good version that no longer emits "register", we instead check for it indirectly in configure.ac, by creating gperf-produced conftest.inc and including that in the program used to test which -std= value to use. We could have done something similar for flex, but creating suitable flex output for inclusion might be more work than it was for the simple gperf case.) Change-Id: I662c6795ea5fde1420d9712c0ec910c0cadbc350 Reviewed-on: https://gerrit.libreoffice.org/63713 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28-Werror=unused-but-set-variableNoel Grandin
after commit 19c56b3befae3a23f42f981de5057de380b4c5a0 loplugin:unusedfields in sw Change-Id: I67314e86695a399fd211a64bdcf4cc3f18ca133d
2018-11-28Related: tdf#121629: Some menu items do not follow the Title Case ruleSabri Unal
Change-Id: I6b071365ee1531c3ddba70a25e36d6bd98561ffc Reviewed-on: https://gerrit.libreoffice.org/64135 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121797 XHP extensions (Help part) WIP. This is the Help part. Extend the XML parser to include new incantations of the <paragraph> tag, namely <h1> to <h6> <note>, <tip> and <warning> Extension to the <item> tag: <menuitem>, <input>, <literal>, <widget> and <keycode> * removed test files Change-Id: I2a473ee8772606f5e84bb02e651bccc6749598f4 Reviewed-on: https://gerrit.libreoffice.org/63954 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28tdf#121697 XHP extensionsOlivier Hallot
This is the core part of the bug, and is WIP Extend the XML parser to include new incantations of the <paragraph> tag, namely <h1> to <h6> <note>, <tip> and <warning> Extension to the <item> tag: <menuitem>, <input>, <literal>, <widget> and <keycode> Change-Id: Idaed321cc8756fa6bcf4fbc170982365ff33d4d7 Reviewed-on: https://gerrit.libreoffice.org/63955 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121736 initial Help pages for Python scripts Work in progress, initial addition of help pages for python scripts in LO. Change-Id: Iee95b1340c821fdb08524fdedeca3817b0de1459 Reviewed-on: https://gerrit.libreoffice.org/64137 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28slideshow: get unit tests to work againThorsten Behrens
Change-Id: I7b5c7a20677ac0f720b41daf8ca59c3cc94f1283 Reviewed-on: https://gerrit.libreoffice.org/59964 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-28loplugin:unusedfieldsNoel Grandin
Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Resolves: tdf#121695 call save_valueCaolán McNamara
so get_value_changed_from_saved detects no-op Change-Id: I2b72bc7a6bc4093f9d942aa56f90542521e23cd9 Reviewed-on: https://gerrit.libreoffice.org/64130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28loplugin:unusedfields in swNoel Grandin
Change-Id: I7a9184511df96bf2a6c40e39091010a7e2974ed6 Reviewed-on: https://gerrit.libreoffice.org/64143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28tdf#90333 Dictionaries Path Cannot Be ChangedCaolán McNamara
PathSettings::impl_storePath wants to be able to nil the Dictionaries path in the old copy of properties Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f Reviewed-on: https://gerrit.libreoffice.org/64115 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28sw RtfStringBufferValue: make members privateMiklos Vajna
Change-Id: I82f8e96901312e91bbc9a2b5c93bea02e180e907 Reviewed-on: https://gerrit.libreoffice.org/64133 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-28oox smartart, accent process: handle followSib axis of forEachMiklos Vajna
Currently the accept process document creates 0 connectors. Instead, it creates empty custom shapes: this commit fixes the loop, so that only one of them is created. The whole purpose of the follow sibling axis is that N - 1 connectors are created for N shapes, not N connectors. Change-Id: I54244c7615b83f607ef53a4ff8d01d3c9594856e Reviewed-on: https://gerrit.libreoffice.org/64122 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-28loplugin:unusedmethodsNoel Grandin
Change-Id: Idbdf2d5d12fad894a3dfc3a86cae839502f42cf6 Reviewed-on: https://gerrit.libreoffice.org/64114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28Colibre icons: add impress Slide tab iconsandreas kainz
Change-Id: Ia3d035d827c0f1b510f9ff3be8652f5bac69cead Reviewed-on: https://gerrit.libreoffice.org/64136 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-27Use HiDPI scaling to load scaled images.Michael Meeks
We render these at apparently the same pixel size as normal images, but the underlying canvas is larger so these then end up pixel-matching the true underlying grid. Change-Id: Ic4b749127e9c81da78d06b34d9f88c5635dc64b9 Reviewed-on: https://gerrit.libreoffice.org/64044 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27weld DataSourceDialogCaolán McNamara
Change-Id: I4d3eb8aa354043d3ff57b4996db7b28ad25e0262 Reviewed-on: https://gerrit.libreoffice.org/64072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-30 17:38:58 +0000