summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-05-15Updated coreGabor Kelemen
Project: help 8f6a82ee50714e2d768f8fe49c60ce78a6764c51 tdf#107229 Update Save as Template window help page Sync with current UI Fix bookmarks and ahelps Translate German section ID Change-Id: I4f84bd25ef68dbcbc4c9b69c77f28ec31f0e86af Reviewed-on: https://gerrit.libreoffice.org/37618 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-15Updated coreGabor Kelemen
Project: help cad09f1811c9de671285a994e11c9fd351861ef5 tdf#107229 Fix Templates dialog title reference Change-Id: If9534b19aba76e9b541099bff15ba1a5181032c8 Reviewed-on: https://gerrit.libreoffice.org/37617 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-15Updated coreGabor Kelemen
Project: help d67bce5a4c44001fbf7ac384c2da23a909d4a8e5 tdf#107229 Translate a German section id It is redundant in shared/01/01110000.xhp anyways Change-Id: I6e8c7ee3a93375e9e7a1c65ab8c8f5a76a871128 Reviewed-on: https://gerrit.libreoffice.org/37616 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-15Updated coreGabor Kelemen
Project: help a64a3552f8550292e073625a656f16ae241a0dfd tdf#107299 Do not refer icons by their picture - it's theme-dependent Change-Id: I4537a820eaf7af5fc39995d6c9c01d963fb4ffd9 Reviewed-on: https://gerrit.libreoffice.org/37615 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-15Updated coreGabor Kelemen
Project: help e16902a941018fc12d04ae1137328fc1acf3b31f tdf#107229 Adapt First Steps page to new Templates window Change-Id: Ib715583ca4dcaca4362c5422db440ff73126ee09 Reviewed-on: https://gerrit.libreoffice.org/37614 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-05-15loplugin:useuniqueptrNoel Grandin
ignore SAL_LOG type stuff in the destructor Change-Id: If014382ca0c96edd3f2b325a28451d83b3d1f278 Reviewed-on: https://gerrit.libreoffice.org/37539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15remove some unnecessary lockingNoel Grandin
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15basic: Fix broken logic in VBA's unit testsTakeshi Abe
It should not be "OK" when no assertion passes. Change-Id: Ib6bab2d597a138468e96b4acf8c3be7abd112cca Reviewed-on: https://gerrit.libreoffice.org/37540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-05-15basic: Fix VBA constant vbNewLine with unit testTakeshi Abe
... making its value CRLF on Windows and LF on others. A winding road of regressions passed through it; first b680e352546dc614f3b30bbe212e6b415a6a6bf4, then 7beeced463648fc67defea2ad48d58dd42f0ca1e. Change-Id: I9e4da4a17436949b4fea35481b8355b4321cb268 Reviewed-on: https://gerrit.libreoffice.org/37500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-05-14tdf#43157: convert cppcanvas module away from OSL_ASSERTChris Sherlock
2nd attempt, this time I've decided makes more sense to just produce a warning. Change-Id: Iaf373a2d38e8f47266b00ea869de38a584788d45 Reviewed-on: https://gerrit.libreoffice.org/37598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-14tdf#107847 Make sure m_xContext is not emptyMaxim Monastirsky
Change-Id: I21d87b3a3d9732266e8c7d18cc07924700aaaafc
2017-05-14tdf#107197 Replace relationship URIFakabbir Amin
Hard coded relationship URI in sd/source/, sw/source/filter and oox/source/export/ directory has been replaced with method calls. Change-Id: Ie1b9542325fa4143bddea2582aa5e946094e457d Reviewed-on: https://gerrit.libreoffice.org/37433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-14tdf#58134 Reset Button in Options Dialogues does not Work with all Optionsmelikeyurtoglu
Change-Id: I99ef82f6b82674e67aa10d270361828545864f8b Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14tdf#96681: Add flag so we can actually work with SID_ATTR_BRUSH_CHARKatarina Behrens
Change-Id: I3e380304eae49290aec80b6aa0f078fcf6618de7 Reviewed-on: https://gerrit.libreoffice.org/37563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-14remove duplicate defineJochen Nitschke
Change-Id: I005fee0d142315a5304ae64c80a898b070a37088 Reviewed-on: https://gerrit.libreoffice.org/37601 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-14catch out of range values in strong_int constructorNoel Grandin
Change-Id: Ibcbb873fda6cb82ad8f575673705ba6cb16217e6 Reviewed-on: https://gerrit.libreoffice.org/37533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14tdf#58134 Reset Button in Options Dialogues does not Work with all Options.melikeyurtoglu
Reset Button in Language Settings > Languages > Language Of > User interface option. Change-Id: I3bc18af185330035cfd0a14b50912ef7a2847fab Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14osl: document file.hxx, swap order of E_ROFS and E_SPIPE to match file.hChris Sherlock
Change-Id: I085852e7c9fed285117f426e775f7ca2c123e4c0 Reviewed-on: https://gerrit.libreoffice.org/37594 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-14remove some unused forward declarationsJochen Nitschke
and unused TransliterationModules include in editeng Change-Id: I02e2d6acfde562a3e0cc8516eb16bb2ce8a810cc Reviewed-on: https://gerrit.libreoffice.org/37556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14accessibility: Remove useless locks.Arnaud Versini
Change-Id: I61bb14e33db1e32f0eb4c27cbb62e7f37006213f Reviewed-on: https://gerrit.libreoffice.org/37342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14Remove more %20 from style commandsMaxim Monastirsky
And fix a typo found in H5/H6 commands in Writer's style toolbar. Change-Id: Ieb8f701d055870040010da66a9a108bbd089bc0a
2017-05-14tdf#96444 Shortcuts are saved with non-parsed URLMaxim Monastirsky
MenuBarManager overwrites the item URL with the parsed version. This causes the keyboard shortcuts of style commands to no longer be found on subsequent opening of the menu, because they have spaces, which in the parsed version were replaced with "%20". Change-Id: I80b559203742922f70b7cec54b5a5ae57d3ef7dd
2017-05-14Revert "tdf#96444 Replace chr(20) with '%20' in style uno commands"Maxim Monastirsky
This reverts commit 939abe5a79674525ce134637947fe424a7e2332a. This causes styles to not appear as having keyboard shortcuts in Tools > Customize... > Keyboard, and style buttons that were added using tdf#106681 to not have their keyboard shortcuts in their tooltips. Given that the original bug is a local problem in MenuBarManager, I prefer to fix it there, rather than put workarounds all over the place, including those ugly "%20". Change-Id: I797f463df2b37ab69f73f357ab9d120697e0ff33
2017-05-14tdf#106999 Feedback for style commandsMaxim Monastirsky
The .uno:StyleApply command takes some arguments, which make it possible to apply any style of any type. The problem is that it doesn't provide toggle state to be used when placing such commands on a toolbar or a menubar. The reason is that sfx2, by design, can provide status updates only for the .uno:StyleApply command as a whole, ignoring any arguments that might be specified in the UI element description. This behavior is even documented in the XDispatch idl. wrt solution, changing the generic UI code to handle the specifics of an individual command can never be a good idea. The usual approach in such cases is to create separate commands which will handle the status updates correctly. This is however not possible in our case because styles can be created by users, and we can't predict their names and create separate commands for all of them (given that now it's easy to add style commands to toolbars and menus - see tdf#106681). One possible solution is to create a toolbar button controller on top of .uno:StyleApply, which will be able to translate its status update to a state compatible with the toolbar. The downside is that it won't work when placing such command inside a menu, and in general the menu code in framework doesn't provide any way to control individual menu items, only a whole sub-menus via a popup menu controller. To fix the menu use-case too, this commit introduces a "proxy" dispatch implementation, which can be used by MenuBarManager in a transparent way, as if it was the "real" application-level dispatcher. This means that the changes needed in MenuBarManager are minimal and do not over-complicate the code, which is a good thing (Alternatively, such dispatcher could be registered via the dispatch interception mechanism, but it will add no gain, given the current requirements, and just add more complexity). And to make it easier to reuse the code, the new dispatcher is also used for the toolbar solution. Change-Id: Ia73b0fa70fd4d1d59360b255aa8fd19570b971ee Reviewed-on: https://gerrit.libreoffice.org/37590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-14Allow destroying old MenuBarManager instancesMaxim Monastirsky
... after dispatch interception change. To reproduce: 1. Open the testdoc of tdf#102355 2. If not under gtk3 - Open several menus or sub menus. 3. Click the "Intercept" button. 4. Tools > Customize.. > Menus, make some change, click OK. Expected that old MenuBarManagers (except the top level) are destructed, and new ones are created. Actually the dtors of MenuBarManagers from step 2 aren't called (but they will be eventually called after closing Writer). The reason we keep active status listening is mainly for Unity's HUD (see my comment in MenuBarManager::Activate). But it assumes that Activate was called for all menus, which is done by GtkSalMenu at application startup, but not after dispatch interception change. Should we fix that, or maybe we can just kill this hack (along with some related code in GtkSalMenu) anytime soon, given that Unity is officially dead? Change-Id: Ia1cb24391b393e31c98355dc91833c7511a17cda Reviewed-on: https://gerrit.libreoffice.org/37589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-14Remove useless m_xContext.is() checkMaxim Monastirsky
Similar to commit 32680923221e1 ("Fix the copy-paste"). The original code was using this to get URLTransformer, but it was later switched to using m_xURLTransformer in ca00697e3dae9 ("CWS-TOOLING: integrate CWS oj18"). Change-Id: I05592915a651a9d8e0fc443f6adeb494704a99d8 Reviewed-on: https://gerrit.libreoffice.org/37588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-14osl: cleanup file_url.cxxChris Sherlock
Change-Id: I636b0a7765be8e6e96e90ff5a004dc452048541a
2017-05-14osl: osl_File.cxx unit test formatting cleanupChris Sherlock
Change-Id: I0e0386834e9cf76cd3c606ae01175aec9cf7e4f1
2017-05-14fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-14fix gdi resource leak with unreleased virtual deviceJulien Nabet
(copycat Markus https://cgit.freedesktop.org/libreoffice/core/commit/?id=289711c2a469bfbe06aef3b3870b65f9c788f56d) Change-Id: I3974609559dd44257d7c3e9e9544348d622953f6 Reviewed-on: https://gerrit.libreoffice.org/37586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-14handle test that apparently depends on our additional fontsMarkus Mohrhard
Change-Id: Ia2db679ee3e974da0f38d24257795d8c4b0ba1f9 Reviewed-on: https://gerrit.libreoffice.org/37560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-14tdf#107823: missing buttons in Presentation MinimizerJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=5d0e485e827057eee9fb2c997685690b710e7f34 Change-Id: I1864e7f7ac73fc13af82237f4f7d4dbaaa5733f5 Reviewed-on: https://gerrit.libreoffice.org/37584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-14fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13add basic universal content test, tdf#107828Markus Mohrhard
Change-Id: Ifb2a867cf2168a5ebf51d4a408d2e2a29032a764 Reviewed-on: https://gerrit.libreoffice.org/37580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13use empty document in orcus gnumeric import, tdf#107828Markus Mohrhard
Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d Reviewed-on: https://gerrit.libreoffice.org/37579 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13import stream on the LibreOffice side, tdf#107827Markus Mohrhard
This adds support for all LibreOffice content providers and non-ascii file names. Change-Id: I0a0fd0ab0c78ef039679516e7a3e880929e8f725 Reviewed-on: https://gerrit.libreoffice.org/37578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13accessibility: simplify and inline VCLXAccessibleList::clearItemsArnaud Versini
Change-Id: Ie32311850a0dc013e71e0456d7e6bfd8611e6e95 Reviewed-on: https://gerrit.libreoffice.org/37567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-13tdf#101885: fix crash in AccFrameSelectorJulien Nabet
Deal with no parent case 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 0 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 1 0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() () See https://bugs.documentfoundation.org/attachment.cgi?id=127141 Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43 Reviewed-on: https://gerrit.libreoffice.org/37575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-13Kill some code duplication, move shared code into private funcKatarina Behrens
Change-Id: I4898f49c5bc6d68e73b283bc5b4abbfa0b000a40 Reviewed-on: https://gerrit.libreoffice.org/37541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-13tdf#107811: expert config, deal no parent caseJulien Nabet
bt part: 3 0x00007ffff73c7ee2 in __GI___assert_fail (assertion=0x7ffff7ba5107 "false", file=0x7ffff7ba4ef8 "/home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx", line=1399, function=0x7ffff7ba6d00 <rtl_uString_newFromSubString::__PRETTY_FUNCTION__> "void rtl_uString_newFromSubString(rtl_uString**, const rtl_uString*, sal_Int32, sal_Int32)") at assert.c:101 4 0x00007ffff7b6a28b in rtl_uString_newFromSubString (ppThis=0x7ffffffef1b0, pFrom=0x55555e122230, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx:1399 5 0x00007fffa6e69136 in rtl::OUString::copy (this=0x7ffffffef1f8, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00007fffa6fed67b in CuiAboutConfigTabPage::InsertEntry (this=0x55555bda0b20, pEntry=0x55555e13eb40) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:874 7 0x00007fffa6fed415 in CuiAboutConfigTabPage::SearchHdl_Impl (this=0x55555bda0b20) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:848 Change-Id: Id9d1003a0e5e52abb878229e710e3fd4612789a1 Reviewed-on: https://gerrit.libreoffice.org/37568 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-13sw: fix gcc-4.8 buildMiklos Vajna
After commit 2308bea5ba38250133d7e344484e688ecaab6d8d (sw: change SwCursorShell::Pop() parameter from meaningless bool to enum, 2017-05-12). Change-Id: I64ecdf3ea16383c3938b32acdf69a78a31938ae6
2017-05-13osl: osl_File.cxx indent fixesChris Sherlock
Change-Id: I4bd6fc88950e8e6fd5648f4a76201c135352e406
2017-05-13osl: final cleanup of sal_File.cxx unit testChris Sherlock
Change-Id: I00201c5456904a537e349fa5e30be223b744fc5e
2017-05-13osl: osl_File.cxx header cleanupChris Sherlock
Change-Id: I9c76e2ef0ee7f28a51c0011ceb7e9e2f45f15ea7
2017-05-13osl: osl_File.cxx qa test - remove osl namespace prefixesChris Sherlock
Change-Id: Iacb82eff69ce5690ad0a054953835863c57dcce0
2017-05-13osl: osl_File.cxx qa file cleanupChris Sherlock
Change-Id: I4973cc0c8445f67cd2b3f6a9d158d6592c190447
2017-05-13osl: file test - space between C comment token and start of commentChris Sherlock
Change-Id: Idf44ed079f04b16f2e8d718358567cfafecbe388
2017-05-13osl: remove commented code from file testChris Sherlock
Change-Id: I85c41a6821e675874e9dae2ab4bfad35b7aebc59
2017-05-13osl: remove extraneous comment cruft from test sourceChris Sherlock
Change-Id: I1a7b5fc62359cd24593fadea1185db7e48c22961
2017-05-13sw: some old GCC apparently doesn't like that, let's try thisMichael Stahl
Change-Id: I1d6e74ae990faecfd3a28e0971ed6abe20bcef75
generated by cgit (git 2.34.1) at 2025-01-21 11:20:11 +0000