summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-18external/pdfium: C++20 comparison operator fixStephan Bergmann
Missing const leads to overload resolution ambiguity when a synthesized candidate of operator == for a reversed-argument rewrite conflicts with the actual operator ==, due to the asymmetric const-ness of the implicit object parameter and the RHS parameter: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:7: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.h:11: > llvm/inst/include/c++/v1/vector:1369:27: error: use of overloaded operator '!=' is ambiguous (with operand types 'std::__1::__vector_base<unsigned char, FxAllocAllocator<unsigned char> >::allocator_type' (aka 'FxAllocAllocator<unsigned char>') and 'std::__1::__vector_base<unsigned char, FxAllocAllocator<unsigned char> >::allocator_type') > if (__base::__alloc() != __c.__alloc()) > ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ > llvm/inst/include/c++/v1/vector:1359:5: note: in instantiation of member function 'std::__1::vector<unsigned char, FxAllocAllocator<unsigned char> >::__move_assign' requested here > __move_assign(__x, integral_constant<bool, > ^ > workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:384:24: note: in instantiation of member function 'std::__1::vector<unsigned char, FxAllocAllocator<unsigned char> >::operator=' requested here > m_FontDataAllocation = std::vector<uint8_t, FxAllocAllocator<uint8_t>>( > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:74:8: note: candidate function > bool operator!=(const FxAllocAllocator& that) { return false; } > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:73:8: note: candidate function > bool operator==(const FxAllocAllocator& that) { return true; } > ^ > workdir/UnpackedTarball/pdfium/core/fxcrt/fx_memory_wrappers.h:73:8: note: candidate function (with reversed parameter order) Change-Id: I48cfc8ce37287d9d3c0dec8c4d8b14b53de895d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86993 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-18calc sidebar numberformat alignment and arrangementandreas kainz
Change-Id: Id283e72ea0f54124df5daa5f74baef62b544e0f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86974 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-18Removed executable permission on fileAndrea Gelmini
Change-Id: Ia16ee2f0c5e3b3293fdc6c1cf2ba4145e752fb11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86999 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-17loplugin:redundantcast (size_t vs. std::size_t)Stephan Bergmann
...which happen to be found by 6efffbbfce9c27439f54970f7a569b069ce46eba "Improve loplugin:redundantcast for sal_Int... vs. ::sal_Int..." only on macOS, not on Linux: At least for my Linux builds, size_t is a typedef in my local LLVM installation's lib/clang/11.0.0/include/stddef.h while std::size_t is an unrelated typedef (but to the same type) in /usr/include/c++/9/x86_64-redhat-linux/bits/c++config.h. Change-Id: I98dd605cb7b4ba5fb9bd3902bd9b1ae960a804e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86994 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Adapt loplugin:duplicatedefines to include/premac.hStephan Bergmann
Change-Id: I2f79409f0fe2a18ba00585a35b6f1cf6243b7c1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Resolves: tdf#130045 dial control frame not hidden along with the controlCaolán McNamara
Change-Id: Idcdf3d748849fbe1ba1a6cce278373e349ba1e5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17can restore this test againCaolán McNamara
Change-Id: I82f5e8f9ce88d5662d391b0635dfc91b25d6126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17limit table spinbuttons width for sidebarCaolán McNamara
to the same width as the paragraph sidebar spinbuttons Change-Id: I980545b4186b25cb5ada473095ece8c77f99420a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17ofz#20169 Integer-overflowCaolán McNamara
runtime error: signed integer overflow: -2147478239 * 127 cannot be represented in type 'int' 72 points in an inch, TWentyInPoint TWIPs in a point, 1440 twips in an inch, 25.4 mm in an inch Change-Id: I4ea1c524cd9a16ab6e58ccf2a19fb8e41d68ffe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86955 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17show degree symbol in DialControl linked spinbuttonsCaolán McNamara
Change-Id: I792755f043109173606a78e947d5dc01f78c6849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to fb0dc909685c512937906fa1c1b2ffab912907d1 - tdf#98230 update of Insert (Text to File) help page - correct title and heading - correct item in Insert Fields Change-Id: Ie69f9a259725352536cc85daf3f2cc930e9bc0e4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86512 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-17Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 5d2af501f0d4d682911284a87d973b3384a0feb2 - allow localization of regular expression example Change-Id: If325dc340ff3be51fab3c3ce19433f5b7df25512 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86815 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-17tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"Xisco Faulí
This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137. Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86981 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-17m_aListenerContainer is effectively unused hereNoel Grandin
ever since initial commit Change-Id: Ia4cde1696edd26b8ddac3d093e043064d1cf87d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-17drop unused GALLERY_USE_CLIPBOARD undefCaolán McNamara
Change-Id: Ic06d08d9316b079e89081de75fbb550e73c276cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#98584 Correct import draw:transform values skewY and matrixRegina Henschel
Covers tdf#98583 and tdf#98565 too. TRBaseGeomety (API) uses for skewX the same angle orientation as written to file. But that results in mathematically wrong matrices. Change sign where needed. Vertical shearing is converted and written to file by LO as sequence rotation * shear horizontal * scale. Same should happen on reading. Because LO does not write skewY itself, I have used the angle orientation, that was used in OOo1.1.5 and that is used in Scribus 1.5.4. Import generates a transformation matrix from the draw:transform attribute. That is a mathematically correct matrix. It is applied to the shape via TRSetBaseGeometry. But that uses a wrong sign in the shear angle. Therefore conversion of mathematical matrix to TRBaseGeometry matrix is needed. The draw:transform attribute can generate a scaling, which needs to be applied on top of the scaling made from svg:width and svg:height. Such happens on import of skewY() and might happen with matrix(). SdrPathObject puts scaling form svg:width and svg:height directly into the coordinates of its points. It had ignored any additional scaling. I have add a part to detect and apply it. Change-Id: I7636b9feec432cf403e7c6ef8dbd6a769793d144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86244 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-01-17Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 3974b8c9cbd0321944d9fe9d9e5109c20d71fe31 - remove duplicated words Change-Id: I8c7d06ce3bec5bbd52adfaf8abb661d6ced6204d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86813 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-17odk: docs: remove the confusing sentence about "user installation"Michael Stahl
Better not mention an undefined term than to leave people guessing what it means. Change-Id: I589475303e215bd12cdc92e0f858d048052b6da6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86987 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-01-17tdf#126795 docx export and TabsRelativeToIndent: added unit testSerge Krot
Change-Id: I233a40133392757978b27666853a1fcef2e00a07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86878 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-17Sidebarpossize update for smaler height and better sizingandreas kainz
Change-Id: Ib26994ad706343c7d94e18644937e66e185b0678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17Clean up duplicated command dispatch test functionalityMiklos Vajna
Used in both Writer and Calc at 5 different places, so host it in unotest/. Change-Id: I013e6df471deb8693cf4ae62f0958b12e16fda7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86972 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17Clean up computation of preprocessed_command passed to ShellExecuteExWStephan Bergmann
* In the URIS_ONLY case (which is intended to open documents etc.), set preprocessed_command to the filesystem pathname the first time that is computed (and which will no longer fail for file URLs with fragment since 14b36a16b225bf7c988f118d499a7287c47cd83e "Remove a fragment from a file URL early on"). * In the !URIS_ONLY case (which is intended to run other programs), we will generally be called with aCommand already being a filesystem pathname. But even if it should be a file URL, it appears to be OK to pass that as-is to ShellExecuteExW: At least on Windows 8, passing "file:///C:/Windows/System32/notepad.exe" does start it. * The code for <https://bz.apache.org/ooo/show_bug.cgi?id=4789> "Hyperlinks doesnt works" should no longer be relevant: In the URIS_ONLY case, any fragment (called a "jump mark" in that code) has already been removed from the incoming URL now. In the !URIS_ONLY case, we should generally not be called with a URL with a fragment, but even if we are, it should be OK to pass that as-is to ShellExecuteExW and let it handle that (see above). * Similarly, the code for <https://bugs.documentfoundation.org/show_bug.cgi?id=54204> "Hyperlinks between documents not works if link contains anchor at the end" is no longer relevant for the same reason. Change-Id: Ia6ec80a30f6d0603bccc87b9d6dd93ca6a84c370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86975 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Avoid unnecessary explicit castStephan Bergmann
...which would only hide unexpected conversion failure, should it ever be possible to happen, from tools like -fsanitize=integer Change-Id: Ic2beab11078a40e16b92ce9ac868d296de028200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86977 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 3646d5561856014b0703a318a10d87897d48e626 - update Organizer tab for pages and styles -added access commands -added module sections in Organizer menu -improved conditional display of module-specific access commands -added <menuitem> Change-Id: Iac6a0a6b08f6ef5c41b9ed0415b687539c0dd80e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86672 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-17weld SvxFrameWindow_ImplCaolán McNamara
which makes .uno:SetBorderStyle in sidebartableedit work again Change-Id: I51faa21530171a47ee78863ddb312e1d9996326c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17don't ping-pong trying to get the perfect size for this widgetCaolán McNamara
Change-Id: I5a0358c9898b3d71666ec7b019b41e6508b3a748 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#129924 critical fix: use SvxColorItem instead of SvxBrushItemSerge Krot
Change-Id: I09b1e9fe53315974864c8d6947c7cb861f069a68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86953 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17Use std::vector in OInterfaceContainerHelper instead of SequenceNoel Grandin
instead of fighting the fact that Sequence is intended to be immutable getSequence() will become a little slower, but since getSequence() is called 5k times during 'make check', while add/remove are called 3M times, I think it's safe to say mutation is dominant. Change-Id: I23d127c93c589050d6c06c0da47871e1ebe7b52d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-17tdf#127619: external/nss: Load smime3 lib with a path on macOSStephan Bergmann
A plain dlopen("libsmime3.dylib",...) would search (among other places) DYLD_FALLBACK_LIBRARY_PATH, which when unset defaults to a set of paths including /usr/local/lib (so would erroneously find Homebrew's /usr/local/lib/libsmime3.dylib instead of LO's LibreOffice.app/Contents/Frameworks/libsmime3.dylib next to the calling LibreOffice.app/Contents/Frameworks/libnspr4.dylib). At least macOS 10.15.2 supports a "@loader_path/" prefix in dlopen, to find the requested library next to the calling code, so use that as a quick fix. (Should that turn out to be problematic, there is PORT_LoadLibraryFromOrigin in workdir/UnpackedTarball/nss/nss/lib/util/secload.c that might be useful in a more elaborate fix.) Change-Id: I8688606017a4b32a2dd55740f67b8fdb36fc5435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86966 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17tdf#129888 DOCX shape import: handle o:allowincellBakos Attila
(VML) and layoutInCell (DrawingML) attributes to fix regressions caused by commit 10f29d8bf05d44ca8bc11d34d1294ec17f8ac0f1 (tdf#87569 tdf#109411 DOCX import: fix shape anchor in tables). Position of shapes anchored to tables is calculated from the cell margin only if the previous attributes allow that. Change-Id: Ifcfcb7f4959aea522dd45dff00cefd1bb9f4edda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86922 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-17tdf#88496 DOCX: disable long repeating table headerLászló Németh
if the pages could contain only that, hiding the non-repeating table rows. This behavior is similar to MSO. See also commit 110781a3a27dffe9e6690839bdce993796a08331 (tdf#58944 DOCX import: workaround for hidden table headers). Change-Id: I646be45c6d2c5fe9e1df0badeee4583097dc79f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86928 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-17sw reqif-xhtml export: fix not needed font name/sizeMiklos Vajna
The only reason commit 4cd3c436923bfba281b1bf16d9785208a2119cea (sw reqif-xhtml export: limit values of the style attribute, 2018-04-11) missed these is because they write their css properties directly, not going via SwHTMLWriter::OutCSS1_Property(). Also adapt testReqIfWellFormed: its intention was to make sure that in case these properties are written, then inline CSS is used: that is true for XHTML, but not for ReqIF-XHTML. Change-Id: I4ceb2bb09187101baa6f4a74d65aaa4dc955511f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86962 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17android: Fix linking of liblo-native-code.so on x86_64Michael Weghorn
This is similar to commit c6dadf5035c8e1c31dbd3fccec167bd4a906bf54 ("commit android: Fix linking of liblo-native-code.so on aarch64."). Build previously failed with Linking obj/local/x86_64/liblo-native-code.so .../x86_64-linux-android/bin/ld.gold: error: cannot find -landroid_support clang++: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [../Bootstrap/Makefile.shared:62: obj/local/x86_64/liblo-native-code.so] Error 1 make[1]: *** [.../android/CustomTarget_lo_android.mk:18: .../workdir/CustomTarget/android/source/done] Error 2 make: *** [Makefile:282: build] Error 2 I quickly checked that the app actually runs on an x86_64 AVD and is able to open and display documents after successfully building with this commit in place. Change-Id: I92b3759af6a86a6717c287d035b6a1add3a9af7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85204 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-01-17sw reqif-xhtml export: fix not needed namespace for commentsMiklos Vajna
In general, all "foo" elements should be started as "<reqif-xhtml:foo" in the reqif case, but not for comments, which stay as "<!--". Change-Id: I841c0d8e448f670b9b42cb915154e6264f7f150a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86952 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-17tdf#42949 Fix IWYU warnings in svx/source/[a-e]*/*cxx and svx/qa/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I68110cdc5cff99a3bc15184c04ae309412511f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-17flush out unused Font objectsCaolán McNamara
Change-Id: Ifd6379b2cb6e5945ff509be8dc61c61bd70724c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17xmloff: create DrawingLayerExport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I1bb8e649cab67a2df4e40277758a47259f65a6c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86946 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-17lok: don't render shape selection overlays in lok mode.Michael Meeks
These are rendered client-side, doing it twice is a bug; also rendering of dashed-lines via drawinglayer decomposition is extraordinarily slow, so avoid it. Change-Id: I821f14699abd6bc9e7a6759c81edded2f792677d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86934 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-17Sidebar sd module slidebackground sync with writerandreas kainz
Change-Id: Ib7937013a2b494da1417f548589fc54b3299ea43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86950 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-17Sidebarparagraph update for smaler height and better sizingandreas kainz
Change-Id: I7fa3fe8f8156107f21a7cc7cbc86a32bbbe67549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86949 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-17For now, work around Clang 11 -flax-vector-conversion=integer in external/skiaStephan Bergmann
<https://github.com/llvm/llvm-project/commit/ b72a8c65e4e34779b6bc9e466203f553f5294486> "PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer" broke the build with > In file included from /data/sbergman/lo-clang/core/workdir/UnpackedTarball/skia/src/core/SkOpts.cpp:43: > /data/sbergman/lo-clang/core/workdir/UnpackedTarball/skia/src/opts/SkRasterPipeline_opts.h:713:26: error: no matching function for call to '_mm_and_ps' > return _mm_or_ps(_mm_and_ps(c, t), _mm_andnot_ps(c, e)); > ^~~~~~~~~~ > /data/sbergman/llvm/inst/lib/clang/11.0.0/include/xmmintrin.h:404:1: note: candidate function not viable: no known conversion from 'sse2::I32' (aka 'V<int32_t>') to '__m128' (vector of 4 'float' values) for 1st argument > _mm_and_ps(__m128 __a, __m128 __b) > ^ etc. We could pass in -flax-vector-conversions=all on the compiler command line for Clang 11, but that option is not understood by older versions, so for now just disable the failing JUMPER_IS_SSE2/JUMPER_IS_SSE41 code paths. Ultimately, the skia code will need to be fixed. Change-Id: If3202789f5f08bb40cf2ad8f6bcef5b5b3e462dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86939 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17use std::vector in ScMarkArray, instead of re-inventing the wheelNoel Grandin
and compact the ScMarkEntry record, this stuff shows up on perf profiles Also make these classes so we don't need to #include the cxx into a unit test. Change-Id: Id806385ae877a576ec25e7772c972448dada130b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-16ofz#20160 Integer-overflowCaolán McNamara
since... commit cf82475c785c47327cdc9d591d63d7a82dd1ac53 Date: Sun Dec 8 19:46:45 2019 +0530 tdf#114441 Changing sal_uLong to appropriate integer type in filters module Change-Id: I1f29e764c6405bb05dfd27da06bdc08cf8ae13cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86947 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16FirstLeft and FirstMaster not handled in CreateParentXTextBjoern Kirchhoff
FirstLeft and FirstMaster were not taken into account in CreateParentXText. Code calling getAnchor().getText().toString() on text fields failed, when they where contained in footers/headers of first left or first right pages. These cases are now implemented. Change-Id: I7fbe9eb95a3fa0d90ebd8432b8a315d186da6f64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86869 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-16ofz#20150 unknown readCaolán McNamara
since... commit cf82475c785c47327cdc9d591d63d7a82dd1ac53 Date: Sun Dec 8 19:46:45 2019 +0530 tdf#114441 Changing sal_uLong to appropriate integer type in filters module Change-Id: I22b56d9a0084e7d55a2299143eae3d806f976d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-16Fix typoAndrea Gelmini
Change-Id: I23e2029486d1bf5880cdd736ac124687158e9f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86941 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-16Fix typoAndrea Gelmini
Change-Id: I249fb621f4920a351da6480966cbdc0ea14fdd13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86940 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-16Fix typoAndrea Gelmini
Change-Id: Ic9e71624812ffa88a28af2888ef57d18c81b8404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-16unoxml: CDocumentBuilder::parseURI should handle non-file:/// URIs.Michael Meeks
The proximate symptom of this is of only some of the slide layouts applying in impress on Android. This is caused by not parsing the file:///assets/.../layoutlist.xml - which needs to use UCB and its cleverer osl/ file APIs. Change-Id: I22ed77170891c0ec136caaa29da69987a0e51a73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86900 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-16fix a crash in welded color toolbar menuCaolán McNamara
Change-Id: I7d11dfddc627e96710a6a16136292abefacc3ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-19 16:12:30 +0000