summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-04underline popup control possible to use outside sidebarSzymon Kłos
Change-Id: I48097007c7dc0439b33233939c1d73902dfeb679 Reviewed-on: https://gerrit.libreoffice.org/24491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-04notebookbar: rearranged layoutSzymon Kłos
+ only 2 lines of icons + large icons Change-Id: Ibabab3ce4893d457df4b957ad78886dbb8626c64 Reviewed-on: https://gerrit.libreoffice.org/24625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-04Rewrite fix for tdf#99353 in way that doesn't trigger loplugin:passstuffbyrefStephan Bergmann
c4acf692e858530b8353dd65876501eb38ce9bab "loplugin:passstuffbyref" had accidentally reverted 390ddd3bde617388e481b6747aa7bbea17d5ddf1 "tdf#99353 take the footgun away from FilterCache". Many thanks to Matteo Casalin for spotting it. Change-Id: I572b940cf215d6e83cac56fd8d2ac2f24b659579
2016-05-04loplugin:implicitboolconversionStephan Bergmann
Change-Id: I80f7967c5d537d1318890687631c0ceebef75fae
2016-05-04CPPUNIT_ASSERT(a == b) -> CPPUNIT_ASSERT_EQUAL(b, a)Miklos Vajna
Change-Id: I84dcd5ccc48d46f4aaa1ad33b341bfe7542757a3 Reviewed-on: https://gerrit.libreoffice.org/24631 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-04Correct value types for the respective function objects.Kohei Yoshida
Change-Id: I88771e976fe2a40fd4734b57dcf1728162ba559a Reviewed-on: https://gerrit.libreoffice.org/24629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-05-04Replace namespace ScErrorCodes with formula...Kohei Yoshida
and remove that 'using namespace' statement in the header... Change-Id: I2f994af5088ce6d1ffe92c8d36285a4f6fdd2248 Reviewed-on: https://gerrit.libreoffice.org/24628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-05-04update creditsChristian Lohmaier
Change-Id: Icb4a443dba8eb22e49fe622ed5ef7c84fabc901b
2016-05-04tdf#82160 Reset mouse pointer if doc loading failedMaxim Monastirsky
Change-Id: Ib05226345c4b83d9190839de5cc04068ce1879d8
2016-05-04LoadEnv::getTargetComponent() is supposed to return nothingMaxim Monastirsky
... if loading the document failed. Make sure that's the case also when the frame containing BackingComp was about to be recycled. Can be tested by trying to open password-protected odt, but canceling the password prompt. Change-Id: I733357b3a961fd88db010dd8eb89e01f0cad10fa
2016-05-03Enable Any functions on sal_uInt16 for LIBO_INTERNAL_ONLYStephan Bergmann
...where sal_uInt16 no longer clashes with sal_Unicode after e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native C++11 type on windows". This allows to consistently use Any ctor instead of makeAny, regardless of argument type, in LIBO_INTERNAL_ONLY code. Change-Id: I9acdcc48be71a90d17013959c8275454e8fa01a0 Reviewed-on: https://gerrit.libreoffice.org/24620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-03NameToken with Sheet instead of boolean GlobalEike Rathke
... to transport an actual sheet number for other-sheet-local names within names when importing OOXML. Change-Id: I00f2ffe07271c1c2a8ce9e10514e10872396f566
2016-05-03tdf#99383 vcl: don't dispatch events from SolarMutexReleaserMichael Stahl
Having SolarMutexReleaser effectively do Reschedule() on WNT and not on other platforms doesn't seem such a good idea. Let's try to restrict it so that it still calls ImplSalYieldMutexAcquireWithWait() but no longer dispatches messages, timers and idles. (regression from 482c52e91fe41a52e68827e9bf64a9736427d517) Change-Id: I52a2c88e9c2473e35909bf270b9e3ae7acbe0d17
2016-05-03bump openssl to 1.0.2hChristian Lohmaier
Change-Id: I1e7c090ff58dc296641a1ce00a2ca4189e9e4156 Reviewed-on: https://gerrit.libreoffice.org/24617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-05-03tdf#42949: clean up includes in include/oox/drawingml with iwyuJorenz Paragas
Add includes in other files to fix compiler errors. Change-Id: I566e2e081094cb074d20afbe7ceee49f759c725b Reviewed-on: https://gerrit.libreoffice.org/24510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-03C++11: disable ctors with delete in include/Jochen Nitschke
replace the old declare and don't implement pattern with C++11 delete keyword no need to hide this design choice behind access restrictions Change-Id: I7e8430a07189aa48514a4613c3a8c2950b230f49 Reviewed-on: https://gerrit.libreoffice.org/24495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-03Trivially improve sal/types.h code indentationStephan Bergmann
...to trigger rebuilding of PCH on Windows after e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native C++11 type on windows" Change-Id: Ia1cafb8a2f207f34b6fb1cb53fbaf23d90e6b296
2016-05-03Handle wchar_t as native C++11 type on windowsDavid Ostrovsky
The option /Zc:wchar_t- prevented to use wchar_t as a built-in type according to the C++ standard. In Visual C++ 6.0 and earlier, wchar_t was not implemented as a built-in type, but was declared in wchar.h as a typedef for unsigned short. Now, years later after the end of life this outdated toolchain, there is no reason not to use native type. The only issue could be the ABI compatibility. But on a quick look at least, it looks like none of the mangled C++ symbols in the stable URE interface actually depend on wchar_t. We forgot to get rid of /Zc:wchar_t- in 5.1. Do that for LibreOffice 5.2, though. Change-Id: I8d6b380660859efa44c83c830734978d31d756a0 Reviewed-on: https://gerrit.libreoffice.org/22589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-03IFS/SWITCH propagate error only for active paths, tdf#97831 follow-upEike Rathke
Change-Id: Ief07f0d582e2f283a3ede88a7d202e8cff0e14bf
2016-05-03Clean up makeAny functionsStephan Bergmann
Let the templated makeAny(v) just call Any(v), so that any special handling of argument types needs to be only done for the Any ctor, not also for makeAny (both the original makeAny implementation and the Any ctor implementation internally use cppu::getTypeFavourUnsigned to determine the UNO type, so this does not cause any difference in behavior): * The specialization of makeAny for bool can be dropped. * The overload of makeAny for OUStringConcat is replaced with an overloaded Any ctor, so that Any(s + "foo") works now, too. Curiously, only the Any ctor had been deleted for a sal_uInt16 argument (which can conflict with sal_Unicode), but not makeAny. So introduce a specialization of makeAny for sal_uInt16, so that that continues to work. (For backwards compatiblity in the non-LIBO_INTERNAL_ONLY case; and in the LIBO_INIERNAL_ONLY case we're moving away from the sal_uInt16/sal_Unicode clash anyway thanks to C++11 char16_t, so it is arguably better to allow makeAny for sal_uIn16 than to prohibit it.) Change-Id: I7803703769730024863bb4e5b1b3416b81bd8960
2016-05-03tdf#97831 [part] Add Excel 2016 functions to CalcWinfried Donkers
Functions IFS and SWITCH. Change-Id: Ic43d42a933bcac883e9aa2213dd4ddeddf45abf0 Reviewed-on: https://gerrit.libreoffice.org/24424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03-Werror,-Wpessimizing-moveStephan Bergmann
Change-Id: Ic20ae0c0534220a2613b73a2bd2e1aa277aecce9
2016-05-03loplugin:passstuffbyrefStephan Bergmann
Change-Id: Iaaaa0569a3e16bd79eeb7830ab9fb4be6ae57f98
2016-05-03NULL -> nullptrStephan Bergmann
Change-Id: I7e4e36fbff89cb45c01a11dc70c4e6f17fe3bc38
2016-05-03NULL -> nullptrStephan Bergmann
Change-Id: I94d0df867b6ef59cf6485e4cee7ac655155f9b87
2016-05-03NULL -> nullptrStephan Bergmann
Change-Id: I0bd2dc2e2ed1f699133e3e7753359b969fbee322
2016-05-03use unique_ptrDavid Tardon
Change-Id: I28615a645e6e4763bb03362a90da93a818985a78
2016-05-03drop obsolete commentDavid Tardon
Change-Id: Iad565ccd92b4518ee57f10b65ca4d8ca0730474d
2016-05-03tdf#99353 take the footgun away from FilterCacheDavid Tardon
FilterCache::impl_saveItem changes the properties of a config. item one-by-one. But it also listens to the configuration changes and reloads the whole item from the configuration on change... Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03Prevent Any ctor from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens to work in environments where sizeof (bool) == 1. The simpler alternative is to use the Any ctor template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: I0f72c73a088ef96e069c3ed8c78546b16d89b50a
2016-05-03sw: HTML filter: avoid turning on Undo with ridiculous hacksMichael Stahl
SwHTMLParser::SetControlSize() loads a "hidden document" into the same model (!) that is currently being imported (!), just so it can get a awt::XControl from the ViewShell; unfortunately creating the ViewShell happens to enable Undo too, so turn that off again. This avoids triggering the assert in SwRegHistory::InsertItems() on kde122884-1.html Change-Id: I3d8fcd5c43bcb8e7ed8775710acbc2d40f2ffdd0
2016-05-03tdf#97835 No decimal separtor for empty decimalLaurent Balland-Poirier
If decimal part is empty (with #) decimal separator should not be added. It was not removed if there was text after value. Change-Id: I891cad8b6bec0f27f4cef8aea80c5dad264f062d Reviewed-on: https://gerrit.libreoffice.org/24586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#61996 Skip quoted text in number formatLaurent Balland-Poirier
Quoted text should be detected and skiped before detecting conditions Change-Id: I1c78fed7f543fb335fbb8ec9ed50d9ab9dd10aa7 Reviewed-on: https://gerrit.libreoffice.org/24550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#98644 : better error message when wrong password enteredSzymon Kłos
Change-Id: Idf4da8000cce43cb66cb94fdfc8be8a3d6909fa6 Reviewed-on: https://gerrit.libreoffice.org/23475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-03tdf#31449 Correctly test if fraction has no integer partLaurent Balland-Poirier
Test if fraction format has no integer part is modified to take into account all cases: ??/?? or ##/## and do not detect false positive like ? ??/?? Change-Id: Ia8677a5ad496e5df56ce6bf1290323555e46ba0a Reviewed-on: https://gerrit.libreoffice.org/24540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03genlang .ulf uses LngText as id.jan Iversen
Added fixed subid for .ulf files Change-Id: I9e882e3ab40e334c7d504d583b8e515d9dc36d6b
2016-05-03genlang .xcu dot handling and level func for .srcjan Iversen
.xcu stores a '.' between keys and keys with no name count .src has commands without name (identifier used instead) Change-Id: I135c5f5594c429ebc1b278dbb7d5709b7b8ca119
2016-05-03genlang .src single line macrojan Iversen
Macros do not always end with \\ only those for translation added #define exception to the lex layer. Change-Id: I656bb8776d970288c243302cdc74a0afd975975e
2016-05-03tdf#99529 sw: don't pop up input field dialog before inserting fieldMichael Stahl
The dialog calls SwEditShell::UpdateFields(), so if there is already a existing field at the current cursor position it will be "updated" before the new field is inserted. Change-Id: I8ddbbe00534950759781a1ce8d0dca0376663462
2016-05-03tdf#98512 sw: add unit testMichael Stahl
... and fix the SAL_WARN not to warn spuriously. Change-Id: Ic951fc0d811e5cab39989285d34bdd2fff8f95fd
2016-05-03Better label for .uno:OpenSmartTagMenuOnCursorMaxim Monastirsky
Change-Id: I4aa578ecdfeaa23b7d665b59b7719f2e0258eac7
2016-05-03Resolves: tdf#98940 (-1 not mapping to maximum string length anymore)Matteo Casalin
Change-Id: I58e4a63bce17b880a97c7ccfb4d42dfb930e54c5 Reviewed-on: https://gerrit.libreoffice.org/24268 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03tdf#99211 Use the restart dialog for notifications about restartirem
Change-Id: I2093e99d7b377285f6b3248a90072f0dea12f732 Reviewed-on: https://gerrit.libreoffice.org/24556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03Remove unnecessary setBOOL, makeBoolAnyStephan Bergmann
Change-Id: Id82c3f352fcc2d4dafad877517098cb6f5d046d4
2016-05-03Remove Edit -> Plug-in as no longer usedBryan Quigley
This functionality seems to only have been used with NPAPI plugins. They've been previously removed. Per the help text, if it is still used by anything, you can use the context menu instead. MN_READONLY_PLUGINOFF also appeared to be unused, so removed. More code might be removable, but would affect activate on click/visible. Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d Reviewed-on: https://gerrit.libreoffice.org/24500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03starmath: Avoid C-style castTakeshi Abe
Change-Id: If8fdb9def831ea9720c3cad1379be47aba7dec30 Reviewed-on: https://gerrit.libreoffice.org/24584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I9c8d41faf903f2d4ec26338a19be1328a68c69db
2016-05-03tdf#95707 RTF import: handle device-independent bitmapsMiklos Vajna
See <https://msdn.microsoft.com/en-us/library/dd183374%28v=vs.85%29.aspx> for more info about the header structure that has to be prepended to the real data to make our BMP import filter happy. Change-Id: Iabdf4cd169b82ea951d1c1b12432d97d61b7af51 Reviewed-on: https://gerrit.libreoffice.org/24604 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>