summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-17loplugin:referencecasting in connectivityNoel
Change-Id: I4b91c3e4a225323235ea37d77f0f96600bf412be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110969 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17Move DXF reader from filter module into VCLTomaž Vajngerl
Change-Id: If1a933256401c1a971f581d1b389ca06fd77eaae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17tdf#127471 correct EMF/WMF im/export for scaled fontArmin Le Grand (Allotropia)
If FontScaling is used, system-dependent data is held at vcl::Font Width(). Already if not scaled, we have three definitions: Width is zero, Width is equal to Height (unx) or - on Windows - Width equals avgFontWidth. If used it is W!=H where on unx Width equals Height multiplied with the scale factor. On Windows, this is Width multiplied with the only there existing avgFontWidth. Unfortunately that is ex/imported (since ever) undetected to EMF/WMF thus making EMF/WMF files containing FontScaling system-dependent - on which system was LO running when creating the file? The error can be seen when loading such a EMF/WMF on the vice-versa system, the FontScale is very ugly and wrong. Since EMF/WMF *are* Windows-specific formats the Windows-like definition is the correct one. This change makes all other systems export that now, and adapt on import to their system- specific definition (assuming coming from Windows). As can be seen, the difficulty is that these adaptions are necessary on non-Windows plattforms, but these do not have that avgFontWidth available. Thus I made a deep-dive investigation and multiple experiments to create a as similar as possible value to apply the needed calculations. For details and discussion refer to the bug description. Change-Id: I983fb6d882e2e8fccf9c8460f01509201d8157f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111000 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-02-17Avoid crash in online on a document with commentsAron Budea
Crashed on a specific doc with the following backtrace: Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault. 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 71 const SwPostItField* GetPostItField() const { return mpField; } 0 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField() const (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 1 0x00007f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&) (this=0x557e1d985a10, rJsonWriter=...) at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337 2 0x00007f4823216534 in getPostIts(LibreOfficeKitDocument*) (pThis=0x557e1d93c890) at /.../libreoffice/desktop/source/lib/init.cxx:3425 ... Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110958 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-17loplugin:referencecasting in configmgrNoel
Change-Id: Ib74468d3a6a40b32896c58b0d30e3121ee834e1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in cppuhelperNoel
Change-Id: Ie19f01a35ef656f5532c5ec41dbed1c0e4cf77d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in cuiNoel
Change-Id: Id73971bdd986101eeb53bf0b140ef6a7c72191a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17pdfium: eliminate FPDF_SIGNATURE from public headerMiklos Vajna
Change-Id: I9c8297c69ca359d861c8506e41c069692331eb8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111005 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-17loplugin:referencecasting in chart2Noel
Change-Id: I4864b5f73a65de04ed3e3524e1331094049b1263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in canvasNoel
Change-Id: Ic802d6593db053bb31c3463e67b63399b5f26d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in comphelperNoel
Change-Id: If826cd7c6818d9cc0662321ff31e0594fe6d48e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in test..toolkitNoel
Change-Id: Ia290ff4849f4d7eda978c7b1e2c7f36de744056f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17Move PBM,PPM reader from filter module into VCLTomaž Vajngerl
Change-Id: I1ce998575f8d204045fabea184e80e71308a16b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111019 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PCD reader from filter module into VCLTomaž Vajngerl
Change-Id: Icd23d1343f5231c09dd8197943ca472f4b573bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111018 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PSD reader from filter module into VCLTomaž Vajngerl
Change-Id: I53b11be6e9eb0013f017b2da5745ff525ca79c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111017 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move EPS reader and writer from filter module into VCLTomaž Vajngerl
Change-Id: I1646f72d6a1db176e4520f8f64321646a26f054e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111016 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move RAS and PCX reader from filter module into VCLTomaž Vajngerl
Change-Id: Id846abf257b598489a59ebf9b62b19840a950322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111015 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move MET reader from filter module into VCLTomaž Vajngerl
Change-Id: I478ef775bc73349094f88012ceb57b1712a27f55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111012 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PICT reader from filter module into VCLTomaž Vajngerl
Change-Id: I6d3a28769ff3bffa3970a4ab6ab2384bb0aebbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move TGA reader from filter module into VCLTomaž Vajngerl
Change-Id: I0fea5d6e75c6bfd05ea91ed7b92aaacfcc5ec177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111010 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17vcl: add TIF case to GraphicDescriptorTestTomaž Vajngerl
Change-Id: I2e2724fda545e67777c1101b33cc10483f73b3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111009 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Improve code for Protect in viewfunc.cxxAnshu
Change-Id: If197f74945b54675c304d23cac802e3769599554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110205 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-17update Find & Replace icons & Show Drawing iconRizal Muttaqin
Change-Id: Ic9288b85bb5df595cac537988e8fd3db040cb329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110990 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-02-16tdf#137208 Assume that dladdr provides an absolute pathnameStephan Bergmann
3dfb38a45d6495d357c3359b5b02cde871df6f67 "added getUrlFromAddress (#88338#)" had introduced the call to osl_getAbsoluteFileURL for no documented reason, but it looks unlikely that any relevant implementation of dladdr (as called by getModulePathFromAddress; and where dladdr is a non-POSIX extension on the various platforms) would provide pathnames that are relative to the process's CWD. (Instead, add a check whether osl_getFileURLFromSystemPath succeeds.) Change-Id: If291e9fdf63fc3f42ba7c7e3138d7db5328ed165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111004 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-16tdf#139511: sd: Add UItestXisco Fauli
Change-Id: I21bd6c0643333cdf98d65b3fa3f141dc6ddfa937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110982 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#140252 unit test Controls in Calc are always on layer 'controls'Regina Henschel
This is the missing unit test for the case of drag-created controls in the fix in commit 1d53f3709de2956f14db31677b6c461f33843bd9. Change-Id: I3afce044588e6b5d850d948dd0cbc4df9185029d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110959 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-16uitest: sc: test charts are pasted in a new document...Xisco Fauli
... when the source sheet has a dot in the name I found this problem while working on another UItest. This started to work after b9652803096b68a33702601aac52e78c8a4250c6 Before this commit, the chart wasn't even pasted, due to a2e6f31c6f90e446d1462e7c80f6b1317f7825bc. Before this commit, the ranges in the pasted chart were incorrect. Not sure when this issue got fixed though. Anyway, let's add a test for it Change-Id: I152d569bfa04a0e3e6056e39b9ee59955bf9e1d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110993 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16WB_HYPHENATION is newly unusedCaolán McNamara
Change-Id: If1fd94b1a0f572fb1bc40f2098079408c9916ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16move FixedImage to toolkit-only headersCaolán McNamara
Change-Id: I7ae18ef3225b4ca1448a2a3b0fccfc2206f7a5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110995 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16merge OStartMarker with its childrenCaolán McNamara
just draw the label + image directly instead of moving vcl widgets around the place to get the same effect Change-Id: I0b77cba9543c7886ab20dd4881fdb1d20679b734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110994 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16loplugin:referencecasting in stoc..svtoolsNoel
Change-Id: I806ffb3ab06731c61fe9c58788aabf00a05e980f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16loplugin:referencecasting in UnoControls..unoxmlNoel
Change-Id: I42f216b6115be693a4e57d70f6cbbf11b62ec185 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16convert m_aTypeImage to weld::Image and move inside OTableWindowTitleCaolán McNamara
Change-Id: Ib3370a2a44761b2f4f5c6d0ade86d2f640c9fc48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16weld sidebar "too-narrow" CloseIndicatorCaolán McNamara
Change-Id: Ifda6f56ba51d46bd35065c2230f39e837b037096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16Remove dead "defined(ANDROID) && !defined(DISABLE_DYNLOADING)" codeStephan Bergmann
4b7e701024219be48b7f8154a508c79cb0a6fdc1 "Use DISABLE_DYNLOADING on Android" has removed lo_dladdr, so this conditional code is apparently dead, and its clean-up was presumably forgotten in that commit. Change-Id: Icf8e4056366f90837c48dd2fcf45936f8015eb43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110981 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-16ofz#1473106 Uninitialized scalar fieldCaolán McNamara
Change-Id: If38a5ad4e5db287a3105bb0faca031bc98c47fd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16weld OTableWindowTitleCaolán McNamara
Change-Id: I466b73b1135c1336e3c94432f220b52343fe00d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16Fix index out of range when vml-shape-types is missingMike Kaganski
See https://lists.freedesktop.org/archives/libreoffice/2021-February/086844.html Change-Id: Id38061c03dc80700872b41f54c679ee3120df9f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110988 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-16tdf#120207 Change the order of default Hebrew font choice for spreadsheetsEyal Rozenberg
* Most importantly, Liberation Sans and Arial will be preferred over Nachlieli CLM, as these are more readable at smaller sizes. * Some other reshuffling of the order Change-Id: I5dca98956ad0d8f77af1002daa7462991bafd916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110790 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-16loplugin:referencecasting in slideshow..starmathNoel
Change-Id: Id9dc0ac27897c8a3650424db65d3a05e2fe418f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16SetSubnodesBinMo fix node order for diagonal operatorsdante
Change-Id: I72a95f91e9bed9aeb6da5f9621f2ba334f63f17c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16loplugin:referencecasting in sfx2Noel
Change-Id: Id24f477ad6cc964215cc04852efc369247f70a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16show context menu on right click in treeviewCaolán McNamara
Change-Id: I2a124d63309130b0488e30169aa54ffbc736999f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16tdf#66409: sc_ucalc: Add unittestXisco Fauli
Change-Id: I911368d5e5c90f4b0225cfe47b6b912cac9fbbdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110978 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16uitest: sc: move these tests to 'sort' folderXisco Fauli
Change-Id: Ib91417c3edd5f449074f55b2a1628e4ee2df4a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110980 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16Use some more o3tl::convertMike Kaganski
Change-Id: I811a00592c3ac5d8cc551090b847f80fc6673032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110918 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-16Revert "Revert "replace SwClient by SvtListener in SwGrammarContact""Bjoern Michaelsen
- This reverts commit 89d770f9727b9e7eddf933c96771df98082b3efb. - ... and replaces the old Notify() with a simpler check for the Broadcaster. - note however, that the ASAN use-after-free reported in the revert was not reproducable locally even with a hundred runs of unoapi_1, so cant claim to have removed what was not there. The fix is just a guess of what might have happened (namely: that the TextNode was locked on destruction and therefore do not send a RES_OBJECTDYING message). Change-Id: I3ff53d8f8537470573cf06314947d9b23bdf578b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110885 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-16loplugin:referencecasting in accessibilityNoel
Change-Id: If66b3c1829b02298b7c9c31172d2a66ad11dce30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16Resolves: tdf#66409 CELL() 2nd argument range take top-left cellEike Rathke
... instead of the otherwise usual intersecting position. Change-Id: I0edbf32b39e45e1c8fe8fcd7af2c84380aa4cd6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110951 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-02-16Improve checkExtensionStephan Bergmann
Change-Id: Iff416a9c5930ad5903f7ee51a2abbc94d5f40800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110970 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-14 02:50:48 +0000