Age | Commit message (Collapse) | Author |
|
anchored to characters or paragraphs.
Tracked deletions and insertions weren't imported,
if they contain only images anchored to character,
resulting loss of the document content: i.e. deleted
images were reappeared, as not deleted images.
Note: because change tracking of the OpenDocument
and Writer supports only text range based changes,
the fix is a workaround using zero width spaces
to create an invisible text around the anchoring point
of the images. This workaround is not used, if it's not
necessary, i.e. if the image is part of a bigger
deletion or insertion, which contains also text, not
only an image.
Change-Id: Iaae6aae2c01191512c71117a0c788a4147c4cae0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118557
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
I have found that in both DOC and DOCX numbering bugs,
many can be fixed simply by not assigning Chapter Numbering
at all. So set a minimum threshold to deter useless assignments.
[Note that a LO round-trip should save as numId 1,
and thus a single entry would make it qualify.
For Word-authored documents, this threshold means
at least 3 Heading X styles (which matches LO default workflow)
or 6 out of 9 Levels defined for non-heading styles.]
Change-Id: Ic3d1c800a703721e7ab5302e274ee1eeda496ac0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118543
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
The handler separates the MetaPolyLine::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: Ic800b13cdca5bc6ffc00f1564e5a05303c445c5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118566
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaChordAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: Id4251e270bab9dc609c220ad0f304ee38b9ed2bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118565
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaPieAction::Read from the metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I7b601a6ef03f4b0e777558e36aff87cd24588573
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118550
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaArcAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I2d6e6bfa53b00811ba473db7e4d2255a1ca4becf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118545
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaEllipseAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I40c5f7c2993dd34cb370d909e251be9a588f6168
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118473
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaRoundRect::Read from the metaact.hxx
Read Implementation is now in SvmReader.hxx
Change-Id: Ic0b29b2119db3417c2feba8dc5fd44215256c040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118433
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaLineAction::Read from the metaact.hxx
Read Implementation is now in SvmReader.hxx
Change-Id: I27bfcc4323e8d351e8277898334fc623d6a53dd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118403
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaPixelAction::Read from metaact.hxx
Read Implementation is now in SvmReader.hxx
Change-Id: If45e8c46c28957c4f11c95d8a0ebbaeab01894d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118399
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the MetaPointAction::Read from mataact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: Ic383be9029f5a74479c511b29cf8759815d55713
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118398
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The handler separates the read method from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I824a06d9018b473fd2398802d69b4952d33c4ada
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118396
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
case RES_VERT_ORIENT + pItem->StaticWhichCast(RES_VERT_ORIENT)
is more likely to match than
case RES_VERT_ORIENT + static_cast<const SwFormatVertOrient&>(*pItem)
Change-Id: If6ce65ae26b1088acb41b390a4fc8c1a69c141bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118590
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Style names for Calc are updated to current style names. As
default styles shown by sidebar dropdown are hardcoded, styles
Accent 1, Accent 2, and Accent 3 were added to offer a few
more options.
Change-Id: I0e4b00f7e8a64e1ded077c559ed208fe71d784ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118038
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
...and move "10.0", "10.10", and "1.5.0_010" from badVersions[] to good
versions[] to make the test succeed (assuming these shall indeed be classified
as good by now, presumably due to changes to the SunVersion implementation in
the meantime)
Change-Id: Ia7cf9b0e607743a5e0534078c0221c1423f6cfb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118570
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I2580dafcf8792bf4b11db78988db8c2976e4545c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118569
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
... to not end up with "BOOL"E"AN" instead, which is a date type
with an era year and literal strings.
This never worked but only was uncovered by
commit ce4fc2fc08be8ea2773194e303ed42d2579e93a0
CommitDate: Fri Mar 2 20:27:45 2018 +0100
Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean
if the format also had to be converted between locales.
Also preserve boolean equivalent formats during Excel export and
try hard to convert back as much as possible if a literal boolean
string format is a Boolean equivalent of the target locale.
Change-Id: I54f65c276cbf7bb99e960b6d7053c5fa95fbccb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118591
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Icfc2f0c39fc223c94c1a3f038a4c186349be4fa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118587
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If0b83e62e6c9905b1ae391fbed7c43b379dce5db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118586
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I656a8c8506d7905ece3ff1b0547c82c42b234ab6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118585
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6a6202783d30da2487e4033bcbe859e72f959f12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118579
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0df18e50ad8955b3e5933287cba2ddcee02fec31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118577
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4d9d391239a57ab81ce6f513a713ac91846b61d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118576
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to dc68b55ae08e9445e3ec982b7d5e91a4b522b9a1
- tdf#143232 Set correct name for shrink/expand in Help
Change-Id: Ia95edf96335a45743fc40e253d35d4b5de7c4f80
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118580
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
and implement for the GMenuModel case
Change-Id: I57da4d984f6a743043cd82c32edff35115fe94c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118575
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I994a0c6aeb2bfabec01999e4722ac0f72a3f359e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118574
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 7c10c96ab3e221764a797442b0a04e8013584815
- Fix typo on sf_methods.xhp
Change-Id: I10ac058ca55a5fd7a5b606e0ad48f28399563b5f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118578
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
reduces time by 20% for me
Change-Id: Ife78248fd36099298eb2401b362f16a1ae3c0434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118534
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Filter "greater than" or "smaller than" (>, <, >=, <=)
conditions according to the cell number format.
Regression from commit: d5c2584bf36d21580db677b231c57f99f49aa2cb
(Related: tdf#140968 avoid duplicated filter values)
Follow-up to commit: 1f755525189884e4b2824889a6b9dea8933402db
(tdf#142402 sc UI: store formatted values in standard filter)
Clean-up for commit: d5c2584bf36d21580db677b231c57f99f49aa2cb
(Related: tdf#140968 avoid duplicated filter values)
Change-Id: I1284892398c9964ca5407b4d617a617f20341107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118272
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
These two SIDs have the same ID, which is fixed now:
* include/sfx2/sfxsids.hrc:
#define SID_NOTEBOOKBAR (SID_SVX_START + 338)
* include/svx/svxids.hrc:
#define SID_ATTR_TEXTCOLUMNS_SPACING ( SID_SVX_START + 338 )
The symptom tdf#143204 is that the tabbed interface was hidden in Impress
or Draw, which is now fixed.
Looking at b66d87086804460c1986df1b832fd6b2ea075a90 (2014-04-01) we read:
As commit 669ad519902e21e0cb3537fb7e203987f75a4077 (colliding
SID_SVX_START based ids, 2013-06-24) suggests, new SID_SVX_START-based
SID's shouldn't be added to include/editeng/editids.hrc. However, if it
was done, at least add a comment about it to include/svx/svxids.hrc, so
it becomes obvious that the two slots have the same ID.
Also in include/sfx2/sfxsids.hrc:551
slot IDs from SVX (svxids.hrc) ------------------------------------
These SID_SVX_START entries came from include/svx/svxids.hrc, avoid
accidentally colliding entries with include/svx/svxids.hrc and
include/editeng/editids.hrc. Only add new SID_SVX_START entries
to include/svx/svxids.hrc
Change-Id: I5e8c14bdbaa72f1b030a686dd5fffc9ae8dd1306
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118459
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I9f762dea7f2a8daadfbe4ee693caf5a40442aabe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118573
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic90bd9f87bfdb8e7de6d5546ea1f8c33236e6469
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118572
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I637dcc4bc8fe31e1c8832ada84f844976ee44da7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118571
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to b46d9178afe749e720ef1a3ba3666e153111fc32
- tdf#143229 Remove empty paragraphs
Change-Id: I4dbb2eb2cfbb140a129c02290642a777c8f9f327
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118496
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
commit 2a694f9e0e7789b4b3b792a9eedd29366fa10c1c
Date: Wed May 6 14:08:07 2020 -0400
lok: fix the window type of the formatted field control
had introduced the new 'WindowType::FORMATTEDFIELD' and set
it for the 'FormattedField' control (instead of using
the previous default value set in the 'SpinField' ctor,
which is 'WindowType::SPINFIELD').
So far, this type was not explicitly handled when
creating the XWindow peer.
Handle it just the same as 'WindowType::SPINFIELD'
and return a new 'VCLXNumericField', which e.g.
makes sure that a "proper" accessible is created
and thus alues of a spin field are announced by
the NVDA screen reader (again).
(See also
commit 33cac418db78f64f7fa84b8e65c01c2b02cf17a7
Date: Fri May 29 16:53:59 2020 +0200
tdf#133498 Make native drawing of FormattedField work (again)
which had fixed a similar regression elsewhere.)
Change-Id: Ie8a4d279a12a1b83a9cf97f1304d84214b3a2a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118568
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Different header of the first page was never imported
(related to the missing UI support), despite its working
ODF export.
This commit sets the values of those options at ODS file load
according to the "display" attribute used to hide or show
a particular header/footer.
Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388
"tdf#121715 XLSX: support custom first page header/footer".
Change-Id: I3409ad94a4d3ff86fd7f6d8afede3e7603024515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117788
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
This reverts commit b3541dea4889b9d0039554f87bd16e55189cf8b1.
Reason for revert: The code did not just deal with text encoding differences, but also with properties whose value contains line breaks.
For example, OpenJ9 has line breaks in "java.vm.info" and "java.fullversion", which now trigger asserts; also there is "line.separator" but this one happened not to cause problems so far.
Change-Id: I3ded8e824e96b6fcf21677dd9ba72cbf58c1d261
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118495
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
a fairly obscure functionality that was used in just one menu that can
be dropped now that the help is changed to contain references to the
help ids the menu items already have
Change-Id: I4efa2f11e7d48b398152d7308341bd3e4308c377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The Forms() method was placed in the SF_Document service
but was applicable only on Writer documents
Now it is placed correctly in the recently created Writer service.
Effective in Basic and Python.
Additionally redundant parentheses have been removed in scriptforge.py
Change-Id: I0d328b40577ddf81a188fdf72611f84751bcb506
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118559
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
Change-Id: I84feb90f63f947a20db06cc66dd0f610fa71e7ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117945
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 147ed04e1bff695f9242d5991334d1c8ddd7435a
- set the extended tooltip explicitly for each of the form 1-9 menu items
in the load/save chapter (outline numbering) menubutton menu so the
code for that can be simplified
Change-Id: Id954bbe39b997b77cf5d17330a651712ea9d5fcb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118560
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia8c893502c1546ae77b03a59ce2798b99340cf72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118556
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iee721fa9f50b2884b2d0e726c36d6821e135a561
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118555
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I08ce91b78a09ad2db1c8e1aa09abc50fd61e177d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118554
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If09508de92aba82ea414cd2fb7b7029e96aaf2f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118553
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
takes 10% of the time off
Change-Id: Ia0a2f4469088e103f162b7d85abb7fadc5f365cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118532
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 28d20be2d79c99bbfd5fedea5c4b2af9d22a29c0
- the button in outline (chapter) numbering is now called 'format' not 'user'
Change-Id: I330a8c1b179921724c9c6d427b700eafcafb7814
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idcdb5dbb4f0754425eeca4b137fa1626bba9ef6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118340
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
makes a small difference
(*) Use strong ref instead of weak ref, because weak ref is expensive to
access
(*) to make that work, fix dispose()
(*) cache the vcl::Window to avoid expensive VCLUnoHelper::GetWindow
Change-Id: Ida7a060d729633a0feb326697509d90052bca1f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118533
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
take 10% of the time off
Change-Id: I75c8d5e1297de342df711d15260073db59946116
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118531
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|