summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-03ProcessAndBlurAlphaMask should take an AlphaMask as paramNoel Grandin
Change-Id: I9235e74499d95750ca93da050014657b418c27d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-03Mysql/Mariadb: implement Users::dropObject (so you can remove a user from UI)Julien Nabet
Change-Id: Ic8fee60e1182303469b5c74598d0ff6ec24667a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160259 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-03Mysql/Mariadb: implement changePasswordJulien Nabet
Change-Id: I565bd96324044bb30b1e096c56e845766663ded1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160258 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-03oox: Refactor and simplify writing to storage with GraphicExportTomaž Vajngerl
Change-Id: I743dc99e0228b59050fb4926c8ef56bed8e82060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160252 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c099ceeaf1cb4651bbca712ba19d16ee4206ab0f - tdf#155876 UI cmds Calc-Format menu (24) + Sparklines and more + refactoring Change-Id: Ie320018d7c3cf13d25bed7f6d7b6af4b2c9f9b26 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160251 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-03Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 3b321caecd0c27ae01afb12924f4f2cb12593dd8 - Python example shared macros documentation Change-Id: If312091c487fd062ec7af24bc4c368bae7b0d748 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160172 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-02Mysql/Mariadb: implement User and ODatabaseMetaData privileges methodsJulien Nabet
User::getPrivileges User::getGrantablePrivileges + create ancillary User::findPrivilegesAndGrantPrivileges ODatabaseMetaData::getTablePrivileges Change-Id: Ib189aa121a3096aab412be68c76a3edaa11af1ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160247 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-02Revert "Drop allownonascii check from pre-commit checks"Mike Kaganski
This reverts commit 8a0015c35f3f137e4f3a80e40616bc078e265a1c. See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html for details. Change-Id: I9bfa893af935587c7a4681e71b13a734d5f50b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160177 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-02Make testHybridPDFFile Windows-only, and filenames in repo ASCII-only.Mike Kaganski
See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html for details. Change-Id: I73f4a48c9b71adc42354f099dcc98aff56e3fc43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-02Simplify some AlphaMask codeNoel Grandin
AlphaMask has an operator=, no need for extra complication Change-Id: Ib0f4aba4e1c9a4a594cc1cbc92f3a335dc9295a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02AlphaMask::ReleaseAccess is unnecessaryNoel Grandin
There is no way the format can change via the Bitmap*Access mechanisms, and we already perform these asserts in the constructor and operator=. The code has been there since commit 8ab086b6cc054501bfbf7ef6fa509c393691e860 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I75195f6fd4e29d7133e787131b6c8479a9188d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02Mysql/Mariadb: implement refreshUsers so get access to users admin pageJulien Nabet
There's still work to do: - retrieve privileges of each table since it's empty for the moment - make the checkboxes editable (it seems read only) - make the user management work (creating one doesn't work for example) Change-Id: Ia1d9c4db7faae16ec1903c5d7aa5e679ce5e944a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160244 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-02Extended loplugin:ostr: sw/qa/extras/layout/layout3.cxxJulien Nabet
Change-Id: I1b86da0ef1ccdd2ccb83f489563f634605c25b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160245 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-02remove printfTomaž Vajngerl
Change-Id: Ib83b5c3b0f80310cd11f7cd8cd83e82d11e12eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160241 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-02Update git submodulesStéphane Guillou
* Update helpcontent2 from branch 'master' to c1e282a842285a55a3f42c62dc1d74c60a8fb3e6 - tdf#135089 update location of Presenter Console settings ...and update various headings and section order. Change-Id: Ib1e19581def728ea35ac8ab837665ffcf482bfb9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159893 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to a1840f2baee7b129990d6c0b218aae1b8d0304d7 - mark untranslatable code and control name in SF Dialog and DialogControl also fixed typos caused by split paragraph Change-Id: I6c4d3badb30629c4bf58011089b4beeb1438204a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160051 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-12-02Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to a0058e57883886e2249e4fc2d03e15454f267f4b - mark bookmarks and paragraph in SF FormDocument as translatable Change-Id: I5867af5313ca86b11b79d59b6a042b16ce9dfee0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160053 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 34d58970fae2b79958754584c3892512e5648bde - fix label of Select Table icon Change-Id: I33fc0fee719c45447cfbbf3baad52770c0329b02 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159951 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to ef8dd17a74f17232e65cc64132d4918024952345 - fix description of ResizeWindowToInitialPage PDF export option Change-Id: I0611e69f0fd7a7c7a05f737264442c07bc629c28 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159800 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-02tdf#152307 sw: layout: invalidate more frames when footer growsEMartinGube
Unit test added. Change-Id: Ibcdb504c57c020cde9b76994cb54e744d1a12888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157905 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-02tdf#123396 actually use the mimetype set in the from documentTomaž Vajngerl
In the document we set the mime type for the images stored, but at import we never actually used the mime types. We always did mime type detection from the filename extension. The problem with this is that files stored as base64 streams don't have a filename so it is also not possible to determine the mime type from the file name. The consequence of this is that we can't know which image to take if we have multiple images (fallback images) so we always take the last one, which could be the wrong one. This happend in the test document. This changes the behavior so that we always first use the document set mime type as there is no reason to not trust that. Only if the mime type isn't provided by the document we use other mime type detection methods. Change-Id: I175c509ce5f11eab2c0454d4d9901ca1fe975272 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160237 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to f7f1aa0417dc645fe1a70022dbd58ef5063f5aac - Fix typos Change-Id: I9dd8a05048631cf0f1b8ec1f2ccef4d800e42e7d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-02tdf#158205 Blueprint Impress template backgroundLaurent Balland
On first master page, move picture from page background to an object at the background Change-Id: I0e01ee9cad4a282c98e3678a7a45cfe13698e0e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159807 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-02Beehive Impress template: restore indentationLaurent Balland
Indentation was broken in content.xml Change-Id: Ia9f05d5af286aa1e3b8ddd9bb205769550d25e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160088 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-02pass BitmapBuffer around by std::optionalNoel Grandin
instead of allocating on the heap, it is small Change-Id: I79eec6605a04c09d9a984cd1a719affb5b06dff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-01Related: tdf#158450 use SfxTabPage::GetFrameWeldCaolán McNamara
to get the parent window. SfxTabPage::GetDialogController returns mpImpl->mpSfxDialogController and that is set in SfxTabPage::SfxTabPage ctor with mpImpl->mpSfxDialogController = dynamic_cast<SfxOkDialogController*>(m_pDialogController); and GetDialogController returns that mpImpl->mpSfxDialogController while nearly everything is derived from OKDialogController, not everything, like this column dialog case is, so mpImpl->mpSfxDialogController is null and it all fails. This same page is inside format, page styles as "columns" but that's the usual multi-page dialog derived from SfxOkDialogController, its just this single page dialog that is different. The original idea was to wait until this parent dialog is needed to figure out what to use. We have this SfxTabPage::SetDialogController so the dialog controller and page can theoretically change after the ctor, though maybe that doesn't happen in this case. Looking at SfxTabPage::GetFrameWeld that one always returns the current parent (of m_pDialogController, not the dynamically casted mpImpl->mpSfxDialogController) so in the best choice to use in general. Change-Id: I4617212fb27fdeeb0afc41123f7bc1b73f495c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01we need these label placeholders for gtkCaolán McNamara
Change-Id: If86e0d1ff4259613bfc20b3ede873dc56ca59206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3d13c05329657af7015c298220855c4fddabd73d - Document new SF IncludeSubfolders argument Change-Id: I360b504446185870e8ea89843e834006f56e2af8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160041 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-01android: Update Android Gradle Plugin to 8.2.0Michael Weghorn
... and gradle to 8.2, as suggested by Android Studio. Change-Id: I1a1df5f43b7a95d24308873b708d3d21b76aa7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160200 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 00f8970a292d6876c29f2d2d4ca7958d832743e9 - CSS: "literal" must wrap normally. Change-Id: Ib0ee56bd4a93d14467bec0ae607477dbbd86cbd8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160226 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-01tdf#158450: fix crash when picking custom colour for column separator lineJulien Nabet
bt: 0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396 396 [this]{ return GetDialogController()->getDialog(); })) 0 0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396 1 0x00007ffeed9c4a05 in std::__invoke_impl<weld::Dialog*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(std::__invoke_other, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__f=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61 2 0x00007ffeed9c4985 in std::__invoke_r<weld::Window*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__fn=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:114 3 0x00007ffeed9c489d in std::_Function_handler<weld::Window* (), SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0>::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290 4 0x00007ffff1cb89e5 in std::function<weld::Window* ()>::operator()() const (this=0x5555574a8e38) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591 5 0x00007ffff1c94604 in ColorWindow::OpenPickerClickHdl(weld::Button&) (this=0x5555574a8db0) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2283 6 0x00007ffff1c9356d in ColorWindow::LinkStubOpenPickerClickHdl(void*, weld::Button&) (instance=0x5555574a8db0, data=...) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2279 See complete bt here: https://bugs.documentfoundation.org/attachment.cgi?id=191146 Regression from: 862fd2fa19b64972247bde9b171ec828a30e1676 defer getting toplevel for color picker until we need it Change-Id: I2932281cb3b1cb510013a19f6bcf3d9f9c6cdb7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160164 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01cid#1557920 COPY_INSTEAD_OF_MOVECaolán McNamara
a sample commit to test this Change-Id: Ibc1a1f75b908e245395a05e81c26158c67e36257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01cid#1546413 silence Using invalid iteratorCaolán McNamara
sample to test silencing this Change-Id: I73a8e22a5266367d7b2c76aa00d38d40431b4841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01cid#1555476 silence Unchecked return valueCaolán McNamara
Change-Id: I55db6a470a2aca5ebcbace7859236b08bb67e25b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160212 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01cid#1558172 Division or modulo by zeroCaolán McNamara
Change-Id: I4060b003fc03c8fe3e0396f9618e64a69715131c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-01tdf#158452: FB: impossible to change field to "entry required" in GUIJulien Nabet
... after table has been saved. There was an hack due to the fact that before FB 3.0, it wasn't possible to use ALTER TABLE to change nullable. See https://bugs.documentfoundation.org/show_bug.cgi?id=158452#c1 Since the hack doesn't work and since FB 3.0 since several years, let's remove the hack and use ALTER TABLE command. Change-Id: I145077bb4c4874f5fe31e375cfb64176a1293575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160220 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-01Fix typoAndrea Gelmini
Change-Id: Iae999cd64ca73f178e4e1148af71b47fe03c8e2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160206 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01Fix typoAndrea Gelmini
Change-Id: Ie5cb165cce88c44004ff37692bfb3c0438c26ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160209 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01Fix typoAndrea Gelmini
Change-Id: I1998241849f0f9fa99d1b111f218cdab7e6074fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160208 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01Fix typoAndrea Gelmini
Change-Id: I9fae0349d8ecf4a4e11b23b46e5b593c07b05290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160210 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01Fix typoAndrea Gelmini
Change-Id: I19abea6905b36e9817de9531dafd389502034910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160205 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-01Fix typoAndrea Gelmini
Change-Id: Ia40016ad2696c8555163074c415ea0e8f9216f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160207 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2023-12-01tdf#158442: fix opening hybrid PDFs on WindowsMike Kaganski
Commit 046e9545956d8ad1d69345d6b4a4c0a33714d179 (Try to revert to use of file_iterator from boost on Windows, 2023-10-31) had introduced a problem that pdfparse::PDFReader::read couldn't create file_iterator for files already opened with write access: mmap_file_iterator ctor on Windows used single FILE_SHARE_READ as dwSharedMode parameter for CreateFileA WinAPI; and that failed, when the file was already opened using GENERIC_WRITE in dwDesiredAccess - which happens when opening stream in TypeDetection::impl_detectTypeFlatAndDeep. Fix this by patching boosts' mmap_file_iterator constructor to use FILE_SHARE_READ | FILE_SHARE_WRITE, like we do in osl_openFile. But there was a pre-existing problem of using char-based CreateFileA API, which disallows opening any files with names not representable in current Windows codepage. Such hybrid PDF files would still fail creation of the file_iterator, and open as PDF. Fix that by further patching boost to have wstring-based constructors for file_iterator and mmap_file_iterator on Windows, which would call CreateFileW. Change-Id: Ib190bc090636159ade390b3dd120957d06d7b89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160218 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-01Drop allownonascii check from pre-commit checksMike Kaganski
Supposedly, at this day and age, it is OK to use non-ascii file names. Specifically, this is intended to allow such names for bugdocs, which allows simpler testing of problems with handling those. An alternative would be to rename bugdocs at runtime; but that still requires that the target filesystem supports such names, so... Change-Id: I25da2402f311d59c5777c4cd302147d6965dea5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160217 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-01Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to cd2824ba5ee24accdeffea3518bd89cc194ed189 - Document new SF Dataset service Change-Id: I4e6a792f2cbcbf826f51f5d62e6dad855d4a0bf0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160035 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-01ScriptForge (SF_Dataset) fix GetRows() in chunksJean-Pierre Ledure
Two bugs are fixed with this commit: 1. when rows in a dataset are read in chunks, one record is skipped errorneously between every two successive chunks. 2. In updatable datasets, the updatable fields need to be identified. This is done at dataset creation. Before: the IsDefinitelyWritable criterion was used, valid for Firebird, not for HSQL After: the IsWritable criterion is used, valid for both. The correction in Basic is valid as well for Python. Documentation is unchanged. Change-Id: I990c02aaa8a93123a7e669b1294605fa19780167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160163 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-12-01Prefer checked ptr to SdrPageView over uncheckedArmin Le Grand (allotropia)
Change-Id: I1610cb82681e415ba6e4a741ad46e5aa90148989 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160201 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-12-01android: Shown warnings about deprecated API usageMichael Weghorn
Configure the gradle build to show detailed warnings about the use of deprecated API, instead of just > Task :compileStrippedUIEditingDebugJavaWithJavac Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. With this in place, 78 specific warnings about the use of deprecated API are now shown in the build output, which can be addressed at some point. Change-Id: I9f3b484b6dfad1fc57895efa7d3426b625030ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160198 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-01sw floattable: fix finding the nearest text in split flys on mouse clickMiklos Vajna
Clicking on the right of the floating table on the page 1 resulted in a cursor position on page 2 instead of a position inside the floating table on page 1. What happens is that the anchor text frame on page 1 is wide enough to contain the mouse click position, but then "before the first character of the paragraph" is on page 2, so a page 1 click results in a page 2 cursor position, which is unexpected. Fix the problem by first ignoring which dummy anchor frames (all non-last ones) in SwLayoutFrame, so SwLayoutFrame::GetModelPositionForViewPoint() in SwPageFrame::GetModelPositionForViewPoint() fails for the perfect match case, and then later looking for split flys explicitly, so the corrected case finds the split fly on the page. I imagine this is not only useful for mouse clicks, but it's also good for everything else that uses GetModelPositionForViewPoint(), e.g. keyboard page-down. Change-Id: I761b211c1b5468d9d8996c59a32ac9be5b83a777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160194 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-12-01[API CHANGE] Add OOXML way of curved connector routingRegina Henschel
The paths generated for curved connectors are basically incompatible between LibreOffice and OOXML. Thus it was not possible to render curved connectors the same way as MS Office. The patch adds an OOXML compatible method for calculating the path. The new method results in a different svg:d attribute when saved in ODF, but needs no change to ODF. The patch introduces the boolean connector property 'EdgeOOXMLCurve' to switch between the two methods. The property value is determined from the svg:d attribute in case of import from ODF. In case of missing svg:d attribute the property value is set to 'true', because Word currently does not write a svg:d attribute when it exports to ODF. The property value is set to 'true' for import of connectors on a drawing canvas in docx. Default value for new connectors is 'false'. The new property has no UI, but can be used via macro. Currently the new method is used for import of curved connectors on drawing canvas in docx documents. Change-Id: I53d99f44febe4d74c2b611f5fdb9de86628c4519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159708 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-06 04:47:30 +0000