summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-16sc: drop dead codeJochen Nitschke
dead after a series of removals, last one commit 4d89865ef2026f40a9a4d66f3e047b77454e6fee new loplugin:deadclass Change-Id: I43caada8d846b29f08ffe9501f3dfba52b7b4e88 Reviewed-on: https://gerrit.libreoffice.org/41228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16Silence further warnings in external/boost/include wrappersStephan Bergmann
...as required by clang-cl: > [build CXX] avmedia/source/framework/modeltools.cxx > In file included from C:/lo64/core/avmedia/source/framework/modeltools.cxx:29: > In file included from C:/lo64/core/external/boost/include\boost/exception/diagnostic_information.hpp:23: > In file included from C:/lo64/core/workdir/UnpackedTarball/boost\boost/exception/diagnostic_information.hpp:17: > C:/lo64/core/workdir/UnpackedTarball/boost\boost/exception/info.hpp(103,13): error: 'boost::exception_detail::error_info_container_impl' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor] > ~error_info_container_impl() throw() > ^ > C:/lo64/core/workdir/UnpackedTarball/boost\boost/exception/info.hpp(172,21): error: delete called on non-final 'boost::exception_detail::error_info_container_impl' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] > delete this; > ^ > 2 errors generated. Change-Id: I026f7e72d027becb68ac9118616ed6d8f2ecbf80 Reviewed-on: https://gerrit.libreoffice.org/41225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-16add a test for storing formula cells in the cacheMarkus Mohrhard
Change-Id: I094491c7a9be5384f88c30ed6a3271aa73674ad8 Reviewed-on: https://gerrit.libreoffice.org/41222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16also import formula cells again from the cacheMarkus Mohrhard
Change-Id: I116337f32151db4d897d88879acb0380fcedc161 Reviewed-on: https://gerrit.libreoffice.org/41221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16i#95698 sw: fix crash on splitting in-table section containing a nested tableMiklos Vajna
Found by crashtesting, ooo95698-1.odt crashed sw layout on load. The intended use-case is splitting section frames inside a table frame, so can just blacklist the non-interesting table-in-section-in-table case that causes the problem here. Change-Id: Ic47cd8c46cc71f7eaa36b03ec2c4a5df8ca8051c Reviewed-on: https://gerrit.libreoffice.org/41224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16Translated "Methoden" to complete b1f6e6299cf5Andrea Gelmini
No more "methoden" in the tree... Change-Id: I4deec3c47bfab12beabd1b6d56c9b9c3c2b6c4a7 Reviewed-on: https://gerrit.libreoffice.org/41226 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16Removed reference to deleted fileAndrea Gelmini
cui/source/dialogs/cuires.src has been deleted on commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Change-Id: I2030a352a9538cf46e3ce078c21d30d3af979284 Reviewed-on: https://gerrit.libreoffice.org/41191 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16Deleted referenced fileAndrea Gelmini
svtools/source/contnr/svcontnr.src has been deleted on commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Change-Id: I0b8a470f141ec64b1a3d410606f52bad1a926cbc Reviewed-on: https://gerrit.libreoffice.org/41193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16Removed reference to deleted fileAndrea Gelmini
extensions/source/propctrlr/formres.src deleted on commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Change-Id: I54853e383be936623299ae6a36fe1809add28e2a Reviewed-on: https://gerrit.libreoffice.org/41192 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16tdf#70280 crete-tags: tweak the UNOIDL regexesMichael Stahl
To more precisely get definitions of top-level entities; particularly nice for interfaces where we don't want to find the ubiqitous forward declarations. Change-Id: I8e0e67506d5c67bfff351c4129c3e7eeda6e67a5
2017-08-16handle formula cells also in the python scriptMarkus Mohrhard
Change-Id: I8a68cbd68db89c3e30827fa449e18f6c13f4d6e0 Reviewed-on: https://gerrit.libreoffice.org/41220 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16add formula cells/groups to the cacheMarkus Mohrhard
Change-Id: I04a8055f4df27a080291362ef31ccf559fa709cf Reviewed-on: https://gerrit.libreoffice.org/41219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16Fix typoAndrea Gelmini
Change-Id: I3f5997ecf2ac05aa62385e20ddc5ee5de2aba1e6 Reviewed-on: https://gerrit.libreoffice.org/41195 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16WaE: C4702: unreachable codeTor Lillqvist
Change-Id: Ic7e21ab6718c246f9fa3ae127827d8d6a1bdbbc3 Reviewed-on: https://gerrit.libreoffice.org/41213 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-08-16tdf#70280 Add UNOIDL support to ctagsJens Carl
This supports the UNOIDL language constructs Enumeration, ElementName, Structure, Interface, FunctioName, Service, and PropertyName. The values are mapping to ctags as: UNOIDL ctags Enumeration e,enum ElementName m,member Structure s,struct Interface i,interface FunctioName f,function Service g,service PropertyName p,property Change-Id: I4ca5dcb289360f7630a85bb3a62ec3b60a8a88e6 Reviewed-on: https://gerrit.libreoffice.org/40911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16[Android Viewer] Fix windowSoftInputModeXimeng Zu
Fix the wrong parameter in AndroidManifest. When changing android:windowSoftInputMode, one should not specify multiple "adjust..." or "state...". Change-Id: I0dcacd846d4fe5c2976fe1708b29086b98f2607b Reviewed-on: https://gerrit.libreoffice.org/40686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-16Ability to change Font Color and added a new Color Picker on Android ViewerMert Tumer
Change-Id: I1d22749a446e451196f0819322cb04ed7d7befae Reviewed-on: https://gerrit.libreoffice.org/37840 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-16external data: apply the transformation still in the fetch threadMarkus Mohrhard
Change-Id: I0509a569f47fcf838ea5c102e6fd0c6e765a0152 Reviewed-on: https://gerrit.libreoffice.org/41208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16tdf#108709 cli_ure,unoil: bump CLI assembly versions for 5.4Michael Stahl
perl cli_ure/source/scripts/increment_version.pl cli_ure/version/version.txt cli_ure/version/incversions.txt temp.txt && mv temp.txt cli_ure/version/version.txt perl cli_ure/source/scripts/increment_version.pl unoil/climaker/version.txt unoil/climaker/incversions.txt temp.txt && mv temp.txt unoil/climaker/version.txt Change-Id: Iaea028fc345d090317f7ebf128b683b4643a1093
2017-08-16cli_ure,unoil: always increment all CLI assembly version numbersMichael Stahl
There is a increment_version.pl, which uses the incversions.txt to increment the CLI version numbers. But it first checks that there are new published UNO types, and exits if there are none. Not sure where the input for that is supposed to come from. But the OOo docs claim that all version numbers have to be incresed for every release to work around some MSI issue, so change the script to do that and add an incversion.txt in unoil too. http://www.openoffice.org/udk/common/man/spec/assemblyversioning.html https://support.microsoft.com/en-us/help/905238/an-assembly-in-the-global-assembly-cache-or-sxs-is-missing-after-you-p Change-Id: I6190b53d1a3ff00b9fe014f86f7ec8cddef9904e
2017-08-16new EMF+ Parser: Implementation of EmfPlusRecordTypeDrawDriverStringPatrick Jaap
The Implementation follows closely EmfPlusRecordTypeDrawString. For each set of characters with the same PosY a TextSimplePortionPrimitive2D is created. Change-Id: I04e4d11dc3c4e1e5bd16aefa8e7f00556aa5282b Reviewed-on: https://gerrit.libreoffice.org/40716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-16add a way to restore from our new cache formatMarkus Mohrhard
Change-Id: I6eeaaf9ca05bed2a908143ae5f4daab6e098799c Reviewed-on: https://gerrit.libreoffice.org/41199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16tdf#39468 Translate German comments/termsJens Carl
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16Add note about order or row, column, and tab as fields vs. parametersTor Lillqvist
Change-Id: I45e0f9a95da20c1a3b6bdf2ac1387b3c14e3dad4
2017-08-16SalFrame Handle* methods can return boolNoel Grandin
Change-Id: Ia28463e1c83aa496e8c389d1614f9b8a78100994 Reviewed-on: https://gerrit.libreoffice.org/41209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16Re-ran bin/gen-boost-headersStephan Bergmann
(missing external/boost/include/boost/exception/diagnostic_information.hpp had caused errors with clang-cl) Change-Id: Ibb84960e5da8fe73cb67aa5ad32a2c249ff921e6
2017-08-16move deadclass plugin to storeNoel Grandin
<sberg> noelgrandin, and is loplugin:deadclass even sound? struct B { B(B const &) {} }; struct D: B { D(): B(*this) {} }; Change-Id: Idadd379b925aa6f9de6c625bffa8560ec4192ac7
2017-08-16convert dialog result methods from long->sal_Int32Noel Grandin
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c Reviewed-on: https://gerrit.libreoffice.org/41206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16remove unused param from CreateScNamePasteDlgNoel Grandin
unused since commit b3dfb1e807eba91eed35a02d74fe8a917c41ee6f "loplugin:checkunusedparams in sc" Change-Id: I53ac9e281a93651259eb39a145acbb89613d3e04 Reviewed-on: https://gerrit.libreoffice.org/41205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16Dead codeStephan Bergmann
...introduced with aeb3853a21435f00f225d751e56184e875bc46ed "osl: (Win32) check allocated pipe succeeded, otherwise needs to fail" Change-Id: Ieeb0b1755e74f583d1b52447eb84f7512eb07914
2017-08-16rename some unnecessary contractions, Lft-Left, etc.Noel Grandin
Change-Id: Idf4ab2d4d2550a02c0c50a981d94c67b111082a9 Reviewed-on: https://gerrit.libreoffice.org/41204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16add python script to interpret the calc cache formatMarkus Mohrhard
Change-Id: I5d66024024b8150fad67397a0debc40aab1ae5fc Reviewed-on: https://gerrit.libreoffice.org/41200 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16introduce a way to write a simple data representation to a streamMarkus Mohrhard
The format used is column orientated and allows quick import and export of the table content. This will be used for the external data to cache the results of each transformation step in the UI. Change-Id: I6e1bfd3b3384cbfadeb98fb995dfd0b03d5e6eb6 Reviewed-on: https://gerrit.libreoffice.org/41198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16Removing unused serialisation codeVarun Dhall
Change-Id: Id31c8de69043d393f005f83d5c7eba878af5119c Reviewed-on: https://gerrit.libreoffice.org/41149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16external data: add HTML data provider testMarkus Mohrhard
Change-Id: I594581ce388221760554f6272ee3af761f172c05 Reviewed-on: https://gerrit.libreoffice.org/41197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16external data: add the deterministic mode also for htmlMarkus Mohrhard
Change-Id: If253b2ff2b4f38ba45a2be7f66dfbcb65ed9be74 Reviewed-on: https://gerrit.libreoffice.org/41196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-16assert on duplicate listener in SfxListenerNoel Grandin
To enable finding the source of the duplicate calls, I add new SAL API (only for internal use) to retrieve and symbolise stack backtraces. The theory is that it relatively cheap to just store a backtrace, but quite expense to symbolise it to strings. Note that the backtrace() library we use on Linux does not do a particularly good job, but it gives enough information that developers can use the addr2line tool to get more precise info. Explanation of fixes in the code that triggered the assert: In SwFrameHolder, we need to only call StartListening() if the pFrame member is actually changing. We also need to call EndListening() on the old values when pFrame changes. In SwNavigationPI, there is already a StartListening() call in the only place we assign to m_pCreateView. In ImpEditEngine, we need to ignore duplicates, because it is doing a ref-counting thing. By storing duplicates on the listener list, it doesn't need to keep track of which stylesheets its child nodes are using. Given that it therefore will see duplicate events, there is probably some performance optimisation opportunities here. In MasterPageObserver::Implementation::RegisterDocument, we seem to be getting called multiple times with the same SdDrawDocument, so just check if we've been registered already before calling StartListening() In SvxShape::impl_initFromSdrObject, do the same thing we do elsewhere in this class, i.e. only call StartListening() if the model has changed. Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac Reviewed-on: https://gerrit.libreoffice.org/41045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16Further clarificationsTor Lillqvist
Change-Id: Iff2b184b8764e459165b7254b32d7ffb810fb3db
2017-08-16Clarify use of "release build" conceptTor Lillqvist
Change-Id: I598b600ca93d86c4c0bc433ae9432ccd7f264192
2017-08-16Make help message for --enable-assert-always-abort match what it actually doesTor Lillqvist
Change-Id: Ie1948c87fd790184fd556617384b1824f85e81ec
2017-08-16remove leftover debugging outputNoel Grandin
Change-Id: Ide78daefced91fff2efeeb25dace6f722acfa3e9
2017-08-16Fix typo in buildingAndrea Gelmini
Change-Id: I727d50ce4725f10efbeaedd70ed961e726f99a5e Reviewed-on: https://gerrit.libreoffice.org/41190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16oovbaapi: Allow copying of multiple selectionsTamas Bunth
Change-Id: If098b44d2627d86795cea4e4211d357d1a562dba Reviewed-on: https://gerrit.libreoffice.org/41176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-08-16Re-add external/harfbuzz/ubsan.patchStephan Bergmann
...after 5aab2900dfdc9f12adda378470149670a2a069df "tdf#109142: Update to HarfBuzz 1.4.8". The parts that were still relevant for 'make check' are: * 6694ce6b542367074667e4445a6b7f50568a2729 "external/harfbuzz: Work around ASan out of bounds warning" * 99f7aacd5b39a0f79351d8d7568b2e43d39878cb "external/harfbuzz: -fsanitize=function" * ca9a08bbf7d42727a93b5f725784308a3590c0fe "external/harfbuzz: Silence -fsanitize=nonnull-attribute" (plus 83a9c8e046dfcaccdb1114ec5a386a11fcca3a02 "build fix") Change-Id: Ibff2a7c52c5de60ae00744acd2ef481bbb08706c
2017-08-16DomainMapper_Impl: add check for m_xTextFactory.is() where missing.Justin Luth
To test: make CppunitTest_writerfilter_rtftok These crash triggering instances were hidden by the presense of \super in topcontext-2.rtf - so I copied it, and only removed \super. My fix for tdf#109382 triggered a unit test failure for one missing m_xTextFactory. It seemed safe enough to test for all of them that aren't in try/catch blocks, not just for the specific instance I can prove with the test. Change-Id: I1e317e05f9bcbbb14360941ce07af1bdf0edac6a Reviewed-on: https://gerrit.libreoffice.org/41060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-16tdf#107480 RTF import: fix HTML automatic spacing in stylesMiklos Vajna
\htmautsp changes the meaning of \sbauto and \saauto, but the auto keywords may appear early in style definitions before \htmautsp arrives. This wasn't a problem before commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), as there the right auto keyword interpretation was repeated as direct formatting. So fix the regression by not deduplicating these keywords, which brings back the correct layout. A larger rework is necessary in the future to delay the parsing of the stylesheet table, that would be a cleaner approach. Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c Reviewed-on: https://gerrit.libreoffice.org/41187 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15tdf#111767 Make the Input Field dialog less confusingAdolfo Jayme Barrientos
The first field isn’t editable, so show it visually. Make the actual editable box have the default focus. Drop the unnecessary heading. Change-Id: Icf0d5fc3ddb9b9af6d04045899d9e8476a217bba
2017-08-16tdf#111797 Fix alignment of 'For the current document only' checkboxGabor Kelemen
Change-Id: Ie7cc004e02e3bb1ac8d52a9c0b67b9fa9f946c8c Reviewed-on: https://gerrit.libreoffice.org/41167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-16Replace stringify by Equals in SdrObject and SdPageVarun Dhall
Change-Id: Ia4cf7a5382a05061ff98f423cf5640a51015236d Reviewed-on: https://gerrit.libreoffice.org/41182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16SfxItemSet::Equal: ignore parents if the pools are differentMichael Stahl
If there are parents, they are necessarily different pointers for different pools; the only sensible way to compare them is by-value, which is a bit tricky because the items overwritten in the child should of course be ignored. Rather than rewrite the whole function, just ignore the parents for now, because this comparison is currently used to replace compares of the serializations of item sets, and SfxItemSet::Store() completely ignores the m_pParent, so this looks like the best replacement. Change-Id: I0a4bf44d4fef49e47a3ec78bc7d977a6fcbd789d Reviewed-on: https://gerrit.libreoffice.org/41186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>