summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-20tdf#43157 Use SAL_WARN instead of OSL_FAILGabor Kelemen
Change-Id: I753254e2e6963e78420288d4c4919cb24282ac81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168128 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-07-20Fix typoAndrea Gelmini
Change-Id: Ibf0f3b94f1a51f86b53ddbe04aa2ee0900c31e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168678 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-20Remove now unneeded osl/diagnose.hGabor Kelemen
followup to commit 57c228803e55ed343c6693de7d0857ad7d3cd9e3 Change-Id: Iebfb23bb65e2bf898bf27f367cc9641f47a14cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167998 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-07-20Fix typoAndrea Gelmini
Change-Id: I197ce7d28e92a9a73ae506c11e407dea838837e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170786 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-20tdf#162111: promote integer types automaticallyMike Kaganski
The problem was, that importing an HTML table into Firebird, and creating a primary key, called OParameterUpdateHelper::updateInt for each record's primary key field. Since commit c07548447a564b2d142cc439a124b76e6a71dfbd (Related: tdf#108057 Use autoincrement for automatically added primary key, 2024-03-20), the type of autocreated primary key in Firebird databases is SQL_INT64, and before this change, OPreparedStatement::setInt failed when the real field's type wasn't strictly SQL_LONG. This allows Firebird SDBC's integral OPreparedStatement::set* methods to promote to larger numeric types capable to represent the values. Change-Id: I7615c8e9ffa29271d04cf264bb950cb76946dfd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170787 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-20Eliminate unnecessary DateTime conversionsEike Rathke
Change-Id: I7bda80e01d37ecd8c2d7e3f8b9ad6fac1e74f3a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170698 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-07-20Fix typosAndrea Gelmini
Implementing Christian fixes from comments here: https://gerrit.libreoffice.org/c/core/+/169901/3 Change-Id: I66c2e596820f481a78e8129d5e77ac292eb8b925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170779 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-19CppunitTest_sd_annotation_tests: remove redundant ProcessEventsToIdleXisco Fauli
it's already called inside dispatchCommand Change-Id: I037fca27b55db2001364fa2b97c661413389f421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170781 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-19tdf#161899: sd_annotation_tests: Add unittestXisco Fauli
Also add a test for uno.DeleteAllAnnotation Change-Id: Icc8cfbad50879b5bc0e9e2b9996666cff0a85cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170780 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-19Related: tdf#162072 DOCX import: handle font family for charactersMiklos Vajna
Open the bugdoc, the first paragraph is meant to be sans and the second paragraph is meant to be serif, but both of them are serif. The bugdoc uses the fonts 'IBM Plex Sans' and 'IBM Plex Serif', which is not something we bundle, so the font fallback is expected, but the fallback should have a matching font family (roman vs swiss). Fix the problem by implementing support for <w:family w:val="..."> in the DOCX import, which was just ignored previously. Now the DOCX import result in on par with the ODT import result. Change-Id: I321b9fc6f63126ca5ad61af57af8a5bc7456d5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170772 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-19tdf#161909: Repair certdialog columns with VCLPLUGIN != gtk3Moritz Duge
Second column was broken since commit cd384e2d31f74223948ea70d8aa3c318d3ceeb50 Change-Id: I4351ff2b3c2ca23884ab0f73906bfe120dc4f298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170667 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19configure,curl: enable GSSAPI on Linux/MacOS/etc.Michael Stahl
This will link libgssapi_krb5.so.2 which is in krb5-libs (ABI CL1 in RHEL8, ABI CL2 in RHEL9). Change-Id: I2dbaa64e70f4502c5a47c6c85123c94b9ad41277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170758 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-07-19resave with latest gladeCaolán McNamara
Change-Id: I9ff2454c5226c224a5211f2b4cb977e84a8c4219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170777 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19getting the "manual cert path" throws unexpectedlyCaolán McNamara
OUString sManualCertPath = officecfg::Office::Common::Security::Scripting::ManualCertDir::get(); in CertPathDialog::Init throws rather unexpectedly since: commit eca31344795f7dca5b3407c56ab240c11a97c58f AuthorDate: Tue Oct 1 15:24:26 2019 +0000 tdf#127909 save manually selected certificate path Change-Id: Icafb8001e8cae2dff350f2267994d19dd73fe1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170776 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19SW: random ID for new content controlsAttila Szűcs
Make the generated unique ID random for new content controls. This way if we copy paste them from different documents, they may still be unique. Change-Id: I2adb6577e08b5798ae88a63b6178352aa76280d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170773 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-19don't use GetItemSurrogates in SwNode::FindPageDescNoel Grandin
They are quite slow, and we want to reduce usage of them Change-Id: Idae1d6035942d29d67269a22b2a771616ea836af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-19don't use GetItemSurrogates in SwPageNumberFieldType::ChangeExpansionNoel Grandin
They are quite slow, and we want to reduce usage of them Change-Id: I5ab3b55e9270419877a08dd1d711ba2fa757a1b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170774 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-19reduce cost of dynamic casting in SdrMarkView::CheckSingleSdrObjectHitNoel Grandin
which shows up when navigating large complex documents with lots of shapes Change-Id: I0631daf1365387f1192815402921ada191ab6046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170760 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-19Fix typoAndrea Gelmini
Change-Id: Iafef7f75454b20e941ab149035284927d6dc28f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169479 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-07-19Fix typoAndrea Gelmini
Change-Id: I1b4316e9b02acbea96b596b26005bf1c774f9f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169228 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-19Fix typoAndrea Gelmini
Change-Id: Ic8196943a5b24541642a117555c2d695fb848db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170754 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-19Fix typoAndrea Gelmini
Change-Id: I3116ab658b21b0069c8b5f8e87723bbf4b84572e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170755 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-19uui: improve Authentication dialogMichael Stahl
"Remember password" will also remember whether the "Use system credentials" was checked. Rename it to "Remember credentials" and place it at the bottom of the dialog. Change-Id: I672715edfa2080a325a0c492b53d6461591e1192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170752 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-07-19Drop obsolete "Ideas for an UNO bridge implementation"Stephan Bergmann
Change-Id: Ibf1de9cf8dc18e62b5ee67b31a8e3f3748c3941b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170769 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-07-19android: Drop unused importMichael Weghorn
Change-Id: Idd578c2f1a984f1ecb9618ddfa8563cc467a6af2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170767 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-07-19android: Drop unused ViewportMetrics classMichael Weghorn
There's still the `ImmutableViewportMetrics` class that actually gets used. Change-Id: I4645a33812441a2de36d666423742b164da76bda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170766 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unnecessary semicolonMichael Weghorn
Change-Id: I6e47003e4c890da9c09b23f64a0e2eac24d2e6bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170765 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unused TextLayer classMichael Weghorn
Change-Id: Id4be67dc7c3ac7ad7a820fca6af730c776ec88f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170764 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unused local varMichael Weghorn
Change-Id: I31f02d8fbc0bb3b5b5cd57665ebd2c02138b654e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170763 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-07-19android: Drop unused importsMichael Weghorn
Change-Id: Ic7f38227d982d1f402b12df85cf37fcda2558ad7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170762 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unused IntSize#nextPowerOfTwo(float)Michael Weghorn
Change-Id: Idec5616195875e4adec22a193d8d8a569de079e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170761 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-07-19improve doc for SwFormatPageDescNoel Grandin
based on a comment from vmiklos Change-Id: Ic627ec5eeee35c8a81854e083814c57c151bac13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-19Resolves: tdf#161662 use some hackery to bring bullet combobox height downCaolán McNamara
There are some Arabic, etc numbering options in there that cause gtk to allocate a large odd-looking height for the combobox. What we can try is to remove top/bottom padding for this widget, but then sync it with a sizegroup to another combobox and then it gets a more natural looking height. Change-Id: Idecbb3ee7b61fe55805d26cabdbaf1885574b3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19don't use GetItemSurrogates in SwFrame::GetVirtPageNumNoel Grandin
So lets implement this just by walking the document node structure. I have tried to limit how much of the document this method now scans, to avoid it also turning into an O(n^2) problem, but I might have missed something, so (a) the loop might be too conservative, in which case performance could be better. (b) the loop might not go far enough, in which case we might see bugs with virtual page numbers. This shaves 10% off the rendering time of large complex docx documents. Change-Id: I69711c65197caf278bd3ad2931c4817e72b28c5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-19Fix typoAndrea Gelmini
Change-Id: I005cbaafeb3f630bd5e5713181aa1ea64ae22ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170757 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-19make pop-up on Encrypt With GPG Key modalSarper Akdemir
Not setting any parent window for XDocumentDigitalSignatures causes the key selection window to be non-modal, letting the user keep editing the document without completing the encryption interaction. Change-Id: Ic7e66cb43606355beaffc720b7c23cdf4f81d934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170630 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-07-19related tdf#134204 : notify change unless all properties are handled #2Justin Luth
This patch is the biggest logic change in this patchset: - no notify if single property (!pNewChgSet) didn't cause a change -bContinue can now be set false - avoiding a false notify - multiple properties: don't block notify -by doing this, I can remove my earlier fix. ------------------------------------------------ Here is my logic: else if( pNewChgSet ) bContinue = false simply was incorrect logic. There is no way we can say that no notification is needed simply because one property is unchanged. AT BEST (which will be done in a follow-up patch) we will need to track how many bContinue = false's there are and see if they match the number of properties that were passed. But sufficient should be to only block when Count == 1, like pOldChgSet now does. bContinue = pNewChgSet->GetChgSet()->Count() > 1; The variable pNewChgSet had been used earlier because it then was checking if pNewChgSet->GetChgdSet... But we can easily substitute pOldChgSet here, becoming else if (pOldChgSet) bContinue = pOldChgSet->GetChgSet()->Count() > 1; There are three mutually exclusive code paths to consider: pOldChgSet, bNewParent, or just a single property Since bNewParent overrides bContinue elsewhere, ignore it and it also doesn't make sense to continue for a single property, so this could simply become else bContinue = pOld... && pOld...->GetChgSet()->Count() > 1; which is identical to the bContinue in the if clause, and thus they could be combined. Change-Id: Ifa5ba56226f4e77a00f3bc8089a8dcaaca2b91ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169898 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-07-19Fix typoAndrea Gelmini
Change-Id: I7a2a583f7646a6d881fecc47ba4cf9158d6d8dcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170756 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-07-19cid#1609598 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554697 COPY_INSTEAD_OF_MOVE cid#1554709 COPY_INSTEAD_OF_MOVE cid#1554764 COPY_INSTEAD_OF_MOVE cid#1554804 COPY_INSTEAD_OF_MOVE cid#1554821 COPY_INSTEAD_OF_MOVE cid#1554833 COPY_INSTEAD_OF_MOVE Change-Id: I3ee0bf523b1c8dfde3674ac5088abe5182cbfb34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19Fix typoAndrea Gelmini
Change-Id: I4eb00c710a940371b2916ae52127f1ff7f808427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170501 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-07-19Fix "lets" -> "let's"Andrea Gelmini
Change-Id: Ie9b6961a2786a518876db7b26258e67e8afee848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169760 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-07-19CppunitTest_sw_uiwriter3: avoid font fallback in testTdf133967Miklos Vajna
I'm not sure when this started, but the testcase fails with: - Expected: 6 - Actual : 7 I.e. the initial page count is meant to be more than 1, but we explicitly assert that page count. Once gb_CppunitTest_set_non_application_font_use is set to abort for this suite, then vcl says the font fallback is: vcl/unx/generic/fontmanager/fontconfig.cxx:1195: PrintFontManager::Substitute: missing font: 'Albany' try: Liberation Sans instead Do that replacement, that restores the 6 pages on load even in cases where it was 7 previously. Change-Id: I0cf40c0cdbbb5c1e894468371ea260f0d15a3e40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170759 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-19libreofficekitgtk: Add include for SAL_DLLPUBLIC_EXPORTMichael Weghorn
`SAL_DLLPUBLIC_EXPORT` is defined in `include/sal/types.h`, so add a corresponding include in `include/LibreOfficeKit/LibreOfficeKitGtk.h` before using it. Without this, Qt Creator's Clang code model would'nt find it, resulting in errors like .../libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx:15: error: In included file: unknown type name 'SAL_DLLPUBLIC_EXPORT' being shown when editing the file `libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx` in Qt Creator. Change-Id: Iedd3490be9de72b931573b305d283d80b25a4645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170749 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19cid#1608321 Double lockCaolán McNamara
Change-Id: I831db1632e2a8fab9194ffb54df61f55e6304864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19cid#1608112 Copy-paste errorCaolán McNamara
Change-Id: Ia2bb23be913324569e7e5588086f1de52d03fa67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-19android: Drop unused importsMichael Weghorn
Change-Id: Ie26eb3ee5e068b75912d0392ca81c966972e72bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170717 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unused DisplayMentrics#toJSONMichael Weghorn
Change-Id: I631932c4f4a6d61e89816b5d276bfe8384194939 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170716 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-19android: Drop unused CairoImage.FORMAT_INVALIDMichael Weghorn
Change-Id: I4cd9aba81129921bae523f8afe182732119471c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170715 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-07-19android: Make constant finalMichael Weghorn
Addresses this warning/suggestion shown in Android Studio: > Field 'LOGTAG' may be 'final' And: Drop an unused import. Change-Id: I6ce730a80690c2701a91cc7900cc801b370dc605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170714 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-07-19android: Drop obsolete '@TargetApi(19)'Michael Weghorn
Obsolete since: commit c2fc2c8c7c63ca4e43bca6e8c9b82c50418422d2 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Dec 5 09:57:22 2023 +0100 android: Bump minSdkVersion to 21 (Android 5.0) Change-Id: I0b8d115b5be1e066a3232c8297de75ea1cea6cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170713 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-01-28 02:06:00 +0000