summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-10vcl PDF import: clean up CompatibleWriterMiklos Vajna
It's cleaner to avoid member functions and constructors when we inherit from a C struct and we pass it to pdfium's C API. Change-Id: Iac9ab99b3d1b66241bb49d3a7707e242078ab5df Reviewed-on: https://gerrit.libreoffice.org/70472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-10SmartArt: omit last atom in forEach loop only when necessaryGrzegorz Araminowicz
now all transition arrows are created in cycle diagrams Change-Id: I69e932f0060786b702dbecae72245bb624fa602b Reviewed-on: https://gerrit.libreoffice.org/70457 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-10Removed executable permission on xlsx fileAndrea Gelmini
Change-Id: Ida96d8a0a993daac87c4e03fe4ba0d22a69f90cb Reviewed-on: https://gerrit.libreoffice.org/70487 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10Fix typoAndrea Gelmini
Change-Id: Id9d19965511760839e8e93488b1cc6a98fbd4a5c Reviewed-on: https://gerrit.libreoffice.org/70493 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10Fix typoAndrea Gelmini
Change-Id: Ia0dd6a96a039056f15e494baf844e11fb9b5e9aa Reviewed-on: https://gerrit.libreoffice.org/70488 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10clang-tidy: Fix suspicious catches of WIP unhandled-self-assignment checkTamás Zolnai
Change-Id: I1cb16b180f4cc5bf4d65485f03c44a06414d3580 Reviewed-on: https://gerrit.libreoffice.org/70481 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-10Fix double-clear of clearable mutex guardMike Kaganski
Change-Id: I91f04cae91cbb5510f70baaf8c31ecc59f6402c7 Reviewed-on: https://gerrit.libreoffice.org/70479 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-10Sifr icon theme: add sc and extension icon folderandreas kainz
Change-Id: Ibdcae261ee19e95a36b094401c9b526c41e261ad Reviewed-on: https://gerrit.libreoffice.org/70484 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-10Sifr icon theme updateandreas kainz
Change-Id: I0a3ba3beb671cae6956fa616308997fcc2bd3d1f Reviewed-on: https://gerrit.libreoffice.org/70476 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-09tdf#124503: Support JRE installations with unknown java.vendor propertyStephan Bergmann
After recent additions of 61c4f96d6ae6a80370774e53287edb27cbce8067 "Support AdoptOpenJDK" and 41507db590b24e1b9b45d95cad55c71ba2e4091d "Support Amazon Corretto" to our hard-coded list, there is now reports that at least Debian and Ubuntu tried to distribute versions of OpenJDK with the java.vendor propety set to string like "Debian" or "Ubuntu". Instead of trying to catch up with an ever-growing hard-coded list, it is probably better to stop relying exclusively on such a hard-coded list, and for unknown vendor values, try out whether the SunInfo backend (which supports the "generic" OpenJDK) would be able to handle the given JRE. (For simplicity, assume that any versions of such JREs are supported. Our baseline is Java 6, and there are unlikely any older versions of JREs from unknown vendors out there. If this turns out to be problematic, we could include information about problematic vendors after all, or add a general check that JREs from unknown vendors are at least Java 6.) Many functions in jvmfwk/inc/vendorplugin.hxx that used to take a set of sVendor/sMinVersion/sMaxVerison/arExcludeList paramters had to be revised to take a vendorSettings parameter instead, and VendorSettings::getVersionInformation has been changed to return a boost::optional, so that unknown vendors can be handled gracefully. Change-Id: Ibf915f2ddd59e09b77e2c03be688cac0547b9ac9 Reviewed-on: https://gerrit.libreoffice.org/70460 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-09[API CHANGE] Asserts to never clear already cleared guardMike Kaganski
... which could help catch copy-paste errors when wrong guard is cleared second time. Also an assert added that when resetting, there's something to reset (i.e., no descendant class had cleared protected pResetT, making reset impossible, and thus actually unable to guard anything). framework/source/layoutmanager/layoutmanager.cxx: made sure to not call clear() second time framework/source/layoutmanager/toolbarlayoutmanager.cxx: restored lock lost in commit 777bc22ca6490a4300f30fc1b45287dce789a36f forms/source/misc/InterfaceContainer.cxx: removed a leftover from commit a19cd21e3c03559877428315bebc0ceaf367a461 which reduced guarded scope forms/source/component/DatabaseForm.cxx: fixed clear-reset sequence broken from the initial commit bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d Change-Id: Ibab6660c79561eee31faf3e6c1128ab141a7e8a3 Reviewed-on: https://gerrit.libreoffice.org/70381 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-09Add asserts to *Guard pointer constructors...Jan-Marek Glogowski
... as we can't drop them. IMHO it's still better then just a crash. Has to use NULL, as the API is pre-C++11 compatible. Change-Id: Idb4395d14a9185f4d7d1c2f048ad950518eef133 Reviewed-on: https://gerrit.libreoffice.org/70465 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-04-09Sifr calc style iconsandreas kainz
Change-Id: Icc7822c942236904b63c26984190312109cfc909 Reviewed-on: https://gerrit.libreoffice.org/70462 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-09update creditsChristian Lohmaier
Change-Id: Ib1d4c660ff8578d86dc2dddb1aeb55b95f127cb8
2019-04-09Translate German variable namesJohnny_M
Please feel free to suggest a better name, if desired Change-Id: I9ddf5007930b90058d448c81ae5733cbc7192d1a Reviewed-on: https://gerrit.libreoffice.org/70374 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-09Translate German variable namesJohnny_M
Please feel free to suggest a better name, if desired Change-Id: I31fd05dbd2e7c86c1aab6967c630c13bd2da455f Reviewed-on: https://gerrit.libreoffice.org/70373 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-09Translate German variable namesJohnny_M
Please feel free to suggest a better name, if desired Change-Id: Ia5b7b6100fc588ba366ed31e249e35ce501e0d1a Reviewed-on: https://gerrit.libreoffice.org/70372 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-09Translate German variable namesJohnny_M
Please feel free to suggest a better name, if desired Change-Id: I1bd5805c206547a5f70d4d5186ecec2e624845fe Reviewed-on: https://gerrit.libreoffice.org/70364 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-09Just use the ResettableGuard's functions...Jan-Marek Glogowski
... instead of the nested MutexGuard and clear. Really had to look twice, that the MutexGuard and ResettableGuard use the same Mutex - who came up with this... yup myself. Change-Id: I70326772a9be8352f169a26467529a7c4100a20d Reviewed-on: https://gerrit.libreoffice.org/70385 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-09zugeordnetes->associatedCaolán McNamara
Change-Id: I4ba1a3c467526b85f576e5549e7c47a1e0fb66a0 Reviewed-on: https://gerrit.libreoffice.org/70456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09find-unneeded-includes: fix tuple default items in debugStlGabor Kelemen
So it gives no false positives as currently seen in e.g. include/sfx2/charmapcontrol.hxx include/sfx2/docinsert.hxx Change-Id: I087a949875df20c4ef25a10c80571bb57334cf80 Reviewed-on: https://gerrit.libreoffice.org/70400 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-09drop unneeded forward declareCaolán McNamara
Change-Id: I6a748d76bb24661404d280236f4c850a9136bb30 Reviewed-on: https://gerrit.libreoffice.org/70430 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09drop some unneeded includesCaolán McNamara
Change-Id: I8e41e28313a22148033c566edce50f5bfa58d065 Reviewed-on: https://gerrit.libreoffice.org/70452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09remove some usages of BitmapColor outside of VCLTomaž Vajngerl
You get BitmapColor only from reading pixels from a Bitmap and we want to avoid usage of Bitmap outside of VCL (and use BitmapEx as the alternative which will eventually replace Bitmap). Change-Id: Iddfa3ef739bfdd4dce5fb47fd9f67a5a36f3388b Reviewed-on: https://gerrit.libreoffice.org/70447 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-09n_children is count of toplevel nodesCaolán McNamara
Change-Id: I38302045bfe096781ce9c59c6f2dbe0a7625efda Reviewed-on: https://gerrit.libreoffice.org/70453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09tdf#124200 missing menubar icons: add packagemanager, macro, findbarandreas kainz
Change-Id: I00ae42334935a807ebbe6855323e031441e191d1 Reviewed-on: https://gerrit.libreoffice.org/70450 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-09drop newly unused ScAbstractTabDialog_ImplCaolán McNamara
Change-Id: I7f200543a77d9bbf2f892498bca8cbecdf9628a1 Reviewed-on: https://gerrit.libreoffice.org/70429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09restore ScEditWindow a11yCaolán McNamara
Change-Id: I425cdf3d868b37a4975f502f3cade4298f3a948a Reviewed-on: https://gerrit.libreoffice.org/70428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09can use OutputDevice baseclassCaolán McNamara
Change-Id: I6c1af0332d9c34dbe22d6ee1325513824f95fb05 Reviewed-on: https://gerrit.libreoffice.org/70427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09MenuButton Click Handler used to be overwritten by the Menu HandlerCaolán McNamara
Change-Id: I0f442efa9e69923fc412a5c1b737dfbc7662c6a5 Reviewed-on: https://gerrit.libreoffice.org/70426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09missing includeStephan Bergmann
Change-Id: I637d86ca3bfa0a526c4d02e991c8460f553f491f
2019-04-09tdf#123747 xmlsecurity, ODF sign roundtrip: preserve invalid reference typeMiklos Vajna
Only add the correct type to new signatures to avoid breaking the hash of old ones. Change-Id: I30f892b292f84a0575a3d4ef5ccf3eddbe0090ca Reviewed-on: https://gerrit.libreoffice.org/70424 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-09tdf#103322 GlyphItem::m_aLinearPos use getX() instead of X()Alexander Farrow
GlyphItem::m_aLinearPos is a tools::Point variable. Eventually it will be changed to a basegfx::B2DPoint variable - to add support for sub pixel glyph positioning. basegfx::B2DPoint has the getX() method to retrieve a point's X coordinate. tools::Point has two methods to retrieve a point's X coordinate: 1. X() 2. getX() Both of these methods return the same value because getX() just calls X(). So any call to X() can replaced by getX() and vice versa. By replacing calls to X() with getX() now we won't have to make these changes later when we swap from tools::Point to basegfx::B2DPoint. Change-Id: Idfa0584cb3a7ce246b5499814b7e29f86167d8b8 Reviewed-on: https://gerrit.libreoffice.org/70436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-09Fix typoAndrea Gelmini
Change-Id: Ifb1b63c27816c244d98fabfd97114c21c9e4ffa4 Reviewed-on: https://gerrit.libreoffice.org/70443 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-09Fix typoAndrea Gelmini
Change-Id: Ibc0b22ac1e3b58d91674822a2378703c681c6a7c Reviewed-on: https://gerrit.libreoffice.org/70445 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-09Fix typoAndrea Gelmini
Change-Id: Ia52e717551d50e57d59feba5709d6bf25e1dc1a2 Reviewed-on: https://gerrit.libreoffice.org/70441 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-09tdf#122924 wrong link in colibre links.txtandreas kainz
Change-Id: I322657823888d33e8dceb63d95251bde54227da9 Reviewed-on: https://gerrit.libreoffice.org/70435 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-09Removed duplicated includeAndrea Gelmini
Change-Id: I4e02a3a6898159dc6f2496c1a67ce477bc59cfe5 Reviewed-on: https://gerrit.libreoffice.org/70439 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09Removed executable permission on sourceAndrea Gelmini
Change-Id: I2e41d3d80a4c3c75b923a90507b7b9b1ed3669c3 Reviewed-on: https://gerrit.libreoffice.org/70438 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09Fix typosAndrea Gelmini
Change-Id: Idc6d5fcc91f74d1450ef44634274651074f768c0 Reviewed-on: https://gerrit.libreoffice.org/70437 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09Fix typoAndrea Gelmini
Change-Id: Ibae0cf4ef91c8b830447c999306a60dea3334ad6 Reviewed-on: https://gerrit.libreoffice.org/70440 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09Fix typoAndrea Gelmini
Change-Id: Icabc8b356d18ee5381f7d43233341a9d8e42ef9c Reviewed-on: https://gerrit.libreoffice.org/70444 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09tdf#124247: Fix tooltip message when color added to recent colorsAditya
Presently, the tool tip text in recent colors is shown in its hexadecimal representation when the split color button is clicked. Change the hexadecimal representation of the colors in 'recent colors' to its actual color name. Change-Id: I59636eb124b75a9397337c9560bfff72804424ae Reviewed-on: https://gerrit.libreoffice.org/70337 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-09tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move remaining XPropertySet Java tests to ScEditFieldObj_Cell and ScEditFieldObj_Header. Change-Id: I43640c6ea5a35fcc1aa8e15be17dae7611551776 Reviewed-on: https://gerrit.libreoffice.org/70434 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09tdf#45904 Remove obsolete/disabled testsJens Carl
The some of the ScCellFieldObj tests are already written in C++ since commit d0af33e87db753d6d171548f75c2e242cde00497. Change-Id: I91dd688452d9374810096a89ed3ddf148df0b996 Reviewed-on: https://gerrit.libreoffice.org/70432 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-09Sifr icon theme: links.txt file updateandreas kainz
Change-Id: I9af08d1af8a92414901cfd2531fda076e2f6a954 Reviewed-on: https://gerrit.libreoffice.org/70421 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-09tdf#124200 missing icon: for HorizontalLineandreas kainz
Change-Id: Ib2ffb703b2649a629c06ee5a50603912bf615cf2 Reviewed-on: https://gerrit.libreoffice.org/70433 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-04-08weld ScHFEditDlgCaolán McNamara
Change-Id: I2f17dfb1f8193730b26e7c338100a786ddbb87c7 Reviewed-on: https://gerrit.libreoffice.org/70418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08drop newly unused SfxSingleTabDialogCaolán McNamara
Change-Id: I3b445aba89ce62d7890d387a962f12a7055dc7b4 Reviewed-on: https://gerrit.libreoffice.org/70416 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08weld calc header/footer dialogCaolán McNamara
Change-Id: Ied5ca56637b2f7be2d769d8f773a6e012d6e5b1f Reviewed-on: https://gerrit.libreoffice.org/70415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-23 13:23:01 +0000