summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-18Fix 'is' operator for comparisonJens Carl
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ic4ba481579d13fd1496431ded59dd626a05fc0c6 Reviewed-on: https://gerrit.libreoffice.org/83033 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-18cid#1249470 Uninitialized scalar fieldCaolán McNamara
use comment as an annotation Change-Id: Ia8b5ba157d0d240c4a3e6beed74d66e6d34d1a32 Reviewed-on: https://gerrit.libreoffice.org/83067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421107 Useless callCaolán McNamara
add annotation Change-Id: I97e9282cb8568378de01764802b0a6d30e71f259 Reviewed-on: https://gerrit.libreoffice.org/83064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18sw: prefix members of SwCallLinkMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ia0b6909ff037c4126e0cba1e63a672d166f6784f Reviewed-on: https://gerrit.libreoffice.org/83059 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-18cid#1421106 Useless callCaolán McNamara
add annotation Change-Id: I9e0f67fc14bc15a011faeb75264f64930a0c3065 Reviewed-on: https://gerrit.libreoffice.org/83063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421069 Useless callCaolán McNamara
add annotation Change-Id: Iaeebd22ccefe4a11b3ae65e3f6dc54f8fdb7e075 Reviewed-on: https://gerrit.libreoffice.org/83062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18use FasterParser for SvxXMLXTableImport::loadNoel Grandin
the SvXMLImport superclass of XMLVersionListImport already constructs a parser, so we can just use that one Change-Id: I28402467f63e166a2c5ffc3bf0c851de81ba2108 Reviewed-on: https://gerrit.libreoffice.org/83061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18Fix 'is' operator for comparisonJens Carl
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ifabe22e4ae3b9e1d3bfd5a663f39500e381cfa6e Reviewed-on: https://gerrit.libreoffice.org/83034 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-18cid#1430070 Copy-paste errorCaolán McNamara
add annotation Change-Id: I6973335b8877b48d5cf0a08f4e291585de352446 Reviewed-on: https://gerrit.libreoffice.org/83035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1430063 Copy-paste errorCaolán McNamara
add annotation Change-Id: I162b4f388baff243425d34a13c1104dfdaf92588 Reviewed-on: https://gerrit.libreoffice.org/83036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1448469 Out-of-bounds accessCaolán McNamara
add an annotation Change-Id: I70a431fecd8a87f2167bdce53ec2397d22436a9d Reviewed-on: https://gerrit.libreoffice.org/83025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1430094 Arguments in wrong orderCaolán McNamara
add an annotation here Change-Id: If28f6494e80df0ea38036196ed152e9dee29339f Reviewed-on: https://gerrit.libreoffice.org/83027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18loplugin:singlevalfieldsNoel Grandin
Change-Id: I0bb32ad7351f0e4cfbdc872ed0e81b8157ecc4cb Reviewed-on: https://gerrit.libreoffice.org/83056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18related tdf#120412 ww8import: allow > 100% escapement, fix calculationJustin Luth
On import, it was calculating the escapement before reading the character size. If there is a fontsize SPRM in the character run, make sure that is processed first. Also, use the new MAX_*_ESC values since 100% is not nearly enough as a maximum. I looked for a mechanism that could delay processing, but found nothing. I thought about creating such a mechanism, but that could get extremely complicated, as loops would need to be detected (co-dependencies, etc). In the end, it seems likely that SOME function would need to be re-run (for example make Read_SubSuperProp runAgain at the end of the character properties) since there (likely) is no guarantee of the order of SPRMs. From my code-reading, it looks like Read_Fontsize is re-entrant-able, so that seems like the simplest solution in this case. This is mature code, so no real call for creating new mechanisms... Change-Id: I1269989c74cf34e38f8db77bd6fc510e395ee864 Reviewed-on: https://gerrit.libreoffice.org/82248 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-18Paragraph Align Tab fixandreas kainz
Change-Id: Ied02b9db154bd007399b8b3d567d692d4973d382 Reviewed-on: https://gerrit.libreoffice.org/83040 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-18tdf#127927 Character Dialog effect preview Alignmentandreas kainz
Change-Id: If4bf99711b09c61d00dafb65ba76f4673c99246b Reviewed-on: https://gerrit.libreoffice.org/83019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-18Options calc general tab only one columnandreas kainz
Change-Id: Iba382f28695ed4452151a7576727114ba99afea9 Reviewed-on: https://gerrit.libreoffice.org/83042 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-18widget theme: correct sizes of combobox/listboxTomaž Vajngerl
Combobox/listbox was clipped on the right side. Fixed this by increasing the size of the widget by one and moving the button to the right by one pixel. Change-Id: If73e93d0c99c1daff9c0bab095169dba3c619450 Reviewed-on: https://gerrit.libreoffice.org/83043 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-17cid#1430084 Arguments in wrong orderCaolán McNamara
add an annotation Change-Id: Id3b90eae8a2306cfb7f0f46b3fd73e320c851f6a Reviewed-on: https://gerrit.libreoffice.org/83029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#1430089 Copy-paste errorCaolán McNamara
add an annotation here Change-Id: Ib8a924271e557f7eb8ee4b5a7353206485b1f10a Reviewed-on: https://gerrit.libreoffice.org/83028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#706181 Use of untrusted string valueCaolán McNamara
use an annotation here and add one to the windows equivalent Change-Id: Ife54949c2e89ae606d7931be82807db4bbb132dc Reviewed-on: https://gerrit.libreoffice.org/83024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#1430104 Arguments in wrong orderCaolán McNamara
add an annotation Change-Id: I2e9356fa1d56e579336f1fb7346112edf576232f Reviewed-on: https://gerrit.libreoffice.org/83026 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#1448230 Dereference null return valueCaolán McNamara
Change-Id: I846959c2f92dc8078ad2ed8accb8f7be0f2833ce Reviewed-on: https://gerrit.libreoffice.org/83023 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#1448367 Explicit null dereferencedCaolán McNamara
Change-Id: I1762ad30ba03ee1d06f85023a42646131a7ccde9 Reviewed-on: https://gerrit.libreoffice.org/83018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17only need xTransform if we have xRecorderCaolán McNamara
Change-Id: I6d1ad119921cf79cf87566d65b4dd700c0890fa7 Reviewed-on: https://gerrit.libreoffice.org/83003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17cid#1455745 Not restoring ostream formatCaolán McNamara
Change-Id: Ie5b73bca282a279a0318e42499d44f19822b1554 Reviewed-on: https://gerrit.libreoffice.org/83017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17tdf#128847 - vcl: fix colorspace names for MacOSChris Sherlock
kCGColorSpaceGenericGray is deprecated and should be kCGColorSpaceGenericGrayGamma2_2, and kCGColorSpaceGenericRGB is similary deprecated and now should be kCGColorSpaceSRGB. This fixes the "color skew" issue found in a variety of tests. Change-Id: I8088b2377e03cde3f8e03e9d3778a40fc3081c4a Reviewed-on: https://gerrit.libreoffice.org/82809 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-17ofz#12553 Timeout, cut out slow uninteresting path for fuzzingCaolán McNamara
Change-Id: Iaaf940e48a54e9578c747e57f2f328c36e4a119b Reviewed-on: https://gerrit.libreoffice.org/83002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17bin/run: missing exedir for macOSStephan Bergmann
...but even the you still get a failure > $ bin/run vcldemo > 2019-11-17 10:37:53.159 vcldemo[18891:7736267] No Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file, exiting Change-Id: I7c11ee5a02c4a71cf3c79dc7b5b180c3e28c059b Reviewed-on: https://gerrit.libreoffice.org/83015 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-17Fix typoAndrea Gelmini
Change-Id: Id04e963ca0435bb042544b93e958b0d25e00eb63 Reviewed-on: https://gerrit.libreoffice.org/82984 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Fix typoAndrea Gelmini
Change-Id: I0f71c9b31456b37130a9b6ef9f47d204b9c21aa1 Reviewed-on: https://gerrit.libreoffice.org/83006 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Fix typoAndrea Gelmini
Change-Id: I59877df3c75d8423ae81a7d877b3144e65526253 Reviewed-on: https://gerrit.libreoffice.org/83007 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Removed executable permission on file pptxAndrea Gelmini
Change-Id: I93dd9533fc4f4d2acc1afe282754af0c78a25f73 Reviewed-on: https://gerrit.libreoffice.org/82985 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Fix typosAndrea Gelmini
Change-Id: I9251205c47f26be7695496b5887b849fcf1335f1 Reviewed-on: https://gerrit.libreoffice.org/82814 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17loplugin:unusedmethodsNoel Grandin
Change-Id: I04deb5a1dee5b8a9a4508d28552ffe0b67288993 Reviewed-on: https://gerrit.libreoffice.org/82977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17tdf#128820: improve unit test to not depend on opening bad file failingMike Kaganski
... also test exported XML directly Change-Id: I50237593dd111e7c7974452769c8d49c22012713 Reviewed-on: https://gerrit.libreoffice.org/83005 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16cid#1448516 silence Dereference null return valueCaolán McNamara
Change-Id: Ifb7e14183e97c225ed7e68f93e6142d10c4a87b0 Reviewed-on: https://gerrit.libreoffice.org/82991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16widget theme: allow for default "stacked" spinbuttonsTomaž Vajngerl
Change-Id: I2943616a641de72a615f57784e8a9927c12edcf7 Reviewed-on: https://gerrit.libreoffice.org/82979 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-16cid#1448453 Untrusted value as argumentCaolán McNamara
coverity doesn't warn about XclImpString::ReadFormats Change-Id: Ide6285f39fed09a1767c2a2272f30ec213a20106 Reviewed-on: https://gerrit.libreoffice.org/82993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16cid#1453998 Wrapper object use after freeCaolán McNamara
Change-Id: I1dc733e72ba63db1eaa20113a7599ea7580eef31 Reviewed-on: https://gerrit.libreoffice.org/82988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16cid#1448447 silence RV: Bad use of return valueCaolán McNamara
Change-Id: If24d5fffb4ecf86fa6a43d824b5e40fcef29a691 Reviewed-on: https://gerrit.libreoffice.org/82995 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16cid#1455212 Uncaught exceptionCaolán McNamara
Change-Id: I75956bfc3dccdf3ef400c3b9dcea40606abb8504 Reviewed-on: https://gerrit.libreoffice.org/82987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16cid#1448226 silence RV: Bad use of return valueCaolán McNamara
Change-Id: Ie85ea159ebed117c11a1d5d67c4292be8ca5b8e8 Reviewed-on: https://gerrit.libreoffice.org/82994 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16loplugin:singlevalfieldsNoel Grandin
Change-Id: I31fd6b251dee9d1ee1a9ac59964034d0136e1f3e Reviewed-on: https://gerrit.libreoffice.org/82978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-16Also consider saved exceptions when terminating parseMike Kaganski
As with previous commit 18ae77a065cb8ae6940d4067f6ab7e99a3f74047, this will start showing parse errors on invalid files which previously just opened without warnings, silently losing the invalid stream part. Any bug bisected to this commit is not a regression from this commit! The real problem was already before, and was just disclosed by this (which is the actual goal). Also simplify unit test data for tdf#128820, which will now be enough after the change. A unit test (testN779627) revealed unexpected throws when parsing; this was fixed. Change-Id: I5a21b9001874ec6e3b8273c10043ef930bf1cc82 Reviewed-on: https://gerrit.libreoffice.org/82981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16oox: avoid control freeze on exceptionVasily Melenchuk
If exception happens somewhere in exportDocument() or later, document controls could be remain locked and later cause crash due to missing exception handler. Use scope guard to avoid this problem on exception. (cherry picked from commit ce684e7d06fc37ac6b672f5676e6113fcf41a03e) Change-Id: I1ce4e487833ddc4b1f1b708f3a7e10bb299ef354 Reviewed-on: https://gerrit.libreoffice.org/80752 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-16sw: RTF export: only enable \formprot if there is actually a sectionMichael Stahl
... that is protected; Writer can also protect the content of text frames, which doesn't(?) appear to be possible in Word. Form protection has annoying side effects like disabling field UI for the whole document, even inside sections that are unprotected via \sectunlocked1. Change-Id: I2bf9503202779f5cb7c6e27ea7f533b2e3acb9d2 Reviewed-on: https://gerrit.libreoffice.org/82804 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-16cid#1448525 Dereference null return valueCaolán McNamara
Change-Id: I0dae9e73e85cef74f041535f3787e3afb45bb94d Reviewed-on: https://gerrit.libreoffice.org/82989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-29 12:21:12 +0000