summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-02Unused return value of rtl_cache_constructorStephan Bergmann
Change-Id: I1e8b8ae65d9989683dde8f642f3c19355d10a571 Reviewed-on: https://gerrit.libreoffice.org/47238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-02clang-tidy modernize-use-equals-default in sc/source/core/toolJochen Nitschke
remove default-able copy-ctors/assignments Change-Id: I40255393899275a5825ffef4df3f08c6ce5348c2 Reviewed-on: https://gerrit.libreoffice.org/47140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01tdf#114628 correct line spacing for impressSzymon Kłos
* use line spacing also for the first line * correct spacing in case of > 100% proportional spacing * impedit2.cxx only code readability change Change-Id: I24832e7dc2fa8cfbb2f9cdfe7062eaaaa63f1729 Reviewed-on: https://gerrit.libreoffice.org/46925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-01Related tdf#104942: implement setByte on firebirdJulien Nabet
There's no TINYINT or equivalent so let's do the same as setShort Change-Id: Ia1154ee068b02f40e7efa21571036d8b49844859 Reviewed-on: https://gerrit.libreoffice.org/47234 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-01ofz#4817 Bad-castCaolán McNamara
Change-Id: I5dc9c66ce17f6401fbc9683cf8b10bf62755a166 Reviewed-on: https://gerrit.libreoffice.org/47236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-01loplugin:passstuffbyref improved return in scNoel Grandin
Change-Id: I487cfe96e9fe65f9be39b2488880410bc7b4baea Reviewed-on: https://gerrit.libreoffice.org/47228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01ofz#4767 Bad-castCaolán McNamara
Change-Id: Ibf8285efae7c570452954feb41a1a36bf44504a4 Reviewed-on: https://gerrit.libreoffice.org/47235 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-01Reduce large VARCHAR columns of the wizard sample databases to fit FirebirdTor Lillqvist
The maximum size of a VARCHAR column in Firebird is 32765 bytes [sic]. We use the UTF8 character set and that means 8190 characters as each character might take four bytes. The maximum size of a row in Firebird is 64 KB [sic]. Avoids errors when creating sample tables using the wizard using just the default values. If the varchar column lengths are under 8190 but the total row size is too large you do get a relatively helpful error message "new record size of <N> bytes is too big", but if you try use a too large size for a varchar column, just some "SQL error code = -204", "Impmentation limit exceeded", etc. Change-Id: I17c2bed4fc098f4e159822f6f81242aae274da7b Reviewed-on: https://gerrit.libreoffice.org/47232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-01sal: (win32) readd comment explaining about buffer size decisionChris Sherlock
Readd comment explaining why we allocate a large buffer for GetEnvironmentVariableW which was removed in commit f78a2bcce88dd5c12052ae3e55c561cdd48b05fe: re-base on ALv2 code. Includes: Patch contributed by Herbert Duerr: #i118662# remove berkeleyDB from module xmlhelp (author=orwitt) http://svn.apache.org/viewvc?view=revision&revision=1213188 #i119141# remove ISCII converter for now http://svn.apache.org/viewvc?view=revision&revision=1306246 make exceptions for cppunittester verbose http://svn.apache.org/viewvc?view=revision&revision=1174831 Patches contributed by Pedro Giffuni: Avoid some uses of non portable #!/bin/bash in shell scripts. http://svn.apache.org/viewvc?view=revision&revision=1235297 Patch contributed by Oliver-Rainer Wittmann 88652: applied patch, remove unicows deps http://svn.apache.org/viewvc?view=revision&revision=1177585 drop OS/2 code, remove in-line assembler ARM atomics, and obsolete armarch header. Change-Id: I75a222393e202e40d78f10fc97f5eb4aad2df743 Reviewed-on: https://gerrit.libreoffice.org/47018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-01Don't call getLength() on OUStringBuffer after makeStringAndClear()Tor Lillqvist
It's the length of the OUString that we just made from the OUStringBuffer that we want. Fixes a problem where the code would try to execute an erronoeus SQL statement like: ')EATE TABLE "Tasks" ("Notes" VARCHAR(32765),"TaskID" INTEGER,"EndDate" DATE,"StartDate" DATE,"Description" VARCHAR(65000),' Too lazy to file a bug for this, the error should be obvious by just reading the code. Change-Id: I473cd8a7a9791700ca8b6467a84f4bad5dee4d55 Reviewed-on: https://gerrit.libreoffice.org/47230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-01Fix typosbansan85
Change-Id: Idcc291dba5cb6d86e29d00f6b34905f6693f7540 Reviewed-on: https://gerrit.libreoffice.org/47207 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-01-01tdf#114775: fix crash when deleting some rowsJulien Nabet
see bt https://bugs.documentfoundation.org/attachment.cgi?id=138757 Change-Id: I493bf47b1541262a5ea78b541bc1f47f93cc73df Reviewed-on: https://gerrit.libreoffice.org/47219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-01Bump copyright year to 2018Adolfo Jayme Barrientos
Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476
2017-12-31improve const-correctness in ScCaptionPtrNoel Grandin
mostly to make my passstuffbyref loplugin happier Change-Id: I148b6b418100de860dfc49aaec6c544d0fe14c72 Reviewed-on: https://gerrit.libreoffice.org/47225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31loplugin:passstuffbyref improved return in lotuswordproNoel Grandin
Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682 Reviewed-on: https://gerrit.libreoffice.org/47222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31Fix indentbansan85
Change-Id: Ie92d9f6cafd0b0af7db9cdb846073762bd4ba7b9 Reviewed-on: https://gerrit.libreoffice.org/47204 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-31tdf#114755: Remove extra parenthesisJulien Nabet
from SELECT block of INSERT INTO <> SELECT <> Change-Id: Ibe3c3f5f2fbc15388c716ae262e87137958c1a7e Reviewed-on: https://gerrit.libreoffice.org/47218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-31loplugin:passstuffbyref improved return in emfio,writerfilterNoel Grandin
Change-Id: I237936d62d0f1b17574dd88b5c9de932dc03238e Reviewed-on: https://gerrit.libreoffice.org/47214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31ofz#4848 Null-dereference READCaolán McNamara
Change-Id: I632aca7e3f59b7edf48c8c35eff4abf1946af652
2017-12-31ofz#4852 Integer-overflowCaolán McNamara
Change-Id: Ifb6a56783ce02a12f5fa5dfae4c815e963dcfe3c
2017-12-31try to fix android buildCaolán McNamara
Change-Id: I80c01fbf839c6980bc8dab40267d1407ca8e1398
2017-12-31ofz#4845 avoid oomCaolán McNamara
Change-Id: I816e2a2e2c21bf999c261e59c860fd142ba59f76
2017-12-31CurrentTableInPaM->PendingTableInPaMCaolán McNamara
Change-Id: Ic8b48d3b3e3f87e9ac3e8a6bb832f8e8dfe8ab7d
2017-12-31App icons: shrink svg files to a minimumandreas kainz
Change-Id: Ifb17c8a7b6f2d5cd4616256bbec08b9c51007be0 Reviewed-on: https://gerrit.libreoffice.org/47201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-31tdf#114045 do not add undo action for table attributesMark Hung
CreateUndoAttrObject() create extra undo steps when using table paint brush on table cells. Undo action for each selected cell is processed individually in SvxTableController::ApplyFormatPaintBrush(). Change-Id: I65034a2b510898db26a7a8ddc4b5f3b742fd9b88 Reviewed-on: https://gerrit.libreoffice.org/46729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-31tdf#51188: allow connector gluepoint undoMark Hung
It should had overwritten the connector data when the connector attach to a different glue point of the same object. Let’s always overwrite it, though it waste a little bit time. Change-Id: Ib4cc4bf105e5ef17289e027dcddd0110f7297190 Reviewed-on: https://gerrit.libreoffice.org/46559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-31Tango icons: add svg files for the app icons in resandreas kainz
Change-Id: I1fc91911844f86572b102fe0dfb8ccdcd42fce0d Reviewed-on: https://gerrit.libreoffice.org/47186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-30Updater Icon: Shrink svg fileandreas kainz
Change-Id: I8a45d4e620b1865dda28eb56a89207226eeac9b2 Reviewed-on: https://gerrit.libreoffice.org/47202 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-12-30ofz#4753 Bad-cast, check all open tablesCaolán McNamara
Change-Id: Ie6e2fb9f2e16e021a4719c418f52ce074c359904 Reviewed-on: https://gerrit.libreoffice.org/47199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-30Disable loplugin:casttovoid when --disable-assert-always-abortStephan Bergmann
...as finding uses of variables in arguments to expand-to-nothing assert macros is just not implemented not implemented. Change-Id: Iacb3bd25d03eca13ac8ff3942f98e46dee3286b9 Reviewed-on: https://gerrit.libreoffice.org/47200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-30loplugin:passstuffbyref improved return in cui,dbaccessNoel Grandin
Change-Id: I1193ff91ccd548acf9492d9701b6411a24d6763e Reviewed-on: https://gerrit.libreoffice.org/47194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-30iOS, make LIBRARY path relative.jan Iversen
Patch based on suggestion from jon Nermut. Change-Id: I91244ad839b2a7f532b45c0ca8b37228c2ff27b1
2017-12-30tdf#90626 PPTX: Fix image bullet position in PPTPaul Trojahn
Scaled bullet points aren't centered in PPT, so padding needs to be added to get them to the correct position. Change-Id: I61509dd43ef9cd697dcbc3cabbf58a21d625ddec Reviewed-on: https://gerrit.libreoffice.org/46994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-30Enable test for exporting text color of activeX checkbox controlTamás Zolnai
It's fixed in: 05f72a2a39fccb58f59b99ebfd3e7d0d8ff354e9 Change-Id: I5f82b1bd5dc0b2155398e4fc74da21f1a96e1d56 Reviewed-on: https://gerrit.libreoffice.org/47193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-30crash in sc, make TextSearch thread safeCaolán McNamara
with tdf95460-1.odt Change-Id: Ic4e643b8e6ae6235fb79ed458f891afd4a4b73fc Reviewed-on: https://gerrit.libreoffice.org/46380 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-30ofz#4837 Null-dereference READCaolán McNamara
Change-Id: I7e4cb934aeac32fa1170beb116e4600b5eb9389a Reviewed-on: https://gerrit.libreoffice.org/47197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-30update android rgba cairo patch to apply againCaolán McNamara
Change-Id: Iaee918439f8472bab7fab2cf545ac2e420d614ab
2017-12-30coverity#1427008 Result is not floating-pointCaolán McNamara
Change-Id: I3066bf4d7161a2606d0f2f7dd33deefe2ed2f421
2017-12-30coverity#1427009 Uninitialized scalar fieldCaolán McNamara
Change-Id: I372e9f7e286e2c563533c88205b7eb5ada1c02b4
2017-12-30tdf#113788 ActiveX controls' text color is not exported to DOCXBán Róbert
The convertFromProperties function does not set the text color. Background color is a similar property and it is handled similarly. Change-Id: I2c1bff6198640b9a30f70d9db641425166ced992 Reviewed-on: https://gerrit.libreoffice.org/47185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-30iOS, bump version to 11.2jan Iversen
Change-Id: Ia24e872f138a78d3d585150e3cde78858de60b77
2017-12-30Support for tcmalloc and jemalloc is long deadStephan Bergmann
When it was originally added to --with-alloc (tcmalloc: f63ffaf3667e218be3538e84e6becc18d5de4334, 54efc5ed83890f0a1166ece3b1e4942bb7922ff7, 0abd71b44144220d2aeec58601929fd0cd1914d6 708b6d4246de915ac960c7b90ee8bb2d966c7d17 "INTEGRATION: CWS configure14: #i59160# allow usage of tcmalloc and system-malloc"; jemalloc: 826a90d68a4dc458585c6d2e647bec17971e9193 "configure25: #i111045# jemalloc"), the old build system's solenv/inc/unxlng*.mk added corresponding -l switches to linker command lines, but it appears that was never carried over into the new build system. And even if the AC_CHECL_LIB calls in configure.ac prior to e612f026de6ca1153c57fb10f0fa75725425a301 "Ensure AC_CHECK_LIB/AC_SEARCH_LIBS do not poison LIBS" would have extended LIBS with the correpsonding -l switches, there appears to be no mechanism in the new build system that would have depended on letting that have any effect on which alloc lib to link against. So the only remaining effect of --with-alloc={tcmalloc,jemalloc} is to set FORCE_SYSALLOC in Library_sal.mk, same as --with-alloc=system does. So whoever still uses the former configure switches should just switch to the latter. (Also adapt the documentation of --with-alloc to reality, "internal" instead of "oo".) Change-Id: Iac0e302c5f9602daf5f8452a0fc1887dc55ee27b Reviewed-on: https://gerrit.libreoffice.org/47178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-30Incrementing end iterator has undefined behavior (dbaccess/cacheset)Julien Nabet
Change-Id: I9f4cdacd87cc4802b13c99c15e1d24d11285a375 Reviewed-on: https://gerrit.libreoffice.org/47188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29Elementary-icons: add Page Layout iconsandreas kainz
Change-Id: I2f11dab4035cb6866d953239515eec3bc6602dfd Reviewed-on: https://gerrit.libreoffice.org/47183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-29tdf#75256 New sifr icon for deletetableMatthias Freund
Change-Id: Id03229cf9229880f570cacba61ae2e563c05559e Reviewed-on: https://gerrit.libreoffice.org/47170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
2017-12-29loplugin:unnecessaryoverride fix for changing accessNoel Grandin
Change-Id: I61b908999be7d94eed0c421125f8e1fc07e3c2db Reviewed-on: https://gerrit.libreoffice.org/47182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Updated coreMike Kaganski
Project: help cac2a5ccfd5d7197a1a1ad706bca5f0f4235a2fd Correction to the QUOTIENT spreadsheet function documentation If arguments have different signs, it isn't equivalent to INT(numerator/denominator). E.g., QUOTIENT(-3,14;1) gives -3, while INT(-3,14/1) gives -4. Change-Id: I1abe0a6bd77ba5f451844cf3e5c2ab2e021d7c96 Reviewed-on: https://gerrit.libreoffice.org/47171 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-29ofz#4825 Bad-castCaolán McNamara
Change-Id: I57f180c9e28d5f2439efcc1f2726d8fabc108bc9 Reviewed-on: https://gerrit.libreoffice.org/47176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-29loplugin:passstuffbyref improved return in variousNoel Grandin
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560 Reviewed-on: https://gerrit.libreoffice.org/47173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin
Change-Id: I8128aa4b5fc60efd1dbf5971cdde11e588f5f64b Reviewed-on: https://gerrit.libreoffice.org/47167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-09 10:28:44 +0000