summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-02-01tdf#107427: sw: move UItest to CppUnittestXisco Fauli
Change-Id: I13b8757c384c3ecd23c0b06b93e2db03ce0b364e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146431 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-01sw: introduce SwFlyFrame::IsFlySplitAllowed()Miklos Vajna
And use it in SwFrame::IsMoveable(). With this, SwContentFrame::MakeAll() calls into SwFlowFrame::MoveFwd() for a paragraph that's inside a fly frame that doesn't fit is body frame in fly split mode. Towards an initial layout for multi-page fly frames. Change-Id: I5a1d5ca499c08dd32432cfacf49d01f393e5d324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146427 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-01Finally drop undocumented rtl_[u]String_newFromStr null argument supportStephan Bergmann
...executing on the TODO left by 4f0c70fb5554325e0cc2129741175bf07de22029 "Avoid calling OString ctor with null pointer" in late 2020. Change-Id: I3db6e2df61ca290948affc5e02ae74757441471d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-01xmloff: import of theme structure + import/export/round-trip testsTomaž Vajngerl
Change-Id: I50e8c53c534895098613e81fd97b346fd3d7d05f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146287 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-02-01sw: implement "Theme" property for the XDrawPage in WriterTomaž Vajngerl
Change-Id: I8eed04f0ccb2e626a648abcaecd957b6f62c39d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146226 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-02-01CppunitTest_sw_rtfexport5: fold preTest() into its only userMiklos Vajna
Avoid magic in preTest() based on the bugdoc name. Change-Id: I7642828480bb4f636956b966275d8c3e26919a50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146421 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-01tdf#153272: add some missing properties in SwSearchPropertiesJulien Nabet
RES_CHRATR_RELIEF RES_CHRATR_ROTATE RES_CHRATR_SCALEW RES_PARATR_VERTALIGN Change-Id: Ic4a3323a4b4b4231dee083016a6112a9e2674c86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-01tdf#152073 qt: Draw background when drawing frameMichael Weghorn
For native drawing of a frame (border), use the window background color as default color. As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06 ("tdf#138010 (IV) VclScrolledWindow: Use actual border width"), the Qt/KDE Breeze style uses a frame width of 2, with the actual 1 pixel border being surrounded by a 1 pixel padding/margin. Transparent background did not ensure that the 1 pixel padding/margin is repainted and could thus result in artifacts from what was painted to that location previously (s. the Basic IDE editor example from tdf#152073). Use the window background for the default image color when drawing a frame to avoid this. The gtk3 VCL plugin also explicitly draws a background for the corresponding code path, using `gtk_render_background`. An alternative might be to explicitly draw the background further up the call stack, or pass an explicit background color from `DecorationView::DrawFrame` and only apply a default color in `QtGraphics_Controls::drawNativeControl` when a background color (other than `COL_DEFAULT`) is passed to that method. Sample bt for gtk3: 1 GtkSalGraphics::drawNativeControl salnativewidgets-gtk.cxx 1835 0x7fffe6271f92 2 SalGraphics::DrawNativeControl salgdilayout.cxx 807 0x7fffee887739 3 OutputDevice::DrawNativeControl nativecontrols.cxx 287 0x7fffee58906e 4 (anonymous namespace)::ImplDrawFrame decoview.cxx 600 0x7fffee1b2055 5 DecorationView::DrawFrame decoview.cxx 886 0x7fffee1b32c8 6 ImplSmallBorderWindowView::DrawWindow brdwin.cxx 742 0x7fffee0ea3ea 7 ImplBorderWindow::Paint brdwin.cxx 1630 0x7fffee0ee99a 8 PaintHelper::DoPaint paint.cxx 313 0x7fffee0c9f1c 9 vcl::Window::ImplCallPaint paint.cxx 617 0x7fffee0cb4b3 10 PaintHelper::~PaintHelper paint.cxx 552 0x7fffee0cae14 11 vcl::Window::ImplCallPaint paint.cxx 623 0x7fffee0cb513 Many thanks to Rafael Lima for the very helpful analysis in [1] and [2]. [1] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c2 [2] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c3 Change-Id: I08e6d05d0fc3d0e54952a65cd28dee92615df0a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146419 Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2023-02-01cui: Make SimilaritySearch dialog async and enable use for jsdialogHannah Meeks
Change-Id: I89c6665138c94aa355efbbc4aa0947226c68af5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146130 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-02-01Remove duplicated includeAndrea Gelmini
Change-Id: I84dc37baac93f946bd66b6d709a43529d023dac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146381 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-01tdf#66580 write more metadata to embedded and attached filesTomaž Vajngerl
Change-Id: I6f40fd98b48893d01d29a806877821c561688897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146288 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31Remove duplicated includeAndrea Gelmini
Change-Id: Ia5f606fd64737aed372afb2ee4762f9eb3e21a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146380 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-31language tool warnings in console on start up with language tool not configuredCaolán McNamara
warn: languagetool:3333070:3333070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372: CURL request returned with error: 3 warn: languagetool:3333070:3333070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372: CURL request returned with error: 3 Change-Id: I67de3351c6f01ed8274b4a282b45ded9f5cea5c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31add default mode linesCaolán McNamara
Change-Id: Ie0485f52f81f31f821f8a6ebc4720528da33fa48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31tdf#152770 undo move warning about ppd with no resolution to use of resolutionCaolán McNamara
and downgrade to SAL_INFO Change-Id: I9a565aa12f83e7ed8dd6b0f903f7b18d62c16c4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31tdf#153083 writerfilter: import locale-dependent TOC \t style names, 2Michael Stahl
There was a problem with commit ecbad22fdf81c6f072b6c9f9c16dbba47fe4748c while it now worked in Writer, the roundtripped DOCX with the en-US built-in style name in the TOC field no longer worked in Word in the original locale (but started to work in en-US locale). Let's try a slightly different approach: use the same style name as-is from the TOC field, and if it doesn't exist as a style, then clone the en-US built-in style with that name, and at the end of the import, iterate all paragraphs in the document and replace any application of the en-US style with the localised style. So both the en-US style and the localised style exist, and for references that aren't fields (e.g. basedOn in other styles) it should hopefully not matter which one is referenced. The DOCX exported from Writer now has a TOC field that works in Word in the original locale. Change-Id: Ibcc3c5899e31295b5704ebefb548f40b67eda9bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146414 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-31tdf#153273 bodge dark scrollbar into drop downsCaolán McNamara
Change-Id: I9c53b931feb7f720f86edfbb6ae88ff5ee436cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146386 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31Restore changes accidentally overwritten in ↵Adolfo Jayme Barrientos
1fb964276c184b0fb052503fe7dbc05bf0331211 Change-Id: I3630a1fe1365593103b1670926d4e7aa318d9a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146374 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-31lok: add Rest Protocol propertyHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I7353e16dbf835684e5ce5963387359924352937b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145599 Tested-by: Jenkins
2023-01-31lingucomponent: implement custom parse response rest protocolHenry Castro
Response: HTTP/1.1 200 OK Transfer encoding: chunked Content-Type: application/json { "hyphenation-positions":[ {"offset":15,"quality":0}, {"offset":20,"quality":1} ], }, "check-positions":[ {"offset":15,"length":6,"errorcode":4711,"type":"orth","severity":1,"propos als":["Entwurf","Entw\u00fcrfe"]}, {"offset":22,"length":3,"errorcode":8221,"type":"orth","severity":1} ] } Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I87228237f23306fb367edab1e21ce002aaf13f2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145598 Tested-by: Jenkins
2023-01-31tdf#153287 rollover in dark mode with "Explorer" is incongruousCaolán McNamara
Using "CFD" gives a brighter border with rollover, but no notable focus state when focused. Try a combination here to get something decent. Change-Id: If7844cb0f1e88410959aa622b0271c3f3954230e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31uitest: remove wait_until_file_is_availableXisco Fauli
Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75 "uitest: introduce wait_until_file_is_available" as a blind fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91 It turned out the root problem was caused by another test and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385 "uitest: Always change doc info setting back to false" Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-31uitest: Always change doc info setting back to falseXisco Fauli
otherwise it won't be changed if an exception is raised affering other tests as seen in https://gerrit.libreoffice.org/c/core/+/130530/2/sw/qa/uitest/writer_tests6/save_readonly_with_password.py#50 Change-Id: Ife443cc6627025a05a0a33ba1c86140f087dd70c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146385 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-31tdf#153289: remove problematic assertionMike Kaganski
It is unclear what it should guarantee; but at least when ungrouping, SwDoc::UnGroupSelection copy-constructs a shared pointer (increasing the refcount), then a copy-constructed argument passed to lcl_CollectTextBoxesForSubGroupObj increases it once again, and then the assertion expectedly fails. Change-Id: I0cb5f303c67b2dc67d5583a9eb03fe405af3573d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-31lingucomponent: implement custom request http rest protocolHenry Castro
Request: POST /api/check HTTP/1.1 Host: localhost:8099 Content-Type: application/json Cache-Control: no-cache { "dictionaries": [ "daily", "jungblutt" ], "text-language": "en-DE", "property-sets": [ "base", "daily", "culture" ], "hyphenation": true, "spellchecking-level": 1, "correction-proposals": true, "single-word-mode": false, "message-language": "fr-LU", "message-level": 1, "text": "This is a final throw for the interface to the Duden server." } Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2a288a7c573014d42df03f7cc12c57a7f788750e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143107 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145597 Tested-by: Jenkins
2023-01-31tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroektagoel12
Also change some range based for Change-Id: I2e17feaba7a6b219aa0c9126c5046cf3bdf855d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145988 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-31loplugin:unusedfieldsNoel Grandin
Change-Id: I6acce1578d21da0ac014410289def3dd500b4de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-31tdf#97362 Convert comphelper SequenceOutputStreamUnitTest to PythonChenxiong Qi
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: I72826fc8180fcb147ff84b10b88c16a4084799ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145690 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-31another stab at making this test reliableCaolán McNamara
Change-Id: If044ae7906f3e98ea558dc90d9580052874e97bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31tdf#143148 sw: inc: Use pragma once instead of include guardsRasenkai
Change-Id: I7a491038d1b8532385e70294872d209dcdc63ce9 Signed-off-by: Rasenkai <rasenkai99@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146300 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-01-31Resolves tdf#137269 - Disable ToC preview by defaultHeiko Tietze
Dialog is too large with the preview for small screens Setting is stored so users who enable it will have the preview next time Change-Id: Iecf63fe10ce35d2132fc3578cd2c239a6b214e40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144003 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-31Some simplification after 743dd1d3c1142c1c99b0844cc26dd0be91a1de40Mike Kaganski
MapMode ctor taking origin and scales sets mbSimple to false, so avoid calling it when these are the defaults. Some calculations become unneeded when the fraction is (1, 1). Change-Id: I19a98ad2cac0a66b9bd7b72620180addb3f7fec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-31sd: use XTheme to transport the theme to xmloff import/exportTomaž Vajngerl
Refactor the existing places and tests in Impress code (sd) to use it instead. Also keep the old property of construction and view of the theme with a sequence of property values, but under the new property named "ThemeUnoRepresentation". This is needed by the UI tests currently. Change-Id: I484567f4a603f1a5e2e03955fdd2b63132dcc66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146225 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31sw: if the fly is to be split, then limit its growth in SwFlyFrame::Format()Miklos Vajna
It seems the first direct cause why flys are not split is because flys can grow forever, so an inner paragraph's SwContentFrame::MakeAll() will never hit the nBottomDist < 0 condition, which is necessary to call into SwFlowFrame::MoveFwd(). With this, at least nBottomDist is negative when a fly with two paragraphs is at the bottom of a page and only one of them fits the body frame. Also add a debug environment variable, so I can debug the "fly split" case till we don't have import/export filters for this. Towards an initial layout for multi-page fly frames. Change-Id: I43114b5795dd42e518a1d776ccd2e7ab607ad859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146376 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-31osl::Mutex->std::mutex in AnimationNodeNoel Grandin
Change-Id: I9a07afcdf17ca464e6a1083fbd7ec1e1f7186a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-31Fix locking orderStephan Bergmann
JunitTest_sfx2_complex occasionally deadlocked when the main thread at > framework::UndoManagerHelper::isUndoPossible > chart::UndoCommandDispatch::fireStatusEvent > chart::CommandDispatch::addStatusListener > svt::ToolboxController::bindListener > framework::ToolBarManager::UpdateControllers > framework::ToolBarManager::AsyncUpdateControllersHdl > Scheduler::CallbackTaskScheduling > SalTimer::CallCallback > SvpSalInstance::CheckTimeout > SvpSalInstance::ImplYield > SvpSalInstance::DoYield > ImplYield > Application::Execute > desktop::Desktop::Main has acquired the SolarMutex in framework::ToolBarManager::AsyncUpdateControllersHdl and is now trying to acquire framework::UndoManagerHelper_Impl::m_aMutex, while a cppu_threadpool at > framework::UndoManagerHelper_Impl::impl_clear > std::function<void ()>::operator() > framework::(anonymous namespace)::UndoManagerRequest::execute > framework::UndoManagerHelper_Impl::impl_processRequest > framework::UndoManagerHelper_Impl::clear > framework::UndoManagerHelper::clear > gcc3::callVirtualMethod first acquired framework::UndoManagerHelper_Impl::m_aMutex and then tries to acquire the SolarMutex. That additional acquiring of the SolarMutex had been added to framework::UndoManagerHelper_Impl::impl_clear in 8611f6e259b807b4f19c8dc0eab86ca648891ce3 "ref-count SdrObject". Change-Id: Ifcb8765b29b65f773be6bbe54092346c5ae3a33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146371 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-31svx: Refactor (sdr) views to access the SdrModel by referenceTomaž Vajngerl
In SdrPaintView (and subclasses) the mpModel variable is always the same as the input (reference) model, so there is no need for that extra variable. Change the strange and confusing var. name mrSdrModelFromSdrView (the input reference to SdrModel) to just mrModel and use that in GetModel(). Change the GetModel() to return a reference instead of a pointer and reactor the code to accomodate the change. This gets rid of many nullptr checks for the pointer that the GetModel() returns and makes the code more simple is some cases. Change-Id: I18351a417fd82f49262a83de036ec1420a65399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-31sw: document SwTextFootnoteMiklos Vajna
It's a bit confusing that "footnote" may mean "footnote" or "footnote or endnote", depending on context. Change-Id: Ibe19dc29f68d1409feb052296e9a3537b160882e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146366 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-31osl::Mutex->std::mutex in ImplEventAttacherManagerNoel Grandin
Change-Id: Id8a4d2d75b1be8f23f6b1260a7a7727ab6bbd27b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-31SdrModel: we never set scale fraction to anything else than 1/1Tomaž Vajngerl
This removes the scale fraction on SdrModel - SetScaleFraction and the m_aObjUnit instance variable, as it is never set to anything else than 1/1 (and don't see it usefult to set it to anything else than this). Change-Id: I990d20f110b3be00e6770b68e39df212f9c576be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146348 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-30cui: add entry "RestProtocol" to language tool dialogHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I6511fc2b353c47b1ff537c42d3484b3a42c1b121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143106 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145596 Tested-by: Jenkins
2023-01-30svtools: add new entry "RestProtocol"Henry Castro
Custom Rest API protocol Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If2f72330f2ed9768f230dc88296df7f757be263a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143105 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145595 Tested-by: Jenkins
2023-01-30Added option to disable ssl verification for languagetoolMert Tumer
This will allow to use self-signed certificates with local run languagetool APIs Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145594 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-01-30external/skia: Still missing includeStephan Bergmann
9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111" had removed the whole external/skia/missing-include.patch.0, including the part added by 5877c6b118c99c9ec807a111471bfd67720a5086 "external/skia: Missing include" (for snprintf in workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h), even though at least my GCC 13 trunk build still requires that. However, the comment at <https://gerrit.libreoffice.org/c/core/+/145552/2#message-7fad3bfd39568500aa66b1c03dfd1670dad636f2> "external/skia: Missing include" pointed out that this "landed upstream at https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/commit/29d492b60c84ca784ea0943efc7d2e6e0f3bdaac", so switch to using a git-format-patch of that (slightly hand-edited to fix up the path of that project's vk_mem_alloc.h as included in the Skia tarball, and to cater for that file's usage of CRLF line endings). Change-Id: I31192b6e0aaf355d5cfee96badc59903ab592aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146365 Reviewed-by: Sam James <sam@gentoo.org> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-30Fix typosAndrea Gelmini
Change-Id: Iaed6f8d3316200f8c5e0c96766a84d59b1066928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146367 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-30external/skia: Another constexpr template point of instantiation issueStephan Bergmann
...with --with-latest-c++ after 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111", > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.cpp:8: > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.h:11: > In file included from workdir/UnpackedTarball/skia/include/core/SkBitmap.h:12: > In file included from workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:14: > In file included from workdir/UnpackedTarball/skia/include/core/SkRect.h:19: > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/algorithm:1747: > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:28: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'SkStrikePinner' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<SkStrikePinner>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:46:47: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::~unique_ptr' requested here > std::unique_ptr<SkStrikePinner> = nullptr) SK_EXCLUDES(fLock); > ^ > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:20:7: note: forward declaration of 'SkStrikePinner' > class SkStrikePinner; > ^ Change-Id: I367323706d047da18fd8d4230a47a78fbb32b677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146349 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-30Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to c6cea6707879ad1c8f5bd11ff26b774f2e59b013 - tdf#142380 Use CSS variable for background color Change-Id: Ia70389ced5e8b698c034f9eec8cb4f030d27dd81
2023-01-30tdf#153260 VML export write trim value true in any caseRegina Henschel
LO renders Fontwork shapes always so as if trim=true is set. But the default value for trim attribute is 'false'. Therefore always write out 'true'. Otherwise the import will treat it as 'false' and apply the shape height reducing workaround. Change-Id: I626c5a84627f16011198a9a4e35d8fedf1fd1b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146361 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-01-30tdf#150380 Calc crash clicking on the title of the Border Color toolbar popdownNoel Grandin
There is probably a better fix for this, but we have a popup inside a popup here, so some weirdness is to be expected. At least it doesn't crash now. Change-Id: Ifaa928c47c3cbfaec8379f01f007b0c1daf4e5a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146359 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-30sw: blind fix for uitest hangXisco Fauli
Seen in https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132028/consoleFull#101810144248ce9c26-9d0a-43a8-83d8-c44f54920d59 Change-Id: I67312b3f7e6c6192e14a6bb3236ba4ff959002f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146353 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-29 02:10:30 +0000