summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-28tdf#139734 removing redundant asserts after MacrosTest::loadFromDesktoppragat-pandya
Change-Id: I89ffa387464ce7cc43c1884b031d6fade5b85078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129581 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-28SwNavigator: fix cursor positioning on comment context menu 'Edit...'Jim Raykowski
Makes the cursor end up in the selected comment annotation window instead of at the comment anchor position in the document when a comment annotation window has the cursor focus and the Comment context menu item 'Edit...' is selected. Change-Id: Iac87177670a1b74525dd03ecce05135c4b89d692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130572 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-02-28uitest: remove duplicated testsXisco Fauli
They are pretty much the same as the other one in the same file Besides, the 'with self.assertRaises(IndexOutOfBoundsException)' nonsense Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-28Fix typoAndrea Gelmini
Change-Id: I9502432260287ae0e6d17231c60f34b4ae2e3729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130722 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-28tdf#122471 xlsx import: pivottable error OUString, not uInt8Justin Luth
This fixes a LO 6.0 regression from commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8 which only half-way changed to OUString from uInt8. An exception was raised because in XLSX, an INT was written while the corresponding read function was expecting an OUString. However, doing this runs into problems with binary files (xlsb), which were still setting the value to an int. Unit test shows the need to use OUString for xlsb too, which now matches what I see in Excel 2003. make CppunitTest_sc_pivottable_filters_test \ CPPUNIT_TEST_NAME=testPivotTableErrorItem2FilterXLSX Change-Id: I399c9e34984bb1ff71695a87aa56f53063d37b3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130714 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-28Fix the tests failing when invalid certificate is in cert storeMike Kaganski
Change-Id: I72055c814a11a76c4934610bcad9c24aae21164e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130690 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-28Fix jurt/source/pipe/staticsalhack.cxxStephan Bergmann
> jurt/source/pipe/staticsalhack.cxx:62: > sal/rtl/ustrbuf.cxx:29:9: error: 'RTL_LOG_STRING_BITS' macro redefined [-Werror,-Wmacro-redefined] > #define RTL_LOG_STRING_BITS 16 > ^ > sal/rtl/strbuf.cxx:27:9: note: previous definition is here > #define RTL_LOG_STRING_BITS 8 > ^ > In file included from jurt/source/pipe/staticsalhack.cxx:62: > sal/rtl/ustrbuf.cxx:29:9: error: duplicate defines [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 16 > ^ > sal/rtl/strbuf.cxx:27:9: note: previous define [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 8 > ^ after 22de5757a2c7c6cd4544a4699e5d4c69969f5961 "Deduplicate string buffer code" Change-Id: I5e6883effea0ce53c96cb5da8e02142450216ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-28tdf#146463: chart2_import2: Add unittestXisco Fauli
Change-Id: I1c8879eaab8cfc3d623a27d7d5d3d8a9cffb003b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130693 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-28wina11y: Drop another 'using' directiveMichael Weghorn
This is similar to Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213 ("wina11y: Unify how AccessibleRole is referred to here"), just for `AccessibleStateType`. Change-Id: I5e99fad42dab87e0e303e5a08c610f6af77641ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130700 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-28wina11y: Unify how AccessibleRole is referred to hereMichael Weghorn
Using using namespace com::sun::star::accessibility::AccessibleRole; and then case /*AccessibleRole::*/DIALOG looks a bit odd. Drop the `using` directive and consistently use `AccessibleRole::<ROLE>` across this source file when referring to `AccessibleRole`s. Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130699 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-28wina11y: Rename IsSpecialToolboItem -> IsSpecialToolbarItemMichael Weghorn
Change-Id: I972a65783fcb481e91db68e6e58124d46f78ee66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130698 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-28wina11y: Convert unomsaaevent.hxx constants to enum class UnoMSAAEventMichael Weghorn
Also drop the previous comments for the constants that add little value and are partially outdated. See the actual implementation to see how values are mapped to send out actual MSAA events, e.g. the previous comment // CARET_CHANGED --> EVENT_OBJECT_LOCATIONCHANGED was no longer correct by now, since that is by now mapped to `IA2_EVENT_TEXT_CARET_MOVED` in `AccObjectWinManager::NotifyAccEvent`. Change-Id: I38111ccb60c06f73ce53b18a6ca32e13dbd629b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130697 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-28wina11y: Drop useless #ifdef blockMichael Weghorn
`ACC_DEBUG` isn't defined anywhere and the `pFile` variable/member used inside of the `ifedf`ed block doesn't exist either. Change-Id: I0d04ca71dbc9a731a6673fad9b69c1229c472d16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130696 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-28ofz#45117 Integer-overflowCaolán McNamara
Change-Id: I1827c1bf3e0153d071b354f9b958d5f84bb2d8a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130710 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#1500397 silence Resource leakCaolán McNamara
this reverts commit 1142dc2398de2e2be0e057ecb432ad9c8895313a Date: Sun Feb 27 14:14:18 2022 +0100 cid#1500397: Resource leak with an alternative that hopefully silences coverity and helps show better what is going on Change-Id: Ifb117d65789e80e66419911dbb6b327bdf7ed948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28tdf#146962 sw: hide deleted row at deletion in Hide ChangesLászló Németh
In Hide Changes mode, deleting table rows with change tracking wasn't applied on the table layout immediately, only using Show Changes and Hide Changes again. Now the deleted row removed from the table instead leaving an empty table row (except the last row of a wholly deleted table). See also commit 95213407dfcbf34056037d60243ff915340d1a2e "tdf#146622 sw crash fix: don't delete already deleted rows". Change-Id: I864957cafa38e631a65db0670c7b566cb689f4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130701 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-28check if cast is to the right typeCaolán McNamara
LIBREOFFICE-311XVJ95 Change-Id: I159f516daafad3e4088677fe2c8c6f5423b3e264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130666 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28Related: tdf#147667 don't toggle radiobutton on mnemonic if it's not uniqueCaolán McNamara
which we already do with checkbuttons, and is what gtk also does when this arises Change-Id: I1b5a4c98bd5062f3a340a53a5d6d977a4af3e384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#1500555 try +taint_sanitize instead of -taint_sourceCaolán McNamara
Change-Id: I2a0f9ef243c3f17717afed8809b1e3fbc033c6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#707501 Uninitialized scalar variableCaolán McNamara
Change-Id: I89f08a858b7a820fce1dd3bc2b914c3e5eb3d656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130703 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#707500 Uninitialized scalar variableCaolán McNamara
Change-Id: I4680b59483ae827cbceb567968dc6c4e864f7ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130702 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#707503 Uninitialized scalar variableCaolán McNamara
Change-Id: I8e1c27f04d8a2ce2ff4608f97b5ff58c55833a37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28tdf#103800 PPTX shape import: fix regression of text colorTünde Tóth
defined by list styles. Properties in a:lstStyle of p:txBody should take precedence over the same properties defined in a:fontRef of style elements. Change-Id: I02cc886eb9eba94f49fe413a63bf7c46c9e3c127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130237 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-28tdf#147121 PPTX: fix regression of font size export of empty linesAttila Bakos (NISZ)
If the empty line has got direct formatted font size, don't forget to export it, unless the master setting is applied. Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e "tdf#111903 tdf#137152 PPTX export: fix placeholders". Change-Id: If686e487bca9c198fd7c96860a21e4efe91381bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130005 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-28tdf#128596 PPTX import: fix default tiled bitmap fillTünde Tóth
OOXML bitmap fill element a:blipFill has got default tiled area setting without explicit a:tile in MSO. Previous import of bitmap fill as "BitmapMode_NO_REPEAT" instead of BitmapMode_REPEAT resulted missing or incomplete area fill of shapes and other objects. Change-Id: Idf94f4450980f67172a0126784b3e08cc5c178c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129483 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-28cid#1473807 Untrusted value as argumentCaolán McNamara
rearrange to make it more obvious to coverity that the value of ttf->glyphOffset(glyphID + 1) is the same as nNextOffset and rename the initial use of length to glyflength to make that clearer to me Change-Id: I0e5c53d9929e1e41d500b7c0833b827808b610f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28cid#1501377 Dereference after null checkCaolán McNamara
Change-Id: I9dceb5c33f62df16b43429ba502b0d12180fa403 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28tdf#147667 - Remove hard-coded underscore from UIHeiko Tietze
Duplicate underscores make the hotkey unusable. While the path removes it from the UI it's neccessary to also clean-up the translations. Change-Id: Id8a216c7c928eccebabbac79744cb802c07ae3f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130688 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-28Use 'assert' where appropriateMike Kaganski
Change-Id: Id7ecf874745fb32406bcd2250a954aaf3a345103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130667 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-28sw clearing breaks: add document modelMiklos Vajna
This is meant to represent clearing breaks, as in HTML's <br clear="..."> and DOCX's <w:br w:type="textWrapping" w:clear="...">. The new pool item is in the RES_TXTATR_NOEND section as this property can be only specified on a single document model position: linebreak characters. Change-Id: I6c86097a049e489e1292f42fc8446eb7282c816a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130687 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-28ensure null terminatorCaolán McNamara
LIBREOFFICE-WB8DT2Q9 Change-Id: I98529325bbd3ff475ba84b4991eb17240440df4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28Deduplicate string buffer codeMike Kaganski
Change-Id: Ia23974ad3a827c84bb1a5d633a953625aea2576a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130663 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-28address review comments for "Add XWeak constructor..."Noel Grandin
for commit 27352b81638f2f1e792ab48ec532eaacf6f61718 (origin/master, origin/HEAD) Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Feb 21 16:00:52 2022 +0200 Add XWeak constructor and operator= to uno::WeakReference I accidentally created a new gerrit change for this, and thus managed to miss sorting out various review comments. (*) Fix version number in gcc3.map (*) Narrow the interface (i.e. assume non-null parameter) in WeakReferenceHelper (*) Remove cargo-cult catch and OSL_ASSERT in WeakReferenceHelper (*) Remove accidental indentation Change-Id: I8d1b22dd42216e9293959032d92df65405fb054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28use SfxItemSet::GetItemIfSet in chart2Noel Grandin
Change-Id: I1e5eeb8b29d2139a9c3e72c645bae9a8fb5dffff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28checked signedness of Sfx*IntItem types (part2)Noel Grandin
See comments here https://lists.freedesktop.org/archives/libreoffice/2022-January/088360.html Make SfxItemSet::GetItemState check the type of the ppItem pointer using TypedWhichId the same way we do for other calls. Take the opportunity to name the new method GetItemIfSet and change the signature to reduce the boilerplate at call sites.. This is just the initial commit, the bulk of the patch (the actual usage) will be split into lots of smaller patches to aid bisecting for bugs. Change-Id: I6704059331787c8776f786af764b4ba3478a307b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128908 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28ofz#44991 keep paragraph's that failed to load until import is completeCaolán McNamara
to avoid dangling references to them Change-Id: Ic8710f63a8cf6a6a665348c7c84bf0b43f0e2c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-28sw: prefix members of SwNumFormatBase, SwOutlineContent, SwPostItContent ...Miklos Vajna
... and SwRegionContent See tdf#94879 for motivation. Change-Id: Ib7d6f1eb5b96e4cebcc2f17727e876670869cd14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130662 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-28Use std::unreachable if availableStephan Bergmann
Change-Id: I686e36cf3e77a94293ef6923ba00181eb3e02c81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130661 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-28remove unused FN_PARAM_TABLE_SPACENoel Grandin
ever since commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b Date: Mon Sep 18 16:15:01 2000 +0000 initial import Change-Id: I65b6af6ba02bf99e0884694c8a776af4e0d5e49b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28remove unused FN_PARAM_GRF*Noel Grandin
ever since commit dec81fe5aa2200b9b351240209fde9434a830c5d Date: Tue May 15 09:03:55 2001 +0000 #86986# SfxFileDialog/SvxImportGraphicDialog removed Change-Id: I5d75770dc86e40870abcc8dfe7b62f6711d6aa9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28unwrap data structure in SwCharURLPageNoel Grandin
we want to work with SvxMacroTableDtor and we are unnecessarily wrapping it in SvxMacroItem. Just use SvxMacroTableDtor directly. And remove FN_INET_FIELD_MACRO which is now unused. Change-Id: I83c0c7b0ecd02b996ddad1a03a0fc0dec6c38c10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28tdf#146463 Apply data series filter to the chart legendOuyang Leyan
Consider a data series as hidden if there is no unfiltered value, do not consider data labels. It solves a regression introduced when working on tdf#134059. Change-Id: I6072bf469137d70e0aa353ffbeb0d0a1216ffa5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28Remove redundant _test from i18npool/CppunitTest*Hossein
As suggested in <https://gerrit.libreoffice.org/c/core/+/125813>, the name of the CppunitTests contain a redundant '_test'. This patch removes this additional word from the name of all the CppunitTests in i18npool. The new names for the tests in i18npool are: CppunitTest_i18npool_break_iterator CppunitTest_i18npool_calendar CppunitTest_i18npool_characterclassification CppunitTest_i18npool_defaultnumberingprovider (unchanged) CppunitTest_i18npool_ordinalsuffix CppunitTest_i18npool_textsearch Change-Id: Ie613c0048a7f156c7d815620f2ccb6578c069e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130542 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-28FN_PARAM_NUM_LEVEL is deadNoel Grandin
since commit 3514ad82c4200be292ef6eaa1e94c5c6a41884e4 Date: Mon Dec 10 10:02:46 2012 +0100 sw: unused SwRTFParser Change-Id: Ib437a3b3a59883869aaec35f3c70403d04bcd950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-28tdf#45904 Move XElementAccess Java test to C++Jens Carl
Move XElementAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: I1bc29be9f17d117edecfd889b4f9784ffbd74d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130660 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2022-02-28Colibre: tdf#137520 Revise Text Capitalization, color and Strikethrough iconsRizal Muttaqin
Change-Id: If055a997abd26b59b3a5852d289d793f8cd5850c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130659 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-02-27tdf#135233: Useless looking translatable string: "error text goes here"Julien Nabet
Change-Id: I7e25ea89594b8b71e9009d8e9227e039aff8ee32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130657 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2022-02-27Colibre: tdf#147686 Fix arrow of Text Direction icons (large size)Rizal Muttaqin
Change-Id: I5e70cc6d4439ca80dd53851f4d710628aa90fd2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130647 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-27ofz#45090 Null-dereference READCaolán McNamara
Change-Id: I74c1c0d1a090dbd763336fec845e29d6cc0065f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-27add translator notes for "Key", the K of the CYMK color modelCaolán McNamara
and so on Change-Id: Ia1104f5c92becee8e94c4e2988203149e6b1406d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-23 06:10:18 +0000