summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-04-18reorg to silence coverity#1358586 Using invalid iteratorCaolán McNamara
Change-Id: If93cead2f4caa203b2d1a3e9c787625e6386dc3e
2016-04-18coverity#1358589 Uninitialized scalar fieldCaolán McNamara
Change-Id: I072dc4a54949fb3186be4a41e8865bdf0794297a
2016-04-18coverity#1358588 Uninitialized scalar fieldCaolán McNamara
Change-Id: I32596c33b9d8fc261d51c880ff1c049879f17509
2016-04-18try next hunspell 1.4.0 prerelease milestoneCaolán McNamara
try using reverse iterators here then and remove dictmgr which we don't seem to use or need Change-Id: I981fccc4ca7562d5ab707dc2f605e409169dec07
2016-04-18Fix unconditional seek in sanedlgRohan Kumar
I fixed my previous mistake of keeping that xTransporter->getStream().Seek( STREAM_SEEK_TO_END ); in live code by wrapping it under OSL_DEBUG_LEVEL > 0 . Change-Id: I3f3bd3308e90610ab3d14f112e4da8bf46ecd25c Reviewed-on: https://gerrit.libreoffice.org/24188 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18BASIC : Simplify SbxArrayArnaud Versini
Change-Id: I988fcfed2b03039cbc167eaee1d09bffe42cd411 Reviewed-on: https://gerrit.libreoffice.org/24171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove needless typedef from xmloff/source/style/impastpl.hxxRyan McCoskrie
Change-Id: I573f7933c6353ae92774517a522fc63f871a09fb Reviewed-on: https://gerrit.libreoffice.org/24178 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove the hardly used SyntaxLineSet typedefRyan McCoskrie
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6 Reviewed-on: https://gerrit.libreoffice.org/24176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove needless typedef from basic/qa/cppunit/basic_coverage.cxxRyan McCoskrie
Change-Id: Iba1c48d58daa618107ad84240d613f675d447aad Reviewed-on: https://gerrit.libreoffice.org/24175 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18SfxViewFrame: rename members missing their prefixesMiklos Vajna
Change-Id: Ib690fed0a0ab76325370c2ca42d4e25c4d0a2882 Reviewed-on: https://gerrit.libreoffice.org/24186 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-18- Removed the only-used-once FontLevelVector typedefRyan McCoskrie
Change-Id: I78bdd690cd80b7caee816b005790b0130dffefeb Reviewed-on: https://gerrit.libreoffice.org/24177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18Use const_iterator when possible (svx/gallery2,items,sdr,stbctrls)Julien Nabet
Change-Id: Idd8992fcb76c25120202b24a23820d85ca09e434 Reviewed-on: https://gerrit.libreoffice.org/24174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-17remove define for ERRORBOXMarkus Mohrhard
Change-Id: I6b5695fb36143b36d72b4c7a4b072d41d94f6501 Reviewed-on: https://gerrit.libreoffice.org/24167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-17tdf#99357: Basic, return if .with pNode nullJulien Nabet
Program received signal SIGSEGV, Segmentation fault. 0x00002aaaaed9741e in SbiExprNode::GetVar (this=0x0) at /home/julien/lo/libreoffice/basic/source/comp/exprnode.cxx:118 118 if( eNodeType == SbxVARVAL ) (gdb) bt 0 0x00002aaaaed9741e in SbiExprNode::GetVar (this=0x0) at /home/julien/lo/libreoffice/basic/source/comp/exprnode.cxx:118 1 0x00002aaaaed9afd6 in SbiParser::With (this=0x50eac70) at /home/julien/lo/libreoffice/basic/source/comp/loops.cxx:266 2 0x00002aaaaed9d1a7 in SbiParser::Parse (this=0x50eac70) at /home/julien/lo/libreoffice/basic/source/comp/parser.cxx:437 Change-Id: If0ecacd007a14e2ba81181da0fe472ea667c4cb7 Reviewed-on: https://gerrit.libreoffice.org/24147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16fix last mdds perf problem in MatConcat, tdf#88849Markus Mohrhard
Change-Id: Idf00ff11e1aa4a3439e17938570385ee3b25726c Reviewed-on: https://gerrit.libreoffice.org/24125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16tdf#97380: don't destroy completely window when replace dialogJulien Nabet
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 210 inline bool isApplication() const { return m_bValid && m_bIsApplication; } (gdb) bt 0 0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 1 0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311 2 0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256 3 0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=..., aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154 4 0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213 Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed Reviewed-on: https://gerrit.libreoffice.org/24139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16Updated coreChristian Lohmaier
Project: help a83f16b977a22efea55105438a7e9d5919a9b0a3 remove doubled + in switchinline via pootle-feedback Change-Id: I661e5cc68309ffe1d43803e89fc546e95faf2b73
2016-04-16add VALGRIND_GDB also for normal unit testsMarkus Mohrhard
Change-Id: I1920ece6ca683403d72a68b6705da2dea7c9ad9b
2016-04-16fix crash in perfcheckMarkus Mohrhard
Change-Id: I8e053f5f0c6994c44485f61f5b3dc489271b8c5f
2016-04-16basctl: prefix some membersJulien Nabet
Change-Id: I59660153a33e83dc9457fbee082e8da444b04b58 Reviewed-on: https://gerrit.libreoffice.org/24126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16switch to a row based storageMarkus Mohrhard
The row based approach fits better with mdds Change-Id: I2a03ccadffaa499c17084c6b131aa3f8eaf66573 Reviewed-on: https://gerrit.libreoffice.org/24123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16make the test case smaller to limit runtimeMarkus Mohrhard
Change-Id: I374f33d2001f872075d2d0be1527d19f1be1175a
2016-04-16add test case for smaller MatConcat case, related tdf#88849Markus Mohrhard
Change-Id: I8faf836e87ae371a156e07ec7a5bc274ccf32efd Reviewed-on: https://gerrit.libreoffice.org/24124 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16Updated coreAndras Timar
Project: translations b0a83a046ece7e828d6a7a2d1304661a8367012c Updated Slovenian translation Change-Id: Ia4c57fc04b46f66b928883f7b1550de66d4e313d
2016-04-16be consistent with number of dots (»Image..« → »Image...«)Christian Lohmaier
via pootle-feedback Change-Id: Iaf9ef1a864f8cc759419d70cc7fc50ac5746adf6
2016-04-16add missing test fileMarkus Mohrhard
Change-Id: I92c879c4efc84115556801fc9a3095ef6b876348
2016-04-16Give this dialog a meaningful nameAdolfo Jayme Barrientos
Change-Id: I5eb3aae0e02f3587da441b9771d21520fca3f146
2016-04-16bin theseDouglas Mencken
Change-Id: Ic43d15d68533ee19b1a7268e5b139e4584ceeb42 Reviewed-on: https://gerrit.libreoffice.org/24121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-16Updated coreAdolfo Jayme Barrientos
Project: help 7f951d4a26bf5ec2937c216b14c11f9f5246419d tdf#99316 “AutoText” is now in the Tools menu Change-Id: Idae2e35965b46ceff3a1810009af9f43f7958c76
2016-04-15hunspell: MSVC debug runtime iterators don't want to decrement past begin()Michael Stahl
Change-Id: I258dc551d14ba72113b284be3566ba924434ab4c
2016-04-15tdf#97499 Fixed containers parameters clearing #5tymyjan
Change-Id: If9868734b255605f2376c30e66ca144e6fd8b803 Reviewed-on: https://gerrit.libreoffice.org/24034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-15drawinglayer: fix WNT buildMichael Stahl
Change-Id: I0a545008e1bd7f99fe1f928b4cd42fbcfdc85517
2016-04-15add test for tdf#88849Markus Mohrhard
Change-Id: Id72d94799e20f0b290d5d5b05fb2b351d0750178
2016-04-15fix calc perfcheck buildMarkus Mohrhard
Change-Id: Ied1ca0c9c3e2c7cd34c4d21e27a95df21ab80bf9
2016-04-15loplugin:refcountingStephan Bergmann
Change-Id: I4f696bdb7b37da5949182d522b0d3c6c41fdc756
2016-04-15test pre 1.4.0 hunspellCaolán McNamara
Change-Id: Ied87b41ec02b993fd08ac13f325b9489b6f07456
2016-04-15Related: tdf#99315 BorderLinePrimitive2D: fix solid line primitive widthMiklos Vajna
Regression from commit 2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc (fdo#75260: Correctly draw double lines for both Writer and Calc., 2014-03-03), the problem was that when decomposing a double border line promitive to solid line primitives (which happens for the legacy "border" type, while both the Calc UI and Excel importer creates "border-thin" ones), the decomposed inner line's height was larger than the requested width. As a result there was no gap between the polygon of the inner and the outer line of the double border, looking like a non-double border. The width of the outer border is still incorrect on the screen, though. Change-Id: Ia9713c315ce8f23e2579b257169798e7c82c0a64 Reviewed-on: https://gerrit.libreoffice.org/24115 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-15loplugin:defaultparamsStephan Bergmann
Change-Id: Ie1ae7247ddbdb6cd2390e173ba91b269e7be1195
2016-04-15loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ic2625b08a57b0f8c1e93b861a8a8add12f02229d
2016-04-15Use an iterator for loop to avoid calling n times std::advanceJulien Nabet
Change-Id: I8ba45094cc86cdef07ebbfe334c6c42a108f073e Reviewed-on: https://gerrit.libreoffice.org/24107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-15tdf#95845 Use CommandInfoProvider in formsSamuel Mehrbrodt
Change-Id: I697f8c442cc4db7b38601c32fb71e0201f145354 Reviewed-on: https://gerrit.libreoffice.org/24106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-15disable MSVC warning C4091Michael Stahl
With MSVC 2015 it is triggered by odd code in Windows 8.1 SDK DbgHelp.h and imagehlp.h. Change-Id: I8694e4598fa8e3a6d6c6e8a0f94429af16f40c6b
2016-04-15vcl: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: I275674edf4fc16fdf7aa1155ae488d96ecc4d643
2016-04-15add test for tdf#72240Markus Mohrhard
Change-Id: Ia27b84094e21758286422921e2bd017f9874dc06 Reviewed-on: https://gerrit.libreoffice.org/24104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-15fix InsertTab and DeleteTab in ScMarkData, tdf#72240Markus Mohrhard
Change-Id: Id3168e4cac6c52b36833b454518cce55b51e36b4 Reviewed-on: https://gerrit.libreoffice.org/24103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-15Updated coreAndras Timar
Project: translations 7ff876ba02b07e56e49d66026c702a26b05439a2 Updated Slovenian translation Change-Id: Ia01bf0c4f1627a576ffa307bee2bdb71c37d9d55
2016-04-15update badstatics plugin to look for VclPtr<> staticsNoel Grandin
maybe we should create a "StaticVclPtr<>" class that checks if VCL is still "alive" before destructing the object? Change-Id: If8619f689c29294efa19c37ec782fa07acec728d Reviewed-on: https://gerrit.libreoffice.org/24085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-15clang-tidy misc-forward-declaration-namespaceNoel Grandin
Change-Id: I0566e9992e0d96ee710c8bce2ae6f44a9e83b4e4