summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-28tdf#115549 Check xPropset is exist.Gülşah Köse
Checks xPropset is exist for chart handling on LibreOffice Online. Change-Id: I57947fd23e089ace4df011873613c2f886770b30 Reviewed-on: https://gerrit.libreoffice.org/68493 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-28fix LockCorruptQueryBox titleNoel Grandin
regression from commit 082e69fefb7439fd4f3d543f0c402039e94c1e9c Date: Mon Feb 26 16:53:37 2018 +0000 convert various MessBox to weld::MessageDialog Change-Id: Ia9cef4de4ae9c13201c838f20f0ba6b6cff7f35d Reviewed-on: https://gerrit.libreoffice.org/68490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28tdf#121440 writerfilter: do not use imported style for foot/endnotesVasily Melenchuk
Extra style is causing editing problem near footnote/endnote references. This behavior is a side effect of eaa9cf6a3069fba3d82c046f0041bfb537d9e648, allowing emission of these "technical" styles. Change-Id: I1885b92814746e7b5cd19f3ddd7bc22eb691615e Reviewed-on: https://gerrit.libreoffice.org/68304 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-28fix "doc will be saved" dialog messageNoel Grandin
looks like a copy/paste error in commit 942f05996bc287923cdbcae12c64e57adf8ec975 Author: Caolán McNamara <caolanm@redhat.com> convert remaining ErrorBox to weld::MessageDialog Change-Id: I52d38311b1e276fd799128e058ea0b9c902aef06 Reviewed-on: https://gerrit.libreoffice.org/68491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28Create the SfxRedactionHelper classMuhammet Kara
And move some code pieces, related to the redaction functionality, from objserv.cxx to the new SfxRedactionHelper.cxx file. Change-Id: I6491c9b581ea6d3a05a72117c5b72e1dc19025dc Reviewed-on: https://gerrit.libreoffice.org/68338 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-28GetDialogController not valid yetCaolán McNamara
Change-Id: I476744d8f351f4ab2afce5974355a066edc8a4a6 Reviewed-on: https://gerrit.libreoffice.org/68489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-28sw: fix some borked commentsMichael Stahl
Change-Id: I18edeff43fcae98514c80d9f2c1594cc2f866e75 Reviewed-on: https://gerrit.libreoffice.org/68401 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-28sw: dump SwCellFrame rowspan in layout.xmlMichael Stahl
Change-Id: I4477874116e8059cf0a82b9b3106c9e26a641947 Reviewed-on: https://gerrit.libreoffice.org/68400 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-28Sifr icon theme updateandreas kainz
Change-Id: I70de808487fab77af720897ecd14370396d4bc93 Reviewed-on: https://gerrit.libreoffice.org/68416 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-28remove some unused typedefsNoel Grandin
Change-Id: I7775a7d86e9641cd514e58f03d3727d2ad846120 Reviewed-on: https://gerrit.libreoffice.org/68485 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28Translate German variable namesJohnny_M
As in f2afa2af10d9d30d7160e73881ca6fe5a409f35a Change-Id: I54323e4b993d4c584932608c9d3721becacddb60 Reviewed-on: https://gerrit.libreoffice.org/68247 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-28Use lambda instead of std::bind + wrapper functionSamuel Mehrbrodt
Change-Id: I7d51d09b78297442d07dd4ecbab7b5ce38d8ffee Reviewed-on: https://gerrit.libreoffice.org/68447 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-28loplugin:cstylecastStephan Bergmann
Change-Id: I7f87f24ed65c3fbc4a0a37357c7be4d16b44ac89 Reviewed-on: https://gerrit.libreoffice.org/68467 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-28loplugin:includeformStephan Bergmann
Change-Id: Id2c44c104a417feba152d4af43caca561f3432bf Reviewed-on: https://gerrit.libreoffice.org/68465 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-28In FitToAcutalSize, keep SwColumn's width >= left + right bordersStephan Bergmann
Given SwColumn::m_nWish is documented as "Desired width, borders included." (sw/inc/fmtclds.hxx), it appears that the invariant GetWishWidth() >= GetLeft() + GetRight() should always hold for SwColumn instances. However, during UITest_writer_tests4's test_tdf113284 loading of sw/qa/uitest/writer_tests/data/tdf113284.odt, it appears that some five-column table is created for which initially all SwColumns' GetWishWidth() = 13107 GetLeft() = 144 (except for first SwColumn, where it's 0) GetRight() = 144 (except for last SwColumn, where it's 0) and later FitToActualSize is called reducing each SwColunn to GetWishWidth() = 286 so that for most SwColumns (except first and last), GetLeft() + GetRight() = 288 would exceed GetWishWidth(). And then (still during loading of the test's document), SwFormatCol::CalcPrtColWidth (sw/source/core/layout/atrfrm.cxx) is called for such a problematic SwColumn, trying to subtract from its GetWishWidth() (the result of SwFormatCol::CalcColWidth) both GetLeft() and GetRight(), and store that into sal_uInt16 nRet. Which triggers Clang's -fsanitize=implicit-signed-integer-truncation "runtime error: implicit conversion from type 'int' of value -2 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65534 (16-bit, unsigned)". So make sure that FitToAcutalSize upholds that presumed SwColumns invariant, shrinking the borders as necessary. Change-Id: I3f6fc07e65a0fc5d5f58c99f1dcdea4467b825f0 Reviewed-on: https://gerrit.libreoffice.org/68463 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-28sw btlr writing mode shell: left/right cursor travelling, fix dest paraMiklos Vajna
Fix aVerticalLeftToRightBottomToTop: - fnXDiff takes "logically larger, logically smaller" arguments, so it's first - second for top to bottom text (existing directions) but it's second - first for btlr - fnXInc was effectively unused before, but it probably meant to provide logical left + width, so set that to physical left - width for btlr And then port 3 places in lcl_UpDown() to use aRectFnSet, so we get correct behavior for both ttb and btt directions. With this, pressing the left/right arrow jumps to the previous / next paragraph correctly. Change-Id: I1323e95e2ce0ab2d66a3ea6e02bd50df2cebf232 Reviewed-on: https://gerrit.libreoffice.org/68462 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-28loplugin:stringconstantStephan Bergmann
Change-Id: I84657379bfc999df40a17fc199bdd20b95414e32 Reviewed-on: https://gerrit.libreoffice.org/68468 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-28loplugin:externvarStephan Bergmann
Change-Id: I7f09837e76a8368fd60aed1bb3a16fd0434e11ec Reviewed-on: https://gerrit.libreoffice.org/68466 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-28Fix typoAndrea Gelmini
Change-Id: I8dc9d97b384a2686f7513499e3ee5819a1b05fe8 Reviewed-on: https://gerrit.libreoffice.org/68482 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27Related: tdf#122301 TRANSPOSE() with ForceArrayReturn on callerEike Rathke
As stated in ECMA-376-1:2016 OOXML 18.17.7.327 TRANSPOSE "The formula containing the call to TRANSPOSE shall be an array formula [...]" Similar to commit d0ded163d8e93dc5b10d7a7c9bdab1d0a6a50bac CommitDate: Wed Jan 16 11:17:14 2019 +0100 Related: tdf#122301 FREQUENCY() with ForceArrayReturn on caller Change-Id: I617bfcc0b8ecb244df3441ab885ec926efd77e3f Reviewed-on: https://gerrit.libreoffice.org/68436 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27tdf#123470 textforwarder has stale view of SdrTextObjCaolán McNamara
When we save the document we get a SwXShape for the SdrObject and call getShapeText on it, which creates a TextForwarder for it. The SwXShape is temporary and is discarded afterwards. If we modify the text and save again we get a new SwXShape and a new TextForwarder. If a11y is active, then when the textbox is inserted a11y gets a SwXShape for the object and the SwXShape stays alive while the a11y view of the Sdrobject stays around. The SdrObject will keep a weak ref to the current SwXShape for it, so on save we get the already existing SwXShape instead of a new one. On the first save this is ok, as the TextForwarder is created on demand. On the second save, the problem is that the SvxTextEditSourceImpl of the TextForwarded was initially created without a SdrView so its in sort of a "snapshot" mode, so first time the text is queried, that sticks as the result. So a cached text forwarder cannot be trusted when its for a SdrTextObj that's being edited and HasView is false Change-Id: Ib3d500752f1876086ef1996885a2b86b581f5bc4 Reviewed-on: https://gerrit.libreoffice.org/68457 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Related: tdf#123711 better optimal size for highlighting tabCaolán McNamara
it only uses the color subtab, so just measure ones which can be visible Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784 Reviewed-on: https://gerrit.libreoffice.org/68431 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld UpdateDialogCaolán McNamara
Change-Id: Ieca75774925a8766162481713f6e8a6ba0e9feb0 Reviewed-on: https://gerrit.libreoffice.org/68396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27tdf#123693 raise max sizeCaolán McNamara
Change-Id: I52d69d825ed11a15d9dbbe61f157035361fa5d52 Reviewed-on: https://gerrit.libreoffice.org/68374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27add missing responsesCaolán McNamara
Change-Id: I2c24ea46b6e81ed02ae53da5e9ae1b7df85e44a1 Reviewed-on: https://gerrit.libreoffice.org/68454 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update list of missin icon replacements Change-Id: I193c10fa8c75f61fbcd749284f81e69f5f4ad603 Reviewed-on: https://gerrit.libreoffice.org/68464 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-27Untabify .l files (to silence loplugin:indentation warnings)Stephan Bergmann
Change-Id: I8368c8a1d52f6c55a8cea952b2b02345e41c1e5c Reviewed-on: https://gerrit.libreoffice.org/68448 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#117890 Remove unhelpful screenshots (1/2) Change-Id: I8a96220ae688f78fe43d66ab205323f3d4605140 Reviewed-on: https://gerrit.libreoffice.org/68392 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-27tdf#122689 qt5: Consider external clipboard updatesMichael Weghorn
Previously, once 'm_aContents' had been assigned in 'VclQt5Clipboard::setContents()', its value (or the one set in a subsequent call to the same method) was always returned in 'VclQt5Clipboard::getContents()', thus ignoring all system clipboard updates done by any other third-party applications, preventing copy-paste from other applications. In order to take external clipboard updates into account, add a slot for the 'QClipboard::changed' signal and drop the current own clipboard content if the clipboard has been updated by another application. In order to detect whether the clipboard update was made by this 'VclQt5Clipboard' itself or elsewhere, a custom MIME type "application/x-libreoffice-clipboard-uuid" is added, whose value is set to the clipboard's (randomly generated) UUID. If the entry is present and has the correct value, the clipboard content was added by this clipboard and can be kept. Otherwise, clear 'm_aContents', so that it's newly assigned in 'VclQt5Clipboard::getContents()', taking into account the external clipboard update. [Side note: Testing showed that, on Wayland, more 'QClipboard::changed' events were emitted without the clipboard content actually having changed (e.g. when switching focus between windows), which is why an approach of simply setting a flag and checking for that one is not enough, like "wrapping" the 'QClipboard::setMimeData()' call in 'VclQt5Clipboard::setContents()' as follows m_bIsFillingClipboard = true; clipboard->setMimeData(pMimeData.release(), m_aClipboardMode); m_bIsFillingClipboard = false; and then evaluating the 'm_bIsfillingClipboard' flag in 'VclQt5Clipboard::handleClipboardChange' instead of using the UUID-based approach. These additional 'QClipboard::changed' events did not show up the same way while testing on X11.] Change-Id: Ib3a6a4f9b7f5ca3573666fb9c072ae97cf2e0049 Reviewed-on: https://gerrit.libreoffice.org/68214 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27KDE5: set correct parent menu in functionAleksei Nikiforov
Set correct parent menu in function Qt5Menu::InsertMenuItem instead of just returning it and setting it later if needed. Change-Id: Id866987e91ec1d57c720735da6afc44109aa901a Reviewed-on: https://gerrit.libreoffice.org/68437 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#121970 KDE5: Regenerate menu when it's set as submenuAleksei Nikiforov
Also add item bits change notification function for SalMenu to properly convert regenerated menu items to check or radiocheck items. Change-Id: I61f16a771b484644bbefd9afaf2776232d38a2f9 Reviewed-on: https://gerrit.libreoffice.org/68438 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-27tdf#123728 Always print on main thread to avoid deadlocksSamuel Mehrbrodt
Change-Id: Ia8c2600aee42c3063e18032d1e485ad417ec4639 Reviewed-on: https://gerrit.libreoffice.org/68421 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-27tdf#104235: Qt5Frame: Set default iconMichael Weghorn
Set a default icon in Qt5Frame constructor, similar to how it's done for the gtk and gtk3 VCL plugins in 'GtkSalFrame::InitCommon'. Change-Id: I4e4e62ffa0eca6499f4752ff467d004cae68788f Reviewed-on: https://gerrit.libreoffice.org/68450 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-27oox smartart, picture strip: fix lack of margin in text shapesMiklos Vajna
Shape text has two kind of spacing inside the shape's bounding box: the shape-level margin and the paragraph-level one. Only the second was handled in the tx algorithm so far, add support for the first. The margins taken from constraints were way large by default: the only explanation I found for that is that SmartArt layout sometimes calculates in MMs, sometimes in Points, and the ratio between the two is exactly the Impress / PowerPoint margin. So assume that indeed that unit difference is the reason for the smaller in-PowerPoint margin values and do the same on our side. Change-Id: I6f1e54301e2e9b33a7e721be34244d968cccf42d Reviewed-on: https://gerrit.libreoffice.org/68453 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-27ofz#13431 fix buildCaolán McNamara
since commit c600817e8349db7957f517365f65f25e4e042439 Date: Mon Feb 25 15:34:13 2019 +0200 Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOP Change-Id: I95ff8ed3dc81ec542ac76d5f5bbd7582391c84a5
2019-02-27CppunitTest_framework_dispatch: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c Reviewed-on: https://gerrit.libreoffice.org/68435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-27Related: tdf#123711 make border page potentially narrowerCaolán McNamara
use size groups to align things rather than forcing homogenous cols Change-Id: I4a1496f15663c4dcbcd6aaf3ea7901c9c7b170d2 Reviewed-on: https://gerrit.libreoffice.org/68427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Relate Python & Basic examples together Change-Id: Ib6abffdfb2f83688eb84f94553f44b3f10dc33c2 Reviewed-on: https://gerrit.libreoffice.org/68388 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-27Add missing modelines to .l filesStephan Bergmann
...and change connectivity/source/parse/sqlflex.l license header from using (unusual, anyway) // comments to using /* */ comment, so that it can go before Flex's opening %{ Change-Id: I371890e937cc5055405c17226dd87ba1694688aa Reviewed-on: https://gerrit.libreoffice.org/68433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27lok: sc: clicking on individual chart elements doesn't select objectMarco Cecchetti
Exporting to svg a selected object of a chart does not work. In the chart case the selected object for the current document is always the chart itself, not an internal chart object. Moreover the exporting action cause the exported object to be selected again. So you try to selected the chart legend and you end up with the whole chart selected again. Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5 Reviewed-on: https://gerrit.libreoffice.org/68347 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-02-27openssl: upgrade to release 1.0.2rMichael Stahl
Fixes CVE-2019-1559, plus a couple low-severity CVEs. Change-Id: Icb6849ca5f33cb1169ce303505b2e32636e3b25b Reviewed-on: https://gerrit.libreoffice.org/68430 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-27Resolves: tdf#123711 measure scrollbar for optimal widthCaolán McNamara
Change-Id: I30225124e44e8a6290270ecba5024f36508817d3 Reviewed-on: https://gerrit.libreoffice.org/68428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Simplify condition whether to return array of references or matrixEike Rathke
Now that we have ParamClass::ReferenceOrRefArray and supporting functions use it as parameter classification and it is set at the called function in array/matrix context, use it as indicator when to return the reference list array and when to return the result matrix. Change-Id: I1fd6001f51530b0d1cfd61320f1cd58521c4fa40 Reviewed-on: https://gerrit.libreoffice.org/68426 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27Fix GenericSolarThreadExecutor<...,void> specializationStephan Bergmann
Change-Id: I4468a3a8d036ca4894ba7977f6654244552464aa Reviewed-on: https://gerrit.libreoffice.org/68423 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27Fix apparent temporary debugging leftoverStephan Bergmann
Change-Id: I3277a341137b1b404ad9839431b5cc39a88fcbe1 Reviewed-on: https://gerrit.libreoffice.org/68425 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-27tdf#42949 Fix IWYU warnings in sc/source/ui/d*/*cxxGabor Kelemen
Also additions were needed in include/sfx2/msg.hxx to avoid build breakage Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I259ff10aaa5d044d4b11f9041174765d5a5f7dc7 Reviewed-on: https://gerrit.libreoffice.org/68364 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-27tdf#123557 PPTX: Export timenode condition targets.Mark Hung
Refactor the code and reuse WriteAnimationTarget to export the target element for the condition element in stCondLst and endCondLst. Add testTdf123557 to make sure import-export-import works. As SdOOXMLExportTest2::testTdf90627 no longer produce corupt pptx that has endCondLst without Cond element, make the xpath more specific about what is testing. Update schema because drawooo:enhanced-path incluced in the test case. Change-Id: If5d64f5c23aa2652cfa72471f9f7886c7dd956eb Reviewed-on: https://gerrit.libreoffice.org/68211 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-27Unit test for array formula and OFFSET() non-ReferenceOrRefArray, tdf#123477Eike Rathke
Change-Id: I1ffe56ada6caed305fd2dbd5fb838e6a7ab3c2e2 Reviewed-on: https://gerrit.libreoffice.org/68408 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-27Fix commentStephan Bergmann
...after ce2792eda318b2760d24d2a744fc89e6a1d87138 "use C++11 exception rethrowing" Change-Id: I7a5cf53daa833cd398e520f67bf4bc5f36b21989 Reviewed-on: https://gerrit.libreoffice.org/68422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-22 18:59:06 +0000