summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-17tdf#98058 Respect menu:style="text" settingMaxim Monastirsky
It was implemented on the xml handling side, but ignored by the menubar code. In addition, make the menu:style attribute survive customization (similar to tdf#114261). Change-Id: I92a3517ee7ba2fe7a0782985d89fb5d0fdbac246 Reviewed-on: https://gerrit.libreoffice.org/46627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-17loplugin:unusedindex Remove useless outer loopMike Kaganski
Change-Id: I6e5e7162b1e0ea2b9f33866ea76e2614acdffb06 Reviewed-on: https://gerrit.libreoffice.org/46606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-17Updated coreOlivier Hallot
Project: help b6e0ecde5fb3eafe88846f055a4917ac99d38e36 tdf#112155 Help page for Save a Copy Change-Id: Ie514f96925c0283e05ac9686b06edbda7853801b Reviewed-on: https://gerrit.libreoffice.org/46632 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help f583ac513198a3aa70840f63aa26d766e5f9daf3 tdf#106421 Terminology change Set Paragraph Style Change-Id: Ia05979c826a283296396ecca42277ce8d352ef1c Reviewed-on: https://gerrit.libreoffice.org/46629 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17fix searched attribute for 3D chart shape, tdf114169Markus Mohrhard
Change-Id: Ic0642d4b223db121bdf5968af73811af8571bd72 Reviewed-on: https://gerrit.libreoffice.org/46614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-17Updated coreOlivier Hallot
Project: help 8b0a4944747cde7395b36e53893d85dc8b07ee05 tdf#40460 Improve help for Calc IRR function Change-Id: Ie61635f75ec8d208656623c61b31d1bc82c75663 Reviewed-on: https://gerrit.libreoffice.org/46625 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help 52613d9b557df908883211cbfb49e7a5f2b9ce3c tdf#106535 better help pg. for text selection modes Change-Id: I4d48553d9ca261493e52183a4b47d5a9e40595d4 Reviewed-on: https://gerrit.libreoffice.org/46620 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help 3114a84355a738b365d3c65c403a8062305ddaff tdf#104171 Cleanup of Macro Help pages Removed shared/main0600.xhp (obsolete) Fixed links between help pages Added entry to tree file (contents) Change-Id: I2a954c328f214728d554bff2166f82b2c2b96f35 Reviewed-on: https://gerrit.libreoffice.org/46618 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17coverity#1426171 Unchecked dynamic_castCaolán McNamara
and coverity#1426170 Unchecked dynamic_cast coverity#1426164 Unchecked dynamic_cast coverity#1426165 Unchecked dynamic_cast and duplicated lines look like cnp gone wrong Change-Id: I195204e9d0a4d591fbe210241203a17b22b25ec1 Reviewed-on: https://gerrit.libreoffice.org/46603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17coverity#1426167 refactor to be less obscureCaolán McNamara
no logic change intended Change-Id: I10ef6038351b2808c2030aa55f05e078d80345ae Reviewed-on: https://gerrit.libreoffice.org/46609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16coverity#1426162 refactor to be more clearCaolán McNamara
and help out coverity wrt 'Dereference after null check' Change-Id: I8c07fd0afc686e1c0bfd87d9c8bd1ea341f6e616 Reviewed-on: https://gerrit.libreoffice.org/46610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16coverity#1426168 Dereference after null checkCaolán McNamara
Change-Id: Ib3ae45a7b012775ee7d540a565c0324f8dcf456e Reviewed-on: https://gerrit.libreoffice.org/46611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16tdf#113538 Add Hebrew fonts into default installationYousuf Philips
Includes these fonts * Alef * David CLM * David Libre * Frank Ruehl CLM * Frank Ruhl Hofshi * Miriam CLM * Miriam Libre * Miriam Mono CLM * Nachlieli CLM * Rubik Change-Id: Ib16a30c1f5b8fae372b3f9fc3f6de8a3be55bc85 Reviewed-on: https://gerrit.libreoffice.org/45101 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-16Fix typosAndrea Gelmini
Change-Id: Iedb99e41887ebfd6fa290bc113b473c5cc9693b4 Reviewed-on: https://gerrit.libreoffice.org/46600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-16Do not recalculate the same weight over and over again, tdf#114251 relatedEike Rathke
Remember it at the group so if for some reason the group is not calculated as group then the individual cells of the group don't iterate over the RPN again to calculate the same value. This does not solve tdf#114251 in any way, just side-cars. Change-Id: Ia26d4a7fe608d8aaa30686ce95c1caa25da02469 Reviewed-on: https://gerrit.libreoffice.org/46601 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-16Updated coreOlivier Hallot
Project: help cdde6459d147fd50348246d20291b1a3d1cd2f64 tdf#79942 Update Draw File menu description Change-Id: I915d17929a55c6035c70c5d20ad034244263b127 Reviewed-on: https://gerrit.libreoffice.org/46605 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-16Related tdf#114457: fix leak in treeopt (cui)Julien Nabet
Change-Id: I28bd32d01bb3d90e68e816720b1b5af7d517760f Reviewed-on: https://gerrit.libreoffice.org/46602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-16can use GetSelectedEntryData hereNoel Grandin
Change-Id: I1f42603a034a28cdd75f6d611a2ddab1fa3c8e40 Reviewed-on: https://gerrit.libreoffice.org/46585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16sal_uLong->SalPrinterError in SalPrinterNoel Grandin
and define a default implementation in the base class that returns SalPrinterError::NONE, since only one of the subclasses wants to override and return something useful Change-Id: Id41ff90693527e8624cc2993b7481114af85fcee Reviewed-on: https://gerrit.libreoffice.org/46509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16sal_uIntPtr->sal_uInt32 in yieldCountsNoel Grandin
to match the underlying field in GenericSolarMutex Change-Id: I98dcab3b684278c4a184534ba782b5b03b0504f0 Reviewed-on: https://gerrit.libreoffice.org/46508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16sal_uIntPtr->SfxItemPropertyMapEntry* in SdExtPropertySetInfoCacheNoel Grandin
Change-Id: I65d284cc1fbc013a17d4bb2f0dd7d7d8d3ccf56f Reviewed-on: https://gerrit.libreoffice.org/46507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16tdf#97648 ooxmlimport: horizontal line's horiOrientJustin Luth
Although LO won't visually do anything with this property (because o:hr is improperly imported AS_CHAR), at least import and assign the property so that it is there for the future if o:hr is changed from AS_CHAR to AT_*. The unit test just adds a test for the existing status - to highlight what still needs to be fixed. o:hr probably ought to be AT_CHAR, with no wrapping. However, simply doing that wraps text the wrong way (always underneath) which seems to be a LO limitation of not putting preceeding chars above an AT_CHAR fly. So that's why I'm not implementing a change to AT_CHAR. Change-Id: I4aec99d3976c6d461715dba304cdf9ad98ab12b6 Reviewed-on: https://gerrit.libreoffice.org/42440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-12-16clang-tidy modernize-use-equals-default in toolkitJochen Nitschke
Change-Id: I3c46fd48130dcec081de1f7807405f252ec247e0 Reviewed-on: https://gerrit.libreoffice.org/46593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16ofz: Null-derefCaolán McNamara
Change-Id: I2a0a6fdfe678e898d73e2bdbfe67764300bde494
2017-12-16ofz: dangling pointersCaolán McNamara
make attribute table a shared_ptr and get HTMLAttrs that belong to it to add a reference to it while they exist Change-Id: I2d3ba433700d4a98fd466b38a495ed5a7adae020 Reviewed-on: https://gerrit.libreoffice.org/46449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16lok: sc: header, cursor and selection overlays issues wrt autofilterMarco Cecchetti
Change-Id: I5d797b48083c24e63f7149cf3a469ebf93213311 Reviewed-on: https://gerrit.libreoffice.org/46530 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-16lok: sc: handling conflicts btw group collapsing and cell editingMarco Cecchetti
Now when a cell is edited, a group including the cell in its range can't be collapsed. When whole levels are collapsed all together any group entry including an edited cell is skipped from collapsing. Undo/redo of collapsing/expanding has been (temporarily) disabled in the LOK case, since it could mess things up when a cell is edited and a group is collapsed because of an undo/redo. Change-Id: I401fa69b7a0275e3e14428b16ab48c409408a861 Reviewed-on: https://gerrit.libreoffice.org/46529 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-16lok: sc: append the col, row position to the cell cursor messageMarco Cecchetti
The payload changes from: "x, y, width, height" to: "x, y, width, height, column, row". This feature is exploited by online starting from the 3.0 release. This change is compatible with older online release: the column, row coordinates are just ignored. Change-Id: I7f8c0e3685c57ff20520ee068b215037f6137389 Reviewed-on: https://gerrit.libreoffice.org/46528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-16Updated coreOlivier Hallot
Project: help 263b467e2b2e5f1a5ccb9a76645606e739881b82 tdf#64242 Terminology: Distribute x Spacing Change-Id: I3b393a41cc3b2cb9bb1e017c8fc454b8f684ba45 Reviewed-on: https://gerrit.libreoffice.org/46571 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-16tdf#114286 Move UnderlineDouble to GenericCommandsYousuf Philips
Change-Id: Iaaffb70e0023317816b582e3d2ea32eded66cd71 Reviewed-on: https://gerrit.libreoffice.org/45974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-16Updated coreGabriel Chiquini
Project: help fae24d85eb9fb736c9fdab08c78d25cafb213913 Fixed remaining index search bugs Show list only after typing 3 or more characters Hide labels when module results is empty Change-Id: Ifb7a255b6ac627a0448878df104e837d96074fce Reviewed-on: https://gerrit.libreoffice.org/46134 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-16Updated coreShinnok
Project: help b07c31d8dfa44e18560eaacfe7f63ef2e5e23ff7 Replace usage of readlink -f with realpath. For consistency reasons, the other scripts use the latter. Additionally on macOS/BSD readlink -f option is not available, nor other default tools for canonicalizing paths, so looking for GNU's realpath in the first place is a better bet. Change-Id: I77b82a956f63c66e352a372895cd623f83916168 Reviewed-on: https://gerrit.libreoffice.org/45486 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-16tdf#103080 Dont package Open Sans and PT_Serif fontsYousuf Philips
Change-Id: Iac1d572f19372465e9cc369454480d9b621bcd66 Reviewed-on: https://gerrit.libreoffice.org/45169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-16sw: Modifiy paragraph-split unit test to also..Tamas Bunth
..assert that no section break is inserted after the paragraph which had to be split and which contains a section break between its parts. Change-Id: I5bf2f313202c1dcc2acdf66b2457152b8d44be81 Reviewed-on: https://gerrit.libreoffice.org/46525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-12-16convert EETextFormat to scoped enumNoel Grandin
and drop unused BIN constant Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053 Reviewed-on: https://gerrit.libreoffice.org/46589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16tdf#91781 Round of improvements to Writer's menus for 6.0Yousuf Philips
Change-Id: I17c1edc2e14146144868df51a1f5a71e323eead6 Reviewed-on: https://gerrit.libreoffice.org/46451 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-16tdf#45904 Move _XCellRangeAddressable Java test to C++Jens Carl
Change-Id: Ic3c1e6d793d4405c2dc4b8e7d1d7b87ed94fc6c3 Reviewed-on: https://gerrit.libreoffice.org/46579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-16Move init of keywords around, preset with English, localized case by caseEike Rathke
This way we can't forget an sKeyword element and need to care only about the exceptions. Adds a slight penalty for German in that it has 25 keywords initialized twice, but.. Change-Id: I99ba228ef8b1517a32ce98a9c79cfbe2b1d0b340 Reviewed-on: https://gerrit.libreoffice.org/46575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-16Blacklist CELL() and INFO() for threadingEike Rathke
They access one utl::TransliterationWrapper via ScCellKeywordTranslator::transKeyword() for the localized keywords. Change-Id: Ia3c1ec8def761b3448d6be4c81d42723e1a28ea2
2017-12-16tdf#45904 Move _XCellFormatRangesSupplier Java test to C++Jens Carl
Change-Id: I95c20893878385ef173875956d3d7166b0e9e563 Reviewed-on: https://gerrit.libreoffice.org/46578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-15sw HTML export: add a filter option to produce XHTMLMiklos Vajna
Add initial support for writing XHTML markup as part of the HTML filter. This already emits valid XHTML for hello world documents. Times for 100 hello world inputs: 16032 -> 9957 ms is spent in ODT-load + export + close (62% of original). Change-Id: I51a0a20985958fbc817c196d3a966e55dcb3f13f Reviewed-on: https://gerrit.libreoffice.org/46567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-15Make temp copy of dbaccess/qa/unit/data/firebird_empty.odb for testingStephan Bergmann
...in CppunitTest_dbaccess_firebird_test. Otherwise, the test would fail with > Test name: FirebirdTest::testEmptyDBConnection > An uncaught exception of type com.sun.star.sdbc.SQLException > - The connection can not be established. No storage or URL was given. if dbaccess/qa/unit/data/firebird_empty.odb is read-only, as DocumentStorageAccess::impl_openSubStorage_nothrow (dbaccess/source/core/dataaccess/ModelImpl.cxx) takes m_pModelImplementation->m_bDocumentReadOnly into account and returns a null xStorage. Adds a move ctor to utl::TempFile (thus causing copy ctor and copy assignment op to be implicitly deleted), but leaves any move assignment op undeclared for now, as none happens to be needed (yet). Change-Id: I6f9eff07eb54f1364a0560ffa4cf1f676a319d16 Reviewed-on: https://gerrit.libreoffice.org/46561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15Fix typosAndrea Gelmini
Change-Id: I061839727b3fd078284117fca3ea53413af7bcf0 Reviewed-on: https://gerrit.libreoffice.org/46574 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15Enable C++17 for clang-cl, tooStephan Bergmann
Similar to libc++ in C++17 mode, some types like std::auto_ptr are indeed removed in C++17 mode by default, and need _HAS_AUTO_PTR_ETC=1 to be enabled (see <https://blogs.msdn.microsoft.com/vcblog/2017/12/08/c17-feature-removals- and-deprecations/>). Unlike libc++, also std::binary_function and std::unary_function are removed (and need the same _HAS_AUTO_PTR_ETC=1 to enable). So either set that flag to make external code build, or use patches (for external/mdds) to make externals' files included in LO proper still work there. Change-Id: I886cc0de8196255334ee03ec48cb4bc54d460afd Reviewed-on: https://gerrit.libreoffice.org/46514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15tdf#113861: Unittest for chart datatable labels expansionVasily Melenchuk
Change-Id: I4ed9019fc1e637e344ab1cb80f650b32aa034a9a Reviewed-on: https://gerrit.libreoffice.org/45670 Reviewed-on: https://gerrit.libreoffice.org/46541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-15Get rid of loop counter variableMike Kaganski
Change-Id: Ia4f4e24819525287e720a9c016b3666bc006b545 Reviewed-on: https://gerrit.libreoffice.org/46531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15Update language-subtag-registry-2017-12-14Eike Rathke
Change-Id: Ieab59f83159cc95faa8119b7b43779329c0a4869
2017-12-15ofz#4649 don't care about exceptions for testingCaolán McNamara
Change-Id: I955460276c3bf98457eff6bc9503edd238a5650c Reviewed-on: https://gerrit.libreoffice.org/46506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15ofz#4643 Direct-leakCaolán McNamara
Change-Id: Ie4fff1a113916c7a3344959cfb4ee14c3fda2073 Reviewed-on: https://gerrit.libreoffice.org/46512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-15Apparently missing dependencyStephan Bergmann
Some bots (the Jenkins lo_ubsan, some Jenkins Gerrit Build v2 macosx_clang_dbgutil builds) recently started to fail CppunitTest_sw_filters_test at least sporadically with an abort() from Scheduler::ProcessTaskScheduling (vcl/source/app/scheduler.cxx). ba81ac19b7aec4fd7f07fcec9f6ea6f85d9aaa24 "Report more debug information about caught exception" reveals that at least <https://ci.libreoffice.org/job/ lo_gerrit/24197/Config=macosx_clang_dbgutil/console> fails because of > warn:vcl.schedule:90989:529951052:vcl/source/app/scheduler.cxx:452: Uncaught com.sun.star.uno.DeploymentException component context fails to supply service com.sun.star.embed.FileSystemStorageFactory of type com.sun.star.lang.XSingleServiceFactory Due to the unfortunate try-catch in Scheduler::ProcessTaskScheduling it is hard to tell where the failure originates (and it only hits some bots and I at least can't reproduce it locally), but lets assume that a dependency on svl/source/fsstor/fsstorage.component is indeed missing, but manifests as a failure only in some cases (for whatever reason). Change-Id: I91214490ac6aab99a281c745ba4b2d138b12ddd1
generated by cgit (git 2.34.1) at 2025-02-20 18:02:43 +0000