summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-29tdf#156066: Add support for feImage filterXisco Fauli
Change-Id: I76cf8932ae352c271283483c9c734408a35b6074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153770 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-29svgio: simplify codeXisco Fauli
Change-Id: I18c4179c36c052cc0ed5b416125e72d542cb7407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153749 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-29[API CHANGE] Drop deprecated org/openoffice/ucb/InteractionHandler.xcs fileGabor Kelemen
Deprecated in 2010 by commit af66a011a47f673a9a0ee2c6a0b27e23b11b6ebf Change-Id: I805f9771fe3730f3e186162cab9ea192517a4f2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152401 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29[API CHANGE] Drop deprecated FormulaSyntax propertyGabor Kelemen
It was marked as deprecated when added in 2010 commit 81571e00b1b423929459ffdb34fd519e7f3d0961 could not find whether it was used ever since Change-Id: I2c14c923f07d97d1df0604b95b3c65b350248029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152403 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29m_aMouseClickHdl is deadNoel Grandin
It was added in commit c706fde1c4ecc6974bcf32ce33aacf3093355ae1 Resolves: tdf#156067 merge special char dialog/popup logic But is never assigned a useful value Change-Id: I476b00a96c53298414239509b2ca5452f0bf08c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153743 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29fix cross-compilation with frozen headersChristian Lohmaier
FROZEN wasn't part of the PERMITTED_BUILD_TARGETS in configure.ac, that in turn means it is not part of BUILD_TYPE when building the crossbuild build-tools. That in turn means gb_Helper_optional in external/Module_external.mk doesn't add it to the external module dirs, and that means the makefiles from external/frozen aren't read, more specifically there won't be any gb_UnpackedTarball_UnpackedTarball,frozen definition. The UnpackedTarball definitions don't error out in this case, and the gb_Library_use_extenals,module,frozen then doesn't work as expected. It happily depends on the UnpackedTarball_get_final_target for frozen, but since there is nothing to unpack (since the makefiles with the definitions are skipped) that is a noop/it goes straight to just touch workdir_for_build/UnpackedTarball/frozen.update to fulfill the dependency without actually extracting any files. This patch deals with the first problem only, adding it to the PERMITTED_BUILD_TARGETS will allow the mechanism to work as intended. Change-Id: Ie9e8ad47ba4c281fb3246daf67450a16f792b908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153747 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29various XLink fields are deadNoel Grandin
after commit 195364a57a5e3090648cb327607bc52da2be583c Date: Thu Jun 8 13:49:11 2023 +0200 tdf#155733: no need to store these values Change-Id: I4a998add0079cbbcf9eaba38a43fc5411647dd64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153745 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29mbIsUIReadOnly is deadNoel Grandin
after I removed SetUIReadOnly in commit e2c7a6bd572644b928704f6cb3696b568ac0aba1 loplugin::unusedmethods and that was dead because of commit cb32938d572777c9a5d75007cc76ba50c5a698eb [API CHANGE] remove unused SlideSorterService Change-Id: Ib0e170794e0f448b094b3d1ca5d309deab4c1bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedfields make it a little smarterNoel Grandin
around dealing with operator[] on map data-types Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29set->unordered_setNoel Grandin
which is more efficient, and we don't need ordering here Change-Id: I1af4412d94680f4449a2eb00168f6c4cef20bd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29tdf#104877 Implement APNG blending modesParis Oplopoios
Change-Id: Ib7ce4d113ccaa4843b8332087ebe52ac3828180e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153556 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29XML-encode text that will appear in ReqIFMike Kaganski
Change-Id: I56ced6717496d6c0a5fe0bcb86de47ae4142e953 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29ReqIF: add unit test for frame text in 'object' elements' alt textMike Kaganski
Change-Id: I369ee9a4e50d758f2a463f79e37e60fb38ca49b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153734 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29[API CHANGE] Drop obsolete Mapping config keyGabor Kelemen
Obsoleted in 2010 by commit c79b576a3dbbbce2a67c6215a4180ac060131790 Change-Id: Iaca64f7560d485338d9de9be19e09d69a83c0d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152402 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-06-29tdf#155706 tdf#86630 sw page number wizard: make OK defaultAron Budea
Change-Id: If1b902d34157be8c9eab2d5ec140f5e85dfc49e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153731 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-29getComplexColor: return a const reference, to avoid an extra copyMike Kaganski
Change-Id: I28ff81c08be4e18169fe8b8fcd67818ea5319d9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153737 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29Fix buildMike Kaganski
Failing like ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class Color const & __cdecl SvxBrushItem::GetColor(void)const " (__imp_?GetColor@SvxBrushItem@@QEBAAEBVColor@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ) ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class model::ComplexColor const & __cdecl SvxBrushItem::getComplexColor(void)const " (__imp_?getComplexColor@SvxBrushItem@@QEBAAEBVComplexColor@model@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ) C:\lo\src\build\workdir\LinkTarget\CppunitTest\test_sc_theme_import_export_test.dll : fatal error LNK1120: 2 unresolved externals Change-Id: I7a64405e3e8bf774163d8f101681c2c0de892767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153736 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29Simplify a bitMike Kaganski
Change-Id: Ia1c142d9841075f307fba69f79999697992a5c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153735 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29increase space around tabbed pane titlesNoel Grandin
Tabbed pane titles are currently incredibly cramped, increase the space a little to make them match better with current OS layouts (all of the different OSes we support use quite a lot of space around the titles) Change-Id: If9c7b4df81f8d206556e7c75097650ae21508384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29tdf#156066: Add support for feDropShadow filterXisco Fauli
Change-Id: I0b2772a7211efb91821853e3369cfc3a5ef6a932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153727 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-29tdf#152723: NatNum12 modifier, keep decimal separator from local settingsJulien Nabet
Change-Id: If49e7b42ac37eead4ef0a902b2e56735bb4017bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153732 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-06-29tdf#156032 - A11Y: fix remove of empty issue sectionsBalazs Varga
Remove issue categories if there is no more issue in it. Change-Id: Ic5dddf3db59c574d1e8712d79bdf203a6b637eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153724 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2023-06-29ReqIF: output frame text instead of name in 'object' elements' alt textMike Kaganski
Change-Id: I79d827edf00143e06b2601018fdf647d6d342355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153721 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29tdf#73537 - sc: show author and creation date in calc commentsBalazs Varga
in temporory mode. Show the author and creation/modification date of the the comment only in temporory mode. In edit mode, or visible mode, shows only the original text. Change-Id: I2c5856e4c6a813dbef4ad55de319f922daa57f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153358 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-06-29tdf#154981 - A11Y sidebar: fix warning missing signature line descBalazs Varga
Add graphic shape objects to "Go to" and "Fix" functions. Change-Id: I258d3664613cbd53b7b26aaa8d88715660d921dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152707 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-29maLayoutLineToPageId and maLayoutPageIdToLine are dead.Noel Grandin
I removed the code in ImplDrawItem that added data to them, because ImplDrawItem was only ever called with bLayout with false, and removing the bLayout param removed that code. That removal happened in: commit f0f973da8560e16cba85d2c9465c3a8c4c0ebbb3 Author: Noel Grandin <noel@peralex.com> Date: Wed Mar 16 08:49:35 2016 +0200 loplugin:constantparams in vcl/ And that happened because.... I noticed that ImplPaint was only ever called with bLayout==false, which meant I removed that param and passed bLayout==false to ImplDrawItem, in: commit 911ae0aeca443fb4b5e400ae0f939567b580e443 Author: Noel Grandin <noel@peralex.com> Date: Fri Feb 26 09:36:26 2016 +0200 loplugin:unuseddefaultparams in /include/vcl which was because the last call to ImplPaint with bLayout == true was removed in: commit a6b9d9a19fb8c5c9f166682f52941aee25b89c94 Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Wed May 6 13:00:13 2015 +0900 refactor "TabControl" to use RenderContext Change-Id: Id234257201726de95e2c10bfacb30670123ca8a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153713 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29tdf#156031 - UX/A11Y: Clicking on a11y check status bar icon opening a11yBalazs Varga
check sidebar deck. Clicing on the a11y check status bar icon, the a11y check sidebar deck will be opened. Change-Id: Iee2e0e9345ed47dd971a9a61e55471d082d5461d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153723 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-29tdf#156023 - A11Y: Add visual hints when fixing an accessibility check issueBalazs Varga
Go to the issue object and select it, before fixing the issue. Change-Id: I0217922c91045c288df7e48965be259e4d4f7ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153642 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-06-29tdf#155526 Restore status bar for moving averageLaurent Balland
Previous commit dc03f59374d4fc74dd44ddedc903bb9c00a74bb7 broke text in status bar when a moving average trend line is selected Change-Id: I259fb9aee1eccf9fac93038c6dd2755490769f88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153677 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6bba9672d36c691c779ce6d40bbf816e661ec882 - related tdf#153721 new command names: move/delete "chapter" -> "heading" Change-Id: I7415fec49fec0319583a5f87e44e7bd3ee96ef4a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153656 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-06-29sc: Add import tests for text, background, border theme colorsTomaž Vajngerl
Change-Id: I03f0ddb42e6491618e56ba98f5bd8befc9ba47a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153506 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29sc: use ComplexColor for font color (+others) in OOXML exportTomaž Vajngerl
Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29oox: convert Excel tint value into LumOff and LumModTomaž Vajngerl
tint value can be converted into LumOff and LumMod values, so we don't need a special Excel case for calculating the final color. Change-Id: I0725c06f9df6a37a309ea5d17b183e4100a228f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153716 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-28tdf#156078: Use TabOverSpacing compat option instead of TabOverflowMike Kaganski
As Justin Luth noted, "TabOverflow is basically always true", and using it basically equal to making the test always true. On the other hand, TabOverSpacing is accurate for the task. Change-Id: I608b200dac0169cbafc935a03452aac9ba0527a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153722 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#148416 saveas: preserve loadreadonly with passwordJustin Luth
If a document is set to load readonly, and that setting is password protected, then at least suggest using a password on save-as. Change-Id: I788da43733470e56af988e7c4b9f2cae01573e50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153726 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#148416 password dialog: suggest current loadreadonly statusJustin Luth
If a document is set to load readonly, and the user saves with a password, then suggest LoadReadOnly status by pre-populating and displaying the checkbox for that setting Change-Id: I3e848b6f97ed4218d066e8f1790cb8fbea8b208c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153725 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#107787 Sync FillGradientStepCount and StepCountRegina Henschel
The FillGradientStepCount property of a shape or page background and the StepCount member of the Gradient2 API struct or nStepCount member of the basegfx::BGradient class are used parallel and mixed. Therefore we need to be careful to keep the values in sync as far as possible. Change-Id: I58ab9654ba0106417794fafe68fb296e66cb3bf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153714 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I21b6a4ae3cac15891a6b50bf975658ac404aefa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153613 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-06-28Fix typoAndrea Gelmini
Change-Id: I4c55e4a263a01fd4fa1d84feb49ac97bed793a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153710 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-28tdf#156077 sw: layout: call AssertFlyPages() in Init()Michael Stahl
The bugdoc has 3 pages, and there are at-page flys anchored to the 3rd page, and these are not displayed - simply missing from the layout. In LO 6.1, this worked because the layout-cache was read from the file, and 3 pages were created in SwRootFrame::Init() calling InsertCnt_(). But now this creates only 2 pages, and later SwLayAction creates the 2nd page between the existing ones on some MoveFwd(), but despite page nr 2 becoming page nr 3 nothing attaches the at-page flys to the now-page-3. If a document is loaded containing at-page flys, then all pages that have flys anchored to them should be created in SwRootFrame::Init() already. (regression from commit 7e8b4756d95057f069467b34e7849f9354856578) Change-Id: I4792c483a7620efd81211e6ad0d9220152367d68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153720 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28flat-odf-cleanup.py: remove unused user field declsMichael Stahl
Change-Id: I5271f975ee8bae558dc00bcf8ea778a3203bbc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153719 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 114401853f335d1e85edee8229c4450c575f1f0c - New features of SF_Dialog and SF_DialogControl services (WiP) Change-Id: I5806e7c9cd014bd92e58b2f9aa739a610050ea76 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153598 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-06-28Send writer document background color on theme changeParis Oplopoios
Send the doc background color to the kit on theme change Change-Id: Ic025e542417da004c1c4a2bfd58a858deb4caa58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153715 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-06-28sc: prefix m_* ScViewFunctionSet class membersHenry Castro
.. Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153405 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8276b9593a2a9e3a0d5aaeaadd64369667120303) Change-Id: Ic16ae0fc6580e350444576a087c333d52296ec5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153663 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-06-28these TAB_ constants do not need to be in the header fileNoel Grandin
they can be inside the .cxx file Also rename slightly and document. Change-Id: Iffd46e9ed6c02aad597a616ac1c583ae657fab40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-28tdf155903 DOCX export: fix corrupt file with embedded mediaTünde Tóth
Regression from commit bc72514f90d90e1ab3fed8167663e835edf03508 "tdf#53970 PPTX: fix export of embedded media files". Change-Id: I04521227346817d91f720b1f6a77beb7f4a01f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153619 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2023-06-28Simplify SvxSearchItem::PutValue a bitMike Kaganski
Change-Id: I2cbc5dce800b773e6c20cb3ea6f0e520a3f69db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28tdf#146547 sfx2: preserve modified state from read-only to editableMichael Stahl
SfxViewFrame::ExecReload_Impl() calls DoSaveCompleted() which resets the modified state, but in this case the document wasn't actually saved. Change-Id: I54f6508a652cc42a127bc59058c5b435dd1a25a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153676 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Move SwXFootnoteText Java tests to C++anfanite396
Change-Id: I7f3477799f532f52993cd0add51185bfd15c7446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153631 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-12 18:21:56 +0000