summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-07Resolves: tdf#121954 basic input box used to have label on top of entryCaolán McNamara
so for a quiet life arrange it like that again. https://xkcd.com/1172/ Change-Id: I8d1f3a914f8792b8c91ccd1b98d1fbd2a25a4213 Reviewed-on: https://gerrit.libreoffice.org/64777 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update links for missing Colibre icons Change-Id: I827b755259ac7dc8de9a706dc111fd021be22306 Reviewed-on: https://gerrit.libreoffice.org/64783 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-12-07Fix typoAndrea Gelmini
Change-Id: Idc4dc73e61b828f989e6c8b46a6fc1fa43253ae6 Reviewed-on: https://gerrit.libreoffice.org/64740 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-07uitest for bug tdf#107869Zdeněk Crhonek
Change-Id: I797b13c3ba76869e67c12832402798ab2b65596a Reviewed-on: https://gerrit.libreoffice.org/64776 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-07tdf#121017, tdf#121897: editstyle is always paragraph styleXisco Fauli
Change-Id: Ia82e6e5c4d6c3e78ba5fbc320d299acf3800a72e Reviewed-on: https://gerrit.libreoffice.org/64766 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-07utility constructor for Image "private:graphicrepository" urlsNoel Grandin
Change-Id: I118039f4e47818a43da9302ce3550ea800522675 Reviewed-on: https://gerrit.libreoffice.org/64765 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-12-07HAVE_BROKEN_CONST_ITERATORS is always false nowStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Change-Id: Ife94cdfd56696edb113e32d84f563dd805e757e5 Reviewed-on: https://gerrit.libreoffice.org/64769 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07Use ref for SvTreeList's parent SvListViewMike Kaganski
Follow-up of commit 74816dd665fb2980823e01f81446147fe7fe6688 Change-Id: I246df80586c8fc60efc68b5deeb865cbfcd0da13 Reviewed-on: https://gerrit.libreoffice.org/64762 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-07Find actual data area inside the main-range...Dennis Francis
and trim all ranges to match this actual data area. Don't do this optimization for COUNTIFS where there is no main-range. This optimization is also turned off if any of the parameter ranges are not double-refs. Benefits in cases like - =SUMIFS(A:A, B:B, ">=20", C:C, "<=10") and the is data only in say A1:A10000 and rest are empty. Range trimming in this case saves lot of execution time and memory (for vConditions and vRefArrayConditions). Change-Id: I6b4ad91e23f89dc48603b98000bcef4dbdb03112 Reviewed-on: https://gerrit.libreoffice.org/64657 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-07Use correct __cplusplus value with MSVCStephan Bergmann
...now that /Zc:__cplusplus is available in Visual Studio 2017 version 15.7 (see <https://blogs.msdn.microsoft.com/vcblog/2018/04/09/ msvc-now-correctly-reports-__cplusplus/>). Some external projects might run into issues when picking up /Zc:__cplusplus directly with $(CXXFLAGS_CXX11) or indirectly via $(gb_CXXFLAGS) now, but that appears not to be the case. Some obsolete MSVC-specific __cplusplus checks can be removed now. (The ones in external/libebook/libebook-msvc.patch.1 pick up /Zc:__cplusplus via $(gb_CXXFLAGS) in external/libebook/ExternalProject_libebook.mk.) Change-Id: Idc6849a0000ea424522f30f61caba112fae25d40 Reviewed-on: https://gerrit.libreoffice.org/64755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07loplugin:unnecessaryparenStephan Bergmann
Change-Id: I924034417bcb19a6e535f8dc427c63ff11356b23
2018-12-07Revert "In flatpak build, disable problematic test using gpg for now"Stephan Bergmann
This reverts commit 23339ec77e38ebdae86eb05a2a3d9a3f5609df64, which is no longer needed after TODO.
2018-12-07Upgrade flatpak to org.freedesktop.Sdk//18.08Stephan Bergmann
...fixing <https://github.com/flathub/org.libreoffice.LibreOffice/issues/54> "Build against org.freedesktop.Platform 18.08" Change-Id: I70448277ce326075435932c75a837bd7be3d4508
2018-12-07Drop obsolete font sources from flatpak manifestStephan Bergmann
...which are no longer used by the LO build since 0ce173b50fd12342979cf3f8f9b2d92267552060 "tdf#103080 Dont package Open Sans and PT_Serif fonts" Change-Id: I9ece7a85fe0003711eb23f332e617b780e6701cd
2018-12-07sc: Peel off a pimplTakeshi Abe
Change-Id: I8797ccc165fb0a6060c6232babc299114411130a Reviewed-on: https://gerrit.libreoffice.org/64707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#121779: extend TWo CApitals list to also ignore sMALL iNITIALSMike Kaganski
Now this list is used also in rules for capitalizing first letter of every sentence, and for correcting accidental use of Caps Lock key. Change-Id: I4fbdbccbae32743d5e9a6757344361eefd88e167 Reviewed-on: https://gerrit.libreoffice.org/64759 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-07tdf#114163 Chart: fix order of legend namesBalazs Varga
Respecting the axis direction in case of normal/stacked/percent stacked Bar chart and the legend names will be in the right order. Change-Id: If782393a33e48dae32f919d137e1d1148a85b0b0 Reviewed-on: https://gerrit.libreoffice.org/64632 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-12-07Upgrade external/postgresql to postgresql-9.2.24Stephan Bergmann
...which is the latest 9.2.x currently listed at <https://www.postgresql.org/ftp/source/>. 9.2.1 doesn't build against OpenSSL 1.1 which dropped SSL_library_init (cf. <https://wiki.openssl.org/ index.php/Library_Initialization#libssl_Initialization>), and 9.2.24 apparently has that covered. (Ran into this when trying to upgrade the LibreOffice flatpak build to org.freedesktop.Sdk//18.08, which has OpenSSL 1.1.) On Windows, the new tarball as-is fails with > ..\..\port\chklocale.c(214): error C2037: left of 'lc_codepage' specifies undefined struct/union '__crt_locale_data' because at least in Windows Kits/10/Include/10.0.17763.0/ucrt/corecrt.h (included from Windows Kits/10/Include/10.0.17763.0/ucrt/locale.h), the relevant definitions are now > typedef struct __crt_locale_data_public > { > unsigned short const* _locale_pctype; > _Field_range_(1, 2) int _locale_mb_cur_max; > unsigned int _locale_lc_codepage; > } __crt_locale_data_public; > > typedef struct __crt_locale_pointers > { > struct __crt_locale_data* locinfo; > struct __crt_multibyte_data* mbcinfo; > } __crt_locale_pointers; > > typedef __crt_locale_pointers* _locale_t; which presumably has changed from a past state where that lc_codepage member was directly publicly accessible. <https://dev-www.libreoffice.org/src/postgresql-9.2.24.tar.bz2> is a copy of <https://ftp.postgresql.org/pub/source/v9.2.24/postgresql-9.2.24.tar.bz2>; `sha256sum postgresql-9.2.24.tar.bz2` reports the same a754c02f7051c2f21e52f8669a421b50485afcde9a581674d6106326b189d126 as recorded in <https://ftp.postgresql.org/pub/source/v9.2.24/postgresql-9.2.24.tar.bz2.sha256> Change-Id: I196dd93aa03471042efba57ea639e1bb6655de98 Reviewed-on: https://gerrit.libreoffice.org/64730 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07custom widgets: Rename 'stock' to 'action'.Jan Holesovsky
If the button has this property, it means it is located in the action area, not that it is a stock button per se. Change-Id: Ia57ad24d8cd4ff1d7b74d7ef82da0f352fe3deb3
2018-12-07custom widgets: Better way to find out whether to use the 'stock' theming.Jan Holesovsky
Change-Id: I75ea7b2d407d3acfd3094f17509c89240c48f50a
2018-12-07lok: Right rotation calculation in case of delta angleTamás Zolnai
Change-Id: Ia7d0a573c1902fba3fc1e69f425bbf2dc93a1c82
2018-12-07Avoid moving the shape by rotationTamás Zolnai
The difference between Impress and Writer is the used unit. We can assume that SID_ATTR_TRANSFORM_ROT_X and SID_ATTR_TRANSFORM_ROT_Y contains the values in twips. Change-Id: I44ba9532348200742b2c7c369b89eb2545295684
2018-12-07LOK: dialogs: limit listbox/combobox drop-down lengthAshod Nakashian
Dialogs routed to the LOK client have limited real estate on the screen because dialogs are rendered on a canvas. When the listbox drop-down bleeds outside the dialog area, on the desktop it's no problem, but in the browser, that requires a larger canvas and that brings a host of problems. Here we limit the maximum length of listbox/combobox drop-down lists to avoid this situation. This would ideally be configured via ListBoxMaximumLineCount alas it doesn't work. Change-Id: I55fff28dbfc59dec36714e221f76cf4160ba1505
2018-12-07lok: get correct handlers for a single rotated shapeMarco Cecchetti
Change-Id: I74668ca8079d8d56b8c3f2c4513e2a2ec95872c6
2018-12-07lok sd: Insert the new shapes in the center of the slide.Jan Holesovsky
Change-Id: I134f86dc0c49ddf26e7a3cfe790c49ab200de9e9
2018-12-07LOK: Update failing unit testsTamás Zolnai
Change-Id: Ib30be297d87fa40c03974e0a97f243812dc488f3
2018-12-07lok: Insert shapes directly into the document.Mike Kaganski
Change-Id: I182aa395ce0f4e4185c9c85a866dec89499842f9
2018-12-07Avoid writing out unneeded data to SVG file in SelectionOnly modeTamás Zolnai
Change-Id: I6d0ce089be051667e965aff45a63f6b1a8342952
2018-12-07add parameter TransformRotationDeltaAngle to .uno:TransformDialogHenry Castro
Change-Id: Ib22ba6956afedf1eea055e0ac3a78c53b4ee5861
2018-12-07LOK: Fix API for renderShapeSelectionAshod Nakashian
Unlike C++, C doesn't allow reference-to-pointer types, and we do have C code that wouldn't compile with ref-to-ptr. Had to change to ptr-to-ptr, which is the proper way of having output arrays. For the same reason, we cannot use new/delete, rather we must use malloc/free. Another (lesser) issue was that we used the renderShapeSelection API to echo back an array we give it as prefix. This made the API unecessarily complex (in undocumented ways) and forced the implementation to both worry about user-data and managing the input memory. This logic is best moved to the client and the API simply returns the output data. Speaking of returning data, the API now returns the size of the array it allocated and wrote to, so the client can do a simple check on the return value directly. Change-Id: Ida216c10d5b37efd1e0861e26b72cabb25c568e6
2018-12-07Remove noise from the SVG file exported in SelectionOnly modeTamás Zolnai
Change-Id: Ia09f6ab40c20c17230e8b544987a5d11b7359f2f
2018-12-07Remove cout lineTamás Zolnai
Change-Id: Ic1b30a89ae513b3b3ec71853830ef7600801dee0
2018-12-07svx: add parameters to .uno:TransformDialogHenry Castro
Change-Id: I6d9e110f48b0f4c6226503d01e10d099cfcb130c
2018-12-07Introduce client-server message for requesting the selected shape as SVGTamás Zolnai
It works for Impress only now. Change-Id: I95e3e37ae7df49b567108f6d6467038b715e886d
2018-12-07tdf#39593 vcl: reduce copy-paste in ImplCalcOutSideRgnDmitriy Shilin
Change-Id: I13e13e5e17815bbffef6132ed28fadd3fb12f99b Reviewed-on: https://gerrit.libreoffice.org/64750 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-07vcl: use ref to const while iterating over palette entriesDmitriy Shilin
Change-Id: I2a1b36d9f4bb17f8b60af86a48bc9ec84588a32b Reviewed-on: https://gerrit.libreoffice.org/64749 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-07Clang (and GCC) always has __cplusplus >= C++17 nowStephan Bergmann
...after 665ac8f32d3aaaf7c27e8976e14fd4819edbf79b "All supported versions of Clang and GCC support at least C++17 now". And even if __cplusplus might still be < 201703L for old versions that only support -std=c++1z and not -std=c++17, this #if should probably be enabled for those too. (MSVC will first need adding /Zc:__cplusplus before it has a correct __cplusplus value.) Change-Id: If932b293d66e704357b10836839d221634bb1a3b Reviewed-on: https://gerrit.libreoffice.org/64751 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07SvTreeList only ever belongs to one and only one SvListViewNoel Grandin
so simplify that Change-Id: I6db807c5aa8ed1e6487bdb4f5ac5c96cf8abbcf6 Reviewed-on: https://gerrit.libreoffice.org/64752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07remove unused ConfigItemMode::DelayedUpdateNoel Grandin
unused ever since commit c1758889cbd5e8e4afb1044425c908715eb3e1cd Date: Fri Nov 11 22:48:37 2011 +0100 Heavily simplified utl::ConfigManager. and rename ConfigItemMode::ImmediateUpdate to NONE, since it doesn't mean that anymore Change-Id: Ia1d06142a25c9eea0f1d30b70653eed325a21b37 Reviewed-on: https://gerrit.libreoffice.org/64719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07sc: Drop ineffective SetError()Takeshi Abe
as GetNewMat() already sets error FormulaError::MatrixSize when returning null. In fact IllegalArgument is irrelevant here. Change-Id: Ib7354c2e861b666deef1353b2c26d876668d77e3 Reviewed-on: https://gerrit.libreoffice.org/64420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#120625: All vcl windows now share 1 instance of clipboardKatarina Behrens
so we can copy'n'pasta between apps (or 2 instances of the same app) Copy'n'pasta into system clipboard is still buggy for non-Writer apps Change-Id: I07f025172654dd3e6c0ef9cd5ad78d24224f039f Reviewed-on: https://gerrit.libreoffice.org/64721 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-12-07tdf#121935 crash on "set up connect to text files"Caolán McNamara
Change-Id: I73bc93ebb5010f3a376b3b121e1ac873f1be137a Reviewed-on: https://gerrit.libreoffice.org/64676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-07tdf#121759 Revert "tdf#99296 - Disable headers/footers by default"Heiko Tietze
This reverts commit 08b5048198d59441cb8033ed14cd17e68c943004. Disabled h/f lead to an inactive menu entry (tdf#121759). Also, the change was not accepted by the OP (tdf#99296). See discussion on the mailing list, Gerrit, and BZ. Change-Id: Ie3dcf14c173a1813da05d8f2a9c8f2eda14cee46 Reviewed-on: https://gerrit.libreoffice.org/64727 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-07tdf#111486 Removed not used EMF+ codeBartosz Kosiorek
Change-Id: I708876fecab1bd6b0c37892efa9c4ab180457d6b Reviewed-on: https://gerrit.libreoffice.org/64366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#121448 Check if fill box event notify is already handledJim Raykowski
Change-Id: I8b2e1e7a7bf711e78feb3c0532d597f1e9f14c03 Reviewed-on: https://gerrit.libreoffice.org/64419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#105225 Add palette choice to calc tab background color dialogJim Raykowski
Change-Id: I9891a20d3bc3de51fec84fb54c7aae42f7142662 Reviewed-on: https://gerrit.libreoffice.org/64329 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07tdf#63029 Copy and paste comments with slidePaul Trojahn
Change-Id: Iceb0e744f8e994ece91cd8f50fefaed631aa8396 Reviewed-on: https://gerrit.libreoffice.org/64126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07adapt to the change from sal_Int32 to TextFrameIndexhimajin100000
see commit 2136dc24 and commit e721f958 Change-Id: I07ace74f93adc2568003314b5f05c41611d6f77c Reviewed-on: https://gerrit.libreoffice.org/64671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-07No need to silence -Wregister in lcms2.h any moreStephan Bergmann
...since 2bea600f0295cab7fad3edb55f0c5e092640e49e "external/lcms2: Stop warnings/errors about 'register'" patched those uses away Change-Id: Ib21bb60d158172c8c4e9e93bc3ebaf3729cdecd9 Reviewed-on: https://gerrit.libreoffice.org/64745 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-07Use gb_UnpackedTarball_update_autoconf_configs in external/postgresqlStephan Bergmann
Change-Id: I56c68b74daa701e0e27ca4b661ece12bf20a8776 Reviewed-on: https://gerrit.libreoffice.org/64729 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>