summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-09-07svx: fix font rendering in the style previewMichael Stahl
If the style does not actually have any font items, as is the case for frame, page and number styles in Writer, the maFont will be default-initialized and the maPixelSize incorrect. Avoid using these variables. Change-Id: I084cd8faa90a3d53310ceec55e8dae3af3dd586c
2015-09-07tdf#90991: sw: fix style preview creating undo objectsMichael Stahl
SwDocStyleSheet::FillStyleSheet() already takes care to remove all temporarily created styles, so assume that works and suppress the creation of user-visible Undo objects. Change-Id: I748f0e8304c42e767b331ebd22be0290b9c0d89d
2015-09-07tdf#91383: sw: prevent style preview from actually creating stylesMichael Stahl
The dialog/sidebar should not actually create styles that don't exist yet, because it messes up Undo and the (unused) styles are then unnecessarily exported to documents. Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky. Add a new function GetItemSetForPreview() and use it from the style preview code. The implementation does not use FillPhysical so will temporarily create and then delete any non-existing styles. Skip page and numbering styles for now since they don't have a useful preview. (regression from ca95307638207db5d662059aa61594151a13e927) Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7
2015-09-07sw: fix not-quite-copypaste code in SwDocStyleSheet::FillStyleSheet()Michael Stahl
This causes the temporary creation of frame styles to fail. Change-Id: I5d148ae008660d9c0f457a4c0e9dc256e0dfc49a
2015-09-07sw: convert boost::ptr_vector to std::vector<std::unique_ptr>Michael Stahl
Change-Id: I341fb7c0712dff77ebfed41560a487f85c27c25a
2015-09-07sw: convert boost::ptr_vector to std::vector<std::unique_ptr>Michael Stahl
Change-Id: If8d9770717c21875b4472b0d94a1fa5a9d136085
2015-09-07sw: erroneous vector assignment in SwTable::OldMerge()Michael Stahl
+ rLineBoxes = pFndBox->GetLines()[nEnd]->GetBoxes(); This actually assigns the boxes vector of the last line to the first line, which the previous code didn't do. Notably after converting the types from boost::ptr_vector to std::vector<std::unique_ptr>, the assignment produces a several page error message from both GCC and clang, and infuriatingly neither compiler was able to tell on which line in tblrwcl.cxx the template was instantiated, so i had to bisect that. (regression from be5e4247e2a164bd1f2eacf9a33d6d73df16d0e3) Change-Id: I646e3ca678895480d38ec48f38d720458860a985
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...the computation of nTop, nBottom was done in this curious way ever since its inception with 108632dc97a720639df495de3b5d966ee286be95 "CWS-TOOLING: integrate CWS impressaccessibility3" Change-Id: Ib516e944d96dc10ff12d0a82c0d8c921b57b0466
2015-09-07that change looked wrongMarkus Mohrhard
Change-Id: Id40a6802536120501133968d003267f21aaf5c27
2015-09-07use correct axis type in secondary x axis exportMarkus Mohrhard
Change-Id: Ic21d88b55b22c650de4fd69479b51d0f640fec6f
2015-09-07prevent crash with non-vcl OpenGL contextsMarkus Mohrhard
Change-Id: Ia829b0f723c8ded1237e52d48f034da3c1ac249e
2015-09-07Related: tdf#93676 unwanted duplicate axis title exportedCaolán McNamara
translateFromChart2AxisIndexToOox toggles between just two states, so convert consumers/suppliers of that to bool Then in exportAxesId toggle between primary/seconday pairs based on that, vs always exporting AXIS_PRIMARY_X + primary/secondary y Change-Id: I2649f5fc07323a73a3a215fdc52d5f1a5c31c349
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I7c19ce1bde1eb405fe64aba7504fc511c0ab646e
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 485d404dc2d12f86acd9c69f19e9075bd375e861 "vcl118: #i115788# fix file specs vs. URI" Change-Id: I990c3610b29b060b516a21ec6cba615fa101ccb5
2015-09-07solenv: improve unittest-failed.sh for WindowsMiklos Vajna
Instead of saying what to do, do it, so the CPPUNITTRACE="... /debugexe" part can be copy&pasted. Change-Id: I2ae54ad52ffa7dfbbf8b4e61f1fa8a0079c7b570
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...needlessly added with 6d96720fd51ca4710c9ffef3db68ac13678f5bed "#98991# fix CJKV vertical glyph rotation, avoid obsolete FT helper functions" Change-Id: Ic0311ca8ae2b4c7d33c42f7fecaae4c95c24500a
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with a949f50ce969b1f8d018d2913c0d86cfcec4e72a "implemented GetGlyphOutline()" Change-Id: I4591ac5c3d42053b3caa9d68bb12ad02dc319b66
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 2d1f08d63942666c0094904f50ba8c512ab69b9d "CWS-TOOLING: integrate CWS otf01" Change-Id: I92ec60f5704e632126f3ba98140c520ae5c9e784
2015-09-07module-deps now distinguishes merged-libs in its output.Michael Meeks
Change-Id: Icc3a965e59f5b2d4e23e0e5a4d0400b6b175c9c1 Reviewed-on: https://gerrit.libreoffice.org/18346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with 5624be5a3520a16d57724064e16df3722d728010 "CWS-TOOLING: integrate CWS graphite01" Change-Id: Ib530362efe1b52f43a2a25e531cce9326001044d
2015-09-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since its inception with d9bf8cb9c3f087115f72ba371e1291fd0eba3818 "add serverside font feature" Change-Id: I430b457dbf278be3299883ba0fac09a6b68c5d67
2015-09-07Related: tdf#93675 'new' ms-alike numbering has same problem as old numberingCaolán McNamara
when it comes to nodes which were numbered, but have their number deleted, where the indent from the numbering is still in effect in writer, but not in msoffice. Change-Id: I700f34171d8c9e9f6fb725d115ff1fe704ceb4bb
2015-09-07Related: tdf#93676 in msword chart appears with axis positioned between ticksCaolán McNamara
not on them Change-Id: I048f86270ee12a38967c81e832619fd5018db6b1
2015-09-07TableRef: prefer internal table column name over header cell contentEike Rathke
Now that table column names are refreshed we can prefer them over header cell content during formula compilation and string creation of a tokenized formula. Change-Id: I0755404883af78c52c8d27a777acd7300bc2af75
2015-09-07TableRef: move swap to empty names to InvalidateTableColumnNames()Eike Rathke
Change-Id: I495377786bd0add1521d37490c8c57d4d30f541e
2015-09-07assert Notify() without containerEike Rathke
Change-Id: Ie2a84f58f63737b241222523f6d6c380e727bb89
2015-09-07TableRef: call InvalidateTableColumnNames() whenever they are invalidatedEike Rathke
Change-Id: I10396818da901a6a4da331ad2152b901968fd8bd
2015-09-07TableRef: introduce InvalidateTableColumnNames()Eike Rathke
Change-Id: I3dcefc3ba55c33f9cfef6ff4bf9aa2242a866c14
2015-09-07TableRef: add a comment why we need a full check anywayEike Rathke
Change-Id: I352a1378cc1a9e3d689c6902a01b901a74466d2d
2015-09-07TableRef: add entire header range to dirty list on address notificationEike Rathke
Change-Id: I0a0fb83a1e72d73a517eabaa3c8dc1b2228848d1
2015-09-07tdf#92357 clear tab type switcher button of rulerLászló Németh
before drawing the new icon Change-Id: Ibbdbed448f965848429ace28dcfae47efc982164
2015-09-07Fix harmless, historic mis-mergeStephan Bergmann
...between 6037a79c3791e41578c384481acec48904951ae0 "cws tl82: #i74049# math symbols should be able to handle 20 bit Unicode characters (surrogates)" and a93c9517dc52b1d9c22a0e69f9d92c119983f7fe "Removes a fair amount of BOOL variables in starmath." Change-Id: Id146defb7231458b945629d4e4dcb7fc8de69f0e
2015-09-07let's follow our pseudo-hungarian notationEike Rathke
Commit 6fb54d7bd3eb8efb2223c6a7250852fb6ad22b89 changed from pointer to reference but didn't adapt the variable name. Change-Id: If91c632d8fc41957ed3b542ed7bf19c376b56a82
2015-09-07svx: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: Id881385b2653da2ee89498afbd6453d40acaea83 Reviewed-on: https://gerrit.libreoffice.org/18358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-07WaE: -Werror, -Wunused-private-fieldCaolán McNamara
Change-Id: I63cfbe32b165b33e986641f9c6270994ddaa6480
2015-09-07cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07cppcheck: noExplicitCopyMoveConstructorCaolán McNamara
Change-Id: I8718ddd144bec48541e6412a8c9feb74d9391ecc
2015-09-07cppcheck: operatorEqVarErrorCaolán McNamara
Change-Id: Ie27c7c5d1b0c87a0e440cf57db436c7c46d46788
2015-09-07cppcheck: redundantConditionCaolán McNamara
Change-Id: If4ef5f054412b75a18d4afd28509ca02d5d2573f
2015-09-07cppcheck: redundantPointerOpCaolán McNamara
Change-Id: I46f0e7c4cd45c7ac596dceae7ad28664b0cc2183
2015-09-07only one use of ScPrivatSplit, and that's for vertical splitCaolán McNamara
Change-Id: I942907d6af150818cb1e9a0f1d3f4cd036d0503e
2015-09-07tdf#93884 windows opengl: make space around cached glyphs depend on font sizeMiklos Vajna
Cached glyphs used to have a 2px border in all font sizes, that's too small for larger fonts. Make the border size depend on the font size for larger fonts to make sure that the rendered glyphs are indeed independent. The introduced GLYPH_SPACE_RATIO = 8 constant is the smallest value where I don't see overflows anymore for large fonts. With this, not even the bugdoc renders correctly when presenting, but also the text is OK when the font size is set to the max allowed by the UI (96pt). Change-Id: I52aa5c4444583fc0467291463697a63f2b8fc86c
2015-09-07WaE: not necessary to pass this argument, it defaults to the same valueTor Lillqvist
[loplugin:defaultparams]. Change-Id: I962bcf4c3de625bb6843cb7aa9ca0f4d6ba5187e
2015-09-07WaE: implicit conversion of literal of type 'int' to 'bool'Tor Lillqvist
[loplugin:literaltoboolconversion]. Change-Id: I815a41b0bc36aea3757ce3458688e92862f732cd
2015-09-07slideshow: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I3160235d0e6253626a8facbfed33e3c252505cbf Reviewed-on: https://gerrit.libreoffice.org/18336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07svl: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe
with the variadic variants. Change-Id: I7aad512c4de034ed96b9a48e797e580e605d98a6 Reviewed-on: https://gerrit.libreoffice.org/18351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07stoc: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I34fe287036ca9b8e5edcb121ba70d9a93ab05276 Reviewed-on: https://gerrit.libreoffice.org/18338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07svtools: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I935dde5c4c83e0f00d1b7dd5ee2500190d80fb69 Reviewed-on: https://gerrit.libreoffice.org/18352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07dbaccess: replace for_each with range-based forDaniel Robertson
Replace complex uses of ::std::for_each with a range-based for-loop. Change-Id: I82331f16cc1994dd9ef36eb80d67b64171cecc74 Reviewed-on: https://gerrit.libreoffice.org/18355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07WaE: implicit conversion of literal of type 'int' to 'bool'Tor Lillqvist
[loplugin:literaltoboolconversion]. Change-Id: Ic971c1e76d6b2f3bcdd8f575440f71212081256b