summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-07tdf#42949 Fix IWYU warnings in sd/source/ui/[a-c]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I75bb860272e23ebc04912295b0ce4f2c8fe540b7 Reviewed-on: https://gerrit.libreoffice.org/68604 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07tdf#121686: fix assert in SvxAutoCorrect::FnChgToEnEmDash (editeng)Julien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=149773 Change-Id: I1696984a8df1b38a359a8177a5f3670526d2696e Reviewed-on: https://gerrit.libreoffice.org/68832 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07build: support disabling popplerAshod Nakashian
This adds --enable-poppler configure option. Poppler can be enabled/disabled by setting this parameter to yes or no. Change-Id: I42ba2d27de7b5014d28523394310616d20073b71 Reviewed-on: https://gerrit.libreoffice.org/68602 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68842 Tested-by: Jenkins
2019-03-07Update git submodulesLior Kaplan
* Update dictionaries from branch 'master' - tdf#117389 Make sure all comments also ends with # Change-Id: I68f513c0ad8b63b416608f8e221450622ef10c2d - tdf#117389 Remove empty line, update total number Change-Id: I4f492ab621d5a41466f55e79e86eeda5c7da1e52 - substantive rework of af_ZA hunspell Change-Id: I873d6135e65089e5905b5c650428b4d9ad7fa4c6
2019-03-07tdf#123637 sw_redlinehide: fix iteration in SwCursorShell::GotoNextOutline()Michael Stahl
If nStartPos == size() and !bUseFirst. (regression from d0e9cc832d19b622532f01580d9cf78ee0b215db) Change-Id: I571d24ec5e9d4f2780e7c6d5c8cee09baeaffcc1 Reviewed-on: https://gerrit.libreoffice.org/68821 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07sw_redlinehide: fix SwGetExpField ODF importMichael Stahl
After import, SwGetExpField are empty if ShowRedlineChanges=false because the content from the document is lost in SwGetExpField::Copy(). Example is ooo26330-3.sxw, which then asserts once fields are updated, but that is a different problem. (regression from 57f358f1ac4f3e05fcdf54326388ba8a19f0f2b3) Change-Id: I1bf939d69e599919c3a5c5631091ca0a0074d139 Reviewed-on: https://gerrit.libreoffice.org/68820 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07Update git submodulesLior Kaplan
* Update dictionaries from branch 'master' - Replace : with # in comments lines Change-Id: I1bcd51d4dab501a051dd6bebe98380299390fc3b Reviewed-on: https://gerrit.libreoffice.org/67282 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-07Update git submodulesLior Kaplan
* Update dictionaries from branch 'master' - tdf#117389 Remove RLM/LRM from Arabic dictionary Change-Id: I002d7be2de961b7a20d48eed628ae35df0b600df Reviewed-on: https://gerrit.libreoffice.org/67281 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-07Fix LTO segfault in libtest_sw_uwriter test.marxin
The problem was seen here: https://bugzilla.suse.com/show_bug.cgi?id=1127857. One needs to call SwGlobals::ensure in order to initialize SfxApplication via SfxApplication::SetModule(SfxToolsModule::Writer. Change-Id: I3add24b56dc44a93ad81c1b52539da821f6244fc Reviewed-on: https://gerrit.libreoffice.org/68839 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>
2019-03-07tdf#123547: do the same as in lcl_DrawBullet from cui/numpages.cxxJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=149389 It seems the method from cui/numpages.cxx takes more things into account At least, it doesn't crash for the attachment of this tracker Change-Id: I05ca0b019ac483890bea4acdbb695d73b660e638 Reviewed-on: https://gerrit.libreoffice.org/68033 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-07CppunitTest_svtools_html: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Icf4d3a649c5e6a53035c2a1573a8dd7154db2edd Reviewed-on: https://gerrit.libreoffice.org/68831 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07Add width, height and margin parameters for widget part def.Tomaž Vajngerl
For some control parts we need to provide the size or redefine the size. Previously this was hardcoded, but this adds new attriburtes for widget part definition: - width, height: defines size for buttons in spinbox, the size of the checkbox or radiobutton - margin-width, margin-height: increases the size (margin) of tab items by the specified amount Change-Id: Ieea69b92ad21adc4f4954e7555f4d59348f5dea8 Reviewed-on: https://gerrit.libreoffice.org/68829 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07Make definition state attribute default to "any"Tomaž Vajngerl
...and remove all the "any" from definition.xml Change-Id: I8a91129c89255c83c1c2f975bf9acb710b664efc Reviewed-on: https://gerrit.libreoffice.org/68828 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07Update SvgRead test - add new parameters and path parsingTomaž Vajngerl
Change-Id: Ic19bd2167cc359eef02648fa0ebd1d858fdeaec5 Reviewed-on: https://gerrit.libreoffice.org/68827 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07Sifr icon theme updateandreas kainz
Change-Id: I63231929679377a53b85aa7e2ee5363512f23912 Reviewed-on: https://gerrit.libreoffice.org/68834 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-07Fix typoAndrea Gelmini
Change-Id: Icafc637004e219b523c862cb5fbad55a2bd4eaaf Reviewed-on: https://gerrit.libreoffice.org/68835 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06sync dbaccess ui files with swriter ui file structureandreas kainz
Change-Id: I5acecb3292c1b4ef6aa2dfdc38775ed5bb81324a Reviewed-on: https://gerrit.libreoffice.org/68806 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06Sifr icon theme updateandreas kainz
Change-Id: I6aa3d3a4dac4af5b1dbf1d23166cc2a560cd984a Reviewed-on: https://gerrit.libreoffice.org/68808 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06Increase font size when drawing from widget definitionTomaž Vajngerl
Change-Id: I983dde507758a42c6ce421ea970b6e5d54c5dcae Reviewed-on: https://gerrit.libreoffice.org/68826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06draw combobox (entire areaonly) from external svg, fix editboxTomaž Vajngerl
Change-Id: Iba7e5b45c4f1ac6f87cbca963bb5284ce810ebcf Reviewed-on: https://gerrit.libreoffice.org/68825 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Add XServiceInfo tests to ScDataPilotFieldObjJens Carl
Change-Id: I7de8902b6857782acb5d2b3566d5768481baab51 Reviewed-on: https://gerrit.libreoffice.org/68824 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06Move variable nMaxFieldIndex out of namespaceJens Carl
Change-Id: I9396abb722b24d8ee6b2d5f8fccac140a1014436 Reviewed-on: https://gerrit.libreoffice.org/68784 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06Draw tabs from external svg image, fixes for tabs (colors)Tomaž Vajngerl
Change-Id: I35db7b8e36c474d2196bfae1ec4dd352e17d2a14 Reviewed-on: https://gerrit.libreoffice.org/68822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw pushbutton from external svg imageTomaž Vajngerl
Change-Id: I45d668636d607e09852ee0ff3144500ac03fb8cf Reviewed-on: https://gerrit.libreoffice.org/68819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Update drawing of spinbox from definitionTomaž Vajngerl
Use SVG to describe the left, right spin button and the entire spinbox widget. Change-Id: I082ee08942fa3fa4145fd7bf53fc2cfc9fc06fd2 Reviewed-on: https://gerrit.libreoffice.org/68818 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Support first, last tab item for the widget definitionTomaž Vajngerl
Add "extra" parameter for the widget definition states with the default set to "any". For tab item, the extra parameter can be "first", "last", "middle" and "first_last" (only one). This is needed to draw first and last tab item differently. Change-Id: I46b6897b485b4df94ab6fe9521925c3715eaa24e Reviewed-on: https://gerrit.libreoffice.org/68817 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Simplify Sequence constructionStephan Bergmann
Change-Id: I52ea31734f7765176e20514c5d02cb3ee5928cdb Reviewed-on: https://gerrit.libreoffice.org/68812 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Support drawing widgets by interpreting an external SVG definitionTomaž Vajngerl
This uses SvgDrawVisitor and draw commands to draw widgets from an "external" SVG file. The difference to normal SVG drawing is that the shapes are adjusted and not just resized to the widget size. The result of such adjusted drawing is that the margins are preserved exactly just the dimensions of the shapes is adjusted to the desired size (if the shape bounding rectangle starts at {5,5}, so will also when it is adjusted), also the stroke widths are completely preserved. This enables us to use SVG to define also for dynamic widgets, like for example entry fields, listboxes, comboboxes,... which vary in size - depending on the dialog definition. Change-Id: I26fc9a37539d3675a77b48660d235a8a55b81156 Reviewed-on: https://gerrit.libreoffice.org/68816 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Blacklist some dialogs which won't get properly initializedStephan Bergmann
...so that at least Clang -fsanitize=implicit-signed-integer-truncation would generate warnings for them Change-Id: I76fd0aaa8e61784053e2b367b302fdd68c3859b4 Reviewed-on: https://gerrit.libreoffice.org/68815 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Pass ENABLE_DEBUG into external/zlibStephan Bergmann
Change-Id: I3aea7c64acfc933e4df901d4de349708a3331bcd Reviewed-on: https://gerrit.libreoffice.org/68811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06tdf#121176 DOCX track changes: same size w:del in w:insLászló Németh
Instead of showing the tracked deletion as untracked normal text, losing the original and actual text contents, now w:del within a same size w:ins is imported as tracked deletion correctly. Change-Id: I7390df34f557664860a63779c5f972d5013ecc99 Reviewed-on: https://gerrit.libreoffice.org/68779 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-06parse more attributes in SvgDrawVisitorTomaž Vajngerl
- add additional parameters for DrawRectangle, DrawPath - parse stroke width, stroke and fill color for path and rect - parse rx, ry for rect - use getCurrentViewPort for top-level SVG rectangle Change-Id: Ife498bdaa721852ef2542ac5df2be0e86dfb4e62 Reviewed-on: https://gerrit.libreoffice.org/68785 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06use gfx namespace for DrawCommandsTomaž Vajngerl
Change-Id: Ib2d97c4fee4e1bb433beeba4fb507fdc7d542af9 Reviewed-on: https://gerrit.libreoffice.org/68775 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic list{node,net,header} from the theme definitionTomaž Vajngerl
Change-Id: I05b2cced0f99d6628a12465748820e3a87c5f3e7 Reviewed-on: https://gerrit.libreoffice.org/68774 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic toolbar from the theme definitionTomaž Vajngerl
Change-Id: I4d9935973bb6e46a7c5f17f914944f91a3e10a63 Reviewed-on: https://gerrit.libreoffice.org/68773 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic frame and window background from the theme definitionTomaž Vajngerl
Change-Id: I2422650a155a874855ad4d72fa3bfd27b7d0da8a Reviewed-on: https://gerrit.libreoffice.org/68772 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic listbox from the theme definitionTomaž Vajngerl
Change-Id: Id3dd5aaa8b5537e5f740752cec292d6f4a44044e Reviewed-on: https://gerrit.libreoffice.org/68771 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06svgio visitor, add draw commands and create the from svgTomaž Vajngerl
Adds a visitor for svgio for visiting svg nodes and create something useful from them. Basic draw commands - a tree of draw commands (with sub-pixel precision support) just to store a simple definition for drawing. Adds a svg draw visitor and create draw commands from the svg structure and expose the commands through UNO API. Change-Id: I073e891a2cffdd76d4e3b838590e3a19c998e9bf Reviewed-on: https://gerrit.libreoffice.org/68770 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06support large toolbar sizeCaolán McNamara
Change-Id: If24baee9a682006ff92e543eeb28490573b6cdec Reviewed-on: https://gerrit.libreoffice.org/68805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06hookup MenuButton::SetDropDown to GtkMenuButton draw-indicatorCaolán McNamara
Change-Id: I556d61256bed8f607eed5a9c6e0ed3fcfd63af2c Reviewed-on: https://gerrit.libreoffice.org/68802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06Fix libtool RPATH outsmarting hack for external/librevengeStephan Bergmann
After the blind fix attempt of 490f07cf7235ab3c5dc4be13c53832e3266bd8e6 "Extend libtool RPATH outsmarting hack to external/librevenge", appears that <https://ci.libreoffice.org/job/lo_daily_update_gandalf/596/> also needs runpath_var=LD_RUN_PATH to be reset. (See also how <https://src.fedoraproject.org/cgit/rpms/librevenge.git/tree/librevenge.spec ?id=4960d4c6c190885b20f56ce9ee1ad2ad92b87021#n46> addresses the same problem for Fedora builds of librevenge.) Change-Id: I5cff145605cd05a8b87360c1edc3574e3364139b Reviewed-on: https://gerrit.libreoffice.org/68800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06sync chart2 ui files with swriter ui filesandreas kainz
Change-Id: I5c31fd0aef8d3a3e2ce4bcc6942f9cc06edff858 Reviewed-on: https://gerrit.libreoffice.org/68791 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06loplugin:staticconstfield improve warning messageNoel Grandin
Change-Id: I000dff6b1b6e33e1b2c5aa337c027c1edd7b1003 Reviewed-on: https://gerrit.libreoffice.org/68795 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06writerfilter: remove empty RTFPicture constructorMiklos Vajna
This is really just a reference-counted struct, not a real class. Change-Id: Ifccd513e56632fd4df7711f7070188671b45e82d Reviewed-on: https://gerrit.libreoffice.org/68777 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-06Introduce Int32ToSVBT32 for cases that apparently want to write a signed valueStephan Bergmann
...and clean up some other (legitimate) uses of UInt32ToSVBT32 to not use a (somewhat misleading) static_cast<long>(...) Change-Id: Ifd0c3f771c3f6e20eef3413b9c27fd2514dc0c13 Reviewed-on: https://gerrit.libreoffice.org/68767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Record external/harfbuzz/msvc.patch as sent upstreamStephan Bergmann
Change-Id: I47277272170508e9af7617e9b774bbdca05e9ec3 Reviewed-on: https://gerrit.libreoffice.org/68766 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06sync sdraw and simpress ui files with swriter ui filesandreas kainz
Change-Id: I321233437b573d254ca63aaf7274b54334ec066a Reviewed-on: https://gerrit.libreoffice.org/68786 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06tdf#123829 Respect CollapseEmptyCellPara setting when reading odf docsSamuel Mehrbrodt
Commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c introduced a "feature" which would hide an empty line after a table and only make it visible when the cursor is in it. So when loading an ODF doc, only enable this feature for which have the CollapseEmptyCellPara setting set. Change-Id: Ib4dfbbe8d45eb57547c51c7eee2f81331fc5300e Reviewed-on: https://gerrit.libreoffice.org/68742 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-06Fix typoAndrea Gelmini
Change-Id: I0b1c04b846ff5e6197fce59bd3c4325528169a7c Reviewed-on: https://gerrit.libreoffice.org/68787 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>