summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-03-29cid#1503287 silence Unchecked dynamic_castCaolán McNamara
Change-Id: Id7c6c1ecbfc88c97d5211826fa2d831344dc795c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-29cid#1503286 Unchecked return valueCaolán McNamara
Change-Id: I701039be73405e354fc64bd6a81999aff44e9e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-29initialize output parameter of ScFormatRangeStyles::GetStyleNameIndex()Luboš Luňák
ScMyDefaultStyles::FillDefaultStyles() calls this in a loop and compares with previous. Change-Id: Iba3420023e16c3091f4695640251a5525b28f467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132199 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-29tdf#147906 change sqrt(a * a + b * b) occurences to std::hypot(a, b)Bartosz Kosiorek
Change-Id: Ic84899bf34f98382e6cc1ffc14310b1667279ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132214 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-29sw: document AbstractSwBreakDlgMiklos Vajna
AbstractSwBreakDlg is implemented by AbstractSwBreakDlg_Impl, which wraps an SwBreakDlg, a bit complex at first. Change-Id: I366bb16b13a6343a45d5538f79ddff729fe31acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132241 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-29-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since f47a9d9db3d06927380bb79b04bb6d4721a92d2b "initial import" Change-Id: I5ae9d757270c69003899a3eaf825acbfc48ea047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-29qt a11y: Handle TABLE_MODEL_CHANGED eventMichael Weghorn
Note however, that as of now, this doesn't have any effect in practice, since `AtSpiAdaptor` for Linux in the Qt library currently just ignores `QAccessible::TableModelChanged` events instead of forwarding them as corresponding AT-SPI events. [1] [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=9a4c32cedda3a00e06eb3aed13a731d23f6c56d9#n1105 Change-Id: I6339d172da54bc30987bb9261ce37005ebce5501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132222 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29a11y: Drop unused, deprecated table model change event typesMichael Weghorn
All places that were previously emitting `AccessibleTableModelChangeType::INSERT` and `AccessibleTableModelChangeType::DELETE` events have been ported to emit the 4 new event types introduced in Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89, "a11y: Add new table model change types for row/col insertion/del" instead. Therefore, the handling of those events can be dropped from the gtk3 VCL plugin and for macOS's a11y listener as well. Also, drop the now completely unused constants from the IDL file as mentioned in Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89: > From a UNO API perspective, this change > and the final removal of the > `AccessibleTableModelChangeType::DELETE` > and `AccessibleTableModelChangeType::INSERT` > constants in a follow-up commit > should be unproblematic, because the > corresponding APIs have been unpublished in > > commit 70626249cd247d9acdad417b8eaf252bae22c059 > Date: Thu Nov 29 00:27:03 2012 +0100 > > API CHANGE a11y unpublishing and add/removeListener rename. Change-Id: I1c062e26481b916af882e301c5f911aba9550ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132221 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29sc a11y: Fix + port events for row/col ins/delMichael Weghorn
Previously, incorrect indices were sent when inserting or deleting rows or columns from a Calc spreadsheet, e.g. when deleting rows 4 to 12 (i.e. rows with indices 3 to 11), the pyatspi script from Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89, "a11y: Add new table model change types for row/col insertion/del" would have this output: > object:row-deleted(12, 10, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] > object:column-deleted(0, 16384, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] i.e. LO would announce the deletion of all columns and the deletion of 10 rows, starting at index 12, which is obviously wrong. For the case where rows or columns have been deleted, the range in the update hint passed to `ScAccessibleSpreadsheet::Notify` is the spreadhseet range after the removed rows/columns; for the case where rows or columns have been inserted, the range in the update hint is from the first inserted row/column to the last row/column in the spreadsheet. So, calculate the indices of the actually inserted/deleted rows/columns from that. Also, switch to using the table model change event types introduced in the change mentioned above. With this in place, output of the Python script for the above case now is as expected (9 rows, starting at row index 3, have been deleted): > object:row-deleted(3, 9, 0) > source: [table | Sheet Sheet1] > host_application: [application | soffice] > sender: [application | soffice] Deletion of non-contiguous row/column ranges (e.g. deleting columns A to C and F to H) also results in the correct events getting sent, since `ScAccessibleSpreadsheet::Notify` gets called multiple times, once for each contiguous cell range. Change-Id: I6e61eb45f255741661b29efb72394029109d682e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132220 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29sc a11y: OSL_ENSURE -> assertMichael Weghorn
Change-Id: I79f477c950e0aca75e2a6041c5fb6a78be4b07c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132219 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29a11y: Use new table model change types for row/col ins/delMichael Weghorn
This ports most existing uses of the now deprecated `AccessibleTableModelChangeType::INSERT` and `AccessibleTableModelChangeType::DELETE` to emit events of the the four new table model change types added in Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89, "a11y: Add new table model change types for row/col insertion/del" instead, which among others fixes the a11y events that are sent on the platform level for gtk3 and macOS, s. commit message of the mentioned change for more details. From all I can see, `AccessibleGridControlTable::commitEvent` is just meant to handle removal of rows, not columns, so add a corresponding assert there. (See how only row-related a11y events are emitted in `svtools/source/table/tablecontrol_impl.cxx`, and the "columns aren't selectable" comment for `AccessibleGridControlTable::isAccessibleColumnSelected`. Given that the full range of rows would previously have been sent in the `AccessibleTableModelChangeType::DELETE` event for column removal, this should still have worked in practice, since this would have cleared the whole vector, and elements would have been inserted on demand as needed again later. However, if that should ever be needed in the future, it should be handled more explicitly.) The handling of sending events when rows or columns are inserted or deleted in a Calc spreadsheet is more fundamentally broken and will be handled in a separate commit. Change-Id: Icfd5e326143e8e90cc513e430bfabbba39e7bdc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132218 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29a11y: Add new table model change types for row/col insertion/delMichael Weghorn
So far, there were two types/constants to use in an `AcessibleTableModelChange` event to indicate the insertion or deletion of rows and/or columns. From `offapi/com/sun/star/accessibility/AccessibleTableModelChangeType.idl`: > /** One or more rows and/or columns have been inserted. > > <p>Use the fields of the AccessibleTableModelChange > structure to determine the indices of the rows and/or columns that > have been inserted.</p> > */ > const short INSERT = 1; > > /** One or more rows and/or columns have been deleted. > > <p>The affected area of the table is stored in the fields of the > AccessibleTableModelChange structure.</p> > */ > const short DELETE = 2; From the documentation, it would be possible to indicate an insertion or deletion of both, rows and columns in a single event. However, there is no single instance where this is actually used to indicate the deletion/insertion of both, whole rows and whole columns at the same time. The way that indices are currently used is rather confusing and results in incorrect a11y events being sent on maOS as well as the gtk3 VCL plugin: When only rows are inserted, row indices are set as expected (index of the first and last inserted row), but the column indices are set to the first and last column in the table; i.e. the indices actually give the range of the newly inserted cell range, rather than just the indices of the rows that have been inserted. (The same applies the other way around when only columns are inserted.) That's not what I would have expected when reading the documentation. ("Use the fields of the AccessibleTableModelChange structure to determine the indices of the rows and/or columns that have been inserted.") In the same way, the range of deleted cells is set when emitting `AccessibleTableModelChangeType::DELETE` events. In this case, this can be seen as matching what the documentation says. ("The affected area of the table is stored in the fields of the AccessibleTableModelChange structure.") In any case, the way that the events are handled in the gtk3 VCL plugin and for macOS results in the emission of incorrect events, since those are handling such indices as if both, rows and columns had been inserted/deleted. Example for the gtk3 VCL plugin: Row with index 1 has been deleted from a table. -> an AccessibleTableModelChange event is sent with Type=AccessibleTableModelChangeType::DELETE FirstRow=1 LastRow=1 FirstColumn=0 LastColumn=<index of last column> This would then result in 2 AT-SPI events being emitted by the gtk3 VCL plugin: * one that indicates that row 1 has been deleted (OK) * another event that indicates that all columns have been deleted (NOT OK) Instead of changing the handling of the existing `AccessibleTableModelChangeType`s, introduce 4 new types to replace the existing ones that don't mix handling of rows and columns at the same time: one for row insertion, one for column insertion, one for row deletion, one for column deletion. This commit also adds handling for the newly added change types for macOS and the gtk3 VCL plugin on Linux. winaccessibility is unaffected because it doesn't have any handling specific to the change type. The qt5/qt6 VCL plugins don't yet have any handling for the `AcessibleTableModelChange` event yet (but that will be added in a follow-up commit). Existing uses of `AccessibleTableModelChangeType::INSERT` and `AccessibleTableModelChangeType::DELETE` will be migrated to use the new types in follow-up commits. From a UNO API perspective, this change and the final removal of the `AccessibleTableModelChangeType::DELETE` and `AccessibleTableModelChangeType::INSERT` constants in a follow-up commit should be unproblematic, because the corresponding APIs have been unpublished in commit 70626249cd247d9acdad417b8eaf252bae22c059 Date: Thu Nov 29 00:27:03 2012 +0100 API CHANGE a11y unpublishing and add/removeListener rename. The following Python script was used in follow-up commits to check that AT-SPI events with the expected indices are retrieved with the gtk3 VCL plugin after porting existing uses of `AccessibleTableModelChangeType::INSERT` and `AccessibleTableModelChangeType::DELETE`. #!/usr/bin/python3 import pyatspi def listener(e): try: if e.host_application.name != 'soffice': return except: return print(e) pyatspi.Registry.registerEventListener(listener, "object:row-inserted", "object:column-inserted", "object:column-deleted", "object:row-deleted") pyatspi.Registry.start() Change-Id: I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132217 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-29sc: fix crash in SdrPageView::GetPageWindow()Aron Budea
From online crashreport: SIG Fatal signal received: SIGSEGV SdrPageView::GetPageWindow(unsigned int) const svx/source/svdraw/svdpagv.cxx:84 (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact(basegfx::B2DVector&, sdr::contact::ViewObjectContact const&) const sc/source/ui/view/gridwin4.cxx:1397 sdr::contact::ViewObjectContact::getGridOffset() const svx/source/sdr/contact/viewobjectcontact.cxx:463 sdr::contact::ViewObjectContact::getPrimitive2DSequence(sdr::contact::DisplayInfo const&) const include/basegfx/tuple/b2dtuple.hxx:81 sdr::contact::ViewObjectContact::getObjectRange() const svx/source/sdr/contact/viewobjectcontact.cxx:198 ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact() didn't check if PageWindowCount() was non-zero. Change-Id: I4a00b5b13a277d0805af3076150a952306908e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132251 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-03-29sc: set default parameters in SparklineGroupTomaž Vajngerl
The colors are set to COL_TRANSPARENT except for the series color, which is set to COL_BLUE by default. Other parameters are set to their default values according to OOXML specs. Change-Id: I67ceab2ffd723511fbf0616cca661992f0a8cf69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-03-29sc: refactor sparkline struture to store a list of sparklinesTomaž Vajngerl
We need to access a list of sparklines and sparkline groups for a sheet. To preven going through all the columns of a sheet, we need to store all the created sparklines in a list. For this it is necessary to change the model structrue a bit. A cell now has a container that stores a shared_ptr to the sparkline instead of storing the sparkline directly. With this we can store a list of weak_ptr to the sparklines in a list (vector), which can be accessed at any time and is quite fast. This is needed by the OOXML export. Change-Id: Iaca0a41e20912775f072ea6e8cab9c44367d6f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131919 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-03-29Colibre: Add some inner shapesRizal Muttaqin
Change-Id: Ic383567a3274d59f9208130adbc2b278fb3de6a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132246 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-29Colibre: Simplify db related icons, update filter iconsRizal Muttaqin
Change-Id: I888cb880a7dd17de63b86517b1d968be1e081d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132247 Tested-by: Jenkins Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 777e3930a1e85b9bc97c1852b09802fc389c5e2d "Move the code for "fill simple" to its own method." Change-Id: Iea240530696b89f56fba314b599e7cd43ce6a780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132231 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since bc712935a05dd34142b4c17dd6686761d9b9d5e1 "TableRef: refresh table column names before saving" Change-Id: I7537fa3632ff03f73d36eaf9fc6ba0ab73319cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132232 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since d9dd003f63a781e63bfbe380ea737e080c21881f "tdf#143103 Support Color Filter in 'Standard Filter' dialog" Change-Id: I04441f4d812e3598b5b91e3bf915315a11ab6e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132233 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since df50b02cd3177570bb26484a03273ba5caa50037 "weld ScFilterListBox" Change-Id: I02e835bb9de373fea7891babbce5eec605455198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since c97f9af5e47ea234ad709a1f66c1e8ed20640066 "tdf#129708 speed-up: reuse enumeration for each effect" Change-Id: Ice1a613676f25e3a63a3479548538d33f1b5ee47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132236 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 24da580f8bd0a348fee64c07f9015b09918f8388 "95584#; add RangeId to have the draw ranges unique" Change-Id: I60e98b9645eb4acb2d3d4e47ada81c976e43a424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...which was apparently meant as a "Possible debugger breakpoint" in DBG_UTIL-only sw_DebugRedline. The obvious fix is to mark nDummy as volatile, but increment of a volatile variable is deprecated, so replace those with reads of the variable, but which triggered false loplugin:casttovoid so fix that too. Change-Id: I07376e665caa4fd9befaba06d261a50df7a63a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since db51589575d37ca608067ad9904dcc6a09651e8c "Convert SVARRAY SORT into STL set" Change-Id: I50384d67252965beb46a9dad5a30df835188f3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132238 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since fa44673e154ed4fb0b518b8850e2f6e4b9069531 "bnc#885548: Adjust xlsx export of revisions to get it to work in Excel." Change-Id: I4e9c8d176cc5bd3ff1f374fcbcf16c738ebf2388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132240 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 376cc3ea0fc2e0f209763a2a27c5852136332c86 "dbaccess: delete old paste autoincrement logic" Change-Id: I4ffa3ffbcc1b80091a4a3449362766334b31c5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28sw: use getProperty<Color> when possibleXisco Fauli
Change-Id: I50339493b0034667e9cd317940102b13066f901c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132203 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-28Colibre: Add some inner shapesRizal Muttaqin
Change-Id: I91ada6c8fca9e54fb5ee954abace04ed6e46c090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132227 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-28Colibre: tdf#148029 Change line only shapes with real intersected shapesRizal Muttaqin
(fontwork shapes) Change-Id: Iee022e5b8051043d920f0b75c5c5a1a99bff889f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132215 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-28forcepoint#94 fix crash on layout of specific htmlCaolán McNamara
Change-Id: I1874a431d5af9d56248a695e08a2f95b5292ba9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 0b6d0ac41afc72a0043e6ccdc6cdfd8648a5efdc "m_pRowMarker is unused" Change-Id: I68d23a11e4be814a23e8ede87723b9aba208b774 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 "tdf#125254 Performance: A spreadsheet opens too slow, part2" Change-Id: Ie04e72155b306f6d5e95abf09623d819ee21cdf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132230 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-03-28Reduce variance in what Jenkins Gerrit builders pick up from their environmentStephan Bergmann
e.g., <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114702/> on tb91 apparently picked up --enable-dconf and --enable-python=system (and failed, for unclear reasons), while a corresponding <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114728/> on tb89 didn't (and succeeded) Change-Id: I9ddd66ff7f1c6595a6cce65365f1cb0a07b6d67e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132216 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since its uses got commented out with a9cc0100645deea53f27e35c7e754c9f062680d8 "chart2: Weld ChartTypePanel" Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 35dce7a06088386f13636bc355bc35e93be6ba5d "INTEGRATION: CWS warnings01" Change-Id: Iaae91d7792348d0bf61173c5839295c8aa1b938f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since f1702aa8e46d63b85cc16e550c96b79509057c89 "INTEGRATION: CWS oj14". (Maybe the odd code was there to allow breaking on it with a debugger, and the original author wondered whether TypeClass_CONSTANT can actually happen here, which it probably can not, so it should probably be replaced with O3TL_UNREACHABLE, but that's left for a follow-up.) Change-Id: I97881b1b35f7de3940400c50b58eb08ca9a746a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox: replace PUT_PROP macro with comphelper::makePropertyValue() calls" Change-Id: Ic90e6e579e0d546454d2acd8c3fb5b5ac50f9f5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28Advanced Diagram support: Move data classes to svxArmin Le Grand (Allotropia)
As preparation for own im/export move data classes for which that is now possible to svx Made TypeConstant more safe, also sorted it. Corrected an error there. Secured TypeConstant usage by identifying usages (mnType -> mnXMLType). Had to convert from oox::OptValue to std::optional since 1st is not available in svx in datamodelcontext.cxx. That makes the test work and the test-file load corrrectly. Change-Id: Ifee008caf486ddb6b52a347dc08e7e053c49ef49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132195 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-03-28Micro-optim of RTFTokenizer::resolveKeywordJulien Nabet
Change-Id: I320df7087e5b9594e7d08a892468ad2cc9a00426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132152 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since 8e73111faeb9620117801fee89a838a407f0b7e5 "CWS-TOOLING: integrate CWS ab72" Change-Id: Ib2fdccc36090d366ca2288b31bd1948832366c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28tdf#148228 sw: fix Undo of tracked table deletion in Hide Changes modeLászló Németh
In Hide Changes mode, tables didn't reappear during Undo of their tracked deletion, only by saving and reloading the document. Follow-up to commit 0c6221e1545e7b96d9df23cdc24302c28ae935b8 "tdf#148227 sw: fix Undo of tracked row deletion in Hide Changes mode". Change-Id: Ifdc25ab4ae0be25a0c7559ee05b6af2e4f1aa8cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132169 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter" Change-Id: Ia01b618c57318657976372257ea37ed2b1b354b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since 45c8bbe9303094b50035967846196cf3b7c72ea6 "vcldemo - more clipping tests for RegionBand and Polygon cases." Change-Id: Ia311a6620b618706dde4de178f202f563bd4c012 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132211 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28tdf#148235 Restore toolbar item to switch XForm to design modeMichael Weghorn
commit 45b6f096e7ae86d0692ecdfd5b7069622d8a6efa Date: Sun Oct 28 17:02:34 2018 +0100 sw toolbars sync context toolbars between different apps had replaced the "Form Design" toolbar item to switch a complete XForm to design mode with an entry that switches the form controls to design mode instead. (The former one is labelled "Design Mode On/Off", the latter one just "Design Mode" in the English UI.) This meant that the XForm could no longer be switched to design mode from there, unless the toolbar was manually customized to add the entry back. This brings the previous toolbar item back. It also removes the one to switch the form controls to design mode again, since that one is already contained in the "Form Controls" toolbar, where it fits better. (And having two different toolbar items with almost identical labels but different functionality would probably be rather confusing.) Change-Id: Ia4c98dfa6ad8372eba08a9f08920153133a7f88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132207 Reviewed-by: Andreas Kainz <kainz.a@gmail.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...since fb6c99f21e03afb85d00459ca1e1abb07e71d126 "loplugin:unuseddefaultparam in svtools" Change-Id: I08da150389bfe8dad09ca293a8f445020c3a51ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28-Werror,-Wunused-but-set-variableStephan Bergmann
...ever since cab1870e677f33a2501f15916110da46d3336d24 "INTEGRATION: CWS languageguessing: #i73173# integrate Google SoC language-guessing" Change-Id: I0abf783944499b6ac8015e37952013d05b273558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132206 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-28Make slideshow touch gestures work again in the mobile appsTor Lillqvist
Need to s/lool/cool/ here, too. Change-Id: Ib6762f196ca2b1c2e8735c6ff3e591164d34fb0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132204 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-03-28jsdialog: fix toolboxes with childrenSzymon Kłos
Don't block JSON generation if toolbox has children... Fixes missing sidebar items Change-Id: I34696d780b4292881792b2190a522610a8b4b597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131696 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132201 Tested-by: Jenkins
2022-03-28Notebookbar style previews: use CJK or CTL fonts if neededSzymon Kłos
Change-Id: I4757cf7af16a11895ec0c6e71257f2b4f02cda68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132159 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> (cherry picked from commit f7c069e1008949a07481dc56e40bcd82343884dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132052 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-06 11:05:25 +0000