summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-21Increase the life-cycle of threads in thread-pool...Dennis Francis
to ScDocument lifetime if possible. This helps to avoid lots of thread setup-cost while doing recalcs especially if there are many formula-groups in the document and most of them are fairly light-weight. Change-Id: Idd57e1ebd0d4e492f99e31237d4a55ec9c95a121 Reviewed-on: https://gerrit.libreoffice.org/69473 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-21Related tdf#122788: avoid assertJulien Nabet
See: - https://bugs.documentfoundation.org/attachment.cgi?id=149853 - https://bugs.documentfoundation.org/attachment.cgi?id=149854 - https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c5 - https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c6 Change-Id: Icd1d4afcd05bf5398813505702bf244bd18fbfee Reviewed-on: https://gerrit.libreoffice.org/69006 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-21tdf#123204 hu_HU collation: don't ignore special charactersLászló Németh
to show/handle them in Calc AutoFilter. Partial revert of "tdf#116666 fix Hungarian sorting" (commit 7b1eb6313c0d2621c364df1724c69d28f8267841). Change-Id: Ib135f1eac77780e901fb4c427c3f1bb8a5e090b9 Reviewed-on: https://gerrit.libreoffice.org/68014 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-21tdf#42949 Fix IWYU warnings in sc/source/ui/pagedlg...undoGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icb5f0235339364e6dc09936e26f256765a60830a Reviewed-on: https://gerrit.libreoffice.org/69378 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-21CppunitTest_svx_unit: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Ib2eac7368ebb06702f05101641e8830ea1fff6d5 Reviewed-on: https://gerrit.libreoffice.org/69483 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-21license: added bzip2Andras Timar
Change-Id: I467e8e7eb60ab0005b15217b0ff088fa6704cf1c Reviewed-on: https://gerrit.libreoffice.org/69492 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: internal Pixman is used, when internal Cairo is usedAndras Timar
Change-Id: I482f6b88314737a793e1d9e9ec1375d49ef676a3 Reviewed-on: https://gerrit.libreoffice.org/69491 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added PDFiumAndras Timar
Change-Id: I523aaa1d623565125a8e224fe8c0a25aa85154b7 Reviewed-on: https://gerrit.libreoffice.org/69490 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added Google breakpadAndras Timar
Change-Id: I79bff85fe4243c3c54fa038d333c713a4a3849ad Reviewed-on: https://gerrit.libreoffice.org/69489 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: STLPort is not included in LibreOfficeAndras Timar
Change-Id: I081ceab1c54b01ed6a3c6ad2702fd69f82b4493e Reviewed-on: https://gerrit.libreoffice.org/69486 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added APR and SerfAndras Timar
Change-Id: Ieaae5fcb6ef0163e63723604f0dea484d55b117d Reviewed-on: https://gerrit.libreoffice.org/69485 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21tdf#79717 save/restore character style on selection overwritePhil Krylov
Change-Id: Ie423e72014734bc188ffb585150dcb024d377d1b Reviewed-on: https://gerrit.libreoffice.org/69323 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-21Fix typoAndrea Gelmini
Change-Id: I5e585dfe96e650da40c0311928e681619ba40bca Reviewed-on: https://gerrit.libreoffice.org/69494 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-21uitest for bug tdf#124111Zdeněk Crhonek
Change-Id: I346415708a439f1b11043c217de46da389d0231e Reviewed-on: https://gerrit.libreoffice.org/69484 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-03-21Sifr icon theme updateandreas kainz
Change-Id: I61762e501e062e0a0a22d5b5d7665b3aaa3bef57 Reviewed-on: https://gerrit.libreoffice.org/69488 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20tdf#124168: The libctllo.a is needed in the iOS app for ToCTor Lillqvist
After I added the share/template folder, the app then turns out to need this UNO component. Change-Id: I877dd8c730f49477e20c58515ee80bafdafaa6b7
2019-03-20tdf#124168: The share/template folder is needed in the iOS appTor Lillqvist
Otherwise we get a warning dialog about a missing internal/idxexample.odt when inserting a table of contents. Change-Id: Id30be100906ea3292b9acd9e983ef7ae39ef63a2
2019-03-20tdf#124226 do fill-on-demand hack only on first visitCaolán McNamara
disconnect focus handler after the fill Change-Id: I77bffe4fa4c516452c36ddb2d816cd5844000c1b Reviewed-on: https://gerrit.libreoffice.org/69479 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Sifr icon theme update lc_andreas kainz
Change-Id: I2511837b91b49fe650844aba82284dd1f2a173b9 Reviewed-on: https://gerrit.libreoffice.org/69480 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20tdf#124168: We do need the BasicDLL thing also in the iOS appTor Lillqvist
For instance, simply inserting a table of contents needs stuff from it. But do keep use of the StarBASIC::* API inside #if HAVE_FEATURE_SCRIPTING. Change-Id: I348ce79899f468e104af336501706f88a6afa287
2019-03-20Related: rhbz#1690732 FC_INDEX doesn't mean exactly what it used to meanCaolán McNamara
its been repurposed to hold font face variation information too Change-Id: I5d667d79a49337e7ade1e1697ca2fc9cb8c00f1c Reviewed-on: https://gerrit.libreoffice.org/69474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Resolves: tdf#119996 remove support for GNOME Shell application menuArkadiy Illarionov
Change-Id: If107a43f34eb13b215d2ebf285fbe3f8d1848b88 Reviewed-on: https://gerrit.libreoffice.org/69362 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Sifr icon theme updateandreas kainz
Change-Id: I8ecc36da016a996622956399fded664834d9aa4d Reviewed-on: https://gerrit.libreoffice.org/69470 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20tdf#124153 fix cut-off radio buttonTomaž Vajngerl
Change-Id: I8e07a8c49a9dc47cb8b75b61450125d449a45d1e Reviewed-on: https://gerrit.libreoffice.org/69467 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-20sw: make ODT export of paragraph auto-styles deterministicMiklos Vajna
If a complex enough document is loaded into Writer and saved as ODT, then the content.xml's automatic paragraph styles (P<num>) are re-ordered on each save, which leads to unnecessary noise. The actual random order is created during import by the time we convert direct formatting (e.g. from HTML import) to autostyles, as StylePoolImpl::maRoot stores autostyles in a map that orders autostyle parents based on their pointer address. This has benefits like automatic ordering of item sets and fast comparison, so don't change that, but extend the svl API to also track the name of those parents. This way by the time StylePool::createIterator() would iterate over those autostyles, it can order the parents by their name, so two import->export runs will result in the same autostyle ordering. (This appears to be the only indeterminism in content.xml for a test HTML input, while meta.xml and settings.xml still changes all the time.) Change-Id: I1cfcae2c664a5c5c3dee48be733046979c1593ed Reviewed-on: https://gerrit.libreoffice.org/69469 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-20VclAbstractDialog_Impl is now unusedCaolán McNamara
Change-Id: Ibd77f77d01137f1e5b41100fd629e8a6f439c1c4 Reviewed-on: https://gerrit.libreoffice.org/69465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20SwAbstractSfxDialog_Impl is now unusedCaolán McNamara
Change-Id: I7d17f8dbee1815cb128023283f6265f334cac0f9 Reviewed-on: https://gerrit.libreoffice.org/69464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Fix MSI build after commit 7a9f6df7fb83ec23d09cb5744c2c865fa22e7143Mike Kaganski
Change-Id: Ib659477a2358b14fbacc1638394c783995272eb5 Reviewed-on: https://gerrit.libreoffice.org/69466 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-20fix transparency handling in BitmapEx::GetPixelColor()Luboš Luňák
Apparently the Color class uses transparency as the opposite of the normally used meaning of opacity, so transparency 255 means transparent. Change-Id: I3a76c2c93d98ad3c850017d3fd569b04dc6c19c8 Reviewed-on: https://gerrit.libreoffice.org/69211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-20tdf#122943 Don't add properties to style when Highlighting and AreaJim Raykowski
...tab pages are simply visited Change-Id: I490275bf7e27160d312bb5b6ad7001298549f7e8 Reviewed-on: https://gerrit.libreoffice.org/69455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-20Fix typoAndrea Gelmini
Change-Id: Icdd2584e03e93f5e3a93e892fc9bcf107b5dbca7 Reviewed-on: https://gerrit.libreoffice.org/69448 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-20tdf#123909 fix event source that refers to a timenode.Mark Hung
p:tn (see below) were treated as delay value instead of timenode id. <p:stCondLst> <p:cond evt="begin" delay="0"> <p:tn val="5"/> </p:cond> </p:stCondLst> Just convert the timenode id to XAnimationNode and set the event source properly. Change-Id: Ib408be6714c6ac70dad7018e544e560cf59a40c0 Reviewed-on: https://gerrit.libreoffice.org/69340 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-03-20tdf#42949 Fix IWYU warnings in include/drawinglayer/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8daf57df5b8f9c609d4f3ca44bae7366addceb6c Reviewed-on: https://gerrit.libreoffice.org/69151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-20rhbz#1690645 null deref of pEntry when GetCurEntry return nullCaolán McNamara
in GetFocusRect at SvTreeList::GetDepth code in since.... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 Change-Id: Ida6cb934c94037c861c7d5da005226f32599b5fc Reviewed-on: https://gerrit.libreoffice.org/69459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Unit test for cut copy move into shared formula group reference, tdf#123714Eike Rathke
Change-Id: Ibcf03f5068630c18eeecf2625cdff7ec1704d292 Reviewed-on: https://gerrit.libreoffice.org/69453 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-03-20Sifr icon theme update lc_andreas kainz
Change-Id: I976fca5e8c5eba513416819bbc3932fb845076a8 Reviewed-on: https://gerrit.libreoffice.org/69452 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20rename SwConditionEdit back to ConditionEditCaolán McNamara
Change-Id: I6ba7cc5193d6d0badf1f520a907864ab3e16f3f3 Reviewed-on: https://gerrit.libreoffice.org/69445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20ConditionEdit is now unusedCaolán McNamara
Change-Id: Ibede37194a6ae67032db68d64f51d58c8c48446b Reviewed-on: https://gerrit.libreoffice.org/69444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20fix some SwFieldVarPage problemsCaolán McNamara
Change-Id: Ib26efb7bf872b14ff4947ee3880fc316550ed226 Reviewed-on: https://gerrit.libreoffice.org/69449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20Fix typoAndrea Gelmini
Change-Id: Ic1e3440c29a1dc77761e94bde41ac3a000975a37 Reviewed-on: https://gerrit.libreoffice.org/69456 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-20The DEBUG_WRITERFILTER code should be a dbgutil thingTor Lillqvist
DEBUG_WRITERFILTER being on or off introduces binary incompatibility between object files that implement and use those things, so it shouldn't be changed without a full recompilation. Thus is matches dbgutil. Change-Id: Iec3c713ca7b299daf4b9cf1c978e49bf5ddf6886 Reviewed-on: https://gerrit.libreoffice.org/69438 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-20sw: document what quo vadis and ergo sum portions portions actually doMiklos Vajna
Thanks Michael Stahl for the hint that they are related to multi-page footnotes. Change-Id: If7d839ff01e96070bfcb51952d5e7aea0fd05d14 Reviewed-on: https://gerrit.libreoffice.org/69442 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-20i#119731 Add icons for InsertHyperlinkControlShubham Goyal
The icons added are dupications of icon InsertHperlink. Change-Id: Ic1fc57e4e8d45910e232e856bd43217f456d3887 Reviewed-on: https://gerrit.libreoffice.org/69457 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20tdf#123504: improve unit test robustnessMike Kaganski
... since the values are unstable for charts. Just use reasonable lower bounds. Change-Id: I9510d834a3905c188b52313e267998a4c73f8aa2 Reviewed-on: https://gerrit.libreoffice.org/69458 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-20Clarify flow, reduce scopeMatteo Casalin
Change-Id: I99dbde5d2b25a8cbffc027e136d29cf911d5337b Reviewed-on: https://gerrit.libreoffice.org/69243 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-20Simplify by using indexed getToken()Matteo Casalin
Change-Id: Ie3c890be9ec3ec01bb72977ab2934bda62b2edea Reviewed-on: https://gerrit.libreoffice.org/69248 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-20Further reducion of OString copying by in-string comparisonMatteo Casalin
Only copy string for SAL_WARN call, to not print unneeded information Change-Id: I962ac8a7ed9bc8ee08d1ea31f4f13a0670cbdf3a Reviewed-on: https://gerrit.libreoffice.org/69232 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-20Reduce OString copying by using in-string comparisonMatteo Casalin
Change-Id: I75dbafe00609c6f85ec7cc0cca492bc01cb62052 Reviewed-on: https://gerrit.libreoffice.org/69231 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-20Reduce OString operationsMatteo Casalin
Change-Id: I13291ca27574d3536e55d8207a0b13b2694385be Reviewed-on: https://gerrit.libreoffice.org/69233 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>