summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-21use more string_view in xmloffNoel Grandin
Change-Id: Ieef49d049760e557d341f1991f28333b09220c1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21Extend loplugin:redundantcast to some suspicious reinterpret_castStephan Bergmann
Change-Id: I5534939bfbea67d216a17891722a683c53621d36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-21new won't return null, so drop conditional nowCaolán McNamara
Change-Id: I08e0bac8215f5aff92dc4c79caea4d3275b9c08e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21use more string_view in svtoolsNoel Grandin
Change-Id: Id0317c400d7bc868916b97cd1c7abae04c4a9e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21tdf#151100: xText->getString() may be empty for content needing exportMike Kaganski
The check that is removed prevents collecting the table data. Assume that it's the performance optimization, and that processing empty text objects would be fast anyway. This basically reverts commit 73fcb052edf1a21d785583bc53e8b4323b577bb1 Author Christian Lippka <cl@openoffice.org> Date Thu Nov 22 12:26:35 2001 +0000 #90330# only export text autostyles for shapes with text and commit 7661bbbaef31adfdb298b1447301b24a70f85834 Author Michael Stahl <mstahl@redhat.com> Date Fri Nov 25 22:46:34 2016 +0100 tdf#102479 ODF export: ignore exceptions when checking shape text that becomes unnecessary after the former change is reverted. Change-Id: I709a7b4c5ac1cc0621d3a1b18f2eb74feb987efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140313 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-21update expat to 2.4.9Taichi Haradaguchi
Fixes CVE-2022-40674 (https://github.com/libexpat/libexpat/blob/R_2_4_9/expat/Changes) Change-Id: I459cf5f5de31e7cf5420d3df6b11893d5c4ca4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21cid#1515518 Dereference before null checkCaolán McNamara
and cid#1515520 Logically dead code Change-Id: If3eaece51004e3b05eaf123a3d80430ffc154be2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140308 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21cid#1515521 Dereference before null checkCaolán McNamara
Change-Id: Ida2a6fa69b5ca771c87669b8c58e8febb0f8a2f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140307 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21bogus OSL_ASSERT: nPos != std::u16string_view::npos ... warningsCaolán McNamara
since: commit 5edefc801fb48559c8064003f23d22d838710ee4 Date: Tue Sep 20 11:37:12 2022 +0200 use more string_view in unotools Change-Id: I095de3a1156613e95c96ad0d1375885e8f36d61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140312 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21drop extra spaceCaolán McNamara
Change-Id: I0cd134dbeaef46bf3c925a01b423edc0be2bba63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140310 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21sw content controls, combo box: make the dropdown case read-onlyMiklos Vajna
Dropdown should be read-only (select from existing list items only), combo box should be read-write (accepting free-form user input as well). Now that we have a combo box, allow editing a combo box's content, but turn dropdown into a read-only control. Change-Id: Ie9434eaf2580be8ce154ec1126f7768eb9401254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140338 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-21Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to a5f80090f50b6d1e06f579d12a22eb1ad805c99c - update translations for 7.4.2 rc1/master and force-fix errors using pocheck Change-Id: Ia36bd93db2652764c7ed865058467bb0b17eb545
2022-09-21sw content controls, combo box: add doc model & UNO APIMiklos Vajna
This is similar to dropdowns, but combo box allow free-form user input, while dropdown is meant to enforce that the content is one of the list items. Change-Id: I4ae226c55f70b2b3237021348e21b7d184e8a5ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140302 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-21cid#1515519 Uninitialized pointer fieldCaolán McNamara
Change-Id: I5ebb88d3f0a9d02301e4bf19e8492300eff63c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140306 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21CppunitTest_sw_ooxmlfieldexport: remove not needed mustTestImportOf()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I819eea323c7445bf25444c11c35314f439d4116c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-21fix/simplify opencl GEOMEAN()Luboš Luňák
I don't quite see why this one would need such a special handling, when most other functions (e.g. the very similar HARMEAN()) can do with just generic handling. Change-Id: I31f3772ffdf9540178a42f11ae4e376023ad2413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140257 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21fix opencl WEIBULL and ZTEST functionsLuboš Luňák
Sync them with their core versions. Change-Id: I8890b13c0be8ac1da91132ec7e294f542dcc577e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140256 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21fix and simplify opencl functions that calculate difference from meanLuboš Luňák
ocVar, ocStDev etc. Besides the copy&paste reductions, these also need to use fsub_approx() otherwise they can fail with large numbers. Change-Id: Ic96caaa0d5711d811a27b0e2034db357a71b9fa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140255 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21fix and enable some disabled opencl functionsLuboš Luňák
Change-Id: Ic7bd01edcc7297317b390567590821ce00e5ef22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140254 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21fix/simplify opencl DDB() and VDB()Luboš Luňák
Change-Id: I7de072defa1f8a1020c0d974bd519e6d2f604381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140253 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21various small opencl code fixes and error checkingLuboš Luňák
Change-Id: I9f1d109887faf11a86be83da050983292e99da49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140252 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21fix some opencl financial functions (PMT, IPMT, etc.)Luboš Luňák
These are mostly copy&paste from ScInterpreter and adapted. Change-Id: Ib05021556a34b2eb35d0e51673636f50f150732f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140251 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21remove opencl implementations of ocDB* functionsLuboš Luňák
- These are hard/impossible to implement properly, since they all use 'SearchCriteria' argument, which is an expression to be matched, and already strings are hard in opencl and parsing/evaluating/whatever an expression would be so complex. Maybe number matching or very basic expressions would be possible, but not much more. - The opencl implementations of these are (hopefully) very unlikely to be ever used, since they generally do not make much sense to be used in formula groups (except if the result is repeated in the group). As such, simply remove these, as it's just not worth it. Change-Id: If007c84c1ff684a94cfce0fe171691d9b3578658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140250 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21rework handling of empty cells in opencl codeLuboš Luňák
Some of the code handling ranges of cells wants empty cells to be zero, some wants to skip them, and few want special handling. So just make three generic cases that handle these, which somewhat simplifies this while still allowing flexibility where needed. Also handle better Test::testFuncSUMXMY2, which works on a pair of ranges, sets a cell in one to a value and another is empty, in this case it is necessary to iterate over this pair with SkipEmpty even if for the second one it's beyond GetArrayLength(). Change-Id: I6c8edaaadb02ffe2a6a7a9399347909008ea188e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140249 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-21use more SwPosition::AssignNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I19e7a24231a2f4c15ffdf4b778e191e1907e40f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21use more string_view in vclNoel Grandin
Change-Id: I66f96a305bb095716023ae1e565950971826bce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21convert TrueTypeCreator to a C++ classNoel Grandin
Change-Id: I07cd2dfeb947f555b31bd0dccb91fb76f549c675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21use more unique_ptrNoel Grandin
Change-Id: I7836a1b1813d16db53ca0d6cc2b2ff2ae95e70cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21convert GlyphOffsets to a C++ classNoel Grandin
Change-Id: If693a5d0a94da666fd0361d45a3047890d9dec8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140265 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21convert HexFmt to a C++ classNoel Grandin
Change-Id: Iebe385b1a6d51ab2c179a27eef4fb1199bc3aa41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-21NameID must encompass the full OpenType Name ID rangeStephan Bergmann
...to avoid CppunitTest_vcl_fontfeature CPPUNIT_TEST_NAME=FontFeatureTest::testGetFontFeaturesOpenType failing with > vcl/source/font/PhysicalFontFace.cxx:376:48: runtime error: load of value 259, which is not a valid value for type 'NameID' > #0 in vcl::font::PhysicalFontFace::GetName(vcl::font::NameID, LanguageTag const&) const at vcl/source/font/PhysicalFontFace.cxx:376:48 > #1 in vcl::font::FeatureCollector::collectForTable(unsigned int) at vcl/source/font/FeatureCollector.cxx:124:44 > #2 in vcl::font::FeatureCollector::collect() at vcl/source/font/FeatureCollector.cxx:198:9 > #3 in OutputDevice::GetFontFeatures(std::vector<vcl::font::Feature, std::allocator<vcl::font::Feature>>&) const at vcl/source/outdev/font.cxx:169:23 > #4 in FontFeatureTest::testGetFontFeaturesOpenType() at vcl/qa/cppunit/FontFeatureTest.cxx:143:5 after 06a23b7b4d23a31a4808c68f00e1be42d8218737 "vcl: Add PhysicalFontFace::GetName()". Per <https://harfbuzz.github.io/harfbuzz-hb-ot-name.html#hb-ot-name-id-t>, hb_ot_name_id_t is a typedef for unsigned int, and per its referenced <https://learn.microsoft.com/en-us/typography/opentype/spec/name> OpenType Name IDs are apparently uint16 values covering the whole value range (e.g., "Name IDs 256 to 32767, inclusive, are reserved for font-specific names"). We could thus presumably use something like std::uint16_t as the underlying type for NameID, but lets play it safe (and avoid potential data loss when casting from hb_ot_name_id_t to NameID) and simply use hb_ot_name_id_t as the underlying type. Change-Id: I50768c5ae6174500d959ba63fdbc15fe416f8777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140301 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-21tdf#151081 render rotated gradients correctlyArmin Le Grand (allotropia)
We have to use regular primitive decomposition when the gradient is transformed in any other way then just tanslate & scale. For more background, refer to the bugzilla task. Corrected some typos. Change-Id: Ic767c9fe6d14444915facc1247ba4ec1f79fd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140237 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-21tdf#151071 Revise Sifr, tidy up links.txt, remove duplicateRizal Muttaqin
Change-Id: Ifcf5014448214238891fe5a583dc36e0b9fccfe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140285 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-09-21Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3b0d630cec012f7aa10cad2029468f5ea6f25b6c - tdf#150958 Fix mention to Find tool in help page Change-Id: I57e98af47bed1ee499ad9f9268514697141eaf9e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140169 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-21tdf#151088 Use "Kraft Paper" instead of "Invoice Paper"Rafael Lima
As per discussion in Weblate, the correct term here is "Kraft Paper". Change-Id: I0c0ffeac66453911f016e2134436f4cb5c340f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140171 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-20tdf#151071 Revise Sifr, remove duplicate and missplaced iconsRizal Muttaqin
Change-Id: I3322303ab50c65301bfaeff14ba371662bb7e3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140259 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-09-20avoid some string refcounting with sheets with lots of conditional formattingNoel Grandin
Change-Id: Ibb2de1aa28a57748bede6085074f60af757ae5ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20add CanJoinNext method that takes a SwPosition*Noel Grandin
part of the process of hiding the internals of SwPosition Change-Id: I401fa4d98a2e53a082bfb39f3d13315261a0a2ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20use more SwPosition::AdjustContentNoel Grandin
part of the process of hiding the internals of SwPosition Change-Id: Ied4eb6b219dbd505c53068ca1ec7a5b43e5a1cfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20tdf#151056: avoid modifying the static shared DEFAULT instanceMike Kaganski
This was a thinko in commit e39fa3c4f5ae2560a4b6f6f789a0c5098ac43cf4 Simplify b2d(poly)polygon implementation This led to exponential growth of elements in each next polypolygon created from scratch, that immediately manifested with the complex SVG logo shown on the backing window. And finally, there's no const_cast/as_const left in the file :) Change-Id: Ie60f75ec86a8fa21799f4f1b589c04c9e4646183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140248 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-20tdf#150642 fix table layout with vertical writing.Mark Hung
Revert part of 1bf82b26ae3. N | V | WAS | 1bf82b26aea3 | WAS | 1bf82b26aea3 | ------------------------------------------------------------------------------- F | F | fnRectHori | fnRectHori | fnAddRight/fnSubLeft | | F | T | fnRectVert | fnRectVert | fnAddRight/fnSubLeft | | T | F | fnRectVert | fnRectHori | fnAddRight/fnSubLeft | fnAddBottom | T | T | fnRectHori | fnRectVert | fnAddRight/fnSubLeft | fnAddBottom | * *: the case fixed in this patch. Ref: commit 1bf82b26aea3a403920a64cdfcb4671c947c7a01 Author: Mark Hung <marklm9@gmail.com> Date: Sun Aug 14 15:23:14 2022 +0800 tdf#135991 fix unexpected hidden RTL sections. Change-Id: I1e30c277dd03369bef0a6930b3d3534b7d57a640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139777 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-09-20fix and simplify openCL *A functions (COUNTA,MINA, etc.)Luboš Luňák
These work just like their non-A counterparts, they just also accept strings and treat them as zeros. So instead of having a duplicated function for everything, use the basic functions, detect that string arguments should be treated this way and then convert them in the input data. This as a side-effect also makes the ScCalcConfig::StringConversion::ZERO part work (no idea if that's even been used). Change-Id: I3385b5363c15b0ae45ff191df00ac357e80bd3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140226 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste (gaussinv)Luboš Luňák
Change-Id: I44e5c74c903bab46a54b5b855f2665d924ac91fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140225 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20fix opencl AND() to treat empty cell in svSingleVectorRef as core doesLuboš Luňák
Functions_Excel_2016.fods incorrectly used "=AND(Sheet2.C22;C33)" instead of the correct "=AND(Sheet2.C22:C33)" (colon vs semicolon), and C33 is an empty cell. The return however was true because empty cells get special treatment because of Excel compatibility. Change-Id: I6d0b28280059fd6fc945e77c7b5d714b5e4727a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140224 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20fix opencl FTEST()Luboš Luňák
Change-Id: I72a6e7e36a8514c1d3c824a70829ebf026659262 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140223 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20simplify opencl code in op_array.cxxLuboš Luňák
Change-Id: I4379683fa239e6f7c543350b645addffa784ba70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140222 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20fix and simplify opencl IRR(), MIRR(), XIRR() and XNPV()Luboš Luňák
Change-Id: Ie57e43458f7fa5a769806d0fe3054745ec71c99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140221 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20Assert that cow_wrapped objects aren't called to do nothingMike Kaganski
An omission from commit e39fa3c4f5ae2560a4b6f6f789a0c5098ac43cf4 Simplify b2d(poly)polygon implementation Change-Id: Ib0b10e06baf91888f0e9797e670e0626f512af15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140229 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-20use more string_view in svlNoel Grandin
Change-Id: Icd978cd3cb7946f96d2570a0b8c87a74eed57c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20move some test from odfexport to odfexport2Noel Grandin
to trim the long run time of odfexport Change-Id: Ib2c2f13796ecea14a3aede51442005c08487c128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140240 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-13 06:34:38 +0000