summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-19nRow argument is unusedCaolán McNamara
Change-Id: I9401d5af8e537423e7198435457107e12817fc09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19drop unneeded includeCaolán McNamara
Change-Id: I78ad2129d97d6a7476e81dc7689ffe30c449eb75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111216 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19weld FunctionPopup_ImplCaolán McNamara
Change-Id: I1489f545af75fc93cf37c4399217cd91ca464243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111212 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Related: tdf#140409 scale the menubutton like the other widgetsCaolán McNamara
Change-Id: I6b42ef958dd1625cfef5e48e45c932aef9a5960f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Add Japanese label makers dataJun NOGATA
* Original Data: Default Settings for Japanese https://ja.osdn.net/projects/openoffice-docj/ * Data cleaning: Tomonori Iwahashi(JO3EMC) Change-Id: Iebe4dcd85bc035d9c64a1fef2d0fd810acc6d3f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108536 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-02-19detect if menubutton already has an image and reuse itCaolán McNamara
Change-Id: Id8e48491ad27cd3bfac96817ae1bb4da751c38e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19python3: upgrade to release 3.8.8rc1Michael Stahl
Fixes CVE-2021-3177 plus these less important ones: CVE-2021-23336 CVE-2020-27619 CVE-2020-26116 CVE-2019-20907 Change-Id: Idbe072a9db1faf8363b4f7795b9fde71c26969f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111208 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-19Starmath now allows multiple parsersdante
This is an intermediate step towards making a parser wich supports mathml standards. The parser now is a "mask" wich calls the correct parser behind the scenes. Parser 6 is the same as parser 5, but will be implemented soon. Parser 5 does what the old parser did. Using as defualt smsyntax5 in order to be able to code parser6 without provoking any backguards compatibility problem. Change-Id: Iccf73e5ba96870450b98907f78a2a0c28abf6093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19rename get_vscroll_width to get_scroll_thicknessCaolán McNamara
and add split customize_scrollbars to form a separate set_scroll_thickness Change-Id: Ia4b1c85d6ae85b0fb7aeb852d3a91b36b63143db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19loplugin:refcounting in ucbNoel
Change-Id: Ib62c99b9cb71adda5c94d268f726949117163ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19loplugin:refcounting in vbahelperNoel
Change-Id: I91c4ce6529e18a309e7b6d4432b612f7d38f817e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111197 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 065569618bde9f98b7f152e4c5aadf11d5f3e64a - Take Mac keyboard into account with Styles shortcut Change-Id: I67322e56753976225ab1ecfa0508269d58c5ab30 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111194 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-19loplugin:refcounting in unoxmlNoel
Change-Id: I979b309271809b64d6f04cbccd14e0ee3b09ec81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19compilerplugins: fix referencecasting for clang 7.0.1Miklos Vajna
The error was: error: 'error' diagnostics seen but not expected: File /libreoffice/master-clang/compilerplugins/clang/test/referencecasting.cxx Line 113: unnecessary get() call [loplugin:referencecasting] 1 error generated. I.e. it seems clang7 has the same problem as clang5 that it emits multiple diagnostics for that problematic code line. Adapt the ifdef accordingly. Change-Id: I232ff9a158663e2cb3030e51f655249ff315361e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111196 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-19tdf#140058 repair which Bullet and Numbering label is changedSeth Chaiklin
https://gerrit.libreoffice.org/c/core/+/110928 describes the intention, but that patch changed the wrong "Bullet and Numbering" label. This patch undoes that change and changes the correct label. Change-Id: I483e597e94e6d8e28b5b914e3e2e44a6abdf1358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111151 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-19tdf#65872 [WIP] Allow prefered interpretation of pasted numbers to be savedGeorge Bateman
Change-Id: I065f1f8cff1b3c7d7198ce431df39a7b8cb7b593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107402 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-19Fix typoAndrea Gelmini
Change-Id: Ia84a41df2359180ddd615aeb5ea6c9915e311e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111154 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-02-19"delete" also empty Calc cells if it helps mdds (tdf#139820)Luboš Luňák
With mixed non-empty and empty cells, deleting a range would normally mean deleting just the non-empty cell ranges, which would make mdds repeatedly move parts of the underlying vector. Including empty cells in the range to delete may result in just one pass. Change-Id: Ia2ebcaba054c6e46f3cf6c964ba883bb600d6ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111125 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-19write color components properly in debug outputLuboš Luňák
They are sal_uInt8, which is technically unsigned char, and those are normally written as chars, not as numbers. Change-Id: I63d81ce270f95d06f1641eea3b2231a12a8aea2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111124 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-19weld BibGeneralPageCaolán McNamara
go the route of all-welded to replace this mix of vcl and awt widgets Change-Id: I242b801dc1d9993fc478bb7253480f5b6c3c0ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19tdf#140409 Comment text ignoring zoom sizeCaolán McNamara
Change-Id: If48d5c1085cbc86f81ba0c92c8875ef534900c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19loplugin:refcounting in vclNoel
Change-Id: Ieca3dd33a7ae40c3f7b8ba30f763d71a548cd144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111171 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19loplugin:refcounting in xmlhelpNoel
Change-Id: Ida82bee18d0828f299db0e87ecb2faf67432dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19loplugin:refcounting in xmlscriptNoel
Change-Id: I82e3fe7ec8f45d9e99ec51688df97a0e5a33f58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19pdfium: eliminate FPDF_DOCUMENT from public headerMiklos Vajna
Which means the last pdfium include can go from PDFiumLibrary.hxx. Change-Id: I73e40767f594c9a6ce75582621af975419ccf996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111163 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-19loplugin:refcounting in xmloffNoel
Change-Id: I739aa5914359edc4fdfdc341b09718ddbb7c04e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19loplugin:refcounting in xmlsecurityNoel
Change-Id: Ic5227df4bd5b1f3dfe9cd13ae971d268a40f0fcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19Some more unit conversion unificationMike Kaganski
Change-Id: I8f0afb93ffb8bd1b88efca802fad5e9aeb447021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111168 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-19tdf#124176 Use pragma once in include/oox/drawingmlQuentin DELAGE
Change-Id: Ifcf41582cd305293a701707618ff0f4b7d6322ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111162 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-19tdf#117706: sc_uicalc: Add unittestXisco Fauli
Change-Id: I7c201585d5c9a2651bea47b44069a5836b3df3b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111166 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-18Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1f290dca1dedb503935ef2ee627b00bbb8eb37be - Another random typo grab bag Change-Id: Ib548ab7e25600fc693d7a9d6319104f431eb8e8e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111167 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-18tdf#134432 icon label to "Character Highlighting Color" for ShapesSeth Chaiklin
WriterCommands.xcu has .uno:BackColor for character highlighting in text, while GenericCommands.xcu has .uno:CharBackColor, which is used for all character highlighting in textboxes and shapes, in all the modules including Writer, but this .uno appears on the Text Objects toolbar for Writer and Text Formatting bar for Calc, Draw, and Impress. Both .unos produce <style:text-properties fo:background-color> http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-fo_background-color .unoCharBackColor appears only in Calc, Draw, Impress, while Writer has both .uno:CharBackColor and .uno:BackColor Adding "Character Highlighting Color" for tooltip and menu labels to .uno:CharBackColor for Calc, Draw, and Impress, togheter with a longer label "(in Textbox and Shape)" that appears only in the "Description" box in the Customize dialog. This longer label should not create confusion for the other modules,which only have .uno:CharBackColor but will help to differentiate the function of .uno:CharBackColor from .uno:BackColor in Customize for Writer. Change-Id: Ia88b51ee73d0c9ccc82700ed39bc01486ff3a8a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110865 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-18tdf#139667 adjust Condition tab dialog for Text Body to "list"Seth Chaiklin
- This dialog referred to "Numbering", but better to refer to "List" because the level can also apply to bullets and graphics. - adjusted tooltip accordingly. Change-Id: I5256be054f44058f44711113a85f3053bfd4c755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111041 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-18Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 99f8092e8b6949c519b8f03c1134b7d3e0282ef7 - tdf#139667 update "numbering style" in footnote/endnote / linenumbering ( swriter/01/06080100.xhp ) "footnote settings" * move 1,2,3 to first in list of numbering schemes (to correspond with dialog box) * combine paragraphs about styles * replace German id - remove "colspan = , rowspan= * move position of "Start at" to correspond to dialog box - remove "Character Style" heading, which is no longer in dialog box. + add sys-switch for F11 shortcut key * update to <h1>,<h2>,<h3>,<note>,<tip> ( swriter/01/06080200.xhp ) "endnote settings" * update replaced German id - remove "Character Style" heading, which is no longer in dialog box. * update to <h1>,<h2>,<h3>,<note>,<tip> ( swriter/01/06180000.xhp ) "line numbering" * "numbering style" -> "numbering scheme" * update to <h1>,<h2>,<h3>,<note>,<relatedtopics> ( swriter/01/05040700.xhp ) "footnotes/endnotes" * "numbering style" -> "numbering scheme" * update to <h1>,<h2> Change-Id: I563b3c20aabe94edfec76fae22a2585483492520 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111035 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-18tdf#139667 Bullet and Numbering tooltips, use verbs and add missing oneSeth Chaiklin
Change-Id: Id5439fb3820db94c08d9902c859da199127fd339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110791 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-18tdf#139667 adjust tooltips and labels for diverse List StylesSeth Chaiklin
Change-Id: I10d9ba5d5f7278cc89db84125e59b0e58eb0e980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110447 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-18extended tooltip corrections in AutoCorrect Exceptions dialogSeth Chaiklin
The Exceptions dialog tab got its extended tooltips automatically from the help pages. Two of them (Autoinclude) inherited a missing space in the tooltip. "Words with TWo INitial CApitals or sMALL iNITIAL" did not have an updated version of the help that included "small initial". Also, the inherited "extended tooltip" was for both "Autoinclude" items, and was missing a critical piece of information. See tdf#140366 and https://gerrit.libreoffice.org/c/help/+/110782 for details. The patch corrects the extended tooltips so that they are appropriate for each autoinclude. Plus it adds a tooltip for each autoinclude. Also, changed the accelerator key for Autoinclude so that it did not clash with the accelerator for the "language" option. Change-Id: I893577c2da6da85cdd25465d6e0463dab185fe3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110773 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-02-18Library_gie no longer existsCaolán McNamara
Change-Id: I1e786496c07b503010ca412879e405ca77007d32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18update DataBrowser has-focus when child widget loses focusCaolán McNamara
similar to tdf#135641 case, focus-out becomes an issue with the bibliography editor if focus-in is seen on clicking in a cell, then click in a GtkEntry and tab around in a circle. Without this lose-focus support focus will be grabbed back to the cell of the initial click on a circuit of the focus-cycle Change-Id: I36288ed21dc4357c077f8dee55b55abf2457c2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111157 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18move async focus-in/focus-out workaround to known client that needs itCaolán McNamara
and for the normal case process immediately. Use-case is the bibliography editor, modified uncommitted entry, click in browser column margin area to select a new row, the entry should commit its old contents to the old row before filling from the new row Change-Id: Ib41d96afcfa86bcd1075b9512d4cfab593afa66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18link up orphan labels in mapping dialog to the entries they should labelCaolán McNamara
Change-Id: I0ed3792d68654f90ebe1e030d25528f087e53ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111102 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18loplugin:referencecasting (macOS)Stephan Bergmann
Change-Id: I99470067a34fab9fbc2ea53d2f8a634240f0d223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-18loplugin:referencecasting (--enable-extension-update)Stephan Bergmann
Change-Id: I658aa527d426c28fc19132c2583429c4b3de816a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111126 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-18Clearer text to add new Impress templateLaurent BP
Change-Id: I291d90795b1b2a6c160bdf20544df73dbb8054c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110209 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-02-18tdf#140486 forms "empty string is null" setting not loadedNoel Grandin
regression from commit 3de38e95561ab7ca114d9f3307702ba89c4e3e9a Date: Tue Nov 10 19:20:06 2020 +0200 use fastparser in forms Change-Id: I1e679bdca17185f20c1f755da16f02aa5661e22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-18tdf#51828: uitest: add comment to existing testXisco Fauli
Change-Id: I30e1fb20685e6eb63954771b4fc3a7b9d2e200b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111122 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-18Better fix for tdf#125824: switch page only for the current view.Tamás Zolnai
First workaround was avoiding undoing: 9dca7c2fac5c6b83a6910aa61b1a2a316f36d948 Second workaround was forcing all views to exit text editing: e6c7a018a0cfee395ce2886d41c908a2447ef5cc Instead of these solutions, we allow to continue text editing in other views. What we do is avoiding jumping to the object location in all views while undoing. In theory, the two views / windows should be able to edit the document's different parts independently. So one view should not jump to the location where the other view edits something / does an undo. It works both with multi-window and Collabora Online's collaborative editing. Change-Id: I7ffe29bf175b8f855fe3e92b3d7e11ca6bcd3f5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111073 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 7db8c3d36db3ed727ade2609b7c1017cc813a560) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111112 Tested-by: Jenkins
2021-02-18tdf#57465: sc: Add UItestXisco Fauli
Change-Id: I600ee7a628087fb35903c34793f5eb1b48eee971 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111114 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-18tdf#100517: sc: Add UItestXisco Fauli
Change-Id: I91dd999d55971374070312ef9f8fa5141ae650fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-18sw bibliography: make URLs in the bibliography table clickableMiklos Vajna
- Don't reuse the <text:index-entry-link-start> / <text:index-entry-link-end> mechianism from <text:table-of-content-entry-template>, because <text:bibliography-entry-template> doesn't allow this - Use STR_POOLCHR_INET_NORMAL as a char style, so the URL looks clickable - Allow absolute URLs for ToxAuthorityField::AUTH_FIELD_URL (other URLs like ToC are always relative) - Track the new text added by FillText() between the StartNewLink() and CloseLink() to figure out what is the URL to be launched on click Change-Id: I126fa06aecfff783e62b65a548228ff781b62c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111117 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins