summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-15get parent for welded menu and location to pop it upCaolán McNamara
Change-Id: I654f6edc4b8bdb0e38f70757b970893980b09638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15add a way to correctly position a weld::Menu given a vcl::WindowCaolán McNamara
Change-Id: I7fc6a1bb6cfca40a4a97568f957d127445b4d31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107727 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15popup_at_rect needs to work like ShowNativePopupMenu for toplevel frameCaolán McNamara
Change-Id: Iec313faa525ddd5564009403060c58d72482038a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15tdf#138893 improve messages in Template ManagerSeth Chaiklin
+ add keyboard accelerators to Settings menu commands * repair grammatical mistake in "Overwrite" message * revise query about loading styles of a modified template * change query about category deletion to singluar and referring to category Change-Id: I41934b0e194f00395345a79e8f69fa4fdd0ff04d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107694 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-15Silence warning C4189: local variable is initialized but not referencedStephan Bergmann
Change-Id: I6157c6e92877738366c142025a3bc8f3e38eb0a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107737 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-15tdf#118711 writerfilter: don't hardcode default page descriptionJustin Luth
well, at least not at the beginning of the document. The problem with specifying is that it becomes a property of the paragraph - and so if the paragraph is copied or moved, the page break comes along with it and the user has to remove the unnecessary page break wherever it lands. Since the default will be applied anyway, there is no value in specifying it. I'm not sure how, but at least one test document started with a Converted1 style, so I had to explicitly confirm that the stylename really did match the default for a first section. A unit test also indicated that it needs to be specified if an explict page number is assigned because RES_PAGEDESC contains MID_PAGEDESC_PAGEDESCNAME as well as MID_PAGEDESC_PAGENUMOFFSET. Change-Id: I0d0f6b70767f7daaf300e09c0d31ac4b17b91ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107555 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-15loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I7920101576f1b5a115bf2af74f18832e0341eb24
2020-12-15graphic: Rework swapping algorithm to take GfxLink into accountTomaž Vajngerl
This reworks the Graphic swap algorithm to not swap to a file when GfxLink is available and leaves the compressed data in memory. With such a sheme, at swap-out we just remember the need specific properties of the Graphic, and delete the graphic content (Bitmap, Animation, VectorGraphic, Metafile). At swap-in use the GfxLink data to decompress and recreate the graphic content, then set the properties back as they were before (if needed). If a GfxLink is not available it swaps out to a file and back, but uses a simpler data format that is specific for swapping only. In the future this case can be removed, when we switch to automatic creation of GfxLink if that one is not present. For reworking of swapping it was also necessary to extensively add and extend the tests that check various swapping scenarios. Change-Id: I135a224f74aa48e6006f48dd2be74b8026614728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107287 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-15tdf#138600 sw: fix too small print area for btlr text in nested tableMiklos Vajna
Regression from commit 435ab51ec8920033b7865f27f4afee8a852a0b31 (tdf#128399 sw btlr: fix clicking to lower rotated cell, 2019-10-29), the bugdoc has a btlr table cell and the row frame of the outer table has a bottom value which is very small at the point when SwFrame::GetPaintArea() is invoked for the inner btlr cell. This means the "cell should not leave its parent" mechanism kicks in and reduces the bottom of the paint area to a small value, so the text is not visible at all. Fix the problem by teaching SwFrame::GetPaintArea() that btlr cell frames are OK to leave their parent towards the bottom of the page; that parent will grow at a later phase of the layout process anyway. Change-Id: I99334bbf0116df8d8ed27f192c81c0441b6c797d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107730 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-15Related tdf#138888: fix assertion on avmedia/MediaControlBaseJulien Nabet
Assertion when trying to insert a video in Impress, see bt: https://bugs.documentfoundation.org/attachment.cgi?id=168161 According to https://en.cppreference.com/w/cpp/algorithm/clamp "behavior is undefined if the value of lo is greater than hi" Regression from: commit 36b3b357fe2a882db6a5f5a006239e16200fb847 Author: Noel <noelgrandin@gmail.com> Date: Thu Nov 12 16:10:56 2020 +0200 replace std::min(std::max()) with std::clamp Change-Id: Idf33eb6c662b60174678f990f98aefc72edec2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15tdf#118435 add 'Text' before 'Documents' in Template Manager filterSeth Chaiklin
Change-Id: Iaae6e3c9e6a212bca4c6b983132e044cd574bb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107697 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-15tdf#122045: sw: Add UItestXisco Fauli
Change-Id: Ic49462e6d5a78d75947518744bde72b3d2cef86e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107688 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-14Silence warning C4189: local variable is initialized but not referencedStephan Bergmann
Change-Id: Ie36d7c4dfee5115b5909ed58a0b16b367e05866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107734 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Reuse pInstStephan Bergmann
Change-Id: I91e5a469344ab951225e61237b462ed58ed796be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107733 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14onedrive integration: updating metadata needs to be http PATCHChristian Lohmaier
avoids general i/o error message when adding newly created documents via the "Save remote" menu option. support for PATCH was added with 9cfcf83f53e0ae897b30705f790c6ebe0b86932e but only applied in onedrive-document.cxx OneDriveDocument::setContentStream which has it's own update of properties instead of reusing the method from onedrive-object.cxx Change-Id: I50f8801ac3186953f60198f877cedf3729307b89
2020-12-14ofz#28630 Fuzzing build failureCaolán McNamara
Step #4: vcl/workben/commonfuzzer.hxx:70:28: error: no matching function for call to 'OUStringToOString' Step #4: aBuffer.append(OUStringToOString(sExecDir + getExecutableName(), osl_getThreadTextEncoding())).append(".fonts"); Step #4: ^~~~~~~~~~~~~~~~~ Step #4: include/rtl/ustring.hxx:3587:16: note: candidate function not viable: no known conversion from 'typename std::enable_if_t<ToStringHelper<OUString>::allowOUStringConcat && ToStringHelper<OUString>::allowOUStringConcat, OUStringConcat<OUString, OUString>>' (aka 'rtl::OUStringConcat<rtl::OUString, rtl::OUString>') to 'std::u16string_view' (aka 'basic_string_view<char16_t>') for 1st argument Step #4: inline OString OUStringToOString( std::u16string_view rUnicode, dunno what the preferred concatenation scheme is these days Change-Id: I7390d5b4a23a76d7cfbc75c90ea75df4ee39457f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107731 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14add missing 'use_underline'Caolán McNamara
Change-Id: Ie6d549b20461d7bb80fd78deb393320e5ba57c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107725 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14warning C4189: 'pInst': local variable is initialized but not referencedStephan Bergmann
Change-Id: I8180087a9e9c3a6d6368d6d94d77ca18d303c1bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107724 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Fix typo in codeAndrea Gelmini
Change-Id: Ia1263267e8bfd4ca92a3da199fbc29a386f69c31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-14remove Seek(nCurr) in SvStream::remainingSize()Noel
which slows down some operations, and is unnecessary, since TellEnd() already resets the file pointer. Change-Id: I71a0d7f45074039b890997a730afa1cd1c160886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14Add -wd4505 also back to gb_CXXFLAGSStephan Bergmann
...which was accidentally missing from aca847cf1283e242c2d1106309ad4bb73d8f37a6 "-wd4505 is still needed" Change-Id: If0d3523f05d47da5dfe6dae45dedcdf075033daf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107723 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14tdf#122045 using 'Apply' doesn't keep document modified on later 'Cancel'Caolán McNamara
Change-Id: I7c6232747785a0c5827fe7344e1dc20758419956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14tdf#124176 Use #pragma once in connectivityDuP-491
Change-Id: Ib817bcd477db276a9554b1b3bdc87cf91c2a6658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107668 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-14use more direct parsing on FastAttributeListNoel
instead of first allocating an OUString Change-Id: I796b1b2d47eb3cb9bebb00ae1bbd465010ebf494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14macOS __arm64__ math.h does not define legacy finiteStephan Bergmann
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/ SDKs/MacOSX.sdk/usr/include/math.h only declares it in an > #if defined __i386__ || defined __x86_64__ [...] > /* Legacy BSD API; use the C99 `isfinite( )` macro instead. */ > extern int finite(double) > __API_DEPRECATED("Use `isfinite((double)x)` instead.", macos(10.0, 10.9)) __API_UNAVAILABLE(ios, watchos, tvos); block, so CppunitTest_odk_checkapi (which deliberately builds in pre-C++11 mode) failed with > In file included from ~/lo/core/odk/qa/checkapi/checkapi.cxx:29: > In file included from ~/lo/core/workdir/CustomTarget/odk/allheaders/allheaders.hxx:351: > ~/lo/core/include/rtl/math.hxx:352:12: error: use of undeclared identifier 'finite'; did you mean 'isfinite'? > return SAL_MATH_FINITE(d); > ^ So extend 19bce817279c7fd150af0422c224975e57ff9f41 "Try to use isfinite() for iOS" to all Apple non-Intel platforms. (We no longer support macOS __i386__ builds, but it probably does not hurt to nevertheless mention it here in the URE interface sal/mathconf.h include file.) Change-Id: I9b3a2ec1e48762dd178704185c64d1d3fe358001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107714 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14-wd4505 is still neededStephan Bergmann
...see e.g. <https://ci.libreoffice.org//job/lo_tb_master_win/29066> > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/unotools/source/config/bootstrap.cxx(269): error C2220: the following warning is treated as an error > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/unotools/source/config/bootstrap.cxx(269): warning C4505: 'utl::dbgCheckStatusOfURL': unreferenced local function has been removed where the OSL_ASSERT used in > OSL_ASSERT(aStatus != Bootstrap::PATH_VALID || dbgCheckStatusOfURL(sDerivedURL) == Bootstrap::PATH_VALID); is defined in terms of SAL_DETAIL_WARN_IF_FORMAT, which in turn is careful to make its contents visible to the compiler even under --disable-sal-log. That MSVC warning, about a function whose only reference is in code that the compiler can statically determine to be unreachable, is really unhelpful. This partially reverts 5c082fc1b59022252d90423afde174123976cdee "remove some MSVC -wd". Change-Id: Ie337989ee0ca6b7d7f29a50026fa249b0b266474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107716 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Bin a few unused forward declarationsTor Lillqvist
Change-Id: I1f0b8938f2174f9b8eee01714ea176fa4df38504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107715 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-14Handle explicit --disable-macosx-package-signingStephan Bergmann
Change-Id: Ib524049405215ac96ad51cbdc7f527f29c4f83f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14add a way to undo ImplConvertToAbsPosCaolán McNamara
Change-Id: Ia739c93c91f512c570d38a385d36bcce76e6fdcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14tdf#138715 remove mork strings and install targetsJan-Marek Glogowski
Hopefully fixes the package build. Regression from commit ee9ed2192b56c98e5b8ee9890ddb4c533117332a ("tdf#138715 remove mork driver"). Change-Id: I0faad65af834e3668c9845eadfe3439ae57b3699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107692 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-14Fix and clean up SalAbort implementations on macOS and WindowsStephan Bergmann
Since "forever", SalAbort has been declared as non-exported in vcl/inc/salinst.hxx and (only) called from Application::Abort (vcl/source/app/svapp.cxx) in Library_vcl. Its various implementations for different platforms have always been scattered across Library_vcl. For Windows, SalAbort was originally implemented in vcl/win/app/salinst.cxx, until 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" introduced an incompatible implementation in vcl/win/app/salplug.cxx (which was added to Library_vcl) and moved the original implementation in vcl/win/app/salinst.cxx from Library_vcl to Library_vclplug_win, where it thus became dead code (and where it now gets removed). For macOS, SalAbort was originally implemented in vcl/osx/salinst.cxx, until 3af4e1a0825c5b11ae4ef58fc411378aab669387 "Implement MacOSX VCL backend as plugin" introduced a different implementation in vcl/osx/salplug.cxx (which was added to Library_vcl) and moved the original implementation in vcl/osx/salinst.cxx from Library_vcl to Library_vclplug_win, where it thus became dead code (and where it now gets removed). (In 0f3be2e19fa408d7069d586ccf04cb3f3eccd6b9 "Unify sal plugin loaders", the--- identical---new implementations in vcl/osx/salinst.cxx and vcl/win/app/salinst.cxx where then consolidated with other---also identical--- implementations in vcl/source/app/salplug.cxx.) For macOS, the original, now removed implementation in vcl/osx/salinst.cxx and the consolidated implementation in vcl/source/app/salplug.cxx only differed in an added CrashReporter::addKeyValue("AbortMessage", rErrorText, CrashReporter::Write); which is presumably harmless to add. But for Windows, the original, now removed implementation in vcl/win/app/salinst.cxx differed substantially from the consolidated implementation in vcl/source/app/salplug.cxx, which is updated here to reflect those differences. The one thing that cannot easily be updated, though, is the //TODO: ImplFreeSalGDI(); call, as ImplFreeSalGDI is defined in Library_vclplug_win. I'll thus leave fixing that TODO for another commit (if calling ImplFreeSalGDI from SalAbort is even necessary, given that it ends in FatalAppExitW anyway)---my gut feeling is that the whole 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" was somewhat misguided. Change-Id: I641a3d7b1bc27ae14c38eb1ec0838bc04e4290d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Revert unneeded isEmpty check in Edit::GetTextJan-Marek Glogowski
Introduced in commit 579cf9548615e8535a0569a8eb4cdf325fbbbac7 ("tdf#138857 fix font replacement table GUI") to prevent a crash in rtl_uString_newFromStr_WithLength (see the bugs comments), neither sberg nor I could reproduce it, after I did a rebase and full build. Maybe it happened because of a partial build after a local rebase... no other idea. Commit 8b66e1745933cd5aa4ae974f709a7e6c8be1f898 also added a unit test, which passes. This revert the change to Edit::GetText. Change-Id: I1a178f912813b48b88b1c2e3831b9e1b7ab3717f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107690 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-14loplugin:unusedenumconstantsNoel
Change-Id: I49996ad433409a9189c0f7adc997858e1512f40c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14loplugin:singlevalfieldsNoel
Change-Id: I31107d4e3b3bd175187a8c29a094a4c6acf2a87c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14loplugin:unusedfieldsNoel
Change-Id: I73c49b83f5c1ef17fbff18af675e95d2f2a7b243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14tdf#138851: sc: Add UItestXisco Fauli
Change-Id: Ia3197a3da56d853ba805157af25fceefa461c85e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107677 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-14tdf#129961 cui: start UI for table shadow as direct formatMiklos Vajna
It reads from the doc model and shows it, but doesn't write it back yet. Change-Id: I6611229e71d0a49f09576ca452b901958c33db58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107682 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-14remove unnecessary const qualifier from toStringNoel
in *StringBuffer Change-Id: Ifc1a07b2ab47d6853e3e0a39e74741b2e0b488fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14tdf#115643 make onedrive work again by switching to graph APIChristian Lohmaier
the live SDK method had been deprecated quite a while ago and has been turned off a while back. Notes: While you can access and save existing files using the remote files dialog, creating new files or using "save as" requires using the LibreOffice open/save dialogs. Authentication is clunky: username and password you're asked when creating a new connection is not used at all for connecting, so only fill out a username to label your onedrive entry. Actual authentication is done in browser - copy'n'paste the URL from the dialog into the browser, login and approve access for LibreOffice (approving access only necessary once), then you get redirected to localhost, ignore that there is nothing to display. The important part is the code from the URL-bar. Copy and paste that into the LibreOffice dialog and LO can request an authentication token for API access. Testing this feature requires compiling with corresponding api-keys specified in configure/having an app registered with microsoft. Change-Id: I2db11ac09f9fdc354a10d6c749b2bec84b5d34a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107646 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-12-14The workaround for MSVC C4702 is still neededStephan Bergmann
...see e.g. <https://ci.libreoffice.org//job/lo_tb_master_win/29063/> > C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win\svtools\source\misc\acceleratorexecute.cxx(213) : error C2220: the following warning is treated as an error > C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win\svtools\source\misc\acceleratorexecute.cxx(213) : warning C4702: unreachable code This partially reverts 5c082fc1b59022252d90423afde174123976cdee "remove some MSVC -wd". Change-Id: I24bc9e1b1d93cecc6d79346e6112411b1fa5989f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107676 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Add empty OUStringBuffer::toString testStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/c/core/+/107643> "Don't crash on an empty OUStringBuffer::toString" Change-Id: I144f0814f585f56df3fcdc818fd8c5e18ad08115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14Silence MSVC warning C4189 "local variable is initialized but not referenced"Stephan Bergmann
Change-Id: I346cf6cf148cd3b4ac851f8c441d54c858f55935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107674 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-14tdf#82802 sw page-style UI: remove pointless makeConditional CBJustin Luth
There is no point in having a tick-box to enable the bottom panel. If anyone assigns anything, then the style automatically becomes a conditional style, and reverts back when all are removed, regardless of the status of that checkbox. So it was just a UI element - probably a remnant of a long-ago design that was phased out. Change-Id: I318f7d8061a938c24c97d5b718f3d328e66f8ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107162 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-14tdf#138662 improve dialog box feedback for invalid Calc sheet namesSeth Chaiklin
Change-Id: I4851f76c1868c71b8c3fb527a5bfd85ce5cf8fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107382 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-14tdf#138621 Hide the .uno:TemplateManager from customizationSeth Chaiklin
Change-Id: I3c166a8e18f94d62562599a5218d302a1833d2ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107490 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-14loplugin:unusedmethodsNoel
Change-Id: I442d99e8f6a7df11dc950c5073f683bffc41a852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14sw: prefix members of SwXMLBlockListContext, SwXMLTextBlockBodyContext, ...Miklos Vajna
... SwXMLTextBlockDocumentContext and SwXMLTextBlockExport See tdf#94879 for motivation. Change-Id: I18eeb2ef5905a1117d5915d403278cfa66dfcc20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107671 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-14tdf#138874 restore sort on first column of paths treeviewCaolán McNamara
Change-Id: I7cd831de30523a61631be5cc2f1f3b8a001d9e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14loplugin:unnecessaryvirtualNoel
Change-Id: Ie083afe2763b21e0abada228e4007b9b387c2d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107660 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-14remove some MSVC -wdNoel Grandin
which appear to no longer be necessary on master with our updated MSVC requirements. Change-Id: I55a0267bfc5e2c36d9da7b9b7281b54e9f770f01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-30 14:15:16 +0000