summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-24Fix AccessibleStateSetHelper::containsAllArkadiy Illarionov
Check if all states of the given state set are members of this object's state set. Previously it checked only last state. Change-Id: I79ffe54a5783aa1c3574bd099d2ea4bdc49a5c2d Reviewed-on: https://gerrit.libreoffice.org/74608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelps on Base - Tools menu page Change-Id: Ide88567847c84f011a98b27c26924d2af6a720c3 Reviewed-on: https://gerrit.libreoffice.org/74606 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-06-24Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelp hid on Math Symbol selector page Change-Id: Ida7cb6349249823ff729862b7ca899dfe8bc9144 Reviewed-on: https://gerrit.libreoffice.org/74578 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-06-24Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelp and missing bookmark on Insert OLE page Change-Id: Ia3c6900b1616266dc38cbba4fc74b461b33462f6 Reviewed-on: https://gerrit.libreoffice.org/74577 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-06-24Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Update Base - Oracle connection page Ahelp and bookmark fixes, also adapt to current UI Change-Id: I278b1df6168515c06e034f8528778c257b892127 Reviewed-on: https://gerrit.libreoffice.org/74576 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-06-24Qt5 don't assert broken height or widthJan-Marek Glogowski
At least maths element docking window has a floating height of zero. So the original gtk comment about broken values is still true. And the initial SalFrameGeometry is ok, so no need to initialize it. And set default size and position on show, if not explicitly set. Change-Id: Ibe4969a164b50b666745ce010f5100af4b3ff2f6 Reviewed-on: https://gerrit.libreoffice.org/74614 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-23Resolves: tdf#125168 label mnemonic appearing in database urlCaolán McNamara
Change-Id: I39531ae2a656c16c7355d73b76cb918d3535f7b0 Reviewed-on: https://gerrit.libreoffice.org/74602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I1586aa67c51a54e5a244126763be0a549a2fe7a6 Reviewed-on: https://gerrit.libreoffice.org/73135 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-23Seprator is positioned correctly in view->userInterfaceSumit Chauhan
It is used differentiate between normal interfaces and notebookbar interfaces in view -> user interface. Change-Id: I691e7a767c1984dfa4bd7e064adf2f24e1381991 Reviewed-on: https://gerrit.libreoffice.org/74446 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-23Use in-class member initializersJens Carl
Don't use a default ctor that only initializes data members, but rather in-class member initializers. Follow CppCoreGuidelines rule C.45 (see https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-default). Change-Id: I52d26fa0393f7e383beb95456dd016aa0e84b777 Reviewed-on: https://gerrit.libreoffice.org/74589 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-23Also treat negative DIBInfoHeader::nX/YPelsPerMeter as an errorStephan Bergmann
According to <https://docs.microsoft.com/en-us/previous-versions/dd183376(v=vs.85)> "BITMAPINFOHEADER structure", all of the biWidth, biHeight, biXPelsPerMeter, and biYPelsPerMeter members are of signed type LONG, but only for biHeight negative values are documented as meaningful. As this code already rejecte negative values for biHeight, do so also for biXPelsPerMeter and biYPelsPerMeter. Otherwise, `--convert-to pdf caolan/id:000164,src:000000,op:havoc,rep:8.bmp` (from the crashtestdata files) would fail with > vcl/source/filter/jpeg/jpegc.cxx:404:23: runtime error: -12.549 is outside the range of representable values of type 'unsigned short' > #0 in WriteJPEG(JPEGWriter*, void*, long, long, basegfx::B2DVector const&, bool, long, long, com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const&) at vcl/source/filter/jpeg/jpegc.cxx:404:23 > #1 in JPEGWriter::Write(Graphic const&) at vcl/source/filter/jpeg/JpegWriter.cxx:240:16 > #2 in ExportJPEG(SvStream&, Graphic const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const*, bool*) at vcl/source/filter/jpeg/jpeg.cxx:69:32 > #3 in GraphicFilter::ExportGraphic(Graphic const&, rtl::OUString const&, SvStream&, unsigned short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const*) at vcl/source/filter/graphicfilter.cxx:2042:22 [...] because the (maliciously crafted?) bmp file has a negative nYPelsPerMeter that translates into a negative rPPI.getY(). Change-Id: Id6dddd86d7111ae1a644337288e9f1023cb47670 Reviewed-on: https://gerrit.libreoffice.org/74582 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-23tdf#125803 deactivate the menu regardless of menu item typeCaolán McNamara
spacebar will toggle radios and checkbuttons without automatically closing the menu. To handle this properly I imagine we need to set groups for the radiobuttons so the others visually untoggle when the active one is togged and we would further need to teach vcl that the state can change more than once. so simpler to just dropdown the menus no matter what type was activated, which won't happen in the unity case, but that's presumably mostly gone by now(?) Change-Id: I2ba841dd192c1461ef26d8395ba572843f4c5c4f Reviewed-on: https://gerrit.libreoffice.org/74580 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Fix typoAndrea Gelmini
Change-Id: Ie4a0e69b78f671f9990f9c750e5ecb63447efe2b Reviewed-on: https://gerrit.libreoffice.org/74599 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: Ib405a8287833f596aa90ae6496b748bf8d45f3c3 Reviewed-on: https://gerrit.libreoffice.org/74601 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Resolves: tdf#126039 erase old content before drawing new contentCaolán McNamara
Change-Id: I0006467f5c172b6a0cb8b9bc4c9a0181fd57a8ac Reviewed-on: https://gerrit.libreoffice.org/74583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I30d3a4e7c30dcd1717663f152221f81769b08459 Reviewed-on: https://gerrit.libreoffice.org/74597 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I5cfe3c3157b60ebd71989d1ca105283392c03fc0 Reviewed-on: https://gerrit.libreoffice.org/74313 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: Ib555f767f4d0c6f9b958b3aaf9a496bf8c31de5e Reviewed-on: https://gerrit.libreoffice.org/74319 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typosAndrea Gelmini
Change-Id: Id805595850125de5d791f016649b660a7fedba8a Reviewed-on: https://gerrit.libreoffice.org/73779 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typosAndrea Gelmini
Change-Id: If81c6224abbd0028bcc446159cf12436e89325d8 Reviewed-on: https://gerrit.libreoffice.org/73421 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: If1f6d73088e87db6e91916ba338725054f63b5ac Reviewed-on: https://gerrit.libreoffice.org/73231 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I528581c5a17e804f7ba39a069e7bb8ac8d005adc Reviewed-on: https://gerrit.libreoffice.org/73223 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I3a4b8aad30f4d8bcfda472ddfd151410db21a5b1 Reviewed-on: https://gerrit.libreoffice.org/74551 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I580bfda7af2f29484817d8e88ba74cb3c43a98fd Reviewed-on: https://gerrit.libreoffice.org/74560 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I357c004e724ebe580a121bf7ecdc63da9c02343f Reviewed-on: https://gerrit.libreoffice.org/74593 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I7e6be2abe50487df7da5486ad9b98aabc67b1caa Reviewed-on: https://gerrit.libreoffice.org/74592 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23Fix typoAndrea Gelmini
Change-Id: I126a490e40d5954f290200edaa377427f59f244a Reviewed-on: https://gerrit.libreoffice.org/74596 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-23editeng/XParaPortionList: OutputDevice's MapModeAdrien Ollier
Change-Id: I77098fd15e131711e4f2a7ef4f21bd1dd8d68768 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/72307 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-23tdf#39593 Remove dbaccess::OContentHelper::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I533bfcd3959037a2621eb3fd42bf7172b5396c5f Reviewed-on: https://gerrit.libreoffice.org/74539 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-23tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTabViewObj. Change-Id: Ic3364f405e4e4c42443a7f439a257ed6328f32a8 Reviewed-on: https://gerrit.libreoffice.org/74586 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-22elementary & KJ Updaterizmut
elementary - Update chart diagram - Update 3D tilt,3D depth, 3D light& brightness - Update cell/table border & border properties - Add Impress transition illustration Karasa Jaga - Update border properties Change-Id: Ia75705c0d5cfb2081958772bed566f0ee7a3a787 Reviewed-on: https://gerrit.libreoffice.org/74569 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-22tdf#45904 Correct mishap with removed converted testsJens Carl
Deleted the wrong test and also forgot to remove a test with commit 0e73f9eb4157. Change-Id: I31257908e935b2130c46436e8d5425bc058b21c5 Reviewed-on: https://gerrit.libreoffice.org/74484 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-22Related: tdf#126036 give options dialog consistent button orderCaolán McNamara
its not welded yet, but skip ahead and give it explicit consistent button order in the meantime Change-Id: Ia850a024cb5a87b9231b5ffdec701646d7014e08 Reviewed-on: https://gerrit.libreoffice.org/74573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22Resolves; ofz#15426 Integer-overflowCaolán McNamara
Change-Id: I43ac26058a98a85fc09321a93e29dbeb151f5069 Reviewed-on: https://gerrit.libreoffice.org/74572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22Qt5 directly show tooltips + respect the help areaJan-Marek Glogowski
I'm not sure why this redirection was implemented, which also ommited the provided help area. I tried hard to use vc::Window code in the beginning, but that also mirrors the cursor position for the window. Using Qt here is simply straight forward, so just do that, Change-Id: Ia8c4efc1e43b915c4b071ee26d4da37d7580817c Reviewed-on: https://gerrit.libreoffice.org/74548 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-22Related: tdf#126036 sort button by native order for async dialogs tooCaolán McNamara
Change-Id: Iddc689b8d332e8e0127806c37b5ccce66eadfcf6 Reviewed-on: https://gerrit.libreoffice.org/74540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22Related: tdf#126036 missing "reset" buttonCaolán McNamara
removing 'standard' should not also hide 'reset' Change-Id: I0c12ea16c378a225052468d01e0f1a99a6d59846 Reviewed-on: https://gerrit.libreoffice.org/74536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22VCL don't mirror Y positionJan-Marek Glogowski
I don't know why Y values should be affected by mirroring at all. This produced a lot of negative Y values for me. Change-Id: I2b147ede948510a7bc1a5838cf89a8fd02e2ed46 Reviewed-on: https://gerrit.libreoffice.org/74547 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-22tdf#123779 Qt5 correctly fill Qt5Frame::maGeometryJan-Marek Glogowski
The tooltip in the bug is actually not one, but the VCL implementation of Gtk's popover widget triggered by SalFrame::ShowPopover. This has no Qt equivalent, so we currently rely on the crude VCL version. But for this maGeometry must contain the correct information, AKA the absolute, unmirrored, paintable system geometry of the frame. Then the window can be positioned correctly. The patch gets rid of most of the code initially copied from gtk, when this VCL backend was in a very early state. Change-Id: Id44e4dc2aac41f1f01d51c4d8107892e644ef243 Reviewed-on: https://gerrit.libreoffice.org/74546 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-22Qt5 fix some broken RTL handlingJan-Marek Glogowski
For RTL decisions we always use Qt's own setting after setting it on startup using QGuiApplication::setLayoutDirection. The only difference between LO and Qt events is the mirrored cursor position, which needs explicit mirroring before reporting mouse based events (mouse and wheel). Tooltips and frame positioning will be handled in separate patches. Additionally the horizontal scroll bar direction hack based on the scroll bar button positions, needs to handle RTL explicitly. Change-Id: I5ce5e69113a6cb6a9cf37a449265c49d92a7c159 Reviewed-on: https://gerrit.libreoffice.org/74545 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-22tdf#125670 check graphics before output cliprectJan-Marek Glogowski
Brown paperbag fix. Caolan and me were so concerned about performance that we actually forgot about the intention of the original fix to ensure a valid graphics before checking the output clip rect, so in the end we re-introduced the bug. This basically reverts commit aeead1782ff1 ("Related: tdf#125670 avoid possible performance issues for the general case"). The output clip rect is not needed for the metafile, as it is ignored. Change-Id: I68f4367cc3afbd659f691999b675a81a21258106 Reviewed-on: https://gerrit.libreoffice.org/74550 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-22Fix typoAndrea Gelmini
Change-Id: Icf137874b218c0123c3e8bcf4759543f97830ddd Reviewed-on: https://gerrit.libreoffice.org/74556 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-22Fix typoAndrea Gelmini
Change-Id: Ia487ac5af064184d3e7c598e2edcee80b949a857 Reviewed-on: https://gerrit.libreoffice.org/74558 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-22Fix typoAndrea Gelmini
Change-Id: Ic1ea1e5d0fbea39c99845817c1646865d6ccd53e Reviewed-on: https://gerrit.libreoffice.org/74553 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-22Fix typoAndrea Gelmini
Change-Id: I7d977cd56a8bb820a62718ea548c34f2c26b4db7 Reviewed-on: https://gerrit.libreoffice.org/74552 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-22VCL move comment to the right functionJan-Marek Glogowski
Regression from commit da8aa9385153 ("VCL: Reorganize and rename wallpaper functions"). Change-Id: I6a992c98c4e5657848ebbca946d5eddca4aa7161 Reviewed-on: https://gerrit.libreoffice.org/74549 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-21tdf#125362 Update tab dialog example set after ApplyJim Raykowski
Change-Id: I0f6ad5273b285080bf2bc55fca3a2365b5b42bbf Reviewed-on: https://gerrit.libreoffice.org/74325 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-06-21reference childwins are all weldedCaolán McNamara
Change-Id: I050b4bdff4eaa645316538725c69e83bee4a90c5 Reviewed-on: https://gerrit.libreoffice.org/74526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21remove newly unused ModelessDialogCaolán McNamara
Change-Id: Ieb629c21d725104a79515fe12e448b2b3eaddd94 Reviewed-on: https://gerrit.libreoffice.org/74121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21remove newly unused SfxModelessDialogCaolán McNamara
Change-Id: I298a96bd3f45d10a92e5f2a853fc4e7a4c52228b Reviewed-on: https://gerrit.libreoffice.org/74120 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-30 02:23:06 +0000