summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-08Fix typoAndrea Gelmini
Change-Id: Ib6c49ad6f8ec29e5ef49a46d4352fd58b182f75a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98296 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-08loplugin:redundantstatic (extensions/updatecheck(config|job))Julien Nabet
Change-Id: Icf0769ab24c8a7c470b1fdf6363204d004c51fb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98297 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-08uui: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I8b7eec5e2cbe61a8dc3bb65f391245c1825fedc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98235 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07lok: symbolic link to the "include" directory when builddir != srcdirHenry Castro
When compiling the android variant build in a different build output directory of the "online" project, it fails due to the missing "include" files. Change-Id: If9056788b3d043e4ae8ad3f799885995c0ab0cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95603 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98269 Tested-by: Jenkins
2020-07-07tdf#100772 sd: add uno:DeleteTable to non-NB menusJustin Luth
Delete Row and Delete Column were there, but no option to delete table, so that major omission was fixed for Draw and Impress. The notebookbar looks very incomplete. Also, I didn't really understand the pop-out menu configuration, and at least in the one case there didn't seem to be a good space to add delete table. So I left the notebookbar completely alone. Change-Id: I5d6c98e3238bc545a02325edfd62f5d937ac6371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97821 Tested-by: Jenkins Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-07-07framework: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I8679b50395d11cb2d807d52526d803df9b0606b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98294 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07formula: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I5983c837977e40b91df02605c1012640ffd5c650 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07android: fix the build output directoryHenry Castro
When compiling in a different build output directory, the "liblo-native-code.so" file is created in the source directory and it fails compiling the "online" project Change-Id: I4782a69796fb298e9c1a6c4370720b18587735e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98290 Tested-by: Jenkins
2020-07-07Fix typoAndrea Gelmini
Change-Id: I7c3e2c4c129c5ff7e3c8e5f3ac94e57508ce39ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97891 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-07tdf#134603 [en|dis]able logic reversedCaolán McNamara
Change-Id: I192b7a6da4bcd311e64a31d9dc2b4c2b422194cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-07ofz#23961 pad back to original lengthCaolán McNamara
in case of multi-byte input encoding resulting in a shorter output string than input Change-Id: Ieb4bb7b5f4551ca22e87c573233f083901f3d3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-07vcl/clipboard: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I8b50ccb014adeba8fa5084bcb804dfa61fa61159 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98265 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07no need to use prefix hereNoel Grandin
all these services use a constructor Change-Id: I8e8e2df27a919e9042a041e1134add8492b3e72f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07configure: try to fail early if qt5 header QtCore/qconfig-32.h missingMichael Stahl
Unfortunately configure passes successfully if qt5-qtbase-devel-*.x86_64 is installed but the host cpu is i686. Change-Id: Ib155d6f91676c12a480eed2f0d4d38c05377e909 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98240 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-07tdf#129452 writerfilter: preserve gridBefore longer than currentRowJustin Luth
It is a fairly common thing for table operations to need to compare items in the same column (like merged cells for example). In order to determine column information, each row's gridBefore (and merged cells) need to be known. So save that information in the row data - and don't just throw it away after the current row has been analyzed. Good grief. Change-Id: Ie305477f0e3468a4a923095d76f520d97fe99ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97432 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-07embedserv: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I5f912ee625a37f64f9d9c35ccb13f995a56685c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07make some symbols privateNoel Grandin
Change-Id: I224831ad18e754fd67d9b16510cd286a5397f1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07Removed duplicated includesAndrea Gelmini
Change-Id: I5c93b8ae1db219cfea3266a15d502747e8709fa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97890 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-07-07Typo: pargraph->paragraphJulien Nabet
Change-Id: I7749951d829eb8aaeacdca0fd66d41cf9d6a1613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98251 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-07Allow making SAL_LOG based output fatalJan-Marek Glogowski
This introduces the [+-]FATAL marker for SAL_LOG. This way you can set part of the matching SAL_LOG string to std::abort on match. The example "SAL_LOG=+FATAL+WARN.vcl.scheduler-FATAL+INFO" will abort for any "+WARN.vcl.scheduler" match, but will just print all additional "+INFO" logs. Change-Id: Ib77f194a78f5165e6c885c82374ae41293815ee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97651 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-07gla11y: improve warning printingSamuel Thibault
Also print the howto URL in messages about suppressed warnings When showing suppression lines, also print the suppression file name. Change-Id: I72da4149c505cec04bf715791f45a2b809d3ce63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97989 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-07gla11y: Document global variablesSamuel Thibault
Change-Id: Ic8ed50bdff182bab1104b5a22e667aadfd25c684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97982 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-07tdf#134260: docx import: allow default value for list tab positionVasily Melenchuk
It looks like previously used as a testcase document is just a specific case with default values. All other readers (incl. Office 365) displaying that doc with default tab at zero position. Change-Id: I50fe00c7f87b6d790fbe6e2f32a306ac59060c72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97089 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-07Removed duplicated includeAndrea Gelmini
Change-Id: I33b3a56d9727dea2cbafcfbf73f5d4c08069ba34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98030 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-07Fix typoAndrea Gelmini
Change-Id: Ib6aa24401db9cd39b314800f4fb5e4443aeec198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98249 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-07Use std::optional to allow optional inclusion of attributesMike Kaganski
... instead of converting the O(U)String objects to char*. Eventually this could allow to drop variants of *Element that take XFastAttributeListRef. Change-Id: Ib2748fcd93e655c55a176c00410fdcc7f052930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-07drawinglayer: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I38de5ec7b9e376ef8868bebbe7f30240de81c241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98219 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07ScGridWindow::UpdateEditViewPos: keep EditView's print-twips data updatedDennis Francis
Change-Id: I2f6fab371a107a4f16704030e341198a541020f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98127 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::EditGrowY: keep EditView's print-twips data updatedDennis Francis
Change-Id: I0207e65fc0386eb9a86de6ab4472780553eadd4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98126 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::EditGrowX: keep EditView's print-twips data updatedDennis Francis
Change-Id: Ia2470f98954859b191432d68db5742d13a61c802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98125 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::SetEditEngine: keep EditView's print-twips data updatedDennis Francis
whenever EditView::SetOutputArea() and EditView::SetVisArea() are called. Change-Id: I90a840b85d01d27427fbaa1101148ce1efb55db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98124 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07scPrintTwipsMsgs: No more view specific edit-cursor messagesDennis Francis
Change-Id: I2a07834568716ea1608a40613108d229699058b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98123 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07set also RGB/BGR LCD order for Skia text rendering (tdf#134275)Luboš Luňák
Change-Id: I797a851f52d9ba4c18127219b9042348225d14dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98199 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-07Allow edit-area computation in print-twips...Dennis Francis
via a optional flag bInPrintTwips (false by default) in ScViewData::GetEditArea() Change-Id: I9bf7465b703a2df817fe438db3671261d0d907a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98122 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07xmlhelp: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Id05885b9da95009609cf8875be489aa88fd5a3cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07vcl: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I7f03e024eef5413d84d98f3fa9bd45ecaf413a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-07tdf#87783 Unify image wrap option labels wordingGabor Kelemen
In Image properties dialog - Wrap tab, and UNO commands Change-Id: I420884a5df3373e74e14bba48bff75555ae7f5ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94762 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-07let browsebox entry stretch to fit allocated spaceCaolán McNamara
Change-Id: I7b09fd8cebed503c86b3df131eb2d7b1a07ef21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-07tdf#134264 writerfilter: fix DOCX->DOC of ADDRESSBLOCK fieldMichael Stahl
... and other unsupported ones; the problem was that the field got exported with ww::eUNKNOWN = 1, which can't be imported again. Move the ww8 eField enum to include/ so it can be used from writerfilter. (regression from e511a0ca5dde6d731bb126bbfe21768867890102..d9030ad6298e2f49ee63489d6158ea6ad23c0111) Change-Id: I19193392d62fdf0bba01fac2516bafe9fdfa5a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98221 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-07tdf#134146 Chart OOXML import: break long horizontal Y axis titleTünde Tóth
Workaround to handle long (near) horizontal Y axis titles, like MSO does. See commit 17f131fcb3f534792a3b2ec6048d03fb54b55eb1 (tdf#134235 Chart OOXML import: fix long chart title). Change-Id: I215aaa8e2ca18920e2b7ca5761c5bed7e8d19663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97631 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-07lokit: editeng: Use 'special-positioning' data...Dennis Francis
for computing edit-cursor messages if available. For Calc, this means the LOK clients get edit-cursor coordinates in print-twips. Change-Id: Ib11f3653e626ba8db7ddbc9bc2b4e071de7b705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98121 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07jsdialog: export combobox entriesSzymon Kłos
Change-Id: Ic0a3c93020c7c915fd908fe994ec0a3a900358eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97625 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97862 Tested-by: Jenkins
2020-07-07tdf#134472 Only add spacing in header when flag is setSamuel Mehrbrodt
Flag was set, but not evaluated in 9b5805d1ef2b9e9c4e8f389c069807bf4489ea95 Change-Id: I46f19945be521e886baa0fc9a9a419d88c0915fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98224 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-07-07Introduce LOK 'special positioning' methods to EditViewDennis Francis
This is meant for Calc. In Calc, all positions in twips are computed by doing independent pixel-alignment for each cell's size. To allow print-twips coordinates in LOK messages specific to EditView, this patch introduces new methods to set/update both 'output-area' and 'visible-doc-position' in print twips coordinates, which are stored separately. Change-Id: Id165966c970fa26c79d583f435dccd62c7eb1f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98120 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07introduce property-tree versions of SfxLokHelper::notifyOtherView*()Dennis Francis
Change-Id: I4ebbc166da94eab6e35984c50220dde7daf7adde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98119 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07tdf#133600 Only one button selected by default in QR code dialogGabor Kelemen
Change-Id: I10a5f04492cf23caeb89cb119f91c578e5d57413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95540 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-06tdf#134253: sw: Add unittestXisco Fauli
Change-Id: Icd930f9c632a5c44d4391ca065afbc4db166ae37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98200 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-06emfio: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I1685fe05a2a6b1761e78359596c265ac6487f99b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98217 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-06move headers inside modulesNoel Grandin
Change-Id: I002f42d83820c86737ddceab805aa53ccb388e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-06Resolves: tdf#134551 ModulWindow deleted when last module removedCaolán McNamara
leaving a dangling reference to m_aName. Hold a reference until ExecuteCommand is finished. Change-Id: I82ac5cc73427a945c78b9317dee9edf6129bb975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>