summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-09desktop: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Id332d79c29c8e5f668663070d83aba596f017908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09tdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-09framework: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Ia2d9447b687f0792d9d3a98d30cd2b8fe54049ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98388 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09jsdialog: export cursor visibility for text areasSzymon Kłos
Change-Id: I404e496a6f68f5cc2e2e628b51c759be49c7fecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97729 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98231 Tested-by: Jenkins
2020-07-09clean up macro usageNoel Grandin
Change-Id: I06669718f692cc5e9e209b4e490365f4f016afdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08tdf#134606 DOCX table import: fix gridBefore + nestingLászló Németh
Nested tables in a table row with gridBefore could result of broken outer table, if the row doesn't contain text before the nested table, resulting invalid TextRange for insertion of gridBefore cells. Regression from commit 70274f86cdc1c023ffdd0130c262c1479262d76b (tdf#116194 DOCX import: fix missing tables with w:gridBefore) Change-Id: I6bb3948b6522d8785a1ea0ccf8d7c7f3c2bde189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98320 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-08Resolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-08Fix typoAndrea Gelmini
Change-Id: I2a5a231d7e58c3a84651c70cdf561c81b56a651a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98250 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-08query if the cursor can be moved up or downCaolán McNamara
Change-Id: I47c09ff5f76c873cf30e608a134f90b42040a0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08expand to cover subwidgetsCaolán McNamara
Change-Id: Ib0765e6a38c6dc6cdb32eefc013b432f3cf36db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08tdf#134264: sw: Add unittestXisco Fauli
Change-Id: I373b2549a067452056f649213c32d5983212580c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98378 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-08framework: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I6237016000dc05eacb14e59815b53cd44fbfce0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08lok: set to export PDF bookmarks by default when save-as a PDFTomaž Vajngerl
Change-Id: Ieb182b9a0d1f18a29a83ce369881578c06e217ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-08pdf: add PDFiumPathSegment to the wrapper & use in ImpSdrPdfImportTomaž Vajngerl
A PageObject of type FPDF_PAGEOBJ_PATH can have a path segment, that is common in vector graphic objects. The path segment is wrapped into PDFiumPathSegment which can be used to handle the path and path properties. Change-Id: I990d51ba90fa356a6eca137eb4b71947858289aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98210 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-08svmtest shouldn't compare rendering against itselfLuboš Luňák
Change-Id: I426187abfd4e5e2596f9680aff14fc1e370a18ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98383 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-08avmedia/win: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I3a4afa5e583ad5b6339d4cf0036e1dc562274864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98379 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08unoxml: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I636d92faa3b26ac06c044c0485e632967daa709c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08dbaccess: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Ib03014444d8176417cbd00b56764ee45fdad557c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08svgio: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Iad7a6435482596dd3e955d3323aaf3d5e6984517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08improve weld::Widget::draw rendering a widgetCaolán McNamara
Change-Id: I1f49e3e7829f41d7eb4ffc137a9b0ab5c47d2cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08SAL_WARN->SAL_INFO to prevent spamming the unit test logsNoel Grandin
Change-Id: I0c4f530f86e1e20f7fc42a1dff4499cc57c45bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08drop WB_BORDER if the border style is invisibleCaolán McNamara
Change-Id: Ie88818cb2b61d411f868f748d6a7c2fdf8028e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08prepareWidgetOwnScrolling already set WB_BORDERCaolán McNamara
the pRealParent != pParent case already caused WB_BORDER to be set in prepareWidgetOwnScrolling Change-Id: Id33d9f8d10b8076a26b31e2dcdc70e3419bba5be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98376 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08scPrintTwipsMsgs: Use print-twips paper-sizeDennis Francis
Paper size for the EditEngine is calculated based on per-cell pixel alignment. So lets use the exact print-twips version whenever we need it to compute/adjust output-area and visible-area of EditView. Change-Id: I7da6db9363d09965315ff5ca9d01f0fea141a533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98130 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-08svx: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: If6bd80525d398b45c2938e921c183633f173dfae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08tdf#129452 writerfilter: preserve gridSpans longer than currentRowJustin Luth
It is a fairly common thing for table operations to compare items in the same column (like merged cells for example). In order to determine column information, each row's (gridBefore - change-id Ie305477f0e3468a4a923095d76f520d97fe99ffe - and) merged cells need to be known. So save that information in the cell data - and don't just throw it away after the current row has been analyzed. Good grief. Change-Id: Ibfdac336bbb1f7303c7e585a85c94be37ad6f916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97433 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-08uitest : Add demo for Calc-commentsAhmed ElShreif
This patch test the support that added to this patch: https://gerrit.libreoffice.org/c/core/+/96837 Change-Id: If7444813f65bd90d62d0eb3504dcfc588c3f4e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97074 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08uitest : Add support to Calc - commentsAhmed ElShreif
This patch has the implementation of the support for Calc comments . Now you can use these lines to use comments in calc: * Open Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"OPEN":""})) * Then Type text as normal : >> gridwin.executeAction("TYPE",mkPropertyValues({"TEXT":"any"})) * Close Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"CLOSE":""})) * Write Comment without opening comment window: >> gridwin.executeAction("COMMENT",mkPropertyValues({"SETTEXT":"any"})) You can also check the comment text by this line: >> get_state_as_dict(gridwind)["CurrentCellCommentText"] I will provide a test case in another patch. Change-Id: Ie3fc4efffb07827e742bdaa99dd5147c8b9711d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96837 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08Avoid "ECHO is off." output when requested variable consists of spacesMike Kaganski
Change-Id: I41e298ee3ea8d6c1cd249e8ee5f0ced997255ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98369 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-08fix fuzzer buildCaolán McNamara
Change-Id: I1c96d177ddf6061e61f4027675e657c2d7fd446e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08tdf#134260: sw: Add unittestXisco Fauli
Change-Id: I719dac8528453b00219c5bdc621f7ce88cd40bde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98318 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-08Fixing top border style by fixing three XSLT issues triggered by...Svante Schubert
... new properties in ODF 1.3 * check for fo:border='none' * missing @ in @fo:background-color * without default case (xsl:otherwise), end delimiter for "page" missing in CSS Change-Id: Ie5d0c3e8a32de0403534c5a4fa33a5f20393ce69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98365 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-08configure: try to fix qconfig.h checkMichael Stahl
Change-Id: Ie88d36d2f00c920a2d2a3e8fc6a84fdca4552b86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98314 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-07-08tdf#134567 Show all properties in DPSShivam Kumar Singh
Change-Id: If2238a80fbc9fc803fc5e12904964bf4289ba2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98310 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-08tdf#134568 Omit Default Character StylesShivam Kumar Singh
Change-Id: Id3cdcb609c9edf3b3ed7a13d0d64a392479f81f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98311 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-08distinguish between dialog screenshoting and rendering a widgetCaolán McNamara
Change-Id: I43ee0c68d72c97a15d26e2ffea577c2a44ba91e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08use gdk_wayland_window_set_application_id when it becomes availableCaolán McNamara
Change-Id: I60775dcbfbc396f195a71f219668944d0bfecf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98325 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08let spinbutton stretch to fill areaCaolán McNamara
Change-Id: I5411fe7cf49a1c9fdc1d9090347ca82736ba4e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98324 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to de1a815d21e38d3942ce3647ffdabb5544b3636d - fix doubled colon Change-Id: I9bad622b777f2e403e24386f7efb985de72aceb6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98292 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-08Add mobile version of find replace dialogSzymon Kłos
Change-Id: If651f84b97a1ed6b08b9f4eb56ce95fe659cddf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97606 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98229 Tested-by: Jenkins
2020-07-08vs-ide-integration: unescape values coming from DEFSMike Kaganski
... so `TK_DLL_NAME=\"tklo.dll\"` becomes `TK_DLL_NAME="tklo.dll"` Change-Id: I0e14ded85be387a342e1979aa3f120727178351d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98319 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-08SetLOKSpecialOutputArea() call must precede SetOutputArea()Dennis Francis
The ordering matters at the moment (unfortunately), since EditView::SetOutputArea(), after updating the output-area it also sends the LOK messages(cursor/selection) immediately. So we need to update the print-twips version in EditView by calling SetLOKSpecialOutputArea() beforehand to avoid wrong messages. Change-Id: Ibff64ad1a92f332ad726452369ecb2c5b2aaae53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98128 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-08uitest : sw: Add UItest for Hyperlink DialogAhmed ElShreif
This test case tests the Hyperlink Dialog in inserting a Hyperlink . Also it tests the Vertical TabControl Support that added here: https://gerrit.libreoffice.org/c/core/+/98135 Change-Id: Ic7975cc12425dbcba24b0261404585ded006e5e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98160 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08uitest: Add support for vertical TabControl ObjectAhmed ElShreif
We need support for this Object as some dialogs use it like Hyperlink Dialog . So now we can navigate in the dialog in the same way we navigate with the normal TabControl Objects . You can use this lines in your test case that test a dialog that has vertical TabControl Object: >> xtab=HyperlinkDialog.getChild("tabcontrol") >> xtab.executeAction("SELECT", mkPropertyValues({"POS": "0"})) Change-Id: Id1792f5cceb8b08e13cb8c0c5fbaf1ff29f996d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98135 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08tdf#134188 tdf#114223 Don't override vertical text button visibilityMaxim Monastirsky
i.e. restore the fix for tdf#33356, which was removed in commit eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b ("Resolves: tdf#130159 hide writedirection unless CTL is enabled"). But do it in a way that doesn't introduce tdf#114223 (a regression of tdf#33356). We can assume that the visibility state of the button at the point of control initialization is the one set with toolbar customization, as any customization triggers clearing of the whole toolbar, and reconstructing from scratch. Change-Id: I2cdf18e144dd6eb99b8c1e1da968beacddbb3728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98317 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-07-08Avoid nullptr dereferenceSzymon Kłos
Change-Id: I5f2bd8206a1339e09f277cdc7f0c6a01a6d85df7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c9ceaeaee923a742d842fbc6174222eaf9667ca6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98270 Tested-by: Jenkins
2020-07-08tdf#131369: Use 'Match case' instead of 'Case Sensitive'Ayhan Yalçınsoy
Change-Id: Ibb6e99f80e8c5e76ad6f23428256145bb3f8c20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97460 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-08prevent SkiaSalBitmap::Scale() from breaking indexed bitmaps (tdf#134574)Luboš Luňák
Since the actual scaling is done later at some unknown time, the palette mustn't change, but scaling can change colors. Change-Id: Ie254c8b31993d9d509c32a730dd8c8b5d3cb2256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98258 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-08make sure SkiaSalBitmap::dump() doesn't change the objectLuboš Luňák
Now that there's delayed resizing and erasing, saving and restoring the state is getting complicated, so just work on a copy. Change-Id: I4df8cdba24d89e16f58d19516d667ff35e42dea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98255 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-08Fix typoAndrea Gelmini
Change-Id: I91bd071261dfd964a6f7705cf8bb30814ef3a671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98295 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>