summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-05-13createFromAscii -> OUString literals in AnimationsExporterNoel Grandin
Change-Id: I20c35e06fb98df5ffb9d9fd521459e267e4a2fa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-13Use less SdOptionsSnapItem->IsSnapFrame/SetSnapFrameGabor Kelemen
in favor of officecfg Change-Id: Ia9d36f3c2d0f85250da6f3483176c551226164a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167534 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-13Revert "reduce symbol visibility in sw"Thorsten Behrens
This reverts commit 1a6711276f0c8abeb0028a47cc345a7453374a38. After some discussion and experiments, it turned out this rather fundamentally breaks clang's PCH build. Conclusion was: this change is not significant enough to warrant making life harder for developers. Excerpt of errors (affected were vbaswobj, msword & swui libs): - ld.lld: error: undefined symbol: SwFormat::~SwFormat() >>> referenced by fmtcol.hxx:37 (sw/inc/fmtcol.hxx:37) >>> core/workdir/CxxObject/sw/inc/pch/precompiled_vbaswobj.o:(SwFormatColl::~SwFormatColl()) - ld.lld: error: undefined symbol: SwFrameFormat::SetPositionLayoutDir(short) >>> referenced by precompiled_msword.cxx >>> core/workdir/CxxObject/sw/inc/pch/precompiled_msword.o:(vtable for sw::SpzFrameFormat) - ld.lld: error: undefined symbol: SwFrameFormat::SetLayoutDir(SwFrameFormat::tLayoutDir) >>> referenced by precompiled_swui.cxx >>> core/workdir/CxxObject/sw/inc/pch/precompiled_swui.o:(vtable for sw::SpzFrameFormat) Change-Id: I1dcf115cc191b1ebf1f8d5023c0c5015f891287a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167549 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-05-13vcl: Merge ComboBox and ComboBox::ImplMichael Weghorn
This removes one level of indirection. `ComboBox::Impl` had originally been introduced in commit ece8699f8f22f6bae137c601bc29b83b75dc3bf3 Author: Michael Stahl <mstahl@redhat.com> Date: Fri Jul 10 12:05:48 2015 +0200 vcl: pImplify ComboBox The boost::signal stuff is quite heavy (33 kloc), so try to hide it from the header. Change-Id: I87826ccfd2a151aff274ffa6b7159a988f751808 , but all of the boost usage in here has been replaced since then. Change-Id: Ia8fb5cb895800edae104857c7713fa65e509a3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167485 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-13tdf#161023: Empty spans may only define paragraph marks in text documentsMike Kaganski
Change-Id: I40607652a0fd8e31c609732daa54bb796e3fffa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167557 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I6d1ea7e14f5d2a75d485dae69d51cec8c2343445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12Use less SdOptionsSnapItem->IsSnapBorder/SetSnapBorderGabor Kelemen
in favor of officecfg Change-Id: Iaa6801ef773de7d3dcb1f08d4eac4a4f62ac656b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167533 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ica8b3c8c5476f2f0f3bebf0cfcd80b08090c6119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167556 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-12createFromAscii -> OUString literals in attribute_set_map_to_property_valuesNoel Grandin
Change-Id: I98f40cba9baf2a21d095af84a07cd794723cb75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in FilterConfigCacheNoel Grandin
Change-Id: I31a16e4b709955cb01d6aebaf169d40f71f7ea09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167551 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in getImportFormatShortNameNoel Grandin
Change-Id: I3f62ea563af8e2c9aa5ed558370b49f05804c632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12cid#1597307 silence Unchecked return valueCaolán McNamara
and cid#1597304 Unchecked return value cid#1597303 Unchecked return value cid#1597306 Unchecked return value cid#1597305 Unchecked return value Change-Id: I2fa1c467751405d3b69f1d9b552232e4d52b610e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I19824cd8fdc3ac5b5afb4e769527bf71513212fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167553 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12help msvc -analyzer out wrt C6011 Dereferencing NULL pointerCaolán McNamara
Change-Id: Ied22e4ea805ab5a94f89a71438962bdd6d118771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167548 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I7a4df11c23a92d0c5538cea4290dcc5e2c9ac3c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12replace createFromAscii with OUString literals in DefaultFontConfigurationNoel Grandin
Change-Id: I550a9a2c069b43cc8824d3b26736f656393a5afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167546 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in OConfigurationValueContainerNoel Grandin
Change-Id: Ib94018bfc542c91c01894006076eb16023d104ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in INetURLObjectNoel Grandin
Change-Id: Ibad8181624afd745e2fa501cdcc7a5d915dfe6ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in SvxStyleToolBoxControlNoel Grandin
Change-Id: Ibdf5f7b0100cafbecc263a038b2234012da10fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12help msvc -analyzer out wrt SkASSERTCaolán McNamara
Change-Id: I32387c80273d0bc080e47a1d9ccf7454a4a3d79a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ieabea4a0ddf8f95ea01b8b0275be0924ad055694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I83952aef1fd44d2b49cbaa2324283c14c83723de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167522 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12add noreturn to boost::spirit::throw_Caolán McNamara
Change-Id: Iac1d998a408d756f50f7c18944f4e1f8afef2e83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167523 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12extend comment on parallel group calculation a titchCaolán McNamara
Change-Id: I3cdb757d1959af17b74a8b973010a8d0f477cfe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12jsdialog: enable Object Name and Description dialogSzymon Kłos
and send uno command enable/disable status Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id643a27308809b6960be72fb368b9f078ff9cf6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167296 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167521 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12Use less SdOptionsSnapItem->IsSnapHelplines/SetSnapHelplinesGabor Kelemen
in favor of officecfg Change-Id: I3f9d62380449c888b47020b4ffc765e9e8aa36ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167532 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-12replace createFromAscii with OUString literals in SvxSearchItemNoel Grandin
Change-Id: Ie1dc68bd5c5550718103f9ecbbb2fa707c950ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I487828fd11e1b22da2cc651b413f0744bf43b6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I2fddf8ae5803041344fe63c4375fe5a3ee46fed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-12WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I85aa6c2f100823d1d39e24ab3ffcb0c44f66354e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167519 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in EnhancedCustomShapeTypeNamesNoel Grandin
Change-Id: I69b89d7ee86c1d0b2dbdc4553cc12c01bdd76d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167530 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in ScIconSetFormatNoel Grandin
Change-Id: I5af0128c55608bf6192af4dc46f9476393a15afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167528 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in ScXMLEditAttributeMapNoel Grandin
Change-Id: I7ab70713b2ee69eccedebeb09b8ea5879736a830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167527 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-12Related: tdf#96671 Also handle other Windows architecturesMike Kaganski
Change-Id: I8b3a9c10781450083ae2cdeb8614b42e33bf9520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167531 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-12Drop some uses of css::uno::Sequence::getConstArrayMike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I64683093afc48ddf2307dc1dee2302cf0b3cbecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167110 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I6029cd4c894c6ab079cc508ba15df41ec5d4f8db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167516 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ImageManagerImplNoel Grandin
Change-Id: I995f3f565c01ba85ae470c506facb1f6e5d517a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167515 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11Drop now unused SdOptionsZoom classGabor Kelemen
Change-Id: I73100a18f9edb37bb93b7612e7e34fdf510a5308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166630 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-05-11WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I95441e62c33bdc5c22dad2fc25a072d9ce93e4d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-11WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ic703c92165ba7f0a43d25bb2899b6455e2e2f312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167513 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-11replace createFromAscii with OUString literals in ControlFeatureInterceptionNoel Grandin
Change-Id: If0fbaafbaa318ec541341fde723f92f3e8e92cfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167510 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in OpenDocumentButtonNoel Grandin
Change-Id: I989f5f82fe65e0f877d86b7eb98ba8ad57147988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in SbaTableQueryBrowserNoel Grandin
Change-Id: Ic822faea02d1d598e7b5deb846a88ae59994535d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11tdf#96671 - Correctly detect windows 64-bit OSkubak
Adds detection: - Windows X86_64, - Windows X86_32 - WoW64 (Windows 32 on Windows 64). Change-Id: Ic40ec8bdfb206a7ad3045edf7ecef3cb97cc08f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167144 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-11tdf#132599 sw: fix unit tests for hyphenation-keep with framesLászló Németh
Fix en_US language of the test documents to be consistent with the hyphenator condition in the related unit tests of commit d4304cd0a4fedd0117fea3625dff1fca2945a0e6 "tdf132599 sw: fix hyphenation-keep for linked frames, also for spreads". The problem was reported by René Engelhard. Change-Id: Iee7fd83aea294fb32c5f358cd25a1d1cb9a76d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167512 Reviewed-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org>
2024-05-11replace createFromAscii with OUString literals in CommandImageResolverNoel Grandin
Change-Id: I668062d2e6e220be16e3aa74b01db281d54876ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in ReadThroughComponentNoel Grandin
Change-Id: Ic92b15ea369e420faf6bfc40f509bba6e454710f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11workaround clang segfault on macos-intelNoel Grandin
Change-Id: Icfced4a990e2d02995bff4078f14b8ee26e9cca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11cid#1597279 Unchecked return valueCaolán McNamara
Change-Id: I603d8269f6831c07dc48b767545180120388831d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>